---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/#review49580
---
Ship it!
Some minor feedback, but I think it's about ready to
See https://builds.apache.org/job/mesos-reviewbot/1275/changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24246/#review49587
---
Patch looks great!
Reviews applied: [24246]
All tests passed.
-
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2284/changes
Changes:
[nik] Forced mesos_pb2 to be generated in a flat fashion.
--
[...truncated 3698 lines...]
creating 'dist/mesos.interface-0.20.0-py2.7.egg' and
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2028/changes
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2292/changes
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/249/changes
On July 29, 2014, 10:15 p.m., Ben Mahler wrote:
src/master/master.cpp, lines 4318-4322
https://reviews.apache.org/r/22796/diff/10/?file=644109#file644109line4318
Do we need to store the Timers at all? OfferIDs are unique and so this
should be correct without storing / canceling
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24246/
---
(Updated Aug. 5, 2014, 3:59 p.m.)
Review request for mesos.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24316/
---
Review request for mesos.
Bugs: MESOS-1662
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/#review49607
---
Bad patch!
Reviews applied: [24264]
Failed command: git apply
On Aug. 5, 2014, 12:45 a.m., Ben Mahler wrote:
include/mesos/mesos.proto, lines 295-297
https://reviews.apache.org/r/24269/diff/1/?file=651223#file651223line295
Since this was never released, and it's a repeated field, we should be
able to remove it. How about commenting it out
On Aug. 5, 2014, 4:11 p.m., Mesos ReviewBot wrote:
Bad patch!
Reviews applied: [24264]
Failed command: git apply --index 24264.patch
Error:
error: missing binary patch data for '3rdparty/pip-1.5.6.tar.gz'
error: binary patch does not apply to '3rdparty/pip-1.5.6.tar.gz'
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24286/
---
(Updated Aug. 5, 2014, 5:10 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24269/
---
(Updated Aug. 5, 2014, 5:11 p.m.)
Review request for mesos, Ben Mahler and
On Aug. 4, 2014, 10:43 p.m., Dominic Hamon wrote:
src/common/resources.cpp, line 520
https://reviews.apache.org/r/24269/diff/1/?file=651225#file651225line520
are you going to expose this in the webui? :)
Nope, not at this time since we try to hide it from frameworks anyway.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24316/#review49621
---
src/linux/cgroups.cpp
On Aug. 5, 2014, 4:11 p.m., Mesos ReviewBot wrote:
Bad patch!
Reviews applied: [24264]
Failed command: git apply --index 24264.patch
Error:
error: missing binary patch data for '3rdparty/pip-1.5.6.tar.gz'
error: binary patch does not apply to '3rdparty/pip-1.5.6.tar.gz'
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24128/#review49620
---
src/master/allocator.hpp
On Aug. 5, 2014, 10:50 a.m., Jie Yu wrote:
src/master/allocator.hpp, line 121
https://reviews.apache.org/r/24128/diff/6/?file=650513#file650513line121
Seems that having a default in a virtual function is dangerous. Refer
to this thread:
On Aug. 5, 2014, 5:50 p.m., Jie Yu wrote:
src/master/allocator.hpp, line 121
https://reviews.apache.org/r/24128/diff/6/?file=650513#file650513line121
Seems that having a default in a virtual function is dangerous. Refer
to this thread:
On July 29, 2014, 10:15 p.m., Ben Mahler wrote:
src/tests/master_tests.cpp, lines 2065-2128
https://reviews.apache.org/r/22796/diff/10/?file=644110#file644110line2065
I'm not sure we need this test, since it's conflating a few things:
(1) Frameworks do not receive any
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/
---
Review request for mesos and Jie Yu.
Bugs: MESOS-1672
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24128/
---
(Updated Aug. 5, 2014, 11:48 a.m.)
Review request for mesos, Benjamin Hindman
On Aug. 5, 2014, 12:30 a.m., Ian Downes wrote:
I'm not 100% clear from the description what this is doing - does it test
correctness in anyway or is it really to be used under profiling to test
the performance of the reaper? If it's the latter, then perhaps this should
be standalone
FWIW - I've been able to setup YARN clusters in containers using bridged
networking and relying on zookeeper for Namenode resolution.
The problem is - 'bridged networking' = IP-fiasco at scale.
However, I still have hopes for MAC VLAN support for Docker:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/
---
(Updated Aug. 5, 2014, 8:10 p.m.)
Review request for mesos and Benjamin
On Aug. 5, 2014, 4:11 p.m., Mesos ReviewBot wrote:
Bad patch!
Reviews applied: [24264]
Failed command: git apply --index 24264.patch
Error:
error: missing binary patch data for '3rdparty/pip-1.5.6.tar.gz'
error: binary patch does not apply to '3rdparty/pip-1.5.6.tar.gz'
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24339/
---
Review request for mesos and Ben Mahler.
Bugs: MESOS-1673
Hi Mesos users and developers,
In Mesos 0.20.0 we’d like to release a feature called framework rate limiting.
What is Framework Rate Limiting
In a multi-framework environment, this feature aims to protect the throughput
of high-SLA (e.g., production, service) frameworks by having the master
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24339/#review49638
---
src/slave/slave.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23912/#review49552
---
src/slave/slave.hpp
On Aug. 5, 2014, 10:22 a.m., Adam B wrote:
Some minor feedback, but I think it's about ready to commit. I'll let
@vinodkone (shepherd) give the final word.
i'll take a look once adam's comments are addressed.
- Vinod
---
This is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24339/
---
(Updated Aug. 5, 2014, 9:33 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24344/
---
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24128/#review49643
---
Ship it!
Ship It!
- Jie Yu
On Aug. 5, 2014, 6:48 p.m., Dominic
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24339/#review49645
---
Ship it!
Ship It!
- Ben Mahler
On Aug. 5, 2014, 9:33 p.m., Jie
On Aug. 5, 2014, 9:43 p.m., Ben Mahler wrote:
Ship It!
Same TODO in master's constants?
- Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24339/#review49645
On Aug. 5, 2014, 12:30 a.m., Ian Downes wrote:
I'm not 100% clear from the description what this is doing - does it test
correctness in anyway or is it really to be used under profiling to test
the performance of the reaper? If it's the latter, then perhaps this should
be standalone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24344/#review49647
---
Ship it!
src/tests/master_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24344/
---
(Updated Aug. 5, 2014, 9:49 p.m.)
Review request for mesos and Ben Mahler.
On Aug. 5, 2014, 9:43 p.m., Ben Mahler wrote:
Ship It!
Ben Mahler wrote:
Same TODO in master's constants?
Done.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24349/
---
Review request for mesos, Benjamin Hindman and Ian Downes.
Repository:
On July 29, 2014, 10:15 p.m., Ben Mahler wrote:
src/master/master.cpp, lines 4318-4322
https://reviews.apache.org/r/22796/diff/10/?file=644109#file644109line4318
Do we need to store the Timers at all? OfferIDs are unique and so this
should be correct without storing / canceling
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24350/
---
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23912/
---
(Updated Aug. 5, 2014, 3:44 p.m.)
Review request for mesos.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23912/
---
(Updated Aug. 5, 2014, 3:45 p.m.)
Review request for mesos.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/
---
(Updated Aug. 5, 2014, 3:50 p.m.)
Review request for mesos and Jie Yu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/
---
(Updated Aug. 5, 2014, 3:50 p.m.)
Review request for mesos, Jie Yu and Vinod
On Aug. 5, 2014, 12:30 a.m., Ian Downes wrote:
3rdparty/libprocess/src/tests/reap_tests.cpp, lines 154-158
https://reviews.apache.org/r/24270/diff/2/?file=651304#file651304line154
Why not merge these loops? i.e., reap the pid then sigkill it
immediately, then you can drop
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23912/#review49658
---
File Attachment: stout patch - MESOS-947-stout.patch2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24350/#review49654
---
Ship it!
Hm.. this seems good for now. If there are a lot of these
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24286/#review49659
---
Looks good, any test?
- Ben Mahler
On Aug. 5, 2014, 5:10 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24270/
---
(Updated Aug. 5, 2014, 11:33 p.m.)
Review request for mesos and Ian Downes.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24343/
---
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-1578
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24355/
---
Review request for mesos and Dominic Hamon.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/
---
(Updated Aug. 5, 2014, 11:49 p.m.)
Review request for mesos, Ian Downes and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/
---
(Updated Aug. 5, 2014, 11:49 p.m.)
Review request for mesos, Ian Downes and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24343/#review49664
---
src/master/master.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/
---
(Updated Aug. 5, 2014, 11:57 p.m.)
Review request for mesos, Ian Downes and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24197/
---
(Updated Aug. 6, 2014, 12:13 a.m.)
Review request for mesos and Ian Downes.
On Aug. 5, 2014, 10:22 a.m., Adam B wrote:
src/tests/slave_tests.cpp, lines 1238-1239
https://reviews.apache.org/r/22313/diff/17/?file=645030#file645030line1238
I'm not sure the Times(2) is being enforced if you follow it with
WillRepeatedly. Maybe you should do
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/
---
(Updated Aug. 6, 2014, 12:17 a.m.)
Review request for mesos, Ian Downes and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/
---
(Updated Aug. 6, 2014, 12:36 a.m.)
Review request for mesos, Ian Downes and
On Aug. 5, 2014, 10:22 a.m., Adam B wrote:
src/tests/slave_tests.cpp, lines 1170-1172
https://reviews.apache.org/r/22313/diff/17/?file=645030#file645030line1170
Do you really need to settle before AND after you advance?
Yes, we actually need to settle() before advance(), Otherwise
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/
---
(Updated Aug. 6, 2014, 12:37 a.m.)
Review request for mesos, Ian Downes and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/
---
(Updated Aug. 6, 2014, 12:37 a.m.)
Review request for mesos, Ian Downes and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24356/
---
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1119
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/
---
(Updated Aug. 6, 2014, 1:11 a.m.)
Review request for mesos, Ian Downes and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24361/
---
Review request for mesos, Benjamin Hindman and Vinod Kone.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24361/#review49677
---
Ship it!
src/tests/environment.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/#review49679
---
Ship it!
src/master/hierarchical_allocator_process.hpp
On Aug. 6, 2014, 1:20 a.m., Vinod Kone wrote:
src/tests/environment.cpp, line 154
https://reviews.apache.org/r/24361/diff/1/?file=653355#file653355line154
We should probably start having a LINUX_ prefix for tests that only run
on linux (cgroups, docker etc). Maybe a TODO for now.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review49681
---
Bad patch!
Reviews applied: [23086]
Failed command: git apply
On Aug. 5, 2014, 9:29 p.m., Vinod Kone wrote:
src/tests/mesos.cpp, lines 330-335
https://reviews.apache.org/r/23912/diff/3/?file=643814#file643814line330
were you unable to directly call Slave::* methods here instead of
having the redirection through unmocked_* methods?
we
On Aug. 5, 2014, 9:29 p.m., Vinod Kone wrote:
src/slave/slave.cpp, lines 1330-1341
https://reviews.apache.org/r/23912/diff/3/?file=643812#file643812line1330
I would recommend pulling this logic outside 'if (executor == NULL)' to
#1326 to make it easy to reason about.
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2285/changes
Changes:
[bmahler] Fixed a flaky ping timeout test.
[yujie.jay] Made MASTER_PING_TIMEOUT a function for fixing MESOS-1673.
[yujie.jay] Fixed the flaky MasterTest.RecoveredSlaveReregisters test.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24286/
---
(Updated Aug. 6, 2014, 2:31 a.m.)
Review request for mesos, Ben Mahler and
See https://builds.apache.org/job/mesos-reviewbot/1280/changes
Changes:
[vinodkone] Fixed docker validation and only run docker tests on linux with
root.
--
[...truncated 3506 lines...]
copying src/mesos.native.egg-info/dependency_links.txt -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24286/#review49691
---
Ship it!
Thanks Jie!
src/master/master.cpp
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/251/changes
Changes:
[yujie.jay] Fixed two flaky tests in GarbageCollectorIntegrationTest.
[yan] Added a trailing space to _CheckFatal's output.
--
[...truncated 3813 lines...]
[--] Global
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24269/#review49697
---
Bad patch!
Reviews applied: [24269]
Failed command: git apply
See https://builds.apache.org/job/mesos-reviewbot/1281/
On Aug. 5, 2014, 4:50 p.m., Dominic Hamon wrote:
src/master/master.hpp, line 753
https://reviews.apache.org/r/24343/diff/1/?file=653285#file653285line753
is there a reason this is a nested class in Master?
It only intended to be used in Master but I guess it doesn't need to be
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24343/
---
(Updated Aug. 5, 2014, 10:53 p.m.)
Review request for mesos, Ben Mahler and
85 matches
Mail list logo
