Re: Review Request 24349: Add ContainerInfo and Volumes proto defs

2014-08-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24349/#review50016 --- include/mesos/mesos.proto

Re: Review Request 24349: Add ContainerInfo and Volumes proto defs

2014-08-08 Thread Timothy Chen
On Aug. 8, 2014, 7:33 a.m., Adam B wrote: include/mesos/mesos.proto, line 829 https://reviews.apache.org/r/24349/diff/4/?file=656505#file656505line829 Why would you ever not have a host path? Or are you imagining that we might eventually support volumes mapping from/to remote or

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2304

2014-08-08 Thread Apache Jenkins Server
from scheduler-631ca56b-b23d-4494-8cc8-bcdf6e0533ee@140.211.11.27:54672 I0808 07:47:21.594349 14231 master.cpp:1275] Authorizing framework principal 'test-principal' to receive offers for role '*' I0808 07:47:21.594458 14231 master.cpp:1374] Registering framework 20140808-074721-453759884-54672

Build failed in Jenkins: Mesos-Ubuntu-distcheck #259

2014-08-08 Thread Apache Jenkins Server
the log to 3 I0808 08:29:20.398218 11422 master.cpp:2877] Registered slave 20140808-082920-453759884-51004-11187-0 at slave(200)@140.211.11.27:51004 (hemera.apache.org) I0808 08:29:20.398233 11422 master.cpp:4088] Adding slave 20140808-082920-453759884-51004-11187-0 at slave(200)@140.211.11.27

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2038

2014-08-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2038/changes Changes: [vinodkone] Temporarily disabled HealthcheckTest.ConsecutiveFailures test due to -- [...truncated 3834 lines...] copying

Build failed in Jenkins: mesos-reviewbot #1295

2014-08-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1295/changes Changes: [vinodkone] Fixed allocator to do allocations per slave rather than per framework. -- [...truncated 5372 lines...] rm -f state/.dirstamp rm -f tests/.deps/.dirstamp rm -f

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2305

2014-08-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2305/changes

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2325

2014-08-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2325/changes

Re: Review Request 24316: Use memory.memsw.limit_in_bytes in cgroup mem isolator with --limit-swap

2014-08-08 Thread Anton Lindström
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24316/ --- (Updated Aug. 8, 2014, 10:40 a.m.) Review request for mesos. Changes ---

Re: Review Request 24316: Use memory.memsw.limit_in_bytes in cgroup mem isolator with --cgroups_limit-swap

2014-08-08 Thread Anton Lindström
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24316/ --- (Updated Aug. 8, 2014, 10:42 a.m.) Review request for mesos. Summary

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2039

2014-08-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2039/changes

Build failed in Jenkins: Mesos-Ubuntu-distcheck #260

2014-08-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/260/changes Changes: [vinodkone] Fixed allocator to do allocations per slave rather than per framework. -- [...truncated 3824 lines...] make[2]: Leaving directory

Build failed in Jenkins: mesos-reviewbot #1296

2014-08-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1296/ -- [...truncated 5568 lines...] rm -f tests/.dirstamp rm -f usage/.deps/.dirstamp rm -f log/*.lo rm -f usage/.dirstamp rm -f zookeeper/.deps/.dirstamp rm -f log/tool/*.o rm -f zookeeper/.dirstamp rm -f

Re: Review Request 24485: Allowed flags to load from a configure file as defaults.

2014-08-08 Thread Tobias Weingartner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24485/#review50037 --- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp

Re: Review Request 24316: Use memory.memsw.limit_in_bytes in cgroup mem isolator with --cgroups_limit-swap

2014-08-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24316/#review50039 --- Looks good! Can you do me one favor, can you test it on a machine

Re: Review Request 23086: Update system check to unbundle protobuf

2014-08-08 Thread Timothy St. Clair
On Aug. 5, 2014, 1:18 a.m., Vinod Kone wrote: 3rdparty/libprocess/configure.ac, line 303 https://reviews.apache.org/r/23086/diff/2/?file=639448#file639448line303 instead of hardcoding the version, is there a way to get this from 3rdparty versions.am? So autoconf feeds forward

Re: Review Request 24485: Allowed flags to load from a configure file as defaults.

2014-08-08 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24485/#review50041 --- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp

Re: Review Request 24464: Redirect docker logs

2014-08-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/#review50042 --- src/docker/docker.hpp

Re: Review Request 24464: Redirect docker logs

2014-08-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/#review50043 --- src/slave/containerizer/docker.cpp

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

2014-08-08 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23348/ --- (Updated Aug. 8, 2014, 9:46 a.m.) Review request for Aurora, Joe Smith, Kevin

Re: Review Request 24464: Redirect docker logs

2014-08-08 Thread Timothy Chen
On Aug. 8, 2014, 4:41 p.m., Jie Yu wrote: src/docker/docker.cpp, line 512 https://reviews.apache.org/r/24464/diff/2/?file=655523#file655523line512 return checkError(cmd, s.get()); I don't think I want to checkError since it already reads stderr, however docker logs pipes the

Re: Review Request 24464: Redirect docker logs

2014-08-08 Thread Jie Yu
Yeah, you are right. Having a continuation to check the status is the right way. On Fri, Aug 8, 2014 at 10:09 AM, Timothy Chen tnac...@apache.org wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/ On August 8th, 2014, 4:41 p.m. UTC,

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

2014-08-08 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/ --- (Updated Aug. 8, 2014, 5:58 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 24407: Use curl-config to locate lib curl when possible

2014-08-08 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24407/#review50057 --- why not follow the prefix pattern if it's in a non-standard

Build failed in Jenkins: mesos-reviewbot #1297

2014-08-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1297/ -- [...truncated 5504 lines...] rm -f slave/containerizer/mesos/*.o rm -rf slave/.libs slave/_libs rm -f slave/containerizer/mesos/*.lo rm -f state/*.o rm -f state/*.lo rm -rf slave/containerizer/.libs

Re: Review Request 24469: Created pure python package for the CLI.

2014-08-08 Thread Thomas Rampelberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24469/ --- (Updated Aug. 8, 2014, 7:36 p.m.) Review request for mesos and Benjamin

Re: Review Request 24464: Redirect docker logs

2014-08-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/ --- (Updated Aug. 8, 2014, 9:14 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 24464: Redirect docker logs

2014-08-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/ --- (Updated Aug. 8, 2014, 9:20 p.m.) Review request for mesos, Benjamin Hindman

Review Request 24509: Refactored credentials and ACLs.

2014-08-08 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24509/ --- Review request for mesos and Vinod Kone. Repository: mesos-git Description

Review Request 24511: Retry freeze in cgroups TasksKiller to workaround MESOS-1689.

2014-08-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24511/ --- Review request for mesos, Ian Downes and Vinod Kone. Repository: mesos-git

Re: Review Request 24511: Retry freeze in cgroups TasksKiller to workaround MESOS-1689.

2014-08-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24511/ --- (Updated Aug. 8, 2014, 9:59 p.m.) Review request for mesos, Ian Downes and

Re: Review Request 24511: Retry freeze in cgroups TasksKiller to workaround MESOS-1689.

2014-08-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24511/#review50078 --- Ship it! lgtm. i will let @iand give the final nod.

Re: Review Request 24511: Retry freeze in cgroups TasksKiller to workaround MESOS-1689.

2014-08-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24511/#review50077 --- Ship it! I'll file a ticket for exposing the overall failure to

Re: Review Request 24511: Retry freeze in cgroups TasksKiller to workaround MESOS-1689.

2014-08-08 Thread Jie Yu
On Aug. 8, 2014, 10:07 p.m., Ian Downes wrote: src/linux/cgroups.cpp, line 1480 https://reviews.apache.org/r/24511/diff/1/?file=656793#file656793line1480 s/freezeTimedout/freezeTimedOut/ ? We consistently use Timedout in our code base:) - Jie

Re: Review Request 24464: Redirect docker logs

2014-08-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/#review50085 --- src/slave/containerizer/docker.cpp

Re: Review Request 24464: Redirect docker logs

2014-08-08 Thread Timothy Chen
On Aug. 8, 2014, 11:13 p.m., Jie Yu wrote: Ah sorry the docker tests passed, but I don't have tests in place for testing the logs. I'll be adding some tests later. - Timothy --- This is an automatically generated e-mail. To reply,

Re: Review Request 24464: Redirect docker logs

2014-08-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/ --- (Updated Aug. 8, 2014, 11:19 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 24464: Redirect docker logs

2014-08-08 Thread Jie Yu
On Aug. 8, 2014, 11:13 p.m., Jie Yu wrote: Timothy Chen wrote: Ah sorry the docker tests passed, but I don't have tests in place for testing the logs. I'll be adding some tests later. Thanks Tim! On Aug. 8, 2014, 11:13 p.m., Jie Yu wrote: src/slave/containerizer/docker.cpp,

Re: Review Request 24464: Redirect docker logs

2014-08-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/#review50090 --- Can you add a test to test the docker.logs. For example, run:

Re: Review Request 24464: Redirect docker logs

2014-08-08 Thread Timothy Chen
On Aug. 8, 2014, 11:22 p.m., Jie Yu wrote: Can you add a test to test the docker.logs. For example, run: /bin/sh -c 'echo out; echo err 12' using docker and make sure that you get 'out' from stdout and 'err' from stderr:) ya I was exactly thinking about that! - Timothy

Re: Review Request 24509: Refactored credentials and ACLs.

2014-08-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24509/#review50093 --- Ship it! Fixed some build errors, added tests and updated

Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes.

2014-08-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22313/#review50094 --- Patch looks great! Reviews applied: [22313] All tests passed. -

Re: Review Request 24509: Refactored credentials and ACLs.

2014-08-08 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24509/ --- (Updated Aug. 8, 2014, 11:58 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 22066: Added timeout to rescind unused offers

2014-08-08 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22066/ --- (Updated Aug. 8, 2014, 8:48 p.m.) Review request for mesos, Adam B and Niklas

Re: Review Request 22066: Added timeout to rescind unused offers

2014-08-08 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22066/ --- (Updated Aug. 8, 2014, 8:51 p.m.) Review request for mesos, Adam B and Niklas

Re: Review Request 22066: Added timeout to rescind unused offers

2014-08-08 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22066/ --- (Updated Aug. 8, 2014, 8:52 p.m.) Review request for mesos, Adam B, Ben

Re: Review Request 22066: Added timeout to rescind unused offers

2014-08-08 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22066/ --- (Updated Aug. 8, 2014, 8:55 p.m.) Review request for mesos, Adam B, Ben

Re: Review Request 22066: Added timeout to rescind unused offers

2014-08-08 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22066/ --- (Updated Aug. 8, 2014, 8:57 p.m.) Review request for mesos, Adam B, Ben