Re: Review Request 27054: Libprocess Socket: introduce connect()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27054/ --- (Updated Oct. 29, 2014, 5:18 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 27023: Libprocess Socket std::shared_ptr

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27023/ --- (Updated Oct. 29, 2014, 5:10 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 27023: Libprocess Socket std::shared_ptr

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27023/ --- (Updated Oct. 29, 2014, 4:43 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 27023: Libprocess Socket std::shared_ptr

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27023/ --- (Updated Oct. 29, 2014, 4:31 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 20423: Moved validation visitors out of master.cpp.

> On Oct. 23, 2014, 7:46 p.m., Vinod Kone wrote: > > Why are some definitions in .hpp and some in .cpp? Why not all in .cpp? > > > > Also, it's not clear to me how this split would help in unit testing? > > AFAICT, all these visitors take Master or Framework or Slave which needs > > bringing u

Re: Review Request 27175: Added support for handling 'rc' tag to Version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27175/#review58954 --- 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp

Re: Review Request 26517: Symlink sandbox directories in docker containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26517/ --- (Updated Oct. 29, 2014, 3 a.m.) Review request for mesos and Benjamin Hindman.

Re: Review Request 26517: Symlink sandbox directories in docker containerizer

> On Oct. 29, 2014, 2:17 a.m., Cody Maloney wrote: > > src/slave/containerizer/docker.hpp, line 40 > > > > > > why not do this as a const char * / compile time string literal rather > > than runtime? > > > > I

Re: Review Request 26517: Symlink sandbox directories in docker containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26517/#review58955 --- src/slave/containerizer/docker.cpp

Re: Review Request 26517: Symlink sandbox directories in docker containerizer

> On Oct. 29, 2014, 2:17 a.m., Cody Maloney wrote: > > src/slave/containerizer/docker.cpp, line 266 > > > > > > I get why this cleanup should be in the destructor, but it feels uneven > > that we do the cleanup in the

Re: Review Request 27315: Updated scheduler driver to exponentially backoff during registration retries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27315/#review58951 --- include/mesos/scheduler.hpp

Re: Review Request 26517: Symlink sandbox directories in docker containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26517/#review58938 --- src/slave/containerizer/docker.hpp

Re: Review Request 26436: Avoid docker inspect on each usage call

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26436/#review58946 --- Patch looks great! Reviews applied: [26610, 26861, 26862, 26896, 26

Re: Review Request 27295: os::killtree() supports case when root pid has exited.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27295/#review58845 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp

Re: Review Request 26436: Avoid docker inspect on each usage call

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26436/ --- (Updated Oct. 29, 2014, 12:26 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 26517: Symlink sandbox directories in docker containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26517/ --- (Updated Oct. 29, 2014, 12:25 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 26898: Add hostname option to docker info

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26898/ --- (Updated Oct. 29, 2014, 12:24 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 26897: Support lxc configurations in docker info

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26897/ --- (Updated Oct. 29, 2014, 12:23 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 26896: Add privileged option to docker info

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26896/ --- (Updated Oct. 29, 2014, 12:22 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 26862: Fix docker flaky tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26862/ --- (Updated Oct. 29, 2014, 12:21 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/#review58921 --- src/master/master.hpp

Re: Review Request 26861: Schedule docker containers for removal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26861/ --- (Updated Oct. 29, 2014, 12:02 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 26862: Fix docker flaky tests

> On Oct. 26, 2014, 1:11 a.m., Benjamin Hindman wrote: > > src/tests/docker_containerizer_tests.cpp, line 111 > > > > > > This doesn't look like it was used by any call sites. Good catch, I'm still going to use this t

Re: Review Request 26382: Add source and reason to TaskStatus.

> On Oct. 24, 2014, 6:08 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 2301 > > > > > > why is this TASK_ERROR instead of TASK_LOST? A relaunch would likely > > succeed here right? > > Dominic Hamon wrote:

Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/#review58924 --- src/master/master.cpp

Jenkins build is back to normal : Mesos-Ubuntu-distcheck #452

See

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2502

tests/setns_test_helper.hpp in Makefile. -- [...truncated 12824 lines...] I1028 23:48:22.413159 31211 hierarchical_allocator_process.hpp:734] Offering cpus(*):2; mem(*):1024; disk(*):3.70122e+06; ports(*):[31000-32000] on slave 20141028-234822-3193029443-50043-31

Re: Review Request 26857: Added CRAM-MD5 Authenticator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/#review58909 --- We added a new module kind but didn't add any new tests. Wouldn't i

Re: Review Request 26578: Memory cleanup: libprocess gc finalize

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26578/#review58919 --- 3rdparty/libprocess/include/process/gc.hpp

Re: Review Request 27122: Reorganized authentication implementation locations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27122/#review58910 --- A fly-by review, mostly about the file naming and include guards.

Re: Review Request 26898: Add hostname option to docker info

> On Oct. 26, 2014, 12:23 a.m., Benjamin Hindman wrote: > > include/mesos/mesos.proto, lines 889-890 > > > > > > Shouldn't this be a generic ContainerInfo field? hmm, didn't think about that, but I think you're right

Re: Review Request 26583: Memory cleanup: libprocess delete garbage collector process

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26583/#review58915 --- The GarbageCollector is one of the earliest libprocess processes tha

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2224

See

Review Request 27315: Updated scheduler driver to exponentially backoff during registration retries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27315/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1903 https://issues.ap

Jenkins build is back to normal : mesos-reviewbot #2308

See

Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26860/#review58906 --- Ship it! Ship It! - Kapil Arya On Oct. 25, 2014, 4:35 p.m., Till

Build failed in Jenkins: mesos-reviewbot #2307

See -- [...truncated 3946 lines...] (/bin/mkdir -p python/native/src/mesos/native && cp -pf ../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp python/native/src/mes

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2501

See

Build failed in Jenkins: Mesos-Ubuntu-distcheck #451

See Changes: [idownes] Correct include of linux/ns.hpp in isolator tests. [tstclair] Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess

Re: git commit: Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess

Thanks guys! On Tue, Oct 28, 2014 at 3:09 PM, Cody Maloney wrote: > I'll try and keep my review board titles a little shorter in the future as > well to help prevent this. > > Cody > > On Tue, Oct 28, 2014 at 3:05 PM, Tim St Clair wrote: > > > My apologies here. > > I had ran support/apply-revi

Re: git commit: Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess

I'll try and keep my review board titles a little shorter in the future as well to help prevent this. Cody On Tue, Oct 28, 2014 at 3:05 PM, Tim St Clair wrote: > My apologies here. > I had ran support/apply-review.sh and had not trim'd the commit message. > > -Tim > > - Original Message ---

Re: git commit: Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess

My apologies here. I had ran support/apply-review.sh and had not trim'd the commit message. -Tim - Original Message - > From: "Benjamin Mahler" > To: "dev" > Cc: comm...@mesos.apache.org > Sent: Tuesday, October 28, 2014 4:38:49 PM > Subject: Re: git commit: Add --enable-debug and --

Build failed in Jenkins: mesos-reviewbot #2306

See Changes: [idownes] Correct include of linux/ns.hpp in isolator tests. [tstclair] Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess --

Re: git commit: Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess

We try to keep the commit messages short: *5) Follow the format of commit messages. The three important bits are (a) be clear and explicit in the commit message and (b) include the link to the review and © use 72 character columns. See support/apply-review.sh for committing someone else’s code (it

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2223

See Changes: [idownes] Include changes to isolation flag when creating Mesos containerizer. [idownes] Move Linux namespace functions into linux/. [idownes] Add getns() for namespaces. [idownes] Add ns::

Build failed in Jenkins: Mesos-Ubuntu-distcheck #450

See Changes: [idownes] Include changes to isolation flag when creating Mesos containerizer. [idownes] Move Linux namespace functions into linux/. [idownes] Add getns() for namespaces. [idownes] Add ns::pid::destroy() to destroy

Build failed in Jenkins: mesos-reviewbot #2305

See Changes: [idownes] Include changes to isolation flag when creating Mesos containerizer. [idownes] Move Linux namespace functions into linux/. [idownes] Add getns() for namespaces. [idownes] Add ns::pid::destroy() to destroy a pid

Re: Review Request 27295: os::killtree() supports case when root pid has exited.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27295/#review58855 --- Patch looks great! Reviews applied: [27295] All tests passed. - M

Review Request 27295: os::killtree() supports case when root pid has exited.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27295/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-1875 https

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2498

8999 hierarchical_allocator_process.hpp:442] Added slave 20141028-023846-3142697795-33379-8981-S0 (pomona.apache.org) with cpus(*):2; mem(*):1024; disk(*):1024; ports(*):[31000-32000] (and cpus(*):2; mem(*):1024; disk(*):1024; ports(*):[31000-32000] available) I1028 02:38:46.850214 9004

Re: Review Request 27252: Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27252/#review58836 --- Ship it! Ship It! - Timothy St. Clair On Oct. 27, 2014, 11:22 p.

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2221

Successfully authenticated with > master master@67.195.81.187:39931 > I1028 02:38:13.650966 11896 sched.cpp:476] Sending registration request to > master@67.195.81.187:39931 > I1028 02:38:13.650967 11899 master.cpp:3893] Successfully authenticated > principal 'test-principal

Re: Review Request 27252: Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27252/#review58817 --- Ship it! Ship It! - Timothy St. Clair On Oct. 27, 2014, 11:22 p.

Re: 0.21.0-pre & Spark latest

Hi RJ, I see, are you or the team on working on this problem already? If not I'd like to take a look as well. Tim On Tue, Oct 28, 2014 at 8:47 AM, RJ Nowling wrote: > Hi Tim, > > The integration test is simply to open the spark shell (Spark 1.1.0) using > mesos 0.21 in coarse-grained mode. We

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2499

ui/2499/changes > > > > Changes: > > [dave] Add Groupon and LIFX to PoweredByMesos documentation. > > -- > [...truncated 63968 lines...] > I1028 08:20:16.717905 4794 hierarchical_allocator_process.hpp:329] Added > framework 20141028

Re: 0.21.0-pre & Spark latest

Hi Tim, Thanks for doing the integration tests, that's something that I wanted to do but never got to yet. I have great interest ensuring spark and mesos work, and I know Brenden as well does. I have been tracking these spark mesos problems with spark jira and labeling them mesos. Can you cre

Re: 0.21.0-pre & Spark latest

inline - Original Message - > From: "Brenden Matthews" > To: u...@mesos.apache.org > Cc: "mesos-devel" , "RJ Nowling" , > "Erik Erlandson" > Sent: Tuesday, October 28, 2014 9:51:58 AM > Subject: Re: 0.21.0-pre & Spark latest > Since we've recently adopted Spark, I'll second Tim's comm

Re: 0.21.0-pre & Spark latest

Since we've recently adopted Spark, I'll second Tim's comment. We had an issue with 0.20.1 that was possibly related to Spark[1], so it's important for us to get this stuff fixed in 0.21.0. Tim, can you elaborate on the issues you saw? Have you tested with my recent Spark patches[2][3]? [1]: ht

0.21.0-pre & Spark latest

Folks - We have some automated tests that run the latest Mesos against the latest Spark, and we've run across a series of issues in both fine, and course grained mode that I believe stem from a series of changes in the 0.21 cycle. I'm not certain if anyone "owns" this integration, but we sho

Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/ --- (Updated Oct. 28, 2014, 12:44 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 26857: Added CRAM-MD5 Authenticator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/ --- (Updated Oct. 28, 2014, 12:43 p.m.) Review request for mesos, Adam B, Benjamin

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2499

717905 4794 hierarchical_allocator_process.hpp:329] Added framework 20141028-082016-3142697795-52878-4771- I1028 08:20:16.717926 4794 hierarchical_allocator_process.hpp:697] No resources available to allocate! I1028 08:20:16.717938 4794 hierarchical_allocator_process.hpp:659] Performed allo

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2222

See