Yes through 0.22. Should be able to drop it after that. Although we may
need to come up with a fix for GCC 4.7 or provide good docs for building on
Debian Wheezy.
On Nov 21, 2014 6:55 PM, Dominic Hamon dha...@twopensource.com wrote:
Or it is time to once again ask: must we continue to support a
/diff/
Testing
---
Thanks,
Cody Maloney
:
https://reviews.apache.org/r/28253/#review62422
---
On Nov. 20, 2014, 12:50 a.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28298/
---
(Updated Nov. 20, 2014, 9:27 p.m.)
Review request
,
Cody Maloney
:
https://reviews.apache.org/r/28303/#review62459
---
On Nov. 20, 2014, 11:11 p.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
request encoding should deal with constructing an
encoded query string, is that not the case? Would like to avoid exposing
this if possible, and if not possible, would like to make this more
intuitive.
Cody Maloney wrote:
So that behavior of parse is going to produce incorrect results I
# No new untracked files
Thanks,
Cody Maloney
/diff/
Testing
---
$cat .clang-format
cat: .clang-format: No such file or directory
$./bootstrap
...
$ls -alh .clang-format
lrwxrwxrwx 1 cody cody 20 Nov 20 16:03 .clang-format - support/clang-format
$cat .clang-format
...
$git status
# No new untracked files
Thanks,
Cody Maloney
request encoding should deal with constructing an
encoded query string, is that not the case? Would like to avoid exposing
this if possible, and if not possible, would like to make this more
intuitive.
Cody Maloney wrote:
So that behavior of parse is going to produce incorrect results I
/clang-format
$cat .clang-format
...
$git status
# No new untracked files
Thanks,
Cody Maloney
://reviews.apache.org/r/28309/#review62497
---
On Nov. 21, 2014, 1:42 a.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27606/#review62386
---
On Nov. 20, 2014, 12:34 a.m., Cody Maloney wrote
to
make hashmap so we don't have to forward most of it's functonality.
Rather, we should define helper functions which take a hashmap. It's
far more maintainable and works better across a range of STL versions.
- Cody Maloney
On Nov. 19, 2014, 8:29 p.m., Cody Maloney wrote
/tests/http_tests.cpp
a90e65f77904da0a45e1cc0cc9889ae69354a1a5
Diff: https://reviews.apache.org/r/28253/diff/
Testing
---
make distcheck ubuntu 14.04
Thanks,
Cody Maloney
://reviews.apache.org/r/28254/diff/
Testing
---
make distcheck ubuntu 14.04
Thanks,
Cody Maloney
/hashmap_tests.cpp
eb3abfc9ba62f92d2ed5bc0e1c093791003a8319
Diff: https://reviews.apache.org/r/28252/diff/
Testing
---
make distcheck ubuntu 14.04
Thanks,
Cody Maloney
-mail. To reply, visit:
https://reviews.apache.org/r/28252/#review62219
---
On Nov. 19, 2014, 8:29 p.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply
On Nov. 19, 2014, 8:29 p.m., Cody Maloney wrote:
In the longer run we will want to not inherit from unordered_map to
make hashmap so we don't have to forward most of it's functonality.
Rather, we should define helper functions which take a hashmap. It's
far more maintainable and works
/process.cpp 7a986d7defb03043ec70a48e161ede50deef9b26
Diff: https://reviews.apache.org/r/28257/diff/
Testing
---
make distcheck ubuntu 14.04
Manually browse the mesos web UI and verify that things seem to generally work
Thanks,
Cody Maloney
---
make distcheck ubuntu 14.04
Thanks,
Cody Maloney
://reviews.apache.org/r/28257/#comment104239
This change would give us the same compiled structure as before /
performance characteristics, but Option being a additional pointer indirection
makes it not.
- Cody Maloney
On Nov. 19, 2014, 9:01 p.m., Cody Maloney wrote
/#review62221
---
On Nov. 19, 2014, 8:30 p.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28253
work
Thanks,
Cody Maloney
, value))
}
```
- Cody
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28256/#review62231
---
On Nov. 19, 2014, 9:01 p.m., Cody Maloney wrote
---
On Nov. 19, 2014, 8:30 p.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28254
b00f9366f5c06b6f20e38c5ae0c23b8a9358
Diff: https://reviews.apache.org/r/28254/diff/
Testing
---
make distcheck ubuntu 14.04
Thanks,
Cody Maloney
/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4
src/proxy/proxy.hpp PRE-CREATION
src/proxy/proxy.cpp PRE-CREATION
src/tests/proxy_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/28262/diff/
Testing
---
make check on ArchLinux, make distcheck ubuntu 14.04
Thanks,
Cody
Description
---
See summary
Diffs
-
src/files/files.cpp 12e8f75aa7bd77d2e81d5d3a7a4d09dd915854aa
Diff: https://reviews.apache.org/r/28263/diff/
Testing
---
make distcheck ubuntu 14.04
Thanks,
Cody Maloney
---
On Nov. 19, 2014, 11:33 p.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28262
, 11:33 p.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28262/
---
(Updated Nov. 19, 2014, 11:33 p.m
? I know it's possible to
have null keys and values.
Cody Maloney wrote:
Keys with empty values do happen in some HTTP APIs I've used before.
Generally there isn't a well-defined scheme for query strings in an RFC
unfortunately. Without this logic we end up with 'key=nextkey=foobar
aa4d9ba68a27c1a7dea8cfe948a90487c4708add
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
eb3abfc9ba62f92d2ed5bc0e1c093791003a8319
Diff: https://reviews.apache.org/r/28252/diff/
Testing
---
make distcheck ubuntu 14.04
Thanks,
Cody Maloney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27606/#review62298
---
On Nov. 5, 2014, 2:53 a.m., Cody Maloney wrote
to generally work
Thanks,
Cody Maloney
/files/files.cpp 12e8f75aa7bd77d2e81d5d3a7a4d09dd915854aa
src/tests/files_tests.cpp 9ad6db51873b96b3cd759523cef9748f6823fb7e
Diff: https://reviews.apache.org/r/27606/diff/
Testing
---
make distcheck on ubuntu 14.04
Thanks,
Cody Maloney
/http_tests.cpp
a90e65f77904da0a45e1cc0cc9889ae69354a1a5
Diff: https://reviews.apache.org/r/28253/diff/
Testing
---
make distcheck ubuntu 14.04
Thanks,
Cody Maloney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28253/#review62303
---
On Nov. 20, 2014, 12:50 a.m., Cody Maloney wrote
/proxy.cpp PRE-CREATION
src/tests/proxy_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/28262/diff/
Testing
---
make check on ArchLinux, make distcheck ubuntu 14.04
Thanks,
Cody Maloney
.
Diffs
-
3rdparty/libprocess/include/process/http.hpp
9cf05acbb724ab9af8010d1788621d37a0e48e86
3rdparty/libprocess/src/http.cpp b00f9366f5c06b6f20e38c5ae0c23b8a9358
Diff: https://reviews.apache.org/r/28254/diff/
Testing
---
make distcheck ubuntu 14.04
Thanks,
Cody Maloney
Thanks,
Cody Maloney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28082/#review61755
---
On Nov. 15, 2014, 2:17 a.m., Cody Maloney wrote
/#review61756
---
On Nov. 15, 2014, 2:17 a.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28082
this shrinks the final size, but we will probably end up
undoing this at some point.
1. libmesos updates, mesos-fetcher gets the new one, slave still uses the
old one.
Cody Maloney wrote:
In the case you are describing, you wouldn't want a static libmesos or a
dynamic one ever. You
On Nov. 15, 2014, 4:15 a.m., Michael Park wrote:
Suggestion: We can simply return `const std::type_info*` rather than
`std::string` for `canonicalize`. The implementation would stay pretty much
the same, and we wouldn't have to construct these `MatchesTypeFunc`
instances.
It
://reviews.apache.org/r/28082/diff/
Testing
---
Built and compared install directory sizes on local machine
Make distcheck on ubuntu 14.04
Thanks,
Cody Maloney
strings in the binary, and excess non-optimizable
code).
Diffs
-
configure.ac c287a17307fb821fc04ded67ff9f33d27947e5d7
Diff: https://reviews.apache.org/r/28082/diff/
Testing
---
Built and compared install directory sizes on local machine
Make distcheck on ubuntu 14.04
Thanks,
Cody
/#review61608
---
On Nov. 15, 2014, 2:17 a.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28082
I'm getting a new warning with this on OS X w/ clang 3.5 which looks like
it probably should be addressed (Add parens to call the node function):
../../../mesos_public/3rdparty/libprocess/src/process.cpp:1662:49: warning:
address of function 'process::node' will always evaluate to 'true'
the warning on Linux as
well).
Definitely a clearer commit message would be nice Log the ip/port rather than
the address of the function to get them?
- Cody Maloney
On Nov. 12, 2014, 10:17 p.m., Dominic Hamon wrote
on ubuntu 14.04
Thanks,
Cody Maloney
,
since the Makefile does really cross the project bounds...
Thanks,
Cody Maloney
Thanks,
Cody Maloney
for
them)
- Cody
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27605/#review60651
---
On Nov. 13, 2014, 12:39 a.m., Cody Maloney wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27945/#review61152
---
On Nov. 13, 2014, 12:35 a.m., Cody Maloney wrote
d166aa1adf56888ae8f6025469e35165e1f21d61
Diff: https://reviews.apache.org/r/27945/diff/
Testing
---
make distcheck with GCC on ubuntu 14.04
Thanks,
Cody Maloney
returnConstRefString(const std:string* str)` which has the null checking logic
in it.
- Cody Maloney
On Nov. 10, 2014, 8:38 p.m., Dominic Hamon wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27826
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27826/#review60684
---
Ship it!
Ship It!
- Cody Maloney
On Nov. 10, 2014, 9:12 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27826/#review60718
---
Ship it!
Ship It!
- Cody Maloney
On Nov. 11, 2014, 12:13 a.m
85fb9958342f0bcdde322d9c55333126e6f86668
Diff: https://reviews.apache.org/r/27660/diff/
Testing
---
make distcheck on ubuntu 14.04
Thanks,
Cody Maloney
on ubuntu 14.04
Thanks,
Cody Maloney
...
Thanks,
Cody Maloney
a696aa22d56b37ee70c6e64c81a849da6d436451
Diff: https://reviews.apache.org/r/27606/diff/
Testing
---
make distcheck on ubuntu 14.04
Thanks,
Cody Maloney
On Sept. 17, 2014, 4:32 p.m., Dominic Hamon wrote:
I'm not convinced that this is necessarily the way we want to go, given the
benefits of move semantics in modern compilers, but for consistency we can
ship this until we have proof that performance favours the alternative.
Kamil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27315/#review59075
---
LGTM
- Cody Maloney
On Oct. 29, 2014, 11:16 p.m., Vinod Kone
: Cody Maloney c...@mesosphere.io
Authored: Tue Oct 28 15:55:40 2014 -0500
Committer: Timothy St. Clair tstcl...@redhat.com
Committed: Tue Oct 28 16:30:08 2014 -0500
--
3rdparty/libprocess/configure.ac | 47
, but the ones in chunks of code
which aren't otherwise touched make the diff harder to read.
src/module/authenticator.hpp
https://reviews.apache.org/r/26859/#comment100115
This needs to be added to a Makefile.am so that distcheck will pass.
- Cody Maloney
On Oct. 28, 2014, 12:44 p.m
://reviews.apache.org/r/26517/#comment100161
Indentation should line up like:
Error(
- Cody Maloney
On Oct. 29, 2014, 12:25 a.m., Timothy Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
numbers.
src/sched/sched.cpp
https://reviews.apache.org/r/27315/#comment100170
nextDuration/durationNext would be a more descriptive variable name.
- Cody Maloney
On Oct. 28, 2014, 11:08 p.m., Vinod Kone wrote
of the members of the enum.
Same goes for operator
3rdparty/libprocess/3rdparty/stout/tests/version_tests.cpp
https://reviews.apache.org/r/27175/#comment100195
Can you add a test for release rc/unknown tag?
- Cody Maloney
On Oct. 24, 2014, 10:55 p.m., Kapil Arya wrote
On Oct. 23, 2014, 7:46 p.m., Vinod Kone wrote:
Why are some definitions in .hpp and some in .cpp? Why not all in .cpp?
Also, it's not clear to me how this split would help in unit testing?
AFAICT, all these visitors take Master or Framework or Slave which needs
bringing up a
combinations of flags, making sure they set the right CXXFLAGS.
Also specified
Thanks,
Cody Maloney
---
On Oct. 24, 2014, 9:29 p.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26426/
---
(Updated Oct. 24, 2014, 9:29
of flags, making sure they set the right CXXFLAGS.
Also specified
Thanks,
Cody Maloney
: https://reviews.apache.org/r/26766/diff/
Testing
---
make distcheck
Thanks,
Cody Maloney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26767/#review57121
---
On Oct. 23, 2014, 4:52 p.m., Cody Maloney wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26766/#review56883
---
On Oct. 23, 2014, 4:52 p.m., Cody Maloney wrote
---
On Oct. 23, 2014, 4:52 p.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26766
it convert to a list of
files?
Cody Maloney wrote:
The code is a lot simpler.
To go from sha-1 back I would need to import subprocess, have it call git
then parse the output. Having bash + xargs just take care of that is a lot
simpler (And also matches the pre-commit style hook
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26825/#review57768
---
On Oct. 23, 2014, 5:17 p.m., Cody Maloney wrote
/diff/
Testing
---
Git added files in various groupings of the subprojects. Tried committing,
resulting in the sample error message above.
Thanks,
Cody Maloney
running gdb on a -g1 binary, in that no local variables will be
inspectable. You can get line numbers and external variables, but that is
it. '-g1' is primarily useful if you are running code analysis tools /
helpers (AddressSanitizer, ThreadSanitizer, etc).
On Wed, Oct 22, 2014 at 4:02 PM, Cody
)
-
configure.ac 2b372e06006250b5230956ef096473e98f3fa590
Diff: https://reviews.apache.org/r/26426/diff/
Testing (updated)
---
Tested all four combinations of flags, making sure they set the right CXXFLAGS.
Also specified
Thanks,
Cody Maloney
the right CXXFLAGS.
Also specified
Thanks,
Cody Maloney
---
make distcheck
Ran mesos-slave, verified the log message printed and
Thanks,
Cody Maloney
at best, but it's better then nothing.
So I think we want all three modes, stripping all debug information is
not really idea.
Cody Maloney wrote:
My main motivation is to shrink the size of libmesos. Yesterday sugis in
#mesos had one which was 213M. For the buildbot internally
/
Testing
---
Git added files in various groupings of the subprojects. Tried committing,
resulting in the sample error message above.
Thanks,
Cody Maloney
://reviews.apache.org/r/26825/#review57081
---
On Oct. 21, 2014, 9:20 p.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
/mesos.hpp e40575c6d330cfa3fbfad2efcf601418c413b992
src/tests/slave_tests.cpp 759670ad91c2f8afbd4b9dcb2f367f50482358e9
Diff: https://reviews.apache.org/r/25525/diff/
Testing
---
make check on localhost
Thanks,
Cody Maloney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25525/#review57511
---
On Oct. 21, 2014, 11:55 p.m., Cody Maloney wrote
On Oct. 15, 2014, 1:25 a.m., Vinod Kone wrote:
src/master/master.cpp, lines 3146-3149
https://reviews.apache.org/r/25525/diff/8/?file=717605#file717605line3146
Hmm. i don't think we want these semantics. Why not just fail if
readmission failed?
Cody Maloney wrote:
So
e36e13843a36360d69a01f62356370bea588a337
src/tests/slave_tests.cpp a1bd00cffe9de178b0b188c3556e479cd1f6d566
Diff: https://reviews.apache.org/r/25525/diff/
Testing
---
make check on localhost
Thanks,
Cody Maloney
://reviews.apache.org/r/26798/diff/
Testing
---
Ran ./support/verify-reviews.py by hand, commenting out the body of
post_reviews, as well as the distcheck step.
I committed the commenting out locally so it wouldn't get undone with the 'git
reset' was executed.
Thanks,
Cody Maloney
On Oct. 16, 2014, 5:36 a.m., Vinod Kone wrote:
support/apply-review.sh, line 20
https://reviews.apache.org/r/26798/diff/1/?file=722887#file722887line20
Update usage?
Cody Maloney wrote:
I was explicitly leaving it out because process wise committers should
look at the diff
/
Testing
---
make distcheck
Thanks,
Cody Maloney
---
make distcheck
Thanks,
Cody Maloney
,
resulting in the sample error message above.
Thanks,
Cody Maloney
to: '26727.patch'
0K . 100% 34.9M=0s
2014-10-16 14:34:43 (34.9 MB/s) - '26727.patch' saved [1574/1574]
error: patch failed: src/module/manager.hpp:89
error: src/module/manager.hpp: patch does not apply
Failed to apply patch
```
Thanks,
Cody
/libprocess/3rdparty/stout/include/stout/json.hpp
719aa964a536cf02dbd2de440157de487ec703b1
Diff: https://reviews.apache.org/r/26723/diff/
Testing
---
make distcheck
Thanks,
Cody Maloney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26827/#review57026
---
On Oct. 16, 2014, 9:37 p.m., Cody Maloney wrote:
---
This is an automatically
101 - 200 of 301 matches
Mail list logo
