/30635/diff/
Testing
---
make check
Thanks,
Jie Yu
check
Thanks,
Jie Yu
> On Jan. 23, 2015, 6:44 p.m., Jie Yu wrote:
> > src/slave/state.hpp, line 120
> > <https://reviews.apache.org/r/29918/diff/9/?file=829596#file829596line120>
> >
> > One more thought:
> >
> > Can we introduce a third parameter for thi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30628/#review70999
---
Ship it!
- Jie Yu
On Feb. 4, 2015, 6:07 p.m., Ian Downes wrote
g/r/30624/#comment116478>
2 lines apart here please:)
src/tests/paths_tests.cpp
<https://reviews.apache.org/r/30624/#comment116480>
s/Pid/LibprocessPid/
Because we also have forked pid.
- Jie Yu
On Feb. 4, 2015, 5:43 p.m., Dominic
> On Feb. 4, 2015, 1:32 a.m., Jie Yu wrote:
> > src/slave/paths.cpp, line 453
> > <https://reviews.apache.org/r/30531/diff/1/?file=844643#file844643line453>
> >
> > const string& directory
>
> Dominic Hamon wrote:
> the function returns
> On Feb. 4, 2015, 1:32 a.m., Jie Yu wrote:
> > src/slave/paths.cpp, line 453
> > <https://reviews.apache.org/r/30531/diff/1/?file=844643#file844643line453>
> >
> > const string& directory
>
> Dominic Hamon wrote:
> the function returns
ttps://reviews.apache.org/r/30531/#comment116470>
Ditto.
- Jie Yu
On Feb. 4, 2015, 5:22 p.m., Dominic Hamon wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
t;
Ditto here on the jaggedness.
src/tests/paths_tests.cpp
<https://reviews.apache.org/r/30531/#comment116345>
const string&
- Jie Yu
On Feb. 2, 2015, 11:40 p.m., Dominic Hamon wrote:
>
> --
src/tests/resource_offers_tests.cpp 24a7eabd40b11f4bbbf30b8251561e73683eef9a
Diff: https://reviews.apache.org/r/30513/diff/
Testing
---
make check
Thanks,
Jie Yu
r.cpp d04b2c4041d8fe8978b877f07579a6f907903e1b
Diff: https://reviews.apache.org/r/30386/diff/
Testing
---
make check
Thanks,
Jie Yu
? Can you remove it for now?
Killed.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30386/#review70144
-----------
> On Feb. 3, 2015, 11:37 p.m., Jie Yu wrote:
> > src/master/master.cpp, line 3908
> > <https://reviews.apache.org/r/30584/diff/1/?file=846680#file846680line3908>
> >
> > This doesn't seem to necessary since we have master/slave_removals
> > alrea
be incremented in removeSlave(slave) below)?
- Jie Yu
On Feb. 3, 2015, 10:36 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
/resource_offers_tests.cpp 24a7eabd40b11f4bbbf30b8251561e73683eef9a
Diff: https://reviews.apache.org/r/30513/diff/
Testing
---
make check
Thanks,
Jie Yu
view70815
---
On Feb. 3, 2015, 11:15 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
name() is 'disk' in this case.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review70815
-----------
matically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review70600
-------
On Feb. 3, 2015, 11:15 p.m., Jie Yu wrote:
>
> ---
PRE-CREATION
src/tests/resource_offers_tests.cpp 24a7eabd40b11f4bbbf30b8251561e73683eef9a
Diff: https://reviews.apache.org/r/30513/diff/
Testing
---
make check
Thanks,
Jie Yu
f funcitons to make it
const.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30459/#review70429
-------
On
g/r/30514/#comment116201>
indent. align the `<<`
src/tests/slave_tests.cpp
<https://reviews.apache.org/r/30514/#comment116202>
Kill process:: prefix by using namespace process?
- Jie Yu
On Feb. 3, 2015, 2:39 a.m.
er for Rate.
- Jie Yu
On Feb. 3, 2015, 2:39 a.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/
Testing
---
make check
Thanks,
Jie Yu
337e00aa46ea127f3667e3383d631c3fb8e22f30
src/master/master.cpp 10056861b95ed9453c971787982db7d09f09f323
src/messages/messages.proto c609f500e5e999a7587feb8acfb62aa637824c0a
Diff: https://reviews.apache.org/r/30536/diff/
Testing
---
make check
Thanks,
Jie Yu
s 1161-1167
> > <https://reviews.apache.org/r/30510/diff/1/?file=843874#file843874line1161>
> >
> > How can we ensure that such a filesystem isolator is being used?
> > Shouldn't all of this functionality be in one place!?
For now,
containerizer).
- Jie Yu
On Dec. 2, 2014, 10:01 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
The shutdown can be cancelled if a pong is
received before the actually shutdown is called.
```
src/tests/slave_tests.cpp
<https://reviews.apache.org/r/30514/#comment115852>
indent?
src/tests/slave_tests.cpp
<https://reviews.apache.org/r/30514/#com
329d8464f0
Diff: https://reviews.apache.org/r/30509/diff/
Testing
---
make check
Thanks,
Jie Yu
---------
On Feb. 2, 2015, 6:37 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30509/
> ---
g/r/30512/#review70609
---
On Feb. 2, 2015, 7:48 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
discrepency between ext3 and ext4 (for meta data) shouldn't affect the
expections.
Diffs
-
src/tests/disk_quota_tests.cpp 83a98447644a5fa46bffdc7f2ed73bb8411841f5
Diff: https://reviews.apache.org/r/30512/diff/
Testing
---
make check on both ext3 and ext4 systems.
Thanks,
Jie Yu
/master/validation.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/30513/diff/
Testing
---
make check
Thanks,
Jie Yu
/30512/diff/
Testing
---
make check on both ext3 and ext4 systems.
Thanks,
Jie Yu
Thanks,
Jie Yu
src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b
Diff: https://reviews.apache.org/r/30508/diff/
Testing
---
make check.
Thanks,
Jie Yu
/containerizer/mesos/containerizer.hpp
802988c90ac872b0cefa5e28f06e6fec98e8d032
src/slave/containerizer/mesos/containerizer.cpp
d712278428889ebdfd598537690138329d8464f0
Diff: https://reviews.apache.org/r/30510/diff/
Testing
---
make check
Thanks,
Jie Yu
/containerizer.cpp
d712278428889ebdfd598537690138329d8464f0
Diff: https://reviews.apache.org/r/30510/diff/
Testing
---
make check
Thanks,
Jie Yu
/mesos/containerizer.hpp
802988c90ac872b0cefa5e28f06e6fec98e8d032
src/slave/containerizer/mesos/containerizer.cpp
d712278428889ebdfd598537690138329d8464f0
Diff: https://reviews.apache.org/r/30509/diff/
Testing
---
make check
Thanks,
Jie Yu
d712278428889ebdfd598537690138329d8464f0
Diff: https://reviews.apache.org/r/30509/diff/
Testing
---
make check
Thanks,
Jie Yu
/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b
Diff: https://reviews.apache.org/r/30508/diff/
Testing (updated)
---
make check.
Thanks,
Jie Yu
p
mechanism to prevent this from ever biting us.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30459/#review70468
---
On Jan. 31, 201
30459/diff/
Testing
---
make check
Thanks,
Jie Yu
be better to
just apply the patch. I didn't change any core logic, just code morevement.
- Jie Yu
On Jan. 30, 2015, 7:13 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://r
10056861b95ed9453c971787982db7d09f09f323
Diff: https://reviews.apache.org/r/30459/diff/
Testing
---
make check
Thanks,
Jie Yu
/validation.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/30459/diff/
Testing
---
make check
Thanks,
Jie Yu
---
Fixed a bug in Resources::contains.
Diffs
-
src/common/resources.cpp 68f64213c47be4700bcb22cd5b76ba6ff616960d
src/tests/resources_tests.cpp 9fd2135a7545268e2f81915ed0a019de36f3d6e1
Diff: https://reviews.apache.org/r/30430/diff/
Testing
---
make check.
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/#review70263
---
Ship it!
That looks good to me!
- Jie Yu
On Jan. 29, 2015, 6:10
----------
On Jan. 29, 2015, 7:03 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30283/
> ---
src/master/master.cpp 54f26900ac8c63e79a1f89562a988c9a2567d209
Diff: https://reviews.apache.org/r/28781/diff/
Testing
---
make check
Thanks,
Jie Yu
ps://reviews.apache.org/r/28781/#review70137
-------
On Jan. 29, 2015, 12:11 a.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28781/
> --
) send checkpointed resources during register/reregister
Diffs
-
src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6
src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b
Diff: https://reviews.apache.org/r/28809/diff/
Testing
---
make check
Thanks,
Jie Yu
54f26900ac8c63e79a1f89562a988c9a2567d209
Diff: https://reviews.apache.org/r/30298/diff/
Testing
---
make check
Thanks,
Jie Yu
,
Jie Yu
/
Testing
---
make check
Thanks,
Jie Yu
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28809/#review65755
---
On Dec. 8, 2014, 10:19 p.m., Jie Yu wrote:
>
>
> > which point the slave gets them back during re-registration, right?. During
> > registration however, the problem still exists, right?
> >
> > Let's document the details here and/or in a ticket!
This TODO has been resolved by using an all-or-nothing
> On Jan. 20, 2015, 8:45 p.m., Jie Yu wrote:
> > src/tests/master_allocator_tests.cpp, lines 235-236
> > <https://reviews.apache.org/r/29991/diff/1/?file=824066#file824066line235>
> >
> > Ditto Alexander's comments. Could you please do a search for
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29991/#review70158
---
Ship it!
Thanks for the cleanup! LGTM.
- Jie Yu
On Jan. 16
check
Thanks,
Jie Yu
Thanks,
Jie Yu
r.hpp 1d342e56116ad63aade43484b6899ce26f25abfd
src/master/master.cpp 54f26900ac8c63e79a1f89562a988c9a2567d209
Diff: https://reviews.apache.org/r/28781/diff/
Testing
---
make check
Thanks,
Jie Yu
he onDiscard callbacks as well
- Jie Yu
On Jan. 28, 2015, 10 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
tps://reviews.apache.org/r/30297/#comment115037>
EXPECT_TRUE?
3rdparty/libprocess/src/tests/limiter_tests.cpp
<https://reviews.apache.org/r/30297/#comment115038>
Discard 'acquire2'.
- Jie Yu
On Jan. 27, 2015, 12:48
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30192/#review70073
---
Ship it!
Ship It!
- Jie Yu
On Jan. 28, 2015, 1:36 a.m., Vinod
tps://reviews.apache.org/r/30348/#comment115023>
This will race with clearAllCallbacks if one thread is calling f.discard()
and another thread is setting/failing the future.
- Jie Yu
On Jan. 28, 2015, 1:35 a.m., Vinod Kone wrote:
>
> -
361/#comment115022>
I guess the same issue in my patch. We cannot assume resources haven't been
persisted. Let me think about a generic way to solve this problem.
- Jie Yu
On Jan. 28, 2015, 7:46 p.m., Michael Park wrote:
>
> ---
tests, could
you please instead kill this TODO in resource offer tests:
```
// TODO(benh): Add tests which launch multiple tasks and check for
// aggregate resource usage.
```
- Jie Yu
On Jan. 28, 2015, 7:45 p.m., Michael Park wrote
: mesos-git
Description
---
Re-enabled tests for validating persistent volumes.
Diffs
-
src/tests/resource_offers_tests.cpp ffad1f8a2348a772c4e76859844b724018e4629c
Diff: https://reviews.apache.org/r/30349/diff/
Testing
---
make check
Thanks,
Jie Yu
/master/master.cpp ab6d1d17367f199191b7c77bccec73ec3b112d4f
Diff: https://reviews.apache.org/r/28781/diff/
Testing
---
make check
Thanks,
Jie Yu
e in here.
Good catch! Yes!
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28781/#review69909
---
On Jan
781/#comment114742>
I guess here I need to consider dynamic reservation as well. It's likely
that the resources has already been persisted since it's dynamically reserved.
- Jie Yu
On Jan. 27, 2015, 11:02 p.m., Jie Yu wrote:
>
> --
ab6d1d17367f199191b7c77bccec73ec3b112d4f
Diff: https://reviews.apache.org/r/28781/diff/
Testing
---
make check
Thanks,
Jie Yu
1d342e56116ad63aade43484b6899ce26f25abfd
src/master/master.cpp ab6d1d17367f199191b7c77bccec73ec3b112d4f
Diff: https://reviews.apache.org/r/28781/diff/
Testing
---
make check
Thanks,
Jie Yu
ge too at some point?
Yeah, I think so:)
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28781/#review65753
-------
ab6d1d17367f199191b7c77bccec73ec3b112d4f
Diff: https://reviews.apache.org/r/30298/diff/
Testing
---
make check
Thanks,
Jie Yu
/master/master.cpp ab6d1d17367f199191b7c77bccec73ec3b112d4f
Diff: https://reviews.apache.org/r/30298/diff/
Testing
---
make check
Thanks,
Jie Yu
he first to
> recommend
> > that we reintroduce the 'internal' namespace.
> >
> > As for Stout I think we should keep the 'internal' namespace.
> >
> > On Mon, Jan 26, 2015 at 10:25 PM, Jie Yu wrote:
> >
> > > One benefit of having an int
One benefit of having an internal namespace is that it tells the
framework/executor writer that those symbols/method/class are internal to
Mesos core and should not be used.
If we kill all the internal namespaces and move many headers like
isolator.hpp to include/mesos, how does the framework writ
://reviews.apache.org/r/30298/diff/
Testing
---
make check
Thanks,
Jie Yu
---
make check
Thanks,
Jie Yu
(updated)
---
make check
Thanks,
Jie Yu
s, but should this be an Option?
Fixed.
- Jie
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30131/#review69646
---
O
is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30131/#review69364
-----------
On Jan. 26, 2015, 6:21 p.m., Jie Yu wrote:
>
> ---
> This is an automati
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30131/#review69103
---
On Jan. 26, 2015, 6:21 p.m., Jie Yu wrote:
>
> ---
56e5714c2ab97d0ac81d29e1acb1fbec15471489
Diff: https://reviews.apache.org/r/30131/diff/
Testing
---
make check
Thanks,
Jie Yu
tests/limiter_tests.cpp
<https://reviews.apache.org/r/30192/#comment114164>
This test might be flaky if 'AWAIT_READY(acquire1)' takes longer
(unlikely), right?
It would be great if we can pause the clock for this test since timing is
very important for t
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30191/#review69451
---
Ship it!
Ship It!
- Jie Yu
On Jan. 22, 2015, 9:36 p.m., Vinod
> On Jan. 23, 2015, 6 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, lines 156-157
> > <https://reviews.apache.org/r/30111/diff/5/?file=828992#file828992line156>
> >
> > Move this comments to the public read i
eckpointing work, we don't need this
temp + rename because we know the old file does not exist.
What do you think?
- Jie Yu
On Jan. 22, 2015, 5 a.m., Michael Park wrote:
>
> ---
> This is an automatically generate
-
>
> (Updated Jan. 22, 2015, 5 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and
> Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> ---
&
tps://reviews.apache.org/r/30112/#comment114112>
One more blank line
src/tests/protobuf_io_tests.cpp
<https://reviews.apache.org/r/30112/#comment114113>
No need for this temp variable.
s/read/actual
But this is up to you:)
- Jie Yu
On Jan. 21, 2015, 10:32 p.m., Michae
s/3rdparty/stout/include/stout/protobuf.hpp
<https://reviews.apache.org/r/30111/#comment114108>
Could you move these two public interfaces right below the internal Read
struct? We usually put relevant code together (no need to worry about multiple
internal namespace blocks).
- Jie Yu
/protobuf.hpp
<https://reviews.apache.org/r/30110/#comment114107>
the 'message' here can actually be messages.
s/message/t/?
- Jie Yu
On Jan. 23, 2015, 1:38 a.m., Michael Park wrote:
>
> ---
> This is an
ed e-mail. To reply, visit:
https://reviews.apache.org/r/30131/#review69364
-------
On Jan. 21, 2015, 6:12 p.m., Jie Yu wrote:
>
> ---
> This is an a
org/r/30130/diff/
Testing
---
make check
Thanks,
Jie Yu
her than validation on invalid
> > input.
Good point. I'll do it.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30130/#review69354
-
> On Jan. 22, 2015, 11:32 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 298
> > <https://reviews.apache.org/r/30110/diff/4/?file=829591#file829591line298>
> >
> > I thought the consensus was to have a internal write
tps://reviews.apache.org/r/30110/#comment113943>
I thought the consensus was to have a internal write in src/slave/state.hpp
(not here)?
- Jie Yu
On Jan. 22, 2015, 4:52 a.m., Michael Park wrote:
>
> ---
> This is an automati
s.cpp b7c1ddfda952f2d6b7f82e90cfe7b6b0aafbc36a
src/tests/sorter_tests.cpp 56e5714c2ab97d0ac81d29e1acb1fbec15471489
Diff: https://reviews.apache.org/r/30130/diff/
Testing
---
make check
Thanks,
Jie Yu
> > How about 'updateAllocation' now that we avoid using "transformation"?
I am renamed transform to update in sorter.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://rev
601 - 700 of 2378 matches
Mail list logo
