---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review60070
---
Ship it!
Ship It!
- Timothy Chen
On Nov. 4, 2014, 9:28 p.m
://reviews.apache.org/r/27483/#comment101116
We cap comments at 70 char width, but I think we can fix this up before
merging it.
- Timothy Chen
On Nov. 4, 2014, 7:47 p.m., Ankur Chauhan wrote:
---
This is an automatically generated e-mail
On Nov. 4, 2014, 8:07 p.m., Timothy Chen wrote:
Ship It!
Vinod you have any more comments?
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review59819
---
make check
Thanks,
Timothy Chen
with me while i get up to speed.
-- Ankur
On 1 Nov 2014, at 19:23, Timothy Chen t...@mesosphere.io
mailto:t...@mesosphere.io wrote:
Hi Ankur,
Can you post on reviewboard? We can discuss more about the code there.
Tim
Sent from my iPhone
On Nov 1, 2014, at 6:29 PM, Ankur Chauhan
://reviews.apache.org/r/24776/diff/
Testing
---
make check
Thanks,
Timothy Chen
/r/27483/#comment100968
if (result.isSome()) {
src/launcher/fetcher.cpp
https://reviews.apache.org/r/27483/#comment100967
Space between parenthesis and also between starting bracket
You're still working on unit tests right?
- Timothy Chen
On Nov. 3, 2014, 11:09 p.m., Ankur Chauhan
/#comment100969
I think we should leave some comments why we're trying to use HDFS (I think
more specifically the HDFS client right?) to fetch all other URIs, the original
motivation of the refactor.
- Timothy Chen
On Nov. 3, 2014, 11:09 p.m., Ankur Chauhan wrote
/#comment100973
End comments with period.
src/launcher/fetcher.cpp
https://reviews.apache.org/r/27483/#comment100974
Fix spacing
- Timothy Chen
On Nov. 3, 2014, 11:42 p.m., Ankur Chauhan wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736/#review59460
---
Can you rebase on latest master? Then I can merge this.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/#review59461
---
Ship it!
Ship It!
- Timothy Chen
On Oct. 5, 2014, 7:16 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26611/#review59462
---
I believe this is submitted
- Timothy Chen
On Oct. 11, 2014, 10
On Oct. 24, 2014, 4:40 p.m., Timothy Chen wrote:
src/tests/slave_tests.cpp, line 448
https://reviews.apache.org/r/26622/diff/4/?file=731893#file731893line448
Just tried bin/ls on OSX and realize Mac's ls has no --author flag so
this is going to fail on OSX.
It's ok
On Oct. 24, 2014, 4:40 p.m., Timothy Chen wrote:
src/tests/slave_tests.cpp, line 448
https://reviews.apache.org/r/26622/diff/4/?file=731893#file731893line448
Just tried bin/ls on OSX and realize Mac's ls has no --author flag so
this is going to fail on OSX.
It's ok
://reviews.apache.org/r/26736/#comment100752
This is not needed, but I'll remove it for you.
src/tests/docker_containerizer_tests.cpp
https://reviews.apache.org/r/26736/#comment100753
This is not needed, but I'll remove it for you.
- Timothy Chen
On Nov. 1, 2014, 5:13 p.m., Ryan Thomas wrote
On Oct. 24, 2014, 4:40 p.m., Timothy Chen wrote:
src/tests/slave_tests.cpp, line 448
https://reviews.apache.org/r/26622/diff/4/?file=731893#file731893line448
Just tried bin/ls on OSX and realize Mac's ls has no --author flag so
this is going to fail on OSX.
It's ok
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26622/#review59477
---
Ship it!
Ship It!
- Timothy Chen
On Oct. 24, 2014, 2:04 a.m
://reviews.apache.org/r/26736/#comment100760
s/killing/stopping/g
- Timothy Chen
On Nov. 1, 2014, 5:13 p.m., Ryan Thomas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26736
/#comment100779
Let's provide more comments what the timeout param is for.
src/docker/docker.cpp
https://reviews.apache.org/r/26736/#comment100780
Our max line width is 80, so please wrap the params
- Timothy Chen
On Nov. 1, 2014, 8:11 p.m., Ryan Thomas wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27419/#review59313
---
Ship it!
Ship It!
- Timothy Chen
On Oct. 31, 2014, 6:47 a.m
On Oct. 31, 2014, 7:30 a.m., Timothy Chen wrote:
Ship It!
thanks for fixing these! will get this in tomorrow
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27419/#review59313
On Oct. 24, 2014, 4:40 p.m., Timothy Chen wrote:
src/tests/slave_tests.cpp, line 448
https://reviews.apache.org/r/26622/diff/4/?file=731893#file731893line448
Just tried bin/ls on OSX and realize Mac's ls has no --author flag so
this is going to fail on OSX.
It's ok
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27419/#review59431
---
Please close this as this is submitted
- Timothy Chen
On Oct. 31
/containerizer/composing.cpp 9022700
src/tests/composing_containerizer_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/26486/diff/
Testing
---
make check
Thanks,
Timothy Chen
On Oct. 24, 2014, 4:40 p.m., Timothy Chen wrote:
src/tests/slave_tests.cpp, line 448
https://reviews.apache.org/r/26622/diff/4/?file=731893#file731893line448
Just tried bin/ls on OSX and realize Mac's ls has no --author flag so
this is going to fail on OSX.
It's ok
/flags.hpp f7a8cde
Diff: https://reviews.apache.org/r/26861/diff/
Testing
---
make check
Thanks,
Timothy Chen
: https://reviews.apache.org/r/26862/diff/
Testing
---
make with gtest_repeat=-1 gtest_shuffle=1
Thanks,
Timothy Chen
Hi Dominic,
Thanks for the email, sorry I was thinking about writing an email to
the list about the new dependencies but didn't get to it.
I'll let BenH talk about why he used libsvn (libapr is a dependency
for libsvn) for implementing diffs.
I've updated the getting-started.md doc as part of
Hi Tim,
Thanks for doing the integration tests, that's something that I wanted to do
but never got to yet.
I have great interest ensuring spark and mesos work, and I know Brenden as well
does.
I have been tracking these spark mesos problems with spark jira and labeling
them mesos. Can you
-grained mode. We didn't even have to run any commands.
RJ
- Original Message -
From: Timothy Chen tnac...@gmail.com
To: dev@mesos.apache.org
Cc: u...@mesos.apache.org, RJ Nowling rnowl...@redhat.com, Erik
Erlandson e...@redhat.com
Sent: Tuesday, October 28, 2014 11:40:19 AM
fairly generic.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26898/#review58539
---
On Oct. 17, 2014, 10:57 p.m., Timothy Chen
/flags.hpp f7a8cde
Diff: https://reviews.apache.org/r/26861/diff/
Testing
---
make check
Thanks,
Timothy Chen
, 12:46 a.m., Timothy Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26862/
---
(Updated Oct. 22, 2014, 12:46 a.m
: https://reviews.apache.org/r/26862/diff/
Testing
---
make with gtest_repeat=-1 gtest_shuffle=1
Thanks,
Timothy Chen
/diff/
Testing
---
make check
Thanks,
Timothy Chen
Hindman.
Repository: mesos-git
Description
---
Support lxc configurations in docker info
Diffs (updated)
-
include/mesos/mesos.proto 168a7a8
src/docker/docker.cpp 9973782
Diff: https://reviews.apache.org/r/26897/diff/
Testing
---
make check
Thanks,
Timothy Chen
Hindman.
Repository: mesos-git
Description
---
Add hostname option to docker info
Diffs (updated)
-
include/mesos/mesos.proto 168a7a8
src/docker/docker.cpp 9973782
Diff: https://reviews.apache.org/r/26898/diff/
Testing
---
make check
Thanks,
Timothy Chen
/docker_containerizer_tests.cpp 67d60a8
Diff: https://reviews.apache.org/r/26517/diff/
Testing
---
make check
Thanks,
Timothy Chen
Hindman.
Repository: mesos-git
Description
---
Review: https://reviews.apache.org/r/26436
Diffs (updated)
-
src/slave/containerizer/docker.cpp 9a29489
Diff: https://reviews.apache.org/r/26436/diff/
Testing
---
make check
Thanks,
Timothy Chen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26517/#review58938
---
On Oct. 29, 2014, 12:25 a.m., Timothy Chen wrote:
---
This is an automatically generated e
/26517/#comment100181
good catch!
- Timothy Chen
On Oct. 29, 2014, 12:25 a.m., Timothy Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26517
/#review58938
---
On Oct. 29, 2014, 12:25 a.m., Timothy Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26517
/docker_containerizer_tests.cpp 67d60a8
Diff: https://reviews.apache.org/r/26517/diff/
Testing
---
make check
Thanks,
Timothy Chen
---
On Oct. 22, 2014, 12:46 a.m., Timothy Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26862
Description
---
Support both 1.8+ and earlier versions of svn library
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp
117ab0a662bfe2d2b1ec8fa64c6d57bdf1b0004a
Diff: https://reviews.apache.org/r/27243/diff/
Testing
---
make check
Thanks,
Timothy Chen
---
make check
Thanks,
Timothy Chen
/
Testing
---
make check
Thanks,
Timothy Chen
Thanks,
Timothy Chen
---
On Oct. 27, 2014, 10:21 p.m., Timothy Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27243
pass 0 anyway for the version argument,
which svn_txdelta_to_svndiff2 is making explicit.
On Mon, Oct 27, 2014 at 4:13 PM, Timothy Chen tnac...@apache.org wrote:
On Oct. 27, 2014, 11:07 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp, line 116
https
117ab0a662bfe2d2b1ec8fa64c6d57bdf1b0004a
Diff: https://reviews.apache.org/r/27243/diff/
Testing
---
make check
Thanks,
Timothy Chen
117ab0a662bfe2d2b1ec8fa64c6d57bdf1b0004a
Diff: https://reviews.apache.org/r/27243/diff/
Testing
---
make check
Thanks,
Timothy Chen
---
make check
Thanks,
Timothy Chen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26634/#review58537
---
Ship it!
Ship It!
- Timothy Chen
On Oct. 25, 2014, 11:41 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27199/#review58546
---
Ship it!
Ship It!
- Timothy Chen
On Oct. 25, 2014, 8:05 p.m
it but then we need to wrap the test in #ifdef
__linux__
- Timothy Chen
On Oct. 24, 2014, 2:04 a.m., R.B. Boyer wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26622
On Oct. 24, 2014, 4:40 p.m., Timothy Chen wrote:
src/tests/slave_tests.cpp, line 448
https://reviews.apache.org/r/26622/diff/4/?file=731893#file731893line448
Just tried bin/ls on OSX and realize Mac's ls has no --author flag so
this is going to fail on OSX.
It's ok
On Oct. 24, 2014, 4:40 p.m., Timothy Chen wrote:
src/tests/slave_tests.cpp, line 448
https://reviews.apache.org/r/26622/diff/4/?file=731893#file731893line448
Just tried bin/ls on OSX and realize Mac's ls has no --author flag so
this is going to fail on OSX.
It's ok
Should this be wrapped in Error() too?
- Timothy Chen
On Oct. 24, 2014, 9:54 p.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27127
.
Shell=false was added for a reason and I think we shouldn't just change it
for them, did you see why we can't just support this variation in the command
executor?
- Timothy Chen
On Oct. 18, 2014, 4:40 a.m., R.B. Boyer wrote
say you're setting shell and arguments in the
original TaskInfo and checking later those are not used to launch the command
executor?
- Timothy Chen
On Oct. 18, 2014, 4:40 a.m., R.B. Boyer wrote:
---
This is an automatically generated
view, I'll let Ben give a ship it before we put this in.
- Timothy Chen
On Oct. 23, 2014, 4:52 p.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26766
On Oct. 23, 2014, 9:11 p.m., Timothy Chen wrote:
src/tests/slave_tests.cpp, line 420
https://reviews.apache.org/r/26622/diff/2/?file=719278#file719278line420
bells and whistles doesn't seem to be a good description of what you're
trying to do. Perhaps just say you're setting
On Oct. 23, 2014, 9:11 p.m., Timothy Chen wrote:
src/tests/slave_tests.cpp, line 420
https://reviews.apache.org/r/26622/diff/2/?file=719278#file719278line420
bells and whistles doesn't seem to be a good description of what you're
trying to do. Perhaps just say you're setting
, Jie Yu, and Timothy Chen.
Bugs: MESOS-1873
https://issues.apache.org/jira/browse/MESOS-1873
Repository: mesos-git
Description
---
Basically if you use shell=false with a non-empty argument list and the
Command Executor it is completely broken.
When we clone the env
alone C++ unit tests so I was
fighting with the project more than fighting with the bug.
Timothy Chen wrote:
You can pretty much copy the MesosExecutorWithOverride test in
slave_tests.cpp, and just modify the CommandInfo accordingly. Let us know if
you still don't know what to do
: https://reviews.apache.org/r/26862/diff/
Testing
---
make with gtest_repeat=-1 gtest_shuffle=1
Thanks,
Timothy Chen
: https://reviews.apache.org/r/26862/diff/
Testing
---
make with gtest_repeat=-1 gtest_shuffle=1
Thanks,
Timothy Chen
---
On Oct. 17, 2014, 10:57 p.m., Timothy Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26517
/docker_containerizer_tests.cpp 67d60a8
Diff: https://reviews.apache.org/r/26517/diff/
Testing
---
make check
Thanks,
Timothy Chen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26611/#review57408
---
Ship it!
Ship It!
- Timothy Chen
On Oct. 11, 2014, 10:09 p.m
/#review57309
---
On Oct. 17, 2014, 7:32 p.m., Timothy Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26861
://reviews.apache.org/r/26486/diff/
Testing
---
make check
Thanks,
Timothy Chen
/flags.hpp 03c62a2
Diff: https://reviews.apache.org/r/26861/diff/
Testing
---
make check
Thanks,
Timothy Chen
---
On Oct. 17, 2014, 7:33 p.m., Timothy Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26862
:
https://reviews.apache.org/r/26486/#review57522
---
On Oct. 20, 2014, 10:08 p.m., Timothy Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
c44a9ad47d6e1262949b9049f4ae25b049440d99
src/slave/containerizer/composing.cpp
9022700b628d9746a6a8a17c9fbf1b1988da6fca
src/tests/composing_containerizer_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/26486/diff/
Testing
---
make check
Thanks,
Timothy Chen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26486/#review57522
---
On Oct. 21, 2014, 4:42 a.m., Timothy Chen wrote
://reviews.apache.org/r/26486/#review57522
---
On Oct. 21, 2014, 4:42 a.m., Timothy Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26486
/stout/svn.hpp PRE-CREATION
3rdparty/libprocess/configure.ac ee482fc
configure.ac bb4fee4
docs/getting-started.md 1602914
src/Makefile.am c44a9ad
Diff: https://reviews.apache.org/r/26214/diff/
Testing
---
make
Thanks,
Timothy Chen
: https://reviews.apache.org/r/26862/diff/
Testing
---
make with gtest_repeat=-1 gtest_shuffle=1
Thanks,
Timothy Chen
/#comment97596
path asAbsolute as I remember is just sticking a / in front if it doesn't
exist. It seems like it's only relevant in this query string path case?
I don't see how asAbsolute is ever useful anywhere else?
- Timothy Chen
On Oct. 16, 2014, 8:53 p.m., Cody Maloney wrote
src/slave/containerizer/docker.cpp 9a29489
src/slave/flags.hpp 03c62a2
Diff: https://reviews.apache.org/r/26861/diff/
Testing
---
make check
Thanks,
Timothy Chen
: https://reviews.apache.org/r/26862/diff/
Testing
---
make with gtest_repeat=-1 gtest_shuffle=1
Thanks,
Timothy Chen
/containerizer/composing.cpp
9022700b628d9746a6a8a17c9fbf1b1988da6fca
src/tests/composing_containerizer_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/26486/diff/
Testing
---
make check
Thanks,
Timothy Chen
c44a9ad47d6e1262949b9049f4ae25b049440d99
src/slave/containerizer/composing.cpp
9022700b628d9746a6a8a17c9fbf1b1988da6fca
src/tests/composing_containerizer_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/26486/diff/
Testing
---
make check
Thanks,
Timothy Chen
/containerizer/docker.cpp:684
error: src/slave/containerizer/docker.cpp: patch does not apply
error: patch failed: src/slave/flags.hpp:300
error: src/slave/flags.hpp: patch does not apply
Ankur Chauhan wrote:
@Ryan Thomas - do you know what reviewbot is complaining about?
Timothy
Description
---
Add privileged option to docker info
Diffs
-
include/mesos/mesos.proto 6b93e90
src/docker/docker.cpp e09b51c
Diff: https://reviews.apache.org/r/26896/diff/
Testing
---
make check
Thanks,
Timothy Chen
Description
---
Support lxc configurations in docker info
Diffs
-
include/mesos/mesos.proto 6b93e90
src/docker/docker.cpp e09b51c
Diff: https://reviews.apache.org/r/26897/diff/
Testing
---
make check
Thanks,
Timothy Chen
Description
---
Add hostname option to docker info
Diffs
-
include/mesos/mesos.proto 6b93e90
src/docker/docker.cpp e09b51c
Diff: https://reviews.apache.org/r/26898/diff/
Testing
---
make check
Thanks,
Timothy Chen
/docker_containerizer_tests.cpp 67d60a8
Diff: https://reviews.apache.org/r/26517/diff/
Testing
---
make check
Thanks,
Timothy Chen
Hindman.
Repository: mesos-git
Description
---
Review: https://reviews.apache.org/r/26436
Diffs
-
src/slave/containerizer/docker.cpp 9a29489
Diff: https://reviews.apache.org/r/26436/diff/
Testing
---
make check
Thanks,
Timothy Chen
On Oct. 17, 2014, 11:02 p.m., Mesos ReviewBot wrote:
Bad patch!
Reviews applied: [26736]
Failed command: ./support/apply-review.sh -n -r 26736
Error:
--2014-10-17 23:02:08-- https://reviews.apache.org/r/26736/diff/raw/
Resolving reviews.apache.org (reviews.apache.org)...
256df0b
3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION
3rdparty/libprocess/configure.ac ee482fc
configure.ac bb4fee4
docs/getting-started.md 1602914
src/Makefile.am c44a9ad
Diff: https://reviews.apache.org/r/26214/diff/
Testing
---
make
Thanks,
Timothy
://reviews.apache.org/r/26766/#comment97336
Like you said { , } really means the same as { }, so let's just
simplify the code and use the while loop below.
- Timothy Chen
On Oct. 15, 2014, 6:46 p.m., Cody Maloney wrote
On Oct. 15, 2014, 10:47 p.m., Mesos ReviewBot wrote:
Bad patch!
Reviews applied: [26736]
Failed command: git apply --index 26736.patch
Error:
error: patch failed: src/docker/docker.cpp:472
error: src/docker/docker.cpp: patch does not apply
error: patch failed:
Description
---
Instead of removing docker containers right after reap, schedule it to be
removed later.
Diffs
-
src/slave/containerizer/docker.cpp 9a29489
Diff: https://reviews.apache.org/r/26861/diff/
Testing
---
make check
Thanks,
Timothy Chen
/
Testing
---
make with gtest_repeat=-1 gtest_shuffle=1
Thanks,
Timothy Chen
Hi Ryan,
You need to enable cgroups, mount the cpu subsystem and run your tests
under root to run the docker tests.
Also you need to run on Linux with docker version at least 1.0+ with
docker daemon running.
The warning you saw for the CgroupsNoHierarchyTest is specifically for
that set of
total)
[ PASSED ] 0 tests.
YOU HAVE 6 DISABLED TESTS
Am I specifying the wrong filter field for just the docker tests?
Cheers,
Ryan
On 15 October 2014 18:25, Timothy Chen tnac...@gmail.com wrote:
Hi Ryan,
You need to enable cgroups, mount the cpu subsystem and run your tests
401 - 500 of 959 matches
Mail list logo
