---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27806/
---
(Updated Nov. 12, 2014, 4:13 p.m.)
Review request for mesos, Adam B, Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27806/
---
(Updated Nov. 12, 2014, 5:41 p.m.)
Review request for mesos, Adam B, Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27806/
---
(Updated Nov. 12, 2014, 5:41 p.m.)
Review request for mesos, Adam B, Kapil
On Nov. 10, 2014, 7:56 p.m., Niklas Nielsen wrote:
LGTM. I agree with Alex that this ended up being duplicated too many times
and will become a pain to maintain consistently. We haven't had this
problem before, but maybe it's worth a JIRA ticket?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27806/#review60836
---
Ship it!
Ship It!
- Vinod Kone
On Nov. 10, 2014, 1:27 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27806/
---
Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27806/#review60589
---
Bad patch!
Reviews applied: [27493, 27806]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27806/#review60595
---
Ship it!
src/sched/flags.hpp
On Nov. 10, 2014, 2:20 p.m., Alexander Rukletsov wrote:
src/sched/flags.hpp, lines 51-56
https://reviews.apache.org/r/27806/diff/1/?file=756738#file756738line51
Can we extract it and put somewhere as a string constant?
That is a very good point and I actually thought the same a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27806/#review60655
---
LGTM. I agree with Alex that this ended up being duplicated too
On Nov. 10, 2014, 5:45 a.m., Mesos ReviewBot wrote:
Bad patch!
Reviews applied: [27493, 27806]
Failed command: ./support/apply-review.sh -n -r 27806
Error:
2014-11-10 13:45:26 URL:https://reviews.apache.org/r/27806/diff/raw/
[3728/3728] - 27806.patch [1]
error: patch
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27806/#review60760
---
Ship it!
LGTM. I'll go ahead and commit this with the rest, unless
12 matches
Mail list logo