Re: Review Request 27502: Introduced a libev async watcher specifically for updating timers.

.) Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668 Diff: https

Re: Review Request 27351: Libprocess: Introduce enable_shared_from_this configure check

/ax_cxx_compile_stdcxx_11.m4 bf2bd19 Diff: https://reviews.apache.org/r/27351/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere

Re: Review Request 27350: Libprocess: Introduce mutex configure check

/ax_cxx_compile_stdcxx_11.m4 bf2bd19 Diff: https://reviews.apache.org/r/27350/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere

Re: Review Request 27351: Libprocess: Introduce enable_shared_from_this configure check

Diffs (updated) - 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19 Diff: https://reviews.apache.org/r/27351/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere

Re: Review Request 27354: Introduce mutex configure check

/mesos-c++-style-guide.md f50354c m4/ax_cxx_compile_stdcxx_11.m4 72a1080 Diff: https://reviews.apache.org/r/27354/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere

Re: Review Request 27356: Introduce enable_shared_from_this configure check

availability of enable_shared_from_this in style guide Diffs (updated) - docs/mesos-c++-style-guide.md f50354c m4/ax_cxx_compile_stdcxx_11.m4 72a1080 Diff: https://reviews.apache.org/r/27356/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van

Re: Review Request 27508: Used io::poll instead of libev for ignore_data.

/ --- (Updated Nov. 11, 2014, 4:55 p.m.) Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone. Repository: mesos-git Description --- See summary. Diffs - 3rdparty

Re: Review Request 27354: Introduce mutex configure check

--- On Nov. 12, 2014, 7:23 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27354

Review Request 27920: Libprocess: Introduce make_shared configure check

--- ./bootstrap ../configure on gcc-4.4 ../configure on gcc-4.9 Thanks, Joris Van Remoortere

Review Request 27921: Introduce make_shared configure check

-4.4 ../configure on gcc-4.9 Thanks, Joris Van Remoortere

Re: Review Request 27350: Libprocess: Introduce mutex configure check

for Libprocess Diffs (updated) - 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19 Diff: https://reviews.apache.org/r/27350/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere

Review Request 27960: Add read() to socket interface. Use it in process' accept().

Diff: https://reviews.apache.org/r/27960/diff/ Testing --- make check Thanks, Joris Van Remoortere

Review Request 27959: Remove dead connection code in process.cpp.

, Joris Van Remoortere

Review Request 27961: Use socket.read() for ignore_data in process.cpp

Diff: https://reviews.apache.org/r/27961/diff/ Testing --- make check Thanks, Joris Van Remoortere

Review Request 27964: Introduce socket.send() and socket.sendFile(). Use them for linked sockets.

Diff: https://reviews.apache.org/r/27964/diff/ Testing --- make check Thanks, Joris Van Remoortere

Review Request 27963: Virtualize backup(length) and remaining() in Encoder interface.

9c5aa8134c101214d740bf231559ce5b5d51764c Diff: https://reviews.apache.org/r/27963/diff/ Testing --- make check Thanks, Joris Van Remoortere

Review Request 27966: Add bind(), listen(), and accept() to Socket interface. Use these in process.cpp.

/libev.cpp PRE-CREATION 3rdparty/libprocess/src/poll.cpp PRE-CREATION 3rdparty/libprocess/src/process.cpp a34b8702b01dec9c954552de0b923866d172c453 Diff: https://reviews.apache.org/r/27966/diff/ Testing --- make check Thanks, Joris Van Remoortere

Review Request 27965: Use Socket send for temporary connections. remove send_data and send_file code.

: https://reviews.apache.org/r/27965/diff/ Testing --- make check Thanks, Joris Van Remoortere

Review Request 27956: Fix race condition in process.cpp

://reviews.apache.org/r/27956/diff/ Testing --- make check Thanks, Joris Van Remoortere

Review Request 27957: Use std::shared_ptr to do reference counting for libprocess

Diff: https://reviews.apache.org/r/27957/diff/ Testing --- make check Thanks, Joris Van Remoortere

Review Request 27962: Introduce kind enumeration in Encoder.

://reviews.apache.org/r/27962/diff/ Testing --- make check Thanks, Joris Van Remoortere

Review Request 27967: Fix a race between SocketManager link() and send().

, Joris Van Remoortere

Re: Review Request 27956: Fix race condition in process.cpp

--- On Nov. 13, 2014, 2:52 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27956

Re: Review Request 27957: Use std::shared_ptr to do reference counting for libprocess

Van Remoortere

Re: Review Request 27957: Use std::shared_ptr to do reference counting for libprocess

generated e-mail. To reply, visit: https://reviews.apache.org/r/27957/#review61193 --- On Nov. 14, 2014, 8:06 p.m., Joris Van Remoortere wrote: --- This is an automatically generated

Re: Review Request 27958: Add connect() to the socket interface.

/libprocess/include/process/socket.hpp 66838814236fc064a2463399fb15f4a815879bf5 3rdparty/libprocess/src/process.cpp a34b8702b01dec9c954552de0b923866d172c453 Diff: https://reviews.apache.org/r/27958/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 27960: Add read() to socket interface. Use it in process' accept().

a34b8702b01dec9c954552de0b923866d172c453 Diff: https://reviews.apache.org/r/27960/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 27960: Add read() to socket interface. Use it in process' accept().

. To reply, visit: https://reviews.apache.org/r/27960/#review61453 --- On Nov. 14, 2014, 9:19 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 27960: Add read() to socket interface. Use it in process' accept().

66838814236fc064a2463399fb15f4a815879bf5 3rdparty/libprocess/src/process.cpp a34b8702b01dec9c954552de0b923866d172c453 Diff: https://reviews.apache.org/r/27960/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 27961: Use socket.read() for ignore_data in process.cpp

/browse/MESOS-1330 Repository: mesos-git Description --- See Summary. Diffs (updated) - 3rdparty/libprocess/src/process.cpp a34b8702b01dec9c954552de0b923866d172c453 Diff: https://reviews.apache.org/r/27961/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 27961: Use socket.read() for ignore_data in process.cpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27961/#review61402 --- On Nov. 14, 2014, 9:51 p.m., Joris Van Remoortere wrote

Re: Review Request 27962: Introduce kind enumeration in Encoder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27962/#review61404 --- On Nov. 13, 2014, 2:52 a.m., Joris Van Remoortere wrote

Re: Review Request 27964: Introduce socket.send() and socket.sendFile(). Use them for linked sockets.

) - 3rdparty/libprocess/include/process/socket.hpp 66838814236fc064a2463399fb15f4a815879bf5 3rdparty/libprocess/src/process.cpp a34b8702b01dec9c954552de0b923866d172c453 Diff: https://reviews.apache.org/r/27964/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 27960: Add read() to socket interface. Use it in process' accept().

66838814236fc064a2463399fb15f4a815879bf5 3rdparty/libprocess/src/process.cpp a34b8702b01dec9c954552de0b923866d172c453 Diff: https://reviews.apache.org/r/27960/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 27960: Add read() to socket interface. Use it in process' accept().

66838814236fc064a2463399fb15f4a815879bf5 3rdparty/libprocess/src/process.cpp a34b8702b01dec9c954552de0b923866d172c453 Diff: https://reviews.apache.org/r/27960/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 27966: Add bind(), listen(), and accept() to Socket interface. Use these in process.cpp.

/libprocess/src/process.cpp a34b8702b01dec9c954552de0b923866d172c453 Diff: https://reviews.apache.org/r/27966/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 27958: Add connect() to the socket interface.

/include/process/socket.hpp 66838814236fc064a2463399fb15f4a815879bf5 3rdparty/libprocess/src/process.cpp a34b8702b01dec9c954552de0b923866d172c453 Diff: https://reviews.apache.org/r/27958/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 27351: Libprocess: Introduce enable_shared_from_this configure check

/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 eebb4bd53168216ad9a6c93b3e43fb6be589c0af Diff: https://reviews.apache.org/r/27351/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere

Re: Review Request 27920: Libprocess: Introduce make_shared configure check

.m4 eebb4bd53168216ad9a6c93b3e43fb6be589c0af Diff: https://reviews.apache.org/r/27920/diff/ Testing --- ./bootstrap ../configure on gcc-4.4 ../configure on gcc-4.9 Thanks, Joris Van Remoortere

Re: Review Request 27957: Use std::shared_ptr to do reference counting for libprocess

--- On Nov. 14, 2014, 8:06 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27957

Re: Review Request 27958: Add connect() to the socket interface.

Summary. Diffs (updated) - 3rdparty/libprocess/include/process/socket.hpp 66838814236fc064a2463399fb15f4a815879bf5 3rdparty/libprocess/src/process.cpp a34b8702b01dec9c954552de0b923866d172c453 Diff: https://reviews.apache.org/r/27958/diff/ Testing --- make check Thanks, Joris Van

Re: Review Request 27960: Add read() to socket interface. Use it in process' accept().

66838814236fc064a2463399fb15f4a815879bf5 3rdparty/libprocess/src/process.cpp a34b8702b01dec9c954552de0b923866d172c453 Diff: https://reviews.apache.org/r/27960/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 27961: Use socket.read() for ignore_data in process.cpp

--- On Nov. 14, 2014, 9:51 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27961

Re: Review Request 27960: Add read() to socket interface. Use it in process' accept().

/libprocess/include/process/socket.hpp 66838814236fc064a2463399fb15f4a815879bf5 3rdparty/libprocess/src/process.cpp a34b8702b01dec9c954552de0b923866d172c453 Diff: https://reviews.apache.org/r/27960/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 27961: Use socket.read() for ignore_data in process.cpp

a34b8702b01dec9c954552de0b923866d172c453 Diff: https://reviews.apache.org/r/27961/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 27962: Introduce kind enumeration in Encoder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27962/#review61519 --- On Nov. 14, 2014, 10:03 p.m., Joris Van Remoortere wrote: --- This is an automatically

Re: Review Request 27964: Introduce socket.send() and socket.sendFile(). Use them for linked sockets.

/include/process/socket.hpp 66838814236fc064a2463399fb15f4a815879bf5 3rdparty/libprocess/src/process.cpp a34b8702b01dec9c954552de0b923866d172c453 Diff: https://reviews.apache.org/r/27964/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 27965: Use Socket send for temporary connections. remove send_data and send_file code.

9c5aa8134c101214d740bf231559ce5b5d51764c 3rdparty/libprocess/src/process.cpp a34b8702b01dec9c954552de0b923866d172c453 Diff: https://reviews.apache.org/r/27965/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 27966: Add bind(), listen(), and accept() to Socket interface. Use these in process.cpp.

--- On Nov. 14, 2014, 10:52 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27966/ --- (Updated

Re: Review Request 27966: Add bind(), listen(), and accept() to Socket interface. Use these in process.cpp.

/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 27967: Fix a race between SocketManager link() and send().

: https://reviews.apache.org/r/27967/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 27967: Fix a race between SocketManager link() and send().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27967/#review61585 --- On Nov. 15, 2014, 5:33 a.m., Joris Van Remoortere wrote

Re: Review Request 27963: Virtualize backup(length) and remaining() in Encoder interface.

encoders. Diffs (updated) - 3rdparty/libprocess/src/encoder.hpp 9c5aa8134c101214d740bf231559ce5b5d51764c Diff: https://reviews.apache.org/r/27963/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 27967: Fix a race between SocketManager link() and send().

://reviews.apache.org/r/27967/diff/ Testing --- make check Thanks, Joris Van Remoortere

Review Request 28125: Fix compilation error for Socket on older linux + OSX.

the socket. Diffs - 3rdparty/libprocess/include/process/socket.hpp 20136ba4c65883b8bbcc8498e09f7ff7b50b68a4 Diff: https://reviews.apache.org/r/28125/diff/ Testing --- make check on linux make check on macos Thanks, Joris Van Remoortere

Re: Review Request 28125: Fix compilation error for Socket on older linux + OSX.

--- On Nov. 17, 2014, 6:47 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28125/ --- (Updated Nov

Re: Review Request 28125: Fix compilation error for Socket on older linux + OSX.

Thanks, Joris Van Remoortere

Re: Review Request 28125: Fix compilation error for Socket on older linux + OSX.

on macos Thanks, Joris Van Remoortere

Review Request 28137: Fix ProcTest.MultipleThreads hanging. Replace sleep with pthread_testcancel.

: https://reviews.apache.org/r/28137/diff/ Testing --- make check 3rdparty/stout-tests --gtest_repeat=500 Thanks, Joris Van Remoortere

Re: Review Request 28137: Fix ProcTest.MultipleThreads hanging.

sleep with pthread_testcancel. Diffs - 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 56a63e8f5d809f03c70c60d4f02cc500d06ff96e Diff: https://reviews.apache.org/r/28137/diff/ Testing --- make check 3rdparty/stout-tests --gtest_repeat=500 Thanks, Joris Van Remoortere

Review Request 28184: Add thread local to short-circuit run_in_event_loop.

04847e30b0d764d258b8c0971da87180043161f2 3rdparty/libprocess/src/process.cpp 404a32dae1b3d22cb55dcbd084623d6b0cb82c71 Diff: https://reviews.apache.org/r/28184/diff/ Testing --- make check 3rdparty/libprocess/benchmark improved throughput ~27% Thanks, Joris Van Remoortere

Re: Review Request 28184: Add thread local to short-circuit run_in_event_loop.

check 3rdparty/libprocess/benchmark improved throughput ~27% Thanks, Joris Van Remoortere

Re: Review Request 28184: Add thread local to short-circuit run_in_event_loop.

, 9:11 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28184/ --- (Updated Nov. 18, 2014, 9:11 p.m

Review Request 28195: Libprocess Future: factor out callback invocation.

/future.hpp 2e4f9efe53e2e9966f23bd516e61fd9d83ed6b33 Diff: https://reviews.apache.org/r/28195/diff/ Testing --- make check Thanks, Joris Van Remoortere

Review Request 28196: Replace std::queue with std::vector in Libprocess Future.

allocated 3rdparty/libprocess/benchmarks throughput improved ~78% Thanks, Joris Van Remoortere

Re: Review Request 28196: Replace std::queue with std::vector in Libprocess Future.

allocated (new) total heap usage: 188,837 allocs, 188,111 frees, 28,694,829 bytes allocated 3rdparty/libprocess/benchmarks throughput improved ~78% Thanks, Joris Van Remoortere

Re: Review Request 28196: Replace std::queue with std::vector in Libprocess Future.

? - Joris --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28196/#review62070 --- On Nov. 19, 2014, 12:06 a.m., Joris Van Remoortere wrote

Review Request 28205: Removing trailing diff/ from Review line in commit message.

/28205 Thanks, Joris Van Remoortere

Re: Review Request 28205: Removing trailing diff/ from Review line in commit message.

--- Submitted this review using post-review. Commit message review line: Review: https://reviews.apache.org/r/28205 Thanks, Joris Van Remoortere

Re: Review Request 28205: Removing trailing diff/ from Review line in commit message.

/#review62158 --- On Nov. 19, 2014, 5:22 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28205

Re: Review Request 28205: Removing trailing diff/ from Review line in commit message.

--- On Nov. 19, 2014, 5:22 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28205/ --- (Updated Nov. 19

Re: Review Request 27967: Fix a race between SocketManager link() and send().

7a986d7defb03043ec70a48e161ede50deef9b26 Diff: https://reviews.apache.org/r/27967/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 28137: Fix ProcTest.MultipleThreads hanging.

/proc_tests.cpp 56a63e8f5d809f03c70c60d4f02cc500d06ff96e Diff: https://reviews.apache.org/r/28137/diff/ Testing --- make check 3rdparty/stout-tests --gtest_repeat=500 Thanks, Joris Van Remoortere

Re: Review Request 28195: Libprocess Future: factor out callback invocation.

e-mail. To reply, visit: https://reviews.apache.org/r/28195/#review62213 --- On Nov. 19, 2014, 10:16 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail

Re: Review Request 28195: Libprocess Future: factor out callback invocation.

easier to read. It also de-duplicates some code. Diffs (updated) - 3rdparty/libprocess/include/process/future.hpp 2e4f9efe53e2e9966f23bd516e61fd9d83ed6b33 Diff: https://reviews.apache.org/r/28195/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 28196: Replace std::queue with std::vector in Libprocess Future.

allocs, 271,410 frees, 56,981,783 bytes allocated (new) total heap usage: 188,837 allocs, 188,111 frees, 28,694,829 bytes allocated 3rdparty/libprocess/benchmarks throughput improved ~78% Thanks, Joris Van Remoortere

Re: Review Request 28205: Removing trailing diff/ from Review line in commit message.

, Joris Van Remoortere

Re: Review Request 28205: Removing trailing diff/ from Review line in commit message.

using post-review. Commit message review line: Review: https://reviews.apache.org/r/28205 Thanks, Joris Van Remoortere

Re: Review Request 28196: Replace std::queue with std::vector in Libprocess Future.

, 271,410 frees, 56,981,783 bytes allocated (new) total heap usage: 188,837 allocs, 188,111 frees, 28,694,829 bytes allocated 3rdparty/libprocess/benchmarks throughput improved ~78% Thanks, Joris Van Remoortere

Re: Review Request 28195: Libprocess Future: factor out callback invocation.

to make the logic easier to read. It also de-duplicates some code. Diffs - 3rdparty/libprocess/include/process/future.hpp 2e4f9efe53e2e9966f23bd516e61fd9d83ed6b33 Diff: https://reviews.apache.org/r/28195/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 28184: Add thread local to short-circuit run_in_event_loop.

--- make check 3rdparty/libprocess/benchmark improved throughput ~27% Thanks, Joris Van Remoortere

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2581

Hi guys, I've been able to repro this more easily with some the libevent based clock I've been working on. I have a fix for this deadlock, just need to sync up with BenH to walk through it. We should have this fixed soon. @Vinod thanks for the extra information, that's exactly where I was able

Re: Review Request 28184: Add thread local to short-circuit run_in_event_loop.

--- make check 3rdparty/libprocess/benchmark improved throughput ~27% Thanks, Joris Van Remoortere

Review Request 28367: Fix deadlock between SocketManager::send() and internal::send().

- 3rdparty/libprocess/src/process.cpp cf75b51fdae821c9b6c80ddcf2a56ba8bbc63f14 Diff: https://reviews.apache.org/r/28367/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2581

Here is the RB: https://reviews.apache.org/r/28367/ Joris On Fri, Nov 21, 2014 at 11:06 AM, Joris Van Remoortere jo...@mesosphere.io wrote: Hi guys, I've been able to repro this more easily with some the libevent based clock I've been working on. I have a fix for this deadlock, just need

Review Request 28415: Add tests for socket interface.

://reviews.apache.org/r/28415/diff/ Testing --- make check. Thanks, Joris Van Remoortere

Re: Review Request 28315: Refactor clock to simplify libev cut.

dfe9ced2415b8567abb8c137ab73d90b59164d67 Diff: https://reviews.apache.org/r/28315/diff/ Testing --- Thanks, Joris Van Remoortere

Re: Review Request 28316: Reorganize clock event callback functions.

1fd418b31133fd5a5444095ac887c77ee9375b2d 3rdparty/libprocess/src/clock.cpp dfe9ced2415b8567abb8c137ab73d90b59164d67 Diff: https://reviews.apache.org/r/28316/diff/ Testing --- Thanks, Joris Van Remoortere

Re: Review Request 28318: Move last references of libev out of process.cpp.

/libev.hpp a43e7d71fdfb6b6482c53a8cbc74dca4fca86c2e 3rdparty/libprocess/src/libev.cpp 8a557ce1d604f27fc1cc2ce601f1fc94f49d1ae6 3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3 Diff: https://reviews.apache.org/r/28318/diff/ Testing --- Thanks, Joris Van

Re: Review Request 28319: Add enable-libevent flag to Libprocess.

/configure.ac 314c8b842d07e1344659449866f7e85c48854204 3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3 Diff: https://reviews.apache.org/r/28319/diff/ Testing --- Thanks, Joris Van Remoortere

Re: Review Request 28317: Move libev specific parts of clock into libev_clock.

/libprocess/src/libev_clock.cpp PRE-CREATION Diff: https://reviews.apache.org/r/28317/diff/ Testing --- Thanks, Joris Van Remoortere

Re: Review Request 28320: Add multiple include guard to libev.

and Niklas Nielsen. Changes --- Rebased. Repository: mesos-git Description --- See summary. Diffs (updated) - 3rdparty/libprocess/src/libev.hpp a43e7d71fdfb6b6482c53a8cbc74dca4fca86c2e Diff: https://reviews.apache.org/r/28320/diff/ Testing --- Thanks, Joris Van

Re: Review Request 28321: Introduce libevent header and implementation.

PRE-CREATION 3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3 Diff: https://reviews.apache.org/r/28321/diff/ Testing --- Thanks, Joris Van Remoortere

Re: Review Request 28323: Introduce libevent poll implementation.

/r/28323/diff/ Testing --- Thanks, Joris Van Remoortere

Re: Review Request 28322: Introduce libevent clock implementation.

://reviews.apache.org/r/28322/diff/ Testing --- Thanks, Joris Van Remoortere

Re: Review Request 28415: Add tests for socket interface.

3rdparty/libprocess/src/tests/socket_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/28415/diff/ Testing --- make check. Thanks, Joris Van Remoortere

Review Request 28484: Rename Socket read to recv. This is more consistent: send/recv vs. send/read.

--- make check Thanks, Joris Van Remoortere

Review Request 28485: Provide a default bind() in Socket: any port localhost.

/libprocess/include/process/socket.hpp 3f3e01c7e9ecc52042c432212f697b69b3fde3b0 3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3 Diff: https://reviews.apache.org/r/28485/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 28415: Add tests for socket interface.

p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28415/ --- (Updated Nov. 26, 2014, 10:50 p.m

Re: Review Request 28415: Add tests for socket interface.

aebd281da41325a0246f5c57780928afc22a1baa 3rdparty/libprocess/src/tests/socket_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/28415/diff/ Testing --- make check. Thanks, Joris Van Remoortere

<    1   2   3   4   5   >