Re: svn commit: r379759 - /myfaces/core/trunk/api/src/main/java/javax/faces/convert/DoubleConverter.java

2006-02-23 Thread Bruno Aranda
The thing is that it was an error in the spec for jsf 1.1, followed by the ri and myfaces. This has been fixed in the spec for jsf 1.2 (after we found the mistake in 1.1). Regards, Bruno On 2/22/06, Adam Winer <[EMAIL PROTECTED]> wrote: > I'm puzzled here - is the TCK *really* asserting that thi

[jira] Commented: (TOMAHAWK-155) Move ExtensionsFilter to commons so it can be reused outside Tomahawk

2006-02-23 Thread Werner Punz (JIRA)
[ http://issues.apache.org/jira/browse/TOMAHAWK-155?page=comments#action_12367480 ] Werner Punz commented on TOMAHAWK-155: -- The Extensionsfilter is just a web frontend trigger for loading resources. The extensionsfilter is way too problematic for the e

Re: svn commit: r379759 - /myfaces/core/trunk/api/src/main/java/javax/faces/convert/DoubleConverter.java

2006-02-23 Thread Bruno Aranda
BTW, this is MYFACES-778 [1] Bruno [1] http://issues.apache.org/jira/browse/MYFACES-778 On 2/23/06, Bruno Aranda <[EMAIL PROTECTED]> wrote: > The thing is that it was an error in the spec for jsf 1.1, followed by > the ri and myfaces. This has been fixed in the spec for jsf 1.2 (after > we found

Re: html editor component

2006-02-23 Thread Werner Punz
Mike Kienenberger schrieb: > Sorry, I guess my statement could be interpreted multiple ways. > > Currently you have to use a dojo tag, an input, and a piece of inline > javascript to make it work. What I meant was that I'd prefer a > component tag so you'd only have to use the component tag (wh

PMD on MyFaces

2006-02-23 Thread Jurgen Lust
Now that we're using maven2 to build MyFaces, perhaps it's time to take advantage of some of the more interesting plugins, and specifically the PMD plugin: http://pmd.sourceforge.net/ The PMD plugin for maven2 offers 2 report types, a Cut&Paste Detector and a problem detector, with configurabl

Re: ExtensionsFilter does not seem to be THREAD SAFE (Again Urgent!!)

2006-02-23 Thread Mario Ivankovits
Hi! Sorry for all my "urgent" mails, but I address them so only if I really think it IS urgent. ;-) > Yes, that is true. > This turned out to be a serious problem here. Not only the java.lang.StringIndexOutOfBoundsException problem, but also that it might deliver the content of another reques

Commons refactoring - reloaded [was: Once more: Commons refactoring and releasing]

2006-02-23 Thread Manfred Geiler
I recollected all the issues, ideas, and feedback and tried to summarize them (from my personal POV): == Here is a "management summary" of what we could/should end with: * A "myfaces-shared" project, housing all MyFaces-specific classes shared between impl

[jira] Closed: (TOMAHAWK-155) Move ExtensionsFilter to commons so it can be reused outside Tomahawk

2006-02-23 Thread sean schofield (JIRA)
[ http://issues.apache.org/jira/browse/TOMAHAWK-155?page=all ] sean schofield closed TOMAHAWK-155: --- Resolution: Won't Fix > Move ExtensionsFilter to commons so it can be reused outside Tomahawk > ---

Re: ExtensionsFilter does not seem to be THREAD SAFE (Again Urgent!!)

2006-02-23 Thread Martin Marinschek
+1 regards, Martin On 2/23/06, Mario Ivankovits <[EMAIL PROTECTED]> wrote: > Hi! > > Sorry for all my "urgent" mails, but I address them so only if I really > think it IS urgent. ;-) > > > Yes, that is true. > > > This turned out to be a serious problem here. > > Not only the java.lang.StringInd

acceptcharset vs. acceptCharset

2006-02-23 Thread Arvid Hülsebus
Hello, is it intended that the acceptCharset attribute of is written in mixed case in MyFaces 1.1.1 and lower case in the Sun RI 1.1.01? Thanks in advance, Arvid

Re: Commons refactoring - reloaded [was: Once more: Commons refactoring and releasing]

2006-02-23 Thread Sean Schofield
> * myfaces-shared will have sub-modules that represent the custom > dependency libs with private namespace for each MyFaces subproject > that needs shared classes (only impl and tomahawk so far). All (=both) > artifacts will automatically be created from the same source that sits > in the Maven p

Re: PMD on MyFaces

2006-02-23 Thread Sean Schofield
Interesting idea. I think for the next few days we will have our hands full with the commons refactor but I'm open to trying it out. Not sure if the license matters since we are not actually distributing the plugin. Maven is the one downloading it. Sean On 2/23/06, Jurgen Lust <[EMAIL PROTECTE

[jira] Updated: (TOMAHAWK-83) Changes in navigationMenuItem jsf component to make it work with HtmlCommandJSCookMenu (action) or any simple URL

2006-02-23 Thread Darlan Oliveira (JIRA)
[ http://issues.apache.org/jira/browse/TOMAHAWK-83?page=all ] Darlan Oliveira updated TOMAHAWK-83: > Changes in navigationMenuItem jsf component to make it work with > HtmlCommandJSCookMenu (action) or any simple URL > --

[jira] Updated: (TOMAHAWK-82) t:commandNavigation2 rendering ignores static text of its value attribute, iff layout="list"

2006-02-23 Thread Mathias Stein (JIRA)
[ http://issues.apache.org/jira/browse/TOMAHAWK-82?page=all ] Mathias Stein updated TOMAHAWK-82: -- > t:commandNavigation2 rendering ignores static text of its value attribute, > iff layout="list" > ---

Re: Commons refactoring - reloaded [was: Once more: Commons refactoring and releasing]

2006-02-23 Thread Manfred Geiler
On 2/23/06, Sean Schofield <[EMAIL PROTECTED]> wrote: > > * myfaces-shared will have sub-modules that represent the custom > > dependency libs with private namespace for each MyFaces subproject > > that needs shared classes (only impl and tomahawk so far). All (=both) > > artifacts will automatica

Re: future vision for MyFaces "commons"

2006-02-23 Thread Sean Schofield
> I don't understand this; don't the component APIs matter? Do > you truly believe that MyFaces should feel free to make any change > at any time? The component API's matter but I don't hold the components to the same standard as I would a language or framework. I think its unrealistic for a us

Re: future vision for MyFaces "commons"

2006-02-23 Thread Adam Winer
On 2/23/06, Sean Schofield <[EMAIL PROTECTED]> wrote: > > I don't understand this; don't the component APIs matter? Do > > you truly believe that MyFaces should feel free to make any change > > at any time? > > The component API's matter but I don't hold the components to the same > standard as I

Re: future vision for MyFaces "commons"

2006-02-23 Thread Craig McClanahan
On 2/23/06, Sean Schofield <[EMAIL PROTECTED]> wrote: > I don't understand this;  don't the component APIs matter?  Do> you truly believe that MyFaces should feel free to make any change> at any time?The component API's matter but I don't hold the components to the same standard as I would a langua

[jira] Reopened: (TOMAHAWK-155) Move ExtensionsFilter to commons so it can be reused outside Tomahawk

2006-02-23 Thread Mike Kienenberger (JIRA)
[ http://issues.apache.org/jira/browse/TOMAHAWK-155?page=all ] Mike Kienenberger reopened TOMAHAWK-155: I don't think you should have closed this issue, especially on such short notice. Currently the extension filter *IS* the defacto way to do

Re: future vision for MyFaces "commons"

2006-02-23 Thread Mike Kienenberger
On 2/22/06, Sean Schofield <[EMAIL PROTECTED]> wrote: > In response to #1 I would say we do not need to be in the business of > ensuring developers can rely on our public API's. From my perspective > we are in the business of providing a JSF implementation and a series > of components and addons f

RE: future vision for MyFaces "commons"

2006-02-23 Thread Danner, Russ
To this point. I would really like to see some of the faces rendering implementation technologies getting together and making child standard APIS. Let me explain: If you look at the RI, they have a set of utils for handling the creation of Javascript, hidden fields, etc. MyFaces has it's own. I

Re: acceptcharset vs. acceptCharset

2006-02-23 Thread Dennis Byrne
Hi Arvid, There is a bug for this and a rather large set of other differences w/ the RI. I think "HTML" and "TLD" are somewhere in the name of the issue. Dennis Byrne >-Original Message- >From: Arvid Hülsebus [mailto:[EMAIL PROTECTED] >Sent: Thursday, February 23, 2006 09:06 AM >To: 'M

[jira] Commented: (TOMAHAWK-2) PRETTY_HTML option is not being universally honored

2006-02-23 Thread Mike Kienenberger (JIRA)
[ http://issues.apache.org/jira/browse/TOMAHAWK-2?page=comments#action_12367535 ] Mike Kienenberger commented on TOMAHAWK-2: -- The concensus at the time was to remove it. No one has been sufficiently motivated to do that yet. Adding IndentingReponse

tomahawk test failed in StylesheetRendererTest and HtmlDataTableTest

2006-02-23 Thread Mario Ivankovits
Hi! This is what I get if I try to build myfaces with tests enabled: [ stacktrace ] --- java.lang.IllegalArgumentException: HTML_BASIC at org.apache.shale.test.mock.MockRenderKitFactory.addRenderKit(MockRenderKitFactory.java:69)

Re: tomahawk test failed in StylesheetRendererTest and HtmlDataTableTest

2006-02-23 Thread Dennis Byrne
Try deleting struts/shale/shale-test.jar in your local repo and running the tests again. Dennis Byrne >-Original Message- >From: Mario Ivankovits [mailto:[EMAIL PROTECTED] >Sent: Thursday, February 23, 2006 12:15 PM >To: 'MyFaces Development' >Subject: tomahawk test failed in StylesheetR

[jira] Created: (MYFACES-1152) HTTP Accept header not properly processed

2006-02-23 Thread Chris Paulson-Ellis (JIRA)
HTTP Accept header not properly processed - Key: MYFACES-1152 URL: http://issues.apache.org/jira/browse/MYFACES-1152 Project: MyFaces Core Type: Bug Components: General Versions: 1.1.1 Reporter: Chris Paulson-El

[jira] Updated: (MYFACES-1152) HTTP Accept header not properly processed

2006-02-23 Thread Chris Paulson-Ellis (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-1152?page=all ] Chris Paulson-Ellis updated MYFACES-1152: - > HTTP Accept header not properly processed > - > > Key: MYFACES-1152 > URL: http://is

Re: tomahawk test failed in StylesheetRendererTest and HtmlDataTableTest

2006-02-23 Thread Mario Ivankovits
Hi Dennis! > Try deleting struts/shale/shale-test.jar in your local repo and running the > tests again. > I already used mvn -U to update the repository, but it looks like you have to delete it. Now it works. Thanks! Ciao, Mario

Re: svn commit: r380161 - /myfaces/tomahawk/branches/1_1_2/

2006-02-23 Thread Mario Ivankovits
Hi! > new tomahawk branch > > Added: > myfaces/tomahawk/branches/1_1_2/ > - copied from r380160, myfaces/tomahawk/trunk/ > I am already working on a fix for the treading problem with AddResource. Even in myfaces-commons this will influence tomahawk too (testCase and extensionFilter) Wi

Re: svn commit: r380161 - /myfaces/tomahawk/branches/1_1_2/

2006-02-23 Thread Sean Schofield
That's ok we can work your fix in later. Right now I am refactoring the commons stuff so we need a branch to do that. We can merge this branch down and then create a new one again (so we will capture your fix at that point.) Just make your fix on the trunk. Sean On 2/23/06, Mario Ivankovits <[

Re: JIRA Changes

2006-02-23 Thread Mike Kienenberger
+1 for creating a jira component to JSF component mapping. Don't really care if we use * or sbx or sandbox or just leave them all the same. The sandbox/tomahawk division is just an indication of stability/support. I don't see it as an important distinction in the context of reporting JIRA issues.

Re: More JIRA Changes

2006-02-23 Thread Mike Kienenberger
On 2/21/06, Sean Schofield <[EMAIL PROTECTED]> wrote: > I made another improvement to our JIRA setup. I added a "Patch > Available" state. There is now an operation called "Provide Patch" > that users can click once they have attached a patch. It will then > place the issue in the "Patch Availab

Re: JIRA Changes

2006-02-23 Thread Sean Schofield
> The sandbox/tomahawk division is just an indication of > stability/support. I don't see it as an important distinction in the > context of reporting JIRA issues. Exactly.

[jira] Commented: (MYFACES-837) WelcomeFileFilter wants to go to the internet to load web.xml DTD

2006-02-23 Thread sean schofield (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-837?page=comments#action_12367558 ] sean schofield commented on MYFACES-837: These files are also in shared which seem confusing to me. > WelcomeFileFilter wants to go to the internet to load web.xml D

[jira] Resolved: (TOMAHAWK-108) ExtensionsFilter is not THREAD SAFE

2006-02-23 Thread Mario Ivankovits (JIRA)
[ http://issues.apache.org/jira/browse/TOMAHAWK-108?page=all ] Mario Ivankovits resolved TOMAHAWK-108: --- Resolution: Fixed Made AddResource request scope so it is request safe now. Its still not "thread safe" but this is not required as the req

[jira] Closed: (TOMAHAWK-108) ExtensionsFilter is not THREAD SAFE

2006-02-23 Thread Mario Ivankovits (JIRA)
[ http://issues.apache.org/jira/browse/TOMAHAWK-108?page=all ] Mario Ivankovits closed TOMAHAWK-108: - > ExtensionsFilter is not THREAD SAFE > --- > > Key: TOMAHAWK-108 > URL: http://issues.apache.org

Re: Commons refactoring - reloaded [was: Once more: Commons refactoring and releasing]

2006-02-23 Thread Sean Schofield
Yes that makes more sense. I created the svn branch for tomahawk. I started the refactoring but I didn't make much progress so feel free to start fresh. There are 3 classes in the core branch that are now in shared and the core since they were moved to shared after the core branch (see MYFACES-1

Re: tomahawk test failed in StylesheetRendererTest and HtmlDataTableTest

2006-02-23 Thread Sean Schofield
Everyone has the same problem. It must be a bug in maven. Sean On 2/23/06, Mario Ivankovits <[EMAIL PROTECTED]> wrote: > Hi Dennis! > > Try deleting struts/shale/shale-test.jar in your local repo and running the > > tests again. > > > I already used mvn -U to update the repository, but it looks

[jira] Commented: (MYFACES-837) WelcomeFileFilter wants to go to the internet to load web.xml DTD

2006-02-23 Thread sean schofield (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-837?page=comments#action_12367562 ] sean schofield commented on MYFACES-837: OK now I know what happened. They are still in core on the branch because the branch is old. > WelcomeFileFilter wants to

Re: Commons refactoring - reloaded [was: Once more: Commons refactoring and releasing]

2006-02-23 Thread Volker Weber
Hi, On 19:53 Sean Schofield wrote: > The refactoring will be a pain because both JBuilder and Idea want to > rename the package in all of the modules and not just commons. after running 'mvn idea:idea' there should be a commons only project file 'myfaces-commons.ipr' in the commons dir. IMO this

Re: Commons refactoring - reloaded [was: Once more: Commons refactoring and releasing]

2006-02-23 Thread Sean Schofield
Well I'm new to idea so I did not have time to experiment. It still seems like that would be a problem because we want the tomahawk and core classes to be refactoring to use the new package. We just don't want their classes in the same dirs to move. Sean On 2/23/06, Volker Weber <[EMAIL PROTECT

Re: PMD on MyFaces

2006-02-23 Thread Matthias Wessendorf
I think BSD makes no problem On 2/23/06, Sean Schofield <[EMAIL PROTECTED]> wrote: > Interesting idea. I think for the next few days we will have our > hands full with the commons refactor but I'm open to trying it out. > Not sure if the license matters since we are not actually distributing >

Re: future vision for MyFaces "commons"

2006-02-23 Thread Adam Winer
On 2/23/06, Craig McClanahan <[EMAIL PROTECTED]> wrote: > > > On 2/23/06, Sean Schofield <[EMAIL PROTECTED]> wrote: > > > I don't understand this; don't the component APIs matter? Do > > > you truly believe that MyFaces should feel free to make any change > > > at any time? > > > > The component

[jira] Updated: (TOMAHAWK-50) equals validator shows text (nit nice by validating passwords...)

2006-02-23 Thread Mike Kienenberger (JIRA)
[ http://issues.apache.org/jira/browse/TOMAHAWK-50?page=all ] Mike Kienenberger updated TOMAHAWK-50: -- > equals validator shows text (nit nice by validating passwords...) > - > > Ke

[jira] Updated: (MYFACES-801) RegExprValidatorTag patch: message attribute

2006-02-23 Thread Mike Kienenberger (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-801?page=all ] Mike Kienenberger updated MYFACES-801: -- > RegExprValidatorTag patch: message attribute > > > Key: MYFACES-801 > URL: http://issu

Re: future vision for MyFaces "commons"

2006-02-23 Thread John Fallows
+1 to Adam and Craig's excellent points.Kind Regards,John Fallows.On 2/23/06, Adam Winer <[EMAIL PROTECTED] > wrote:On 2/23/06, Craig McClanahan < [EMAIL PROTECTED]> wrote:>>> On 2/23/06, Sean Schofield <[EMAIL PROTECTED]> wrote:> > > I don't understand this;  don't the component APIs matter?  Do >

[jira] Updated: (TOMAHAWK-150) custom ScheduleEntryRenderer is applied to all schedule components in the same application

2006-02-23 Thread Jurgen Lust (JIRA)
[ http://issues.apache.org/jira/browse/TOMAHAWK-150?page=all ] Jurgen Lust updated TOMAHAWK-150: - > custom ScheduleEntryRenderer is applied to all schedule components in the > same application > --

[jira] Updated: (TOMAHAWK-104) dataScroller "divide by zero" error should be changed to a "missing row attribute" error

2006-02-23 Thread Anonymous (JIRA)
[ http://issues.apache.org/jira/browse/TOMAHAWK-104?page=all ] updated TOMAHAWK-104: -- > dataScroller "divide by zero" error should be changed to a "missing row > attribute" error > --

[jira] Commented: (MYFACES-1148) Weblogic Classloader problems during development (FactoryFinder)

2006-02-23 Thread Adam Brod (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-1148?page=comments#action_12367592 ] Adam Brod commented on MYFACES-1148: Well, I'm still working with Bea to see if they can provide a great solution. However, I have found one cause in the MyFaces Star

[jira] Resolved: (TOMAHAWK-146) Schedule renders duplicate ids in render tree

2006-02-23 Thread Jurgen Lust (JIRA)
[ http://issues.apache.org/jira/browse/TOMAHAWK-146?page=all ] Jurgen Lust resolved TOMAHAWK-146: -- Resolution: Fixed This problem occurred in the old example jsps, it no longer applies for the new examples > Schedule renders duplicate ids in rend

[jira] Resolved: (TOMAHAWK-148) Schedule component in Sandbox fails to run on WebSphere Application Server 5.1.1.8

2006-02-23 Thread Jurgen Lust (JIRA)
[ http://issues.apache.org/jira/browse/TOMAHAWK-148?page=all ] Jurgen Lust resolved TOMAHAWK-148: -- Resolution: Duplicate Assign To: Jurgen Lust this is a duplicate of TOMAHAWK-146 > Schedule component in Sandbox fails to run on WebSphere Appl

[jira] Closed: (TOMAHAWK-146) Schedule renders duplicate ids in render tree

2006-02-23 Thread sean schofield (JIRA)
[ http://issues.apache.org/jira/browse/TOMAHAWK-146?page=all ] sean schofield closed TOMAHAWK-146: --- > Schedule renders duplicate ids in render tree > - > > Key: TOMAHAWK-146 > URL: http://i

[jira] Closed: (TOMAHAWK-148) Schedule component in Sandbox fails to run on WebSphere Application Server 5.1.1.8

2006-02-23 Thread sean schofield (JIRA)
[ http://issues.apache.org/jira/browse/TOMAHAWK-148?page=all ] sean schofield closed TOMAHAWK-148: --- > Schedule component in Sandbox fails to run on WebSphere Application Server > 5.1.1.8 > -