[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core

2011-11-09 Thread Leonardo Uribe (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147411#comment-13147411 ] Leonardo Uribe commented on MYFACES-3368: - Fixed almost all checkstyle rules on

[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core

2011-10-27 Thread Mark Struberg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13137507#comment-13137507 ] Mark Struberg commented on MYFACES-3368: Leo, can you please check the following

[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core

2011-10-27 Thread Leonardo Uribe (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13138042#comment-13138042 ] Leonardo Uribe commented on MYFACES-3368: - Ok, no problem, but give me some

[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core

2011-10-25 Thread Mark Struberg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134783#comment-13134783 ] Mark Struberg commented on MYFACES-3368: I know Leo, but somewhen we had to do

[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core

2011-10-25 Thread Mark Struberg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134930#comment-13134930 ] Mark Struberg commented on MYFACES-3368: Leo, I now finished the

[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core

2011-10-25 Thread Leonardo Uribe (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13135166#comment-13135166 ] Leonardo Uribe commented on MYFACES-3368: - I checked them and fix the checkstyle

[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core

2011-10-24 Thread Bernd Bohmann (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133924#comment-13133924 ] Bernd Bohmann commented on MYFACES-3368: what are the 'standard' myfaces rules?

[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core

2011-10-24 Thread Bernd Bohmann (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133936#comment-13133936 ] Bernd Bohmann commented on MYFACES-3368: please look at

[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core

2011-10-24 Thread Mark Struberg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133937#comment-13133937 ] Mark Struberg commented on MYFACES-3368: svn co

[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core

2011-10-24 Thread Bernd Bohmann (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133941#comment-13133941 ] Bernd Bohmann commented on MYFACES-3368: Are you care that are the 'standard'

[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core

2011-10-24 Thread Mark Struberg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133943#comment-13133943 ] Mark Struberg commented on MYFACES-3368: the sun conventions are 12 years old

[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core

2011-10-24 Thread Bernd Bohmann (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133946#comment-13133946 ] Bernd Bohmann commented on MYFACES-3368: Why do you think the are archaic I

[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core

2011-10-24 Thread Mark Struberg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133947#comment-13133947 ] Mark Struberg commented on MYFACES-3368: Just as an explanation about _why_ I'm

[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core

2011-10-24 Thread Mark Struberg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133948#comment-13133948 ] Mark Struberg commented on MYFACES-3368: Bernd, if there is some particular

[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core

2011-10-24 Thread Bernd Bohmann (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133950#comment-13133950 ] Bernd Bohmann commented on MYFACES-3368: I agree with enforcing braces and other

[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core

2011-10-24 Thread Mark Struberg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133954#comment-13133954 ] Mark Struberg commented on MYFACES-3368: but if someone force me to use '_ '

[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core

2011-10-24 Thread Michael Kurz (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133963#comment-13133963 ] Michael Kurz commented on MYFACES-3368: --- Btw.: Is [1] really the only and definite

[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core

2011-10-24 Thread Mark Struberg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133964#comment-13133964 ] Mark Struberg commented on MYFACES-3368: Yes, absolutely! I came across this

[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core

2011-10-24 Thread Michael Kurz (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133973#comment-13133973 ] Michael Kurz commented on MYFACES-3368: --- Yes, it didn't work for me too on IDEA

[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core

2011-10-24 Thread Leonardo Uribe (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134750#comment-13134750 ] Leonardo Uribe commented on MYFACES-3368: - Just one comment: apply this