Re: MyFaces shipping with JBoss AS6?

2010-08-20 Thread Leonardo Uribe
Hi Just for your information, I committed the proposal on MYFACES-2863. Suggestions are welcome. regards, Leonardo Uribe 2010/8/4 ssilv...@redhat.com Hi guys, Would you like to see MyFaces Core ship with JBoss AS6? If so, read on. If you've been around MyFaces awhile, you probably

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-11 Thread Matthias Wessendorf
On Tue, Aug 10, 2010 at 11:55 PM, Bernd Bohmann bernd.bohm...@atanion.com wrote: Hello, why we need the @author tag? I don't like code owner ship. well, some do. I am fine without. In fact a lot of Apache project do so, since there is no code-ownership. SVN has still all the information

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-11 Thread Jan-Kees van Andel
Hey, I'm not a big fan of code ownership either, but the proposal was just to remove the redundant stuff. If there is a consensus about removing the @author tag too, that's fine with me. Removing all this stuff at once is easier than having multiple runs where we remove one thing at a time.

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-11 Thread Michael Kurz
I would also get rid of the author tags too. I guess that in many cases they are not correct anyway as files are constantly changed. Michael Am 11.08.2010 08:22, schrieb Matthias Wessendorf: On Tue, Aug 10, 2010 at 11:55 PM, Bernd Bohmann bernd.bohm...@atanion.com wrote: Hello, why we need

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-11 Thread Matthias Wessendorf
On Wed, Aug 11, 2010 at 8:38 AM, Jan-Kees van Andel jankeesvanan...@gmail.com wrote: Hey, I'm not a big fan of code ownership either, but the proposal was just to remove the redundant stuff. If there is a consensus about removing the @author tag too, that's fine with me. Removing all this

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-11 Thread Matthias Wessendorf
On Wed, Aug 11, 2010 at 8:40 AM, Michael Kurz michi.k...@gmx.at wrote: I would also get rid of the author tags too. I guess that in many cases they are not correct anyway as files are constantly changed. exactly, and still svn (blame) knows everything... Original committer and who introduced

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-11 Thread Ganesh
I'd like to keep the @author tags. Isn't the spirit of the meritocracy involved with making authors visible? Shouldn't personal merit for a project be made visible in the code? I think it's great to see Manfred Geiler as the orginal author of most MyFaces parts. Many people download the source

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-11 Thread Matthias Wessendorf
On Wed, Aug 11, 2010 at 9:21 AM, Ganesh gan...@j4fry.org wrote: I'd like to keep the @author tags. Isn't the spirit of the meritocracy involved with making authors visible? Actually not... There are a ton of discussions on this in the archives. Fact: there is no code ownership... Shouldn't

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-11 Thread Matthias Wessendorf
On Wed, Aug 11, 2010 at 9:31 AM, Matthias Wessendorf mat...@apache.org wrote: On Wed, Aug 11, 2010 at 9:21 AM, Ganesh gan...@j4fry.org wrote: I'd like to keep the @author tags. Isn't the spirit of the meritocracy involved with making authors visible? Actually not... There are a ton of

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-11 Thread Jakob Korherr
Hi guys, +1 on removing all this stuff. Frankly I always added or changed the headers to include author and version information, but only because I read it in the MyFaces developer notes [1] and the referenced Struts svn guide [2] in the wiki. @Jan-Kees: I don't really understand what you mean

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-11 Thread Matthias Wessendorf
On Wed, Aug 11, 2010 at 10:43 AM, Jakob Korherr jakob.korh...@gmail.com wrote: Hi guys, +1 on removing all this stuff. Frankly I always added or changed the headers to include author and version information, but only because I read it in the MyFaces developer notes [1] and the referenced

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-11 Thread Ganesh
there are other social issues dealing with collaborative development, but the Board is concerned about the legal ramifications around the use of author tags OK, I see the point.

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-10 Thread Werner Punz
+1 of removing this, the info is in svn anyway, why duplicate it? Werner Am 09.08.10 21:43, schrieb Jan-Kees van Andel: Hi, What do you guys think about pruning the SVN keywords in the source files? Matthias pointed out a nice example of an issue you run into with this stuff. 1 Not

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-10 Thread Jan-Kees van Andel
Hi, The issue has been filed: https://issues.apache.org/jira/browse/MYFACES-2871 About the guidelines Michael referred to: - I suggest to completely get rid of all SVN related stuff. - I think it's ok to keep the @author tags. - Also the @since tags seem useful to me. In other words, drop all

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-10 Thread Leonardo Uribe
Hi Could you provide an explicit example about how the header of java files should be? best regards, Leonardo

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-10 Thread Jan-Kees van Andel
Hi, Sure. For example, take a look at: http://svn.apache.org/repos/asf/myfaces/core/trunk/api/src/main/java/javax/faces/FacesException.java If we remove the SVN stuff, we'll end up with this JavaDoc comment: /** * see Javadoc of a href=

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-10 Thread Bernd Bohmann
Hello, why we need the @author tag? I don't like code owner ship. Does your request mean we don't allow the svn:keywords=Date Author Id Revision HeadURL in the Subversion config file? Regards Bernd On Tue, Aug 10, 2010 at 10:00 PM, Jan-Kees van Andel jankeesvanan...@gmail.com wrote: Hi,

Re: MyFaces shipping with JBoss AS6?

2010-08-09 Thread Leonardo Uribe
Hi Stan I have attached a proposal for this issue on: https://issues.apache.org/jira/browse/MYFACES-2860 It includes the patch to be applied on myfaces, the project created to do the integration, and the jsf deployer used in JBoss AS6 to give a try. It could be good to know what do yo think

Re: MyFaces shipping with JBoss AS6?

2010-08-09 Thread Matthias Wessendorf
+ * @author Leonardo Uribe (latest modification by $Author: jankeesvanandel $) + * @version $Revision: 799929 $ $Date: 2009-08-01 16:29:33 -0500 (sáb, 01 ago 2009) $ did you copy that into your IDE template for new files? :-) -M On Mon, Aug 9, 2010 at 7:25 PM, Leonardo Uribe lu4...@gmail.com

Re: MyFaces shipping with JBoss AS6?

2010-08-09 Thread Jan-Kees van Andel
Yeah, I know. I'm so quick. I can edit files back in time. ;-) /JK 2010/8/9 Matthias Wessendorf mat...@apache.org + * @author Leonardo Uribe (latest modification by $Author: jankeesvanandel $) + * @version $Revision: 799929 $ $Date: 2009-08-01 16:29:33 -0500 (sáb, 01 ago 2009) $ did

Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-09 Thread Jan-Kees van Andel
Hi, What do you guys think about pruning the SVN keywords in the source files? Matthias pointed out a nice example of an issue you run into with this stuff. 1 Not everybody has (the same) svn:keywords on every file. 2 When 1, it will get out of sync. 3 Unreadable version numbers are pretty

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-09 Thread Gerhard
+1 these are the reasons why you won't find such information in the extensions projects. regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2010/8/9 Jan-Kees van Andel

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-09 Thread Mark Struberg
+1 because it's most times broken anyway ;) LieGrue, strub From: Gerhard gerhard.petra...@gmail.com To: MyFaces Development dev@myfaces.apache.org Sent: Mon, August 9, 2010 11:22:34 PM Subject: Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?) +1

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-09 Thread Michael Kurz
: Gerhardgerhard.petra...@gmail.com To: MyFaces Developmentdev@myfaces.apache.org Sent: Mon, August 9, 2010 11:22:34 PM Subject: Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?) +1 these are the reasons why you won't find such information in the extensions

Re: MyFaces shipping with JBoss AS6?

2010-08-05 Thread Matthias Wessendorf
Hello Stan, welcome back. We do understand that you can not make any promise on that topic. The fact that some folks at JBoss are thinking about shipping MyFaces (as an alternative option) is a good news for this entire community here. Especially it is a great motivation for the folks that did

Re: MyFaces shipping with JBoss AS6?

2010-08-05 Thread Jan-Kees van Andel
Hi, Great news! It would be very nice if JBoss ships with MyFaces 2. This also opens up possibilities to do some enhancements to increase developer productivity in JBoss, like better resource reloading and so on. Or doing some things more efficient by plugging into the JBoss infrastructure. Just

Re: MyFaces shipping with JBoss AS6?

2010-08-05 Thread Matthias Wessendorf
At Apache we can not have code that contains (L)GPL code; or depends on it. We had discussion(s) about this in the past. The below link contains references to other (Apache) documents: http://markmail.org/message/qtc4g6vsracgzbok -Matthias On Thu, Aug 5, 2010 at 9:55 AM, Jan-Kees van Andel

Re: MyFaces shipping with JBoss AS6?

2010-08-05 Thread Martin Marinschek
Hi guys, sure we would want to have this! @Leonardo: can you take care of this high priority (next to your optimization and performance improvement work)? best regards, Martin On 8/4/10, ssilv...@redhat.com ssilv...@redhat.com wrote: Hi guys, Would you like to see MyFaces Core ship with

Re: MyFaces shipping with JBoss AS6?

2010-08-05 Thread ssilvert
That's OK. I guess I can do the SPI implementations on my end but it might not make it into JBoss AS6 GA. Let's concentrate on the MyFaces SPI's for now. How does MyFaces handle the SPI's like Mojarra has? I'm sure it's OK to look at Mojarra code since it's GPL2, right? If not, you can

Re: MyFaces shipping with JBoss AS6?

2010-08-05 Thread Matthias Wessendorf
Well, looking at the RI is for sure not OK. I didn't see a problem with the previous provided links (the JBoss code), however I have not opened any of the provided links yet. -Matthias On Thu, Aug 5, 2010 at 1:54 PM, ssilv...@redhat.com wrote: That's OK.  I guess I can do the SPI

Re: MyFaces shipping with JBoss AS6?

2010-08-05 Thread Matthias Wessendorf
Somehow I think there was already work/discussion about it, based on a Tomcat interface. It for sure does bring back some fragile memory. Let me think... On Thu, Aug 5, 2010 at 2:09 PM, Matthias Wessendorf mat...@apache.org wrote: Well, looking at the RI is for sure not OK. I didn't see a

Re: MyFaces shipping with JBoss AS6?

2010-08-05 Thread ssilvert
Can you look at javadoc comments? Quoting Matthias Wessendorf mat...@apache.org: Well, looking at the RI is for sure not OK. I didn't see a problem with the previous provided links (the JBoss code), however I have not opened any of the provided links yet. -Matthias On Thu, Aug 5, 2010 at

Re: MyFaces shipping with JBoss AS6?

2010-08-05 Thread Leonardo Uribe
Hi 2010/8/4 ssilv...@redhat.com Hi guys, Would you like to see MyFaces Core ship with JBoss AS6? If so, read on. This is top priority for me. If you've been around MyFaces awhile, you probably remember that JBoass AS used to ship with MyFaces instead of Mojarra. It was regrettable,

Re: MyFaces shipping with JBoss AS6?

2010-08-05 Thread ssilvert
Quoting David Jencks david_jen...@yahoo.com: I haven't and wont look at the mojarra code but I think you are looking for org.apache.myfaces.config.annotation.LifecycleProvider Looks like that takes care of spec section 5.4 (injection, @PreDestroy, @PostConstruct). How do you deal with

Re: MyFaces shipping with JBoss AS6?

2010-08-05 Thread Jan-Kees van Andel
MyFaces has an AnnotationConfigurator [1] which scans the classpath using a simple bytecode scanning mechanism [2] (comparable with the one in Javassist). It's pretty fast, but it's true that classes might be scanned twice. Regards, Jan-Kees [1]

MyFaces shipping with JBoss AS6?

2010-08-04 Thread ssilvert
Hi guys, Would you like to see MyFaces Core ship with JBoss AS6? If so, read on. If you've been around MyFaces awhile, you probably remember that JBoass AS used to ship with MyFaces instead of Mojarra. It was regrettable, but at the time Mojarra was far ahead spec-wise and the powers

Re: MyFaces shipping with JBoss AS6?

2010-08-04 Thread Werner Punz
Hi Stan, welcome back, good to hear from you again, this is excellent news. Werner Am 04.08.10 20:42, schrieb ssilv...@redhat.com: Hi guys, Would you like to see MyFaces Core ship with JBoss AS6? If so, read on. If you've been around MyFaces awhile, you probably remember that JBoass AS used