Re: [TRINIDAD] JQuery Themeroller compatibility

Hi I hope to do some work into this issue, but maybe at the beginning of August. regards, Leonardo Uribe 2012/7/23 Walter Mourão : > Hi folks. Just a heads up, I would like to know if somebody else is working > with https://issues.apache.org/jira/browse/TRINIDAD-2120. > > thanks, > > Walter Mou

Re: [TRINIDAD] JQuery Themeroller compatibility

Hi Ok, I let some comments in TRINIDAD-2120. Unfortunately my time is running out these days, but I hope to contribute a little bit more after my vacations. regards, Leonardo Uribe 2012/7/3 Pavitra Subramaniam : > > > On 7/2/2012 3:48 PM, Pavitra Subramaniam wrote: >> >> >> >> On 6/29/2012 5:48

Re: [TRINIDAD] JQuery Themeroller compatibility

On 7/2/2012 3:48 PM, Pavitra Subramaniam wrote: On 6/29/2012 5:48 AM, Leonardo Uribe wrote: Hi I have been playing for some time with this idea. I tried to create a base skin: themeroller.desktop themeroller simple.desktop org.apache.myfaces.trinidad.desktop skins/themeroller/casablanca

Re: [TRINIDAD] JQuery Themeroller compatibility

On 6/29/2012 5:48 AM, Leonardo Uribe wrote: Hi I have been playing for some time with this idea. I tried to create a base skin: themeroller.desktop themeroller simple.desktop org.apache.myfaces.trinidad.desktop

Re: [TRINIDAD] JQuery Themeroller compatibility

Hi Leonardo, Thanks for adding this improvement to -tr-property-ref feature. I reviewed your code changes and noted my review comments in 2120. Thanks, Prakash On 7/2/2012 4:22 AM, Leonardo Uribe wrote: Hi I have attached a patch with the suggested changes to do in trinidad-impl: https://iss

Re: [TRINIDAD] JQuery Themeroller compatibility

Hi I have attached a patch with the suggested changes to do in trinidad-impl: https://issues.apache.org/jira/secure/attachment/12534191/TRINIDAD-2120-4-changes-trinidad-impl-only.patch Could somebody review and commit these changes? It implements the following syntax: .JQBorderColorLook:alias {

Re: [TRINIDAD] JQuery Themeroller compatibility

+1, do keep in mind that we don't release the component showcase, but it would be available for people to try. Sent from my iPhone On Jun 29, 2012, at 6:49 AM, Leonardo Uribe wrote: > Hi > > I have been playing for some time with this idea. I tried to create a base > skin: > > >the

Re: [TRINIDAD] JQuery Themeroller compatibility

Hi I have been playing for some time with this idea. I tried to create a base skin: themeroller.desktop themeroller simple.desktop org.apache.myfaces.trinidad.desktop skins/themeroller/casablanca-themerolle

Re: [TRINIDAD] JQuery Themeroller compatibility

Hi I did some changes to the css, and now this is the result. https://issues.apache.org/jira/secure/attachment/12533046/redmond%2Bcasablanca-2.png https://issues.apache.org/jira/secure/attachment/12533047/south-street%2Bcasablanca-2.png There is still room for improvement, I think we can just ta

Re: [TRINIDAD] JQuery Themeroller compatibility

Hi 2012/6/22 Pavitra Subramaniam : > Hello Leonardo, Scott, > > Thanks for working on this. The LAF is very neat. I looked at the patch > uploaded to the issue 2120 but didn't find the changes made to > DocumentRenderer. Can you upload it as well? I see 2 issues being discussed > The first patch

Re: [TRINIDAD] JQuery Themeroller compatibility

Hello Leonardo, Scott, Thanks for working on this. The LAF is very neat. I looked at the patch uploaded to the issue 2120 but didn't find the changes made to DocumentRenderer. Can you upload it as well? I see 2 issues being discussed 1.

Re: [TRINIDAD] JQuery Themeroller compatibility

Yeah, that looks pretty cool I gotta say. I'e pinged some of the trin developers to comment. Sent from my iPhone On Jun 21, 2012, at 9:41 AM, Leonardo Uribe wrote: > Hi Scott > > 2012/6/21 Scott O'Bryan : >> Wow... That looks really good Leonardo... :D >> > > Yes, looks great! And it is also

Re: [TRINIDAD] JQuery Themeroller compatibility

Hi Scott 2012/6/21 Scott O'Bryan : > Wow... That looks really good Leonardo... :D > Yes, looks great! And it is also very fun to do, because you can write the changes on the template and then update the page without restart the server. > I think the skin enhancements might be something we coul

Re: [TRINIDAD] JQuery Themeroller compatibility

Wow... That looks really good Leonardo... :D I think the skin enhancements might be something we could use in core trinidad, but I would like a review of the API's first. I understand you overrode the document to include a copy of JQuery. Could the same be accomplished generically by allow

Re: [TRINIDAD] JQuery Themeroller compatibility

Hi I have done the following steps: 1. Override tr:document renderer to include a copy of jQuery. 2. Set in top of the skin, just one generated by Themeroller. 3. Take casablanca skin as base model and copy it in a new file. 4. Use -tr-rule-ref and -tr-property-ref (with some improvements) to gra