[jira] Resolved: (TRINIDAD-2035) Several resources do not have proper capitolization
[ https://issues.apache.org/jira/browse/TRINIDAD-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott O'Bryan resolved TRINIDAD-2035. - Resolution: Fixed Fix Version/s: 2.0.0-beta-2 Patch has been committed to the beta-2 release and will be moved into trunk soon. Several resources do not have proper capitolization --- Key: TRINIDAD-2035 URL: https://issues.apache.org/jira/browse/TRINIDAD-2035 Project: MyFaces Trinidad Issue Type: Bug Components: Documentation Reporter: Scott O'Bryan Assignee: Scott O'Bryan Fix For: 2.0.0-beta-2 Original Estimate: 0.5h Remaining Estimate: 0.5h Several resources in the logger bundle have inproper capitolization -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[VOTE] Release for Trinidad 2.0.0-beta-2
Hey all, I was running the tasks needed to get the Trinidad 2.0.0-beta-2 release out and now I need a vote as to whether everything looks good or not. This is still a beta release so there are still a few open bugs, but all of the unit tests pass and this beta has undergone some considerable testing. I have deployed the artifacts to the Nexus Repository [1] for review. The release notes for the Trinidad 2.0.0-beta-2 release are on the JIRA site [2] for review as well. This vote will remain open for at least 72 hours. Thanks, Scott O'Bryan PS- This is my first release of Trinidad since moving over to NEXUS, so a lot of scrutiny and your suggestions would be much appreciated. [1] https://repository.apache.org/content/repositories/orgapachemyfaces-005/ [2] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092
Re: [VOTE] Release for Trinidad 2.0.0-beta-2
Okay, so my first hickup. I forgot to include the voting part. :D [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Scott On 02/15/2011 01:59 AM, Scott O'Bryan wrote: Hey all, I was running the tasks needed to get the Trinidad 2.0.0-beta-2 release out and now I need a vote as to whether everything looks good or not. This is still a beta release so there are still a few open bugs, but all of the unit tests pass and this beta has undergone some considerable testing. I have deployed the artifacts to the Nexus Repository [1] for review. The release notes for the Trinidad 2.0.0-beta-2 release are on the JIRA site [2] for review as well. This vote will remain open for at least 72 hours. Thanks, Scott O'Bryan PS- This is my first release of Trinidad since moving over to NEXUS, so a lot of scrutiny and your suggestions would be much appreciated. [1] https://repository.apache.org/content/repositories/orgapachemyfaces-005/ [2] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092
Re: [VOTE] Release for Trinidad 2.0.0-beta-2
+1 On 02/15/2011 02:09 AM, Scott O'Bryan wrote: Okay, so my first hickup. I forgot to include the voting part. :D [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Scott On 02/15/2011 01:59 AM, Scott O'Bryan wrote: Hey all, I was running the tasks needed to get the Trinidad 2.0.0-beta-2 release out and now I need a vote as to whether everything looks good or not. This is still a beta release so there are still a few open bugs, but all of the unit tests pass and this beta has undergone some considerable testing. I have deployed the artifacts to the Nexus Repository [1] for review. The release notes for the Trinidad 2.0.0-beta-2 release are on the JIRA site [2] for review as well. This vote will remain open for at least 72 hours. Thanks, Scott O'Bryan PS- This is my first release of Trinidad since moving over to NEXUS, so a lot of scrutiny and your suggestions would be much appreciated. [1] https://repository.apache.org/content/repositories/orgapachemyfaces-005/ [2] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092
[jira] Resolved: (TOBAGO-973) Disabled Button/Link does not use the Disabled Icon
[ https://issues.apache.org/jira/browse/TOBAGO-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Udo Schnurpfeil resolved TOBAGO-973. Resolution: Fixed Fix Version/s: 1.5.0 1.0.34 1.5.0-alpha-2 Disabled Button/Link does not use the Disabled Icon - Key: TOBAGO-973 URL: https://issues.apache.org/jira/browse/TOBAGO-973 Project: MyFaces Tobago Issue Type: Bug Components: Themes Affects Versions: 1.0.30 Environment: Tomcat 5.5, JDK 1.4 Reporter: Rainer Rohloff Assignee: Udo Schnurpfeil Fix For: 1.5.0-alpha-2, 1.0.34, 1.5.0 An disabled Button/Link does not use the Disabled Icon ( *Disabled.gif - defined in the Theme) -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [VOTE] Release for Trinidad 2.0.0-beta-2
Downloaded the source: https://repository.apache.org/content/repositories/orgapachemyfaces-005/org/apache/myfaces/trinidad/trinidad/2.0.0-beta-2/trinidad-2.0.0-beta-2-source-release.zip did an unzip and mvn clean install I am getting this error: [INFO] [buildnumber:create {execution: default}] [INFO] Checking for local modifications: skipped. [INFO] Updating project files from SCM: skipped. [INFO] Executing: /bin/sh -c cd /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api svn --non-interactive info [INFO] Working directory: /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api Provider message: The svn command failed. Command output: svn: '.' is not a working copy [INFO] [ERROR] BUILD ERROR [INFO] [INFO] Cannot get the revision information from the scm repository : Error! This is due to the buildnumber-maven-plugin, not sure if that should be really _always_ enabled... Looks like I can't download the soruce and build it, since the target folder (of my unzip) is (of course) not SVN folder. Any hints? -Matthias On Tue, Feb 15, 2011 at 10:09 AM, Scott O'Bryan darkar...@gmail.com wrote: +1 On 02/15/2011 02:09 AM, Scott O'Bryan wrote: Okay, so my first hickup. I forgot to include the voting part. :D [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Scott On 02/15/2011 01:59 AM, Scott O'Bryan wrote: Hey all, I was running the tasks needed to get the Trinidad 2.0.0-beta-2 release out and now I need a vote as to whether everything looks good or not. This is still a beta release so there are still a few open bugs, but all of the unit tests pass and this beta has undergone some considerable testing. I have deployed the artifacts to the Nexus Repository [1] for review. The release notes for the Trinidad 2.0.0-beta-2 release are on the JIRA site [2] for review as well. This vote will remain open for at least 72 hours. Thanks, Scott O'Bryan PS- This is my first release of Trinidad since moving over to NEXUS, so a lot of scrutiny and your suggestions would be much appreciated. [1] https://repository.apache.org/content/repositories/orgapachemyfaces-005/ [2] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: Revision numbers in MANIFEST.MF file (was: Re: svn commit: r1069504 - in /myfaces/trinidad/trunk: trinidad-api/pom.xml trinidad-impl/pom.xml)
I have commented it out, again (see vote thread for more information) -M On Fri, Feb 11, 2011 at 12:59 PM, Scott O'Bryan darkar...@gmail.com wrote: +1, I totally agree with Bernd.. Releases have VERSION numbers. It's snapshots that need revision and I see no harm either way. On Feb 11, 2011, at 2:44 AM, Gerhard gerhard.petra...@gmail.com wrote: hi, +1 for adding the revision number in any case. regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/2/11 Volker Weber v.we...@inexso.de Hi, i agree to Bernd, the revision number for a release is not needed, but what is the Problem having this few more lines in any manifest? I would prefer having this info packaged. Regards, Volker 2011/2/10 Bernd Bohmann bernd.bohm...@googlemail.com: Hello Matthias, For a release the revision number is not needed. For a snapshot it might be helpful if someone reports a bug and it's not clear with revision was the base for the snapshot. Regards Bernd Am 10.02.2011 19:23 schrieb Matthias Wessendorf mat...@apache.org: Having the actual revision number inside of the manifest.mf file is nice. However, not sure if that is really needed for every build, therefore I commented it out. Perhaps this should be done only in the release profile ? What do you think ? -Matthias On Thu, Feb 10, 2011 at 7:05 PM, mat...@apache.org wrote: Author: matzew Date: Thu Feb 10 18:05:24 2011 New Revision: 1069504 URL: http://svn.apache.org/viewvc?rev=1069504view=rev Log: disabling the svn revision number plugin - should it be done only on release profile??? Modified: myfaces/trinidad/trunk/trinidad-api/pom.xml myfaces/trinidad/trunk/trinidad-impl/pom.xml Modified: myfaces/trinidad/trunk/trinidad-api/pom.xml URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-api/pom.xml?rev=1069504r1=1069503r2=1069504view=diff == --- myfaces/trinidad/trunk/trinidad-api/pom.xml (original) +++ myfaces/trinidad/trunk/trinidad-api/pom.xml Thu Feb 10 18:05:24 2011 @@ -172,7 +172,8 @@ !-- To make the current revision number, we use the buildnumber-maven-plugin. -- - plugin + !-- Perhaps this should be only enabled on release profile ? -- + !--plugin groupIdorg.codehaus.mojo/groupId artifactIdbuildnumber-maven-plugin/artifactId version1.0-beta-4/version @@ -190,7 +191,7 @@ getRevisionOnlyOncetrue/getRevisionOnlyOnce buildNumberPropertyNamescm.revision/buildNumberPropertyName /configuration - /plugin + /plugin-- plugin groupIdorg.apache.maven.plugins/groupId Modified: myfaces/trinidad/trunk/trinidad-impl/pom.xml URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-impl/pom.xml?rev=1069504r1=1069503r2=1069504view=diff == --- myfaces/trinidad/trunk/trinidad-impl/pom.xml (original) +++ myfaces/trinidad/trunk/trinidad-impl/pom.xml Thu Feb 10 18:05:24 2011 @@ -211,7 +211,8 @@ !-- To make the current revision number, we use the buildnumber-maven-plugin. -- - plugin + !-- Perhaps this should be only enabled on release profile ? -- + !--plugin groupIdorg.codehaus.mojo/groupId artifactIdbuildnumber-maven-plugin/artifactId version1.0-beta-4/version @@ -229,7 +230,7 @@ getRevisionOnlyOncetrue/getRevisionOnlyOnce buildNumberPropertyNamescm.revision/buildNumberPropertyName /configuration - /plugin + /plugin-- plugin groupIdorg.apache.maven.plugins/groupId -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- inexso - information exchange solutions GmbH Ofener Str. 30 | 26121 Oldenburg Tel.: +49 441 219 730 56 | FAX: +49 441 219 730 66 | eMail: volker.we...@inexso.de Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251 Geschäftsführer: Stefan Schulte, Michael Terschüren -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [VOTE] Release for Trinidad 2.0.0-beta-2
Hello Matze, good point. I think the revisionOnScmFailure parameter should be set to 'unkown'. Regards Bernd On Tue, Feb 15, 2011 at 10:52 AM, Matthias Wessendorf mat...@apache.org wrote: Downloaded the source: https://repository.apache.org/content/repositories/orgapachemyfaces-005/org/apache/myfaces/trinidad/trinidad/2.0.0-beta-2/trinidad-2.0.0-beta-2-source-release.zip did an unzip and mvn clean install I am getting this error: [INFO] [buildnumber:create {execution: default}] [INFO] Checking for local modifications: skipped. [INFO] Updating project files from SCM: skipped. [INFO] Executing: /bin/sh -c cd /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api svn --non-interactive info [INFO] Working directory: /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api Provider message: The svn command failed. Command output: svn: '.' is not a working copy [INFO] [ERROR] BUILD ERROR [INFO] [INFO] Cannot get the revision information from the scm repository : Error! This is due to the buildnumber-maven-plugin, not sure if that should be really _always_ enabled... Looks like I can't download the soruce and build it, since the target folder (of my unzip) is (of course) not SVN folder. Any hints? -Matthias On Tue, Feb 15, 2011 at 10:09 AM, Scott O'Bryan darkar...@gmail.com wrote: +1 On 02/15/2011 02:09 AM, Scott O'Bryan wrote: Okay, so my first hickup. I forgot to include the voting part. :D [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Scott On 02/15/2011 01:59 AM, Scott O'Bryan wrote: Hey all, I was running the tasks needed to get the Trinidad 2.0.0-beta-2 release out and now I need a vote as to whether everything looks good or not. This is still a beta release so there are still a few open bugs, but all of the unit tests pass and this beta has undergone some considerable testing. I have deployed the artifacts to the Nexus Repository [1] for review. The release notes for the Trinidad 2.0.0-beta-2 release are on the JIRA site [2] for review as well. This vote will remain open for at least 72 hours. Thanks, Scott O'Bryan PS- This is my first release of Trinidad since moving over to NEXUS, so a lot of scrutiny and your suggestions would be much appreciated. [1] https://repository.apache.org/content/repositories/orgapachemyfaces-005/ [2] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
[jira] Created: (MYFACES-3044) Resource jsf.js not found when using the OSGi bundle
Resource jsf.js not found when using the OSGi bundle Key: MYFACES-3044 URL: https://issues.apache.org/jira/browse/MYFACES-3044 Project: MyFaces Core Issue Type: Bug Affects Versions: 2.0.3 Reporter: Clovis First there is a {color:red}WARNING: Resource referenced by resourceName jsf.js and libraryName javax.faces not found in call to ResourceHandler.createResource. It will be silenty ignored.{color:red} and later a NullPointerException Using javax.faces.PROJECT_STAGE=Development, the class loader was trying to load META-INF/internal-resources/javax.faces/jsf-uncompressed-full.js (so I added the package META-INF.internal-resources.javax.faces to the list of exported packages of myfaces-bundle.jar). But then I changed it from Development to Production, and myfaces tried to load something else (and I decided to write a bug). -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [VOTE] Release for Trinidad 2.0.0-beta-2
Matthias, Can it be activated only for the release procedure? with the profile apache-release? It will also fail on computers that don't have a command line SVN client installed. That is also the reason why we abandoned it in the company projects. regards Rudy. On 15 February 2011 11:07, Bernd Bohmann bernd.bohm...@googlemail.comwrote: Hello Matze, good point. I think the revisionOnScmFailure parameter should be set to 'unkown'. Regards Bernd On Tue, Feb 15, 2011 at 10:52 AM, Matthias Wessendorf mat...@apache.org wrote: Downloaded the source: https://repository.apache.org/content/repositories/orgapachemyfaces-005/org/apache/myfaces/trinidad/trinidad/2.0.0-beta-2/trinidad-2.0.0-beta-2-source-release.zip did an unzip and mvn clean install I am getting this error: [INFO] [buildnumber:create {execution: default}] [INFO] Checking for local modifications: skipped. [INFO] Updating project files from SCM: skipped. [INFO] Executing: /bin/sh -c cd /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api svn --non-interactive info [INFO] Working directory: /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api Provider message: The svn command failed. Command output: svn: '.' is not a working copy [INFO] [ERROR] BUILD ERROR [INFO] [INFO] Cannot get the revision information from the scm repository : Error! This is due to the buildnumber-maven-plugin, not sure if that should be really _always_ enabled... Looks like I can't download the soruce and build it, since the target folder (of my unzip) is (of course) not SVN folder. Any hints? -Matthias On Tue, Feb 15, 2011 at 10:09 AM, Scott O'Bryan darkar...@gmail.com wrote: +1 On 02/15/2011 02:09 AM, Scott O'Bryan wrote: Okay, so my first hickup. I forgot to include the voting part. :D [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Scott On 02/15/2011 01:59 AM, Scott O'Bryan wrote: Hey all, I was running the tasks needed to get the Trinidad 2.0.0-beta-2 release out and now I need a vote as to whether everything looks good or not. This is still a beta release so there are still a few open bugs, but all of the unit tests pass and this beta has undergone some considerable testing. I have deployed the artifacts to the Nexus Repository [1] for review. The release notes for the Trinidad 2.0.0-beta-2 release are on the JIRA site [2] for review as well. This vote will remain open for at least 72 hours. Thanks, Scott O'Bryan PS- This is my first release of Trinidad since moving over to NEXUS, so a lot of scrutiny and your suggestions would be much appreciated. [1] https://repository.apache.org/content/repositories/orgapachemyfaces-005/ [2] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [VOTE] Release for Trinidad 2.0.0-beta-2
On Tue, Feb 15, 2011 at 11:11 AM, Rudy De Busscher rdebussc...@gmail.com wrote: Matthias, Can it be activated only for the release procedure? with the profile apache-release? it does not make sense to do it only on releases - as they are always from a TAG, hence the revision is known. It will also fail on computers that don't have a command line SVN client installed. That is also the reason why we abandoned it in the company projects. I think Bernd's suggestion is the right one. -Matthias regards Rudy. On 15 February 2011 11:07, Bernd Bohmann bernd.bohm...@googlemail.com wrote: Hello Matze, good point. I think the revisionOnScmFailure parameter should be set to 'unkown'. Regards Bernd On Tue, Feb 15, 2011 at 10:52 AM, Matthias Wessendorf mat...@apache.org wrote: Downloaded the source: https://repository.apache.org/content/repositories/orgapachemyfaces-005/org/apache/myfaces/trinidad/trinidad/2.0.0-beta-2/trinidad-2.0.0-beta-2-source-release.zip did an unzip and mvn clean install I am getting this error: [INFO] [buildnumber:create {execution: default}] [INFO] Checking for local modifications: skipped. [INFO] Updating project files from SCM: skipped. [INFO] Executing: /bin/sh -c cd /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api svn --non-interactive info [INFO] Working directory: /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api Provider message: The svn command failed. Command output: svn: '.' is not a working copy [INFO] [ERROR] BUILD ERROR [INFO] [INFO] Cannot get the revision information from the scm repository : Error! This is due to the buildnumber-maven-plugin, not sure if that should be really _always_ enabled... Looks like I can't download the soruce and build it, since the target folder (of my unzip) is (of course) not SVN folder. Any hints? -Matthias On Tue, Feb 15, 2011 at 10:09 AM, Scott O'Bryan darkar...@gmail.com wrote: +1 On 02/15/2011 02:09 AM, Scott O'Bryan wrote: Okay, so my first hickup. I forgot to include the voting part. :D [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Scott On 02/15/2011 01:59 AM, Scott O'Bryan wrote: Hey all, I was running the tasks needed to get the Trinidad 2.0.0-beta-2 release out and now I need a vote as to whether everything looks good or not. This is still a beta release so there are still a few open bugs, but all of the unit tests pass and this beta has undergone some considerable testing. I have deployed the artifacts to the Nexus Repository [1] for review. The release notes for the Trinidad 2.0.0-beta-2 release are on the JIRA site [2] for review as well. This vote will remain open for at least 72 hours. Thanks, Scott O'Bryan PS- This is my first release of Trinidad since moving over to NEXUS, so a lot of scrutiny and your suggestions would be much appreciated. [1] https://repository.apache.org/content/repositories/orgapachemyfaces-005/ [2] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
[jira] Created: (TOBAGO-974) javascript error when unselectAll in empty simplesheet
javascript error when unselectAll in empty simplesheet -- Key: TOBAGO-974 URL: https://issues.apache.org/jira/browse/TOBAGO-974 Project: MyFaces Tobago Issue Type: Bug Components: Sandbox Affects Versions: 1.0.33 Reporter: Volker Weber Priority: Trivial In simpleSheet we get an javascript error in IE when click on unselectAll in columnSelector header: Details zum Fehler auf der Webseite Benutzer-Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729) Zeitstempel: Tue, 15 Feb 2011 12:49:08 UTC Meldung: 'firstChild' ist Null oder kein Objekt Zeile: 595 Zeichen: 7 Code: 0 URI: http://tui/erm/org/apache/myfaces/tobago/renderkit/html/standard/standard/script/tobago-sheet.js -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [VOTE] Release for Trinidad 2.0.0-beta-2
This plugin actually kind of worries me if used on released code. Unless we use a timestamp type build id, I think ANY revision of tagged code should be unknown. It's not like people are going to commit their changes to the tag, this allowing a unique number to be calculated. What do we use this for, debugging? If so, I'm wondering if we could only allow this to be executed with snapshots and allow everything else to be unknown.. Scott On Feb 15, 2011, at 3:18 AM, Matthias Wessendorff mat...@apache.org wrote: On Tue, Feb 15, 2011 at 11:11 AM, Rudy De Busscher rdebussc...@gmail.com wrote: Matthias, Can it be activated only for the release procedure? with the profile apache-release? it does not make sense to do it only on releases - as they are always from a TAG, hence the revision is known. It will also fail on computers that don't have a command line SVN client installed. That is also the reason why we abandoned it in the company projects. I think Bernd's suggestion is the right one. -Matthias regards Rudy. On 15 February 2011 11:07, Bernd Bohmann bernd.bohm...@googlemail.com wrote: Hello Matze, good point. I think the revisionOnScmFailure parameter should be set to 'unkown'. Regards Bernd On Tue, Feb 15, 2011 at 10:52 AM, Matthias Wessendorf mat...@apache.org wrote: Downloaded the source: https://repository.apache.org/content/repositories/orgapachemyfaces-005/org/apache/myfaces/trinidad/trinidad/2.0.0-beta-2/trinidad-2.0.0-beta-2-source-release.zip did an unzip and mvn clean install I am getting this error: [INFO] [buildnumber:create {execution: default}] [INFO] Checking for local modifications: skipped. [INFO] Updating project files from SCM: skipped. [INFO] Executing: /bin/sh -c cd /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api svn --non-interactive info [INFO] Working directory: /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api Provider message: The svn command failed. Command output: svn: '.' is not a working copy [INFO] [ERROR] BUILD ERROR [INFO] [INFO] Cannot get the revision information from the scm repository : Error! This is due to the buildnumber-maven-plugin, not sure if that should be really _always_ enabled... Looks like I can't download the soruce and build it, since the target folder (of my unzip) is (of course) not SVN folder. Any hints? -Matthias On Tue, Feb 15, 2011 at 10:09 AM, Scott O'Bryan darkar...@gmail.com wrote: +1 On 02/15/2011 02:09 AM, Scott O'Bryan wrote: Okay, so my first hickup. I forgot to include the voting part. :D [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Scott On 02/15/2011 01:59 AM, Scott O'Bryan wrote: Hey all, I was running the tasks needed to get the Trinidad 2.0.0-beta-2 release out and now I need a vote as to whether everything looks good or not. This is still a beta release so there are still a few open bugs, but all of the unit tests pass and this beta has undergone some considerable testing. I have deployed the artifacts to the Nexus Repository [1] for review. The release notes for the Trinidad 2.0.0-beta-2 release are on the JIRA site [2] for review as well. This vote will remain open for at least 72 hours. Thanks, Scott O'Bryan PS- This is my first release of Trinidad since moving over to NEXUS, so a lot of scrutiny and your suggestions would be much appreciated. [1] https://repository.apache.org/content/repositories/orgapachemyfaces-005/ [2] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [VOTE] Release for Trinidad 2.0.0-beta-2
currently codi uses a profile for activating it for nightly builds (see [1]). regards, gerhard [1] https://svn.apache.org/repos/asf/myfaces/extensions/cdi/trunk/pom.xml http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/2/15 Scott O'Bryan darkar...@gmail.com This plugin actually kind of worries me if used on released code. Unless we use a timestamp type build id, I think ANY revision of tagged code should be unknown. It's not like people are going to commit their changes to the tag, this allowing a unique number to be calculated. What do we use this for, debugging? If so, I'm wondering if we could only allow this to be executed with snapshots and allow everything else to be unknown.. Scott On Feb 15, 2011, at 3:18 AM, Matthias Wessendorff mat...@apache.org wrote: On Tue, Feb 15, 2011 at 11:11 AM, Rudy De Busscher rdebussc...@gmail.com wrote: Matthias, Can it be activated only for the release procedure? with the profile apache-release? it does not make sense to do it only on releases - as they are always from a TAG, hence the revision is known. It will also fail on computers that don't have a command line SVN client installed. That is also the reason why we abandoned it in the company projects. I think Bernd's suggestion is the right one. -Matthias regards Rudy. On 15 February 2011 11:07, Bernd Bohmann bernd.bohm...@googlemail.com wrote: Hello Matze, good point. I think the revisionOnScmFailure parameter should be set to 'unkown'. Regards Bernd On Tue, Feb 15, 2011 at 10:52 AM, Matthias Wessendorf mat...@apache.org wrote: Downloaded the source: https://repository.apache.org/content/repositories/orgapachemyfaces-005/org/apache/myfaces/trinidad/trinidad/2.0.0-beta-2/trinidad-2.0.0-beta-2-source-release.zip did an unzip and mvn clean install I am getting this error: [INFO] [buildnumber:create {execution: default}] [INFO] Checking for local modifications: skipped. [INFO] Updating project files from SCM: skipped. [INFO] Executing: /bin/sh -c cd /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api svn --non-interactive info [INFO] Working directory: /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api Provider message: The svn command failed. Command output: svn: '.' is not a working copy [INFO] [ERROR] BUILD ERROR [INFO] [INFO] Cannot get the revision information from the scm repository : Error! This is due to the buildnumber-maven-plugin, not sure if that should be really _always_ enabled... Looks like I can't download the soruce and build it, since the target folder (of my unzip) is (of course) not SVN folder. Any hints? -Matthias On Tue, Feb 15, 2011 at 10:09 AM, Scott O'Bryan darkar...@gmail.com wrote: +1 On 02/15/2011 02:09 AM, Scott O'Bryan wrote: Okay, so my first hickup. I forgot to include the voting part. :D [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Scott On 02/15/2011 01:59 AM, Scott O'Bryan wrote: Hey all, I was running the tasks needed to get the Trinidad 2.0.0-beta-2 release out and now I need a vote as to whether everything looks good or not. This is still a beta release so there are still a few open bugs, but all of the unit tests pass and this beta has undergone some considerable testing. I have deployed the artifacts to the Nexus Repository [1] for review. The release notes for the Trinidad 2.0.0-beta-2 release are on the JIRA site [2] for review as well. This vote will remain open for at least 72 hours. Thanks, Scott O'Bryan PS- This is my first release of Trinidad since moving over to NEXUS, so a lot of scrutiny and your suggestions would be much appreciated. [1] https://repository.apache.org/content/repositories/orgapachemyfaces-005/ [2] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [VOTE] Release for Trinidad 2.0.0-beta-2
Yeah... This makes more sense to me. Only nightly builds really need this info and it should be easy enough to add the custom profile to Hudson (or whatever they're calling it these days).. :) On Feb 15, 2011, at 6:31 AM, Gerhard gerhard.petra...@gmail.com wrote: currently codi uses a profile for activating it for nightly builds (see [1]). regards, gerhard [1] https://svn.apache.org/repos/asf/myfaces/extensions/cdi/trunk/pom.xml http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/2/15 Scott O'Bryan darkar...@gmail.com This plugin actually kind of worries me if used on released code. Unless we use a timestamp type build id, I think ANY revision of tagged code should be unknown. It's not like people are going to commit their changes to the tag, this allowing a unique number to be calculated. What do we use this for, debugging? If so, I'm wondering if we could only allow this to be executed with snapshots and allow everything else to be unknown.. Scott On Feb 15, 2011, at 3:18 AM, Matthias Wessendorff mat...@apache.org wrote: On Tue, Feb 15, 2011 at 11:11 AM, Rudy De Busscher rdebussc...@gmail.com wrote: Matthias, Can it be activated only for the release procedure? with the profile apache-release? it does not make sense to do it only on releases - as they are always from a TAG, hence the revision is known. It will also fail on computers that don't have a command line SVN client installed. That is also the reason why we abandoned it in the company projects. I think Bernd's suggestion is the right one. -Matthias regards Rudy. On 15 February 2011 11:07, Bernd Bohmann bernd.bohm...@googlemail.com wrote: Hello Matze, good point. I think the revisionOnScmFailure parameter should be set to 'unkown'. Regards Bernd On Tue, Feb 15, 2011 at 10:52 AM, Matthias Wessendorf mat...@apache.org wrote: Downloaded the source: https://repository.apache.org/content/repositories/orgapachemyfaces-005/org/apache/myfaces/trinidad/trinidad/2.0.0-beta-2/trinidad-2.0.0-beta-2-source-release.zip did an unzip and mvn clean install I am getting this error: [INFO] [buildnumber:create {execution: default}] [INFO] Checking for local modifications: skipped. [INFO] Updating project files from SCM: skipped. [INFO] Executing: /bin/sh -c cd /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api svn --non-interactive info [INFO] Working directory: /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api Provider message: The svn command failed. Command output: svn: '.' is not a working copy [INFO] [ERROR] BUILD ERROR [INFO] [INFO] Cannot get the revision information from the scm repository : Error! This is due to the buildnumber-maven-plugin, not sure if that should be really _always_ enabled... Looks like I can't download the soruce and build it, since the target folder (of my unzip) is (of course) not SVN folder. Any hints? -Matthias On Tue, Feb 15, 2011 at 10:09 AM, Scott O'Bryan darkar...@gmail.com wrote: +1 On 02/15/2011 02:09 AM, Scott O'Bryan wrote: Okay, so my first hickup. I forgot to include the voting part. :D [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Scott On 02/15/2011 01:59 AM, Scott O'Bryan wrote: Hey all, I was running the tasks needed to get the Trinidad 2.0.0-beta-2 release out and now I need a vote as to whether everything looks good or not. This is still a beta release so there are still a few open bugs, but all of the unit tests pass and this beta has undergone some considerable testing. I have deployed the artifacts to the Nexus Repository [1] for review. The release notes for the Trinidad 2.0.0-beta-2 release are on the JIRA site [2] for review as well. This vote will remain open for at least 72 hours. Thanks, Scott O'Bryan PS- This is my first release of Trinidad since moving over to NEXUS, so a lot of scrutiny and your suggestions would be much appreciated. [1] https://repository.apache.org/content/repositories/orgapachemyfaces-005/ [2] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions:
Re: [VOTE] Release for Trinidad 2.0.0-beta-2
yes it's easy - you just have to add the profile. e.g. in case of codi: clean deploy -Pextended-manifest (at Goals und Optionen) regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/2/15 Scott O'Bryan darkar...@gmail.com Yeah... This makes more sense to me. Only nightly builds really need this info and it should be easy enough to add the custom profile to Hudson (or whatever they're calling it these days).. :) On Feb 15, 2011, at 6:31 AM, Gerhard gerhard.petra...@gmail.com wrote: currently codi uses a profile for activating it for nightly builds (see [1]). regards, gerhard [1] https://svn.apache.org/repos/asf/myfaces/extensions/cdi/trunk/pom.xml https://svn.apache.org/repos/asf/myfaces/extensions/cdi/trunk/pom.xml http://www.irian.athttp://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/2/15 Scott O'Bryan darkar...@gmail.comdarkar...@gmail.com This plugin actually kind of worries me if used on released code. Unless we use a timestamp type build id, I think ANY revision of tagged code should be unknown. It's not like people are going to commit their changes to the tag, this allowing a unique number to be calculated. What do we use this for, debugging? If so, I'm wondering if we could only allow this to be executed with snapshots and allow everything else to be unknown.. Scott On Feb 15, 2011, at 3:18 AM, Matthias Wessendorff mat...@apache.org mat...@apache.org wrote: On Tue, Feb 15, 2011 at 11:11 AM, Rudy De Busscher rdebussc...@gmail.comrdebussc...@gmail.com wrote: Matthias, Can it be activated only for the release procedure? with the profile apache-release? it does not make sense to do it only on releases - as they are always from a TAG, hence the revision is known. It will also fail on computers that don't have a command line SVN client installed. That is also the reason why we abandoned it in the company projects. I think Bernd's suggestion is the right one. -Matthias regards Rudy. On 15 February 2011 11:07, Bernd Bohmann bernd.bohm...@googlemail.com bernd.bohm...@googlemail.com wrote: Hello Matze, good point. I think the revisionOnScmFailure parameter should be set to 'unkown'. Regards Bernd On Tue, Feb 15, 2011 at 10:52 AM, Matthias Wessendorf mat...@apache.org mat...@apache.org wrote: Downloaded the source: https://repository.apache.org/content/repositories/orgapachemyfaces-005/org/apache/myfaces/trinidad/trinidad/2.0.0-beta-2/trinidad-2.0.0-beta-2-source-release.zip https://repository.apache.org/content/repositories/orgapachemyfaces-005/org/apache/myfaces/trinidad/trinidad/2.0.0-beta-2/trinidad-2.0.0-beta-2-source-release.zip did an unzip and mvn clean install I am getting this error: [INFO] [buildnumber:create {execution: default}] [INFO] Checking for local modifications: skipped. [INFO] Updating project files from SCM: skipped. [INFO] Executing: /bin/sh -c cd /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api svn --non-interactive info [INFO] Working directory: /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api Provider message: The svn command failed. Command output: svn: '.' is not a working copy [INFO] [ERROR] BUILD ERROR [INFO] [INFO] Cannot get the revision information from the scm repository : Error! This is due to the buildnumber-maven-plugin, not sure if that should be really _always_ enabled... Looks like I can't download the soruce and build it, since the target folder (of my unzip) is (of course) not SVN folder. Any hints? -Matthias On Tue, Feb 15, 2011 at 10:09 AM, Scott O'Bryan darkar...@gmail.com darkar...@gmail.com wrote: +1 On 02/15/2011 02:09 AM, Scott O'Bryan wrote: Okay, so my first hickup. I forgot to include the voting part. :D [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Scott On 02/15/2011 01:59 AM, Scott O'Bryan wrote: Hey all, I was running the tasks needed to get the Trinidad 2.0.0-beta-2 release out and now I need a vote as to whether everything looks good or not. This is still a beta release so there are still a few open bugs, but all of the unit tests pass and this beta has undergone some considerable testing. I have deployed the artifacts to the Nexus Repository [1] for
Re: [VOTE] Release for Trinidad 2.0.0-beta-2
+1 On 2/15/2011 4:09 AM, Scott O'Bryan wrote: +1 On 02/15/2011 02:09 AM, Scott O'Bryan wrote: Okay, so my first hickup. I forgot to include the voting part. :D [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Scott On 02/15/2011 01:59 AM, Scott O'Bryan wrote: Hey all, I was running the tasks needed to get the Trinidad 2.0.0-beta-2 release out and now I need a vote as to whether everything looks good or not. This is still a beta release so there are still a few open bugs, but all of the unit tests pass and this beta has undergone some considerable testing. I have deployed the artifacts to the Nexus Repository [1] for review. The release notes for the Trinidad 2.0.0-beta-2 release are on the JIRA site [2] for review as well. This vote will remain open for at least 72 hours. Thanks, Scott O'Bryan PS- This is my first release of Trinidad since moving over to NEXUS, so a lot of scrutiny and your suggestions would be much appreciated. [1] https://repository.apache.org/content/repositories/orgapachemyfaces-005/ [2] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092
[jira] Updated: (TRINIDAD-2034) DatePropertyTagRule and StringArrayPropertyTagRule cache mutable objects
[ https://issues.apache.org/jira/browse/TRINIDAD-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Max Starets updated TRINIDAD-2034: -- Status: Patch Available (was: Open) DatePropertyTagRule and StringArrayPropertyTagRule cache mutable objects Key: TRINIDAD-2034 URL: https://issues.apache.org/jira/browse/TRINIDAD-2034 Project: MyFaces Trinidad Issue Type: Bug Reporter: Max Starets Assignee: Max Starets When DatePropertyTagRule and StringArrayPropertyTagRule are applied to attributes specified as string literals, the parsing results are cached on the tag. The issue is that the parsing results are mutable (java.util.Date and String[]), so they a) cannot be shared; b) cannot be cached. The fix will be to clone a new object every time LiteralPropertyMetadata.applyMetadata() is called. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (TRINIDAD-2034) DatePropertyTagRule and StringArrayPropertyTagRule cache mutable objects
[ https://issues.apache.org/jira/browse/TRINIDAD-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Max Starets updated TRINIDAD-2034: -- Resolution: Fixed Status: Resolved (was: Patch Available) DatePropertyTagRule and StringArrayPropertyTagRule cache mutable objects Key: TRINIDAD-2034 URL: https://issues.apache.org/jira/browse/TRINIDAD-2034 Project: MyFaces Trinidad Issue Type: Bug Reporter: Max Starets Assignee: Max Starets Attachments: trinidad-2034.diff When DatePropertyTagRule and StringArrayPropertyTagRule are applied to attributes specified as string literals, the parsing results are cached on the tag. The issue is that the parsing results are mutable (java.util.Date and String[]), so they a) cannot be shared; b) cannot be cached. The fix will be to clone a new object every time LiteralPropertyMetadata.applyMetadata() is called. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-3042) CCE: when running in portlet: Remove Servlet dependencies in FaceletViewDeclarationLanguage.java
[ https://issues.apache.org/jira/browse/MYFACES-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Freedman updated MYFACES-3042: -- Status: Patch Available (was: Open) CCE: when running in portlet: Remove Servlet dependencies in FaceletViewDeclarationLanguage.java Key: MYFACES-3042 URL: https://issues.apache.org/jira/browse/MYFACES-3042 Project: MyFaces Core Issue Type: Bug Components: Portlet_Support Affects Versions: 2.0.5-SNAPSHOT Reporter: Michael Freedman Attachments: jira-myfaces-3042.patch In FaceletViewDeclarationLanguage.java: createResponseWriter(), getResponseEncoding(), handleFaceletNotFound(), and sendSourceNotFound() each cast to Servlet object. This causes ClassCastExceptions when run in a portlet environment. Each of these calls/casts can be removed and ExternalContext APIs can be used instead to get/set the needed information from the request or response object. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [VOTE] Release for Trinidad 2.0.0-beta-2
-1 I am voting -1 because I am not able to build the source release. The source release is the most important part of an apache release -Matthias On Tue, Feb 15, 2011 at 4:16 PM, MAX STARETS max.star...@oracle.com wrote: +1 On 2/15/2011 4:09 AM, Scott O'Bryan wrote: +1 On 02/15/2011 02:09 AM, Scott O'Bryan wrote: Okay, so my first hickup. I forgot to include the voting part. :D [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Scott On 02/15/2011 01:59 AM, Scott O'Bryan wrote: Hey all, I was running the tasks needed to get the Trinidad 2.0.0-beta-2 release out and now I need a vote as to whether everything looks good or not. This is still a beta release so there are still a few open bugs, but all of the unit tests pass and this beta has undergone some considerable testing. I have deployed the artifacts to the Nexus Repository [1] for review. The release notes for the Trinidad 2.0.0-beta-2 release are on the JIRA site [2] for review as well. This vote will remain open for at least 72 hours. Thanks, Scott O'Bryan PS- This is my first release of Trinidad since moving over to NEXUS, so a lot of scrutiny and your suggestions would be much appreciated. [1] https://repository.apache.org/content/repositories/orgapachemyfaces-005/ [2] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
[jira] Commented: (MYFACES-3042) CCE: when running in portlet: Remove Servlet dependencies in FaceletViewDeclarationLanguage.java
[ https://issues.apache.org/jira/browse/MYFACES-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12994882#comment-12994882 ] Michael Freedman commented on MYFACES-3042: --- I have attached a potential patch -- Apologies for not just making the changes but (1) this change breaks an automated test that is part of the build as it seems the test environment doesn't provide its own stub impl of the new JSF 2.0 ExternalContext methods that these changes rely on -- and I have no clue how to address those and (2) the various paperwork Oracle made me sign to allow me to participate in Apache only allows me to submit work related to the Portlet Bridge project -- MyFaces work has to be submitted by those from Oracle signed up to do that. CCE: when running in portlet: Remove Servlet dependencies in FaceletViewDeclarationLanguage.java Key: MYFACES-3042 URL: https://issues.apache.org/jira/browse/MYFACES-3042 Project: MyFaces Core Issue Type: Bug Components: Portlet_Support Affects Versions: 2.0.5-SNAPSHOT Reporter: Michael Freedman Attachments: jira-myfaces-3042.patch In FaceletViewDeclarationLanguage.java: createResponseWriter(), getResponseEncoding(), handleFaceletNotFound(), and sendSourceNotFound() each cast to Servlet object. This causes ClassCastExceptions when run in a portlet environment. Each of these calls/casts can be removed and ExternalContext APIs can be used instead to get/set the needed information from the request or response object. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [VOTE] Release for Trinidad 2.0.0-beta-2
It built fine for me on my Mac. But +0 until we find out what is up with Matthias' build. -- Blake On 2/15/11 9:06 AM, Matthias Wessendorf wrote: -1 I am voting -1 because I am not able to build the source release. The source release is the most important part of an apache release -Matthias On Tue, Feb 15, 2011 at 4:16 PM, MAX STARETSmax.star...@oracle.com wrote: +1 On 2/15/2011 4:09 AM, Scott O'Bryan wrote: +1 On 02/15/2011 02:09 AM, Scott O'Bryan wrote: Okay, so my first hickup. I forgot to include the voting part. :D [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Scott On 02/15/2011 01:59 AM, Scott O'Bryan wrote: Hey all, I was running the tasks needed to get the Trinidad 2.0.0-beta-2 release out and now I need a vote as to whether everything looks good or not. This is still a beta release so there are still a few open bugs, but all of the unit tests pass and this beta has undergone some considerable testing. I have deployed the artifacts to the Nexus Repository [1] for review. The release notes for the Trinidad 2.0.0-beta-2 release are on the JIRA site [2] for review as well. This vote will remain open for at least 72 hours. Thanks, Scott O'Bryan PS- This is my first release of Trinidad since moving over to NEXUS, so a lot of scrutiny and your suggestions would be much appreciated. [1] https://repository.apache.org/content/repositories/orgapachemyfaces-005/ [2] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092
Re: [VOTE] Release for Trinidad 2.0.0-beta-2
On Tue, Feb 15, 2011 at 7:05 PM, Blake Sullivan blake.sulli...@oracle.com wrote: It built fine for me on my Mac. I know why I bought one :-) But +0 until we find out what is up with Matthias' build. -- Blake On 2/15/11 9:06 AM, Matthias Wessendorf wrote: -1 I am voting -1 because I am not able to build the source release. The source release is the most important part of an apache release -Matthias On Tue, Feb 15, 2011 at 4:16 PM, MAX STARETSmax.star...@oracle.com wrote: +1 On 2/15/2011 4:09 AM, Scott O'Bryan wrote: +1 On 02/15/2011 02:09 AM, Scott O'Bryan wrote: Okay, so my first hickup. I forgot to include the voting part. :D [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Scott On 02/15/2011 01:59 AM, Scott O'Bryan wrote: Hey all, I was running the tasks needed to get the Trinidad 2.0.0-beta-2 release out and now I need a vote as to whether everything looks good or not. This is still a beta release so there are still a few open bugs, but all of the unit tests pass and this beta has undergone some considerable testing. I have deployed the artifacts to the Nexus Repository [1] for review. The release notes for the Trinidad 2.0.0-beta-2 release are on the JIRA site [2] for review as well. This vote will remain open for at least 72 hours. Thanks, Scott O'Bryan PS- This is my first release of Trinidad since moving over to NEXUS, so a lot of scrutiny and your suggestions would be much appreciated. [1] https://repository.apache.org/content/repositories/orgapachemyfaces-005/ [2] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [VOTE] Release for Trinidad 2.0.0-beta-2
Okay cool. Stopping the vote. I'll get a patch right in for this and regenerate the artifacts. Expect a vote today or tomorrow. Basically, I'm going to follow Gerhard's suggestion and add a profile which is disabled by default which would allow us to enable this functionality for nightly builds where it's important. Sound Good? Scott On 02/15/2011 10:06 AM, Matthias Wessendorf wrote: -1 I am voting -1 because I am not able to build the source release. The source release is the most important part of an apache release -Matthias On Tue, Feb 15, 2011 at 4:16 PM, MAX STARETSmax.star...@oracle.com wrote: +1 On 2/15/2011 4:09 AM, Scott O'Bryan wrote: +1 On 02/15/2011 02:09 AM, Scott O'Bryan wrote: Okay, so my first hickup. I forgot to include the voting part. :D [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Scott On 02/15/2011 01:59 AM, Scott O'Bryan wrote: Hey all, I was running the tasks needed to get the Trinidad 2.0.0-beta-2 release out and now I need a vote as to whether everything looks good or not. This is still a beta release so there are still a few open bugs, but all of the unit tests pass and this beta has undergone some considerable testing. I have deployed the artifacts to the Nexus Repository [1] for review. The release notes for the Trinidad 2.0.0-beta-2 release are on the JIRA site [2] for review as well. This vote will remain open for at least 72 hours. Thanks, Scott O'Bryan PS- This is my first release of Trinidad since moving over to NEXUS, so a lot of scrutiny and your suggestions would be much appreciated. [1] https://repository.apache.org/content/repositories/orgapachemyfaces-005/ [2] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310661version=12316092
[jira] Created: (MYFACES-3045) jsf.js jsf.ajax.request doesn't resolve calling URL correctly -- ajax use in portlets broken
jsf.js jsf.ajax.request doesn't resolve calling URL correctly -- ajax use in portlets broken Key: MYFACES-3045 URL: https://issues.apache.org/jira/browse/MYFACES-3045 Project: MyFaces Core Issue Type: Bug Components: JSR-314 Affects Versions: 2.0.5-SNAPSHOT Reporter: Michael Freedman Javadoc for jsf.ajax.request says you determine the calling URL by: Determine the posting URL as follows: If the hidden field javax.faces.encodedURL is present in the submitting form, use its value as the posting URL. Otherwise, use the action property of the form element as the URL. Looks like the MyFaces impl skips loking for/using the javax.faces.encodedURL and only uses the form action. This means ajax is broken in portlets (when using MyFaces). I.e. the javax.faces.encodedURL in the portlet case is different than the action URL and the one that needs to be used. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (TRINIDAD-2037) Unable to build from source archive
Unable to build from source archive --- Key: TRINIDAD-2037 URL: https://issues.apache.org/jira/browse/TRINIDAD-2037 Project: MyFaces Trinidad Issue Type: Bug Components: Build Affects Versions: 2.0.0-beta-2 Reporter: Scott O'Bryan Assignee: Scott O'Bryan Priority: Blocker The buildnumber-maven-plugin prevents the building of the Trinidad source in Maven when the source tree is downloaded as an archive vs. taken from the svn repository. The steps to reproduce and the results are as follows: Downloaded the source: https://repository.apache.org/content/repositories/orgapachemyfaces-005/org/apache/myfaces/trinidad/trinidad/2.0.0-beta-2/trinidad-2.0.0-beta-2-source-release.zip did an unzip and mvn clean install I am getting this error: [INFO] [buildnumber:create {execution: default}] [INFO] Checking for local modifications: skipped. [INFO] Updating project files from SCM: skipped. [INFO] Executing: /bin/sh -c cd /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api svn --non-interactive info [INFO] Working directory: /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api Provider message: The svn command failed. Command output: svn: '.' is not a working copy [INFO] [ERROR] BUILD ERROR [INFO] [INFO] Cannot get the revision information from the scm repository : Error! This is due to the buildnumber-maven-plugin, not sure if that should be really _always_ enabled... Looks like I can't download the soruce and build it, since the target folder (of my unzip) is (of course) not SVN folder. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TRINIDAD-2037) Unable to build from source archive
[ https://issues.apache.org/jira/browse/TRINIDAD-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12995023#comment-12995023 ] Scott O'Bryan commented on TRINIDAD-2037: - As discussed in this thread[1], probably the best thing to do here is to disable this plugin unless we are dealing with a nightly build. Ultimately the extra manifest information is irrelevant for tags and custom builds as it will give us no REAL information to help users debug. For nightly builds, however, this is a different story. I'm looking at following the same convention used by codi and suggested by Gerard and adding an extended-manifest profile which would add the revision information. [1] http://www.mail-archive.com/dev@myfaces.apache.org/msg51466.html Unable to build from source archive --- Key: TRINIDAD-2037 URL: https://issues.apache.org/jira/browse/TRINIDAD-2037 Project: MyFaces Trinidad Issue Type: Bug Components: Build Affects Versions: 2.0.0-beta-2 Reporter: Scott O'Bryan Assignee: Scott O'Bryan Priority: Blocker The buildnumber-maven-plugin prevents the building of the Trinidad source in Maven when the source tree is downloaded as an archive vs. taken from the svn repository. The steps to reproduce and the results are as follows: Downloaded the source: https://repository.apache.org/content/repositories/orgapachemyfaces-005/org/apache/myfaces/trinidad/trinidad/2.0.0-beta-2/trinidad-2.0.0-beta-2-source-release.zip did an unzip and mvn clean install I am getting this error: [INFO] [buildnumber:create {execution: default}] [INFO] Checking for local modifications: skipped. [INFO] Updating project files from SCM: skipped. [INFO] Executing: /bin/sh -c cd /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api svn --non-interactive info [INFO] Working directory: /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api Provider message: The svn command failed. Command output: svn: '.' is not a working copy [INFO] [ERROR] BUILD ERROR [INFO] [INFO] Cannot get the revision information from the scm repository : Error! This is due to the buildnumber-maven-plugin, not sure if that should be really _always_ enabled... Looks like I can't download the soruce and build it, since the target folder (of my unzip) is (of course) not SVN folder. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (TRINIDAD-1863) trinidad requeststatemap does not preserve its state between action and render
[ https://issues.apache.org/jira/browse/TRINIDAD-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott O'Bryan resolved TRINIDAD-1863. - Resolution: Fixed trinidad requeststatemap does not preserve its state between action and render -- Key: TRINIDAD-1863 URL: https://issues.apache.org/jira/browse/TRINIDAD-1863 Project: MyFaces Trinidad Issue Type: Bug Components: Portlet Environment: JSF 2.0, Portlet Reporter: Scott O'Bryan Assignee: Scott O'Bryan The Trinidad configurator framework stores some persisted state in an object called the RequestStateMap. The RequestStateMap's lifespan is supposed to be on physical request which, in a portlet environment, means one processAction/render pair in the case of an ActionRequest, one processEvent/render pain in the case of an event request, or the entire render or resource requests. This is done by checking for the type of request and, if the request is an eventRequest or actionRequest, the map is saved off to the session before the actionRequest ends and then is retrieved from the session when the next renderRequest is executed. Currently, however, this state is getting saved to the RequestMap rather then the session where it belongs. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TRINIDAD-1890) NullPointerException when using file upload with trinidad
[ https://issues.apache.org/jira/browse/TRINIDAD-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12995051#comment-12995051 ] vinod commented on TRINIDAD-1890: - We are using Trinidad 1.2.14, and we need to use tr:inputfile jsp:directive.page contentType=text/html; charset=UTF-8 pageEncoding=UTF-8/ f:view tr:form usesUpload=true tr:document title=InputFile Demo tr:inputFile id=inputFileName label=Label valueChangeListener=#{fileUploadBacker.uploadFileValueChange} value=#{fileUploadBacker.inputFile} / tr:commandButton text=Submit action=#{fileUploadBacker.uploadFile} / /tr:document /tr:form /f:view When ever we use usesUpload=true, we are getting the NullPointer exception upon submitting. And when we remove the usesUpload attribute, the file input doesnt contain any reference to the uploaded file. java.lang.NullPointerException at org.apache.myfaces.trinidadinternal.config.upload.UploadRequestWrapper.setCharacterEncoding(UploadRequestWrapper.java:83) at org.apache.myfaces.context.servlet.ServletExternalContextImpl.setRequestCharacterEncoding(ServletExternalContextImpl.java:457) at org.apache.myfaces.trinidad.context.ExternalContextDecorator.setRequestCharacterEncoding(ExternalContextDecorator.java:266) at org.apache.myfaces.trinidad.context.ExternalContextDecorator.setRequestCharacterEncoding(ExternalContextDecorator.java:266) at javax.faces.application.ViewHandler.initView(ViewHandler.java:188) at javax.faces.application.ViewHandlerWrapper.initView(ViewHandlerWrapper.java:42) at org.apache.myfaces.lifecycle.RestoreViewExecutor.execute(RestoreViewExecutor.java:61) at org.apache.myfaces.lifecycle.LifecycleImpl.executePhase(LifecycleImpl.java:103) at org.apache.myfaces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:76) at javax.faces.webapp.FacesServlet.service(FacesServlet.java:183) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:857) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:588) at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489) at java.lang.Thread.run(Unknown Source) NullPointerException when using file upload with trinidad - Key: TRINIDAD-1890 URL: https://issues.apache.org/jira/browse/TRINIDAD-1890 Project: MyFaces Trinidad Issue Type: Bug Environment: Linux x64 Java 1.6 Reporter: Thomas Müller Assignee: Matthias Weßendorf Hi, I tried to use the file upload in trinidad. When I want to submit a file, I get ther following exception: java.lang.NullPointerException org.apache.myfaces.trinidadinternal.config.upload.UploadRequestWrapper.setCharacterEncoding(UploadRequestWrapper.java:83) com.sun.faces.context.ExternalContextImpl.setRequestCharacterEncoding(ExternalContextImpl.java:165) org.apache.myfaces.trinidad.context.ExternalContextDecorator.setRequestCharacterEncoding(ExternalContextDecorator.java:266) org.apache.myfaces.trinidad.context.ExternalContextDecorator.setRequestCharacterEncoding(ExternalContextDecorator.java:266) javax.faces.application.ViewHandler.initView(ViewHandler.java:270) com.sun.faces.application.ViewHandlerImpl.initView(ViewHandlerImpl.java:119) javax.faces.application.ViewHandlerWrapper.initView(ViewHandlerWrapper.java:175) com.sun.faces.lifecycle.RestoreViewPhase.doPhase(RestoreViewPhase.java:102) com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:118) javax.faces.webapp.FacesServlet.service(FacesServlet.java:265) Can you help me if this is a bug or something is wrong in my enviroment properties? web.xml: ?xml version=1.0 encoding=UTF-8? web-app id=WebApp_ID version=2.5 xmlns=http://java.sun.com/xml/ns/j2ee; xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation=http://java.sun.com/xml/ns/javaee
[jira] Resolved: (TRINIDAD-2037) Unable to build from source archive
[ https://issues.apache.org/jira/browse/TRINIDAD-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott O'Bryan resolved TRINIDAD-2037. - Resolution: Fixed Fix Version/s: 2.0.0-beta-2 Added the discussed profile Unable to build from source archive --- Key: TRINIDAD-2037 URL: https://issues.apache.org/jira/browse/TRINIDAD-2037 Project: MyFaces Trinidad Issue Type: Bug Components: Build Affects Versions: 2.0.0-beta-2 Reporter: Scott O'Bryan Assignee: Scott O'Bryan Priority: Blocker Fix For: 2.0.0-beta-2 The buildnumber-maven-plugin prevents the building of the Trinidad source in Maven when the source tree is downloaded as an archive vs. taken from the svn repository. The steps to reproduce and the results are as follows: Downloaded the source: https://repository.apache.org/content/repositories/orgapachemyfaces-005/org/apache/myfaces/trinidad/trinidad/2.0.0-beta-2/trinidad-2.0.0-beta-2-source-release.zip did an unzip and mvn clean install I am getting this error: [INFO] [buildnumber:create {execution: default}] [INFO] Checking for local modifications: skipped. [INFO] Updating project files from SCM: skipped. [INFO] Executing: /bin/sh -c cd /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api svn --non-interactive info [INFO] Working directory: /home/matzew/work/source/SCOTT/trinidad-2.0.0-beta-2/trinidad-api Provider message: The svn command failed. Command output: svn: '.' is not a working copy [INFO] [ERROR] BUILD ERROR [INFO] [INFO] Cannot get the revision information from the scm repository : Error! This is due to the buildnumber-maven-plugin, not sure if that should be really _always_ enabled... Looks like I can't download the soruce and build it, since the target folder (of my unzip) is (of course) not SVN folder. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (EXTCDI-137) restore the window-id as soon as possible
restore the window-id as soon as possible - Key: EXTCDI-137 URL: https://issues.apache.org/jira/browse/EXTCDI-137 Project: MyFaces CODI Issue Type: Improvement Components: JEE-JSF12-Module, JEE-JSF20-Module Affects Versions: 0.9.2 Reporter: Gerhard Petracek some constellations require the window-id quite early. therefore, the window-id should be restored as soon as possible. it should be possible to disable this new behavior via WindowContextConfig#isEagerWindowContextInitializationEnabled (default: true) attention: it's only supported if WindowContextConfig#isUrlParameterSupported is enabled (default: true) -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (EXTCDI-137) detect the window-id as soon as possible
[ https://issues.apache.org/jira/browse/EXTCDI-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek resolved EXTCDI-137. - Resolution: Fixed Fix Version/s: 0.9.3 detect the window-id as soon as possible Key: EXTCDI-137 URL: https://issues.apache.org/jira/browse/EXTCDI-137 Project: MyFaces CODI Issue Type: Improvement Components: JEE-JSF12-Module, JEE-JSF20-Module Affects Versions: 0.9.2 Reporter: Gerhard Petracek Fix For: 0.9.3 some constellations require the window-id quite early. therefore, the window-id should be restored as soon as possible. it should be possible to disable this new behavior via WindowContextConfig#isEagerWindowContextDetectionEnabled (default: true) attention: it's only supported if WindowContextConfig#isUrlParameterSupported is enabled (default: true) -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (EXTCDI-131) Lost ViewAccessScope when re post action with navigation
[ https://issues.apache.org/jira/browse/EXTCDI-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek resolved EXTCDI-131. - Resolution: Fixed Fix Version/s: 0.9.3 Lost ViewAccessScope when re post action with navigation Key: EXTCDI-131 URL: https://issues.apache.org/jira/browse/EXTCDI-131 Project: MyFaces CODI Issue Type: Bug Reporter: Marcus Büttner Assignee: Mark Struberg Fix For: 0.9.3 Post on page 1 calls an action with navigation to page 2. Press reload to trigger a (re)post then ViewAccessScope get lost. ViewAccessConversationExpirationEvaluator#isExpired causes the problem. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (EXTCDI-121) CodiUtils#lookupFromEnvironment should also use the ServiceLoader
[ https://issues.apache.org/jira/browse/EXTCDI-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek resolved EXTCDI-121. - Resolution: Fixed Fix Version/s: 0.9.3 CodiUtils#lookupFromEnvironment should also use the ServiceLoader - Key: EXTCDI-121 URL: https://issues.apache.org/jira/browse/EXTCDI-121 Project: MyFaces CODI Issue Type: Improvement Components: Core Reporter: Gerhard Petracek Fix For: 0.9.3 -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira