Here are some more options combined with the old top vote getters
(1) MAX_CACHED_SKINS
(2) MAX_SKINS_CACHED
(3) MAX_SKINS_IN_CACHE
(4) SKIN_MAX_CACHE_SIZE
Still, my vote is Pavitra's take on Blake's, (2). It is the maximum
number of skins that we cache, hence MAX_SKINS_CACHED
Jeanne
I vote for 2.
-- Blake Sullivan
On 4/14/11 11:22 AM, Jeanne Waldman wrote:
Here are some more options combined with the old top vote getters
(1) MAX_CACHED_SKINS
(2) MAX_SKINS_CACHED
(3) MAX_SKINS_IN_CACHE
(4) SKIN_MAX_CACHE_SIZE
Still, my vote is Pavitra's take on Blake's, (2). It is the
2 for me
On 04/14/2011 12:23 PM, Blake Sullivan wrote:
I vote for 2.
-- Blake Sullivan
On 4/14/11 11:22 AM, Jeanne Waldman wrote:
Here are some more options combined with the old top vote getters
(1) MAX_CACHED_SKINS
(2) MAX_SKINS_CACHED
(3) MAX_SKINS_IN_CACHE
(4) SKIN_MAX_CACHE_SIZE
Hi,
For this issue, TRINIDAD-2026 memory
leak in skinstyleprovider, I use a least-recently-used-map instead of
a HashMap so I can limit the number of skins that I cache.
This is useful if an application is built so that they have many skins,
like if they have a skin per user, so that the numbe
On 4/13/11 1:13 PM, Jeanne Waldman wrote:
Hi,
For this issue, TRINIDAD-2026
https://issues.apache.org/jira/browse/TRINIDAD-2026memory leak in
skinstyleprovider, I use a least-recently-used-map instead of a
HashMap so I can limit the number of skins that I cache.
This is useful if an
That's a good one, too.
SKIN_STYLE_PROVIDER_CACHE_SIZE is specific, but then SkinStyleProvider
(and StyleProvider for that matter) are in the impl package.
Blake Sullivan wrote, On 4/13/2011 1:52 PM PT:
On 4/13/11 1:13 PM, Jeanne Waldman wrote:
Hi,
For this issue, TRINIDAD-2026 memory
I think configurators are less likely to understand what a 'STYLE PROVIDER' means. So I like the simpler name Blake
proposed 'org.apache.myfaces.trinidad.skin.MAX_CACHED_SKINS'.
Thanks,
Prakash
On 4/13/2011 3:52 PM, Blake Sullivan wrote:
On 4/13/11 1:13 PM, Jeanne Waldman wrote:
Hi,
For this
I like it too. It doesn't roll of the tongue, but I can't think of
something simpler and better.
Prakash Udupa wrote, On 4/13/2011 2:36 PM PT:
I think configurators are less likely to understand what a 'STYLE
PROVIDER' means. So I like the simpler
name Blake proposed
On 4/13/2011 2:46 PM, Jeanne Waldman wrote:
I like it too. It doesn't roll of the tongue, but I can't think of
something simpler and better.
You could try a slight variation MAX_SKINS_CACHED.
Prakash Udupa wrote, On 4/13/2011 2:36 PM PT:
I think configurators are less likely to understand