Re: HtmlColumn 1.2

2008-01-16 Thread Leonardo Uribe
Hi Checking one test for h:column headerClass and footerClass (a test for see if issue 4 of JSR 252), after MYFACES-1790 does not work. The change from javax.faces.HtmlColumn to javax.faces.Column let this code on shared without effect:

Re: HtmlColumn 1.2

2008-01-16 Thread Matthias Wessendorf
ah, good. please do it. so, we can keep the 1.2.6 plugins, right? Don't have time to look deeper at it, sorry -M On Jan 16, 2008 2:25 PM, Leonardo Uribe [EMAIL PROTECTED] wrote: Hi Checking one test for h:column headerClass and footerClass (a test for see if issue 4 of JSR 252), after

Re: HtmlColumn 1.2

2008-01-16 Thread Leonardo Uribe
The changes made in trunk of 1.2.6 plugins are necessary to make this solution work. I think that the spec is wrong, the component type of HtmlColumnTag should be javax.faces.HtmlColumn and not javax.faces.Column. But we need to be according to the spec if we want a release, so is a fact that the

Re: HtmlColumn 1.2

2008-01-03 Thread Matthias Wessendorf
I think the TAG-Clazz should cast against UIColumn (instanceof) and not against HtmlColumn; I can look at the generator next week, after vacation. -M On Jan 3, 2008 11:20 AM, Mario Ivankovits [EMAIL PROTECTED] wrote: Hi! After checking against ri and spec; I think we do it in the right

Re: HtmlColumn 1.2

2008-01-03 Thread Mario Ivankovits
Matthias Wessendorf schrieb: I think the TAG-Clazz should cast against UIColumn (instanceof) and not against HtmlColumn; Ok, I'll do that, still, I think there is something very wrong if we have to check for this special case in the generator all around. Ciao, Mario

Re: HtmlColumn 1.2

2008-01-03 Thread Mario Ivankovits
Hi! After checking against ri and spec; I think we do it in the right way. The component type in htmlcolumntag is javax.faces.column and the component-type in standard-config for htmlcolumn is javax.faces.HtmlColumn. I think the componentType in HtmlColumnTag should be

Re: HtmlColumn 1.2

2008-01-03 Thread Mario Ivankovits
Hi! AFAIK this tag-class is the only tag that the RI folks don't generate. I don't like to fuck the plugin as well; so we could have this tag as real code as well; regarding the std-faces-cfg I agree that HtmlColumn should reflect it's type. With wrong, you talk about the UIColumn (since 1.2)

Re: HtmlColumn 1.2

2008-01-03 Thread Matthias Wessendorf
AFAIK this tag-class is the only tag that the RI folks don't generate. I don't like to fuck the plugin as well; so we could have this tag as real code as well; regarding the std-faces-cfg I agree that HtmlColumn should reflect it's type. With wrong, you talk about the UIColumn (since 1.2) itself

Re: HtmlColumn 1.2

2008-01-03 Thread Matthias Wessendorf
this one is a special guy; On Jan 3, 2008 11:37 AM, Mario Ivankovits [EMAIL PROTECTED] wrote: Hi! AFAIK this tag-class is the only tag that the RI folks don't generate. I don't like to fuck the plugin as well; so we could have this tag as real code as well; regarding the std-faces-cfg

Re: HtmlColumn 1.2

2008-01-03 Thread Martin Marinschek
I would agree with Mario - the spec is wrong if this is treated differently. regards, Martin On 1/3/08, Matthias Wessendorf [EMAIL PROTECTED] wrote: this one is a special guy; On Jan 3, 2008 11:37 AM, Mario Ivankovits [EMAIL PROTECTED] wrote: Hi! AFAIK this tag-class is the only tag

Re: HtmlColumn 1.2

2008-01-02 Thread Martin Marinschek
Hi Cagatay, but shouldn't the component type be the same in the faces-config and in the tag? regards, Martin On Dec 24, 2007 12:20 PM, Cagatay Civici [EMAIL PROTECTED] wrote: After checking against ri and spec; I think we do it in the right way. The component type in htmlcolumntag is

Re: HtmlColumn 1.2

2007-12-24 Thread Cagatay Civici
After checking against ri and spec; I think we do it in the right way. The component type in htmlcolumntag is javax.faces.column and the component-type in standard-config for htmlcolumn is javax.faces.HtmlColumn. The error I get; Caused by: java.lang.IllegalArgumentException : Component

Re: HtmlColumn 1.2

2007-12-24 Thread Cagatay Civici
Just checked RI's ColumnTag, they do a cast to UIColumn. Yes, then the plugins need a change. On Dec 24, 2007 1:20 PM, Cagatay Civici [EMAIL PROTECTED] wrote: After checking against ri and spec; I think we do it in the right way. The component type in htmlcolumntag is javax.faces.column and

Re: HtmlColumn 1.2

2007-12-23 Thread Cagatay Civici
Ok, I see. But the component-type for HtmlColumn in standart faces-config is still javax.faces.HtmlColumn. I see this strange issue when using h:column and h:datatable; Caused by: java.lang.IllegalArgumentException: Component javax.faces.component.UIColumn is no HtmlColumn at

Re: HtmlColumn 1.2

2007-12-23 Thread Matthias Wessendorf
I'll get to it after xmas. -M On Dec 23, 2007 1:14 PM, Cagatay Civici [EMAIL PROTECTED] wrote: Ok, I see. But the component-type for HtmlColumn in standart faces-config is still javax.faces.HtmlColumn. I see this strange issue when using h:column and h:datatable; Caused by:

Re: HtmlColumn 1.2

2007-12-23 Thread Matthias Wessendorf
btw. javax.faces.HtmlColumn is correct for HtmlColumn see: http://java.sun.com/javaee/javaserverfaces/1.2_MR1/docs/api/constant-values.html#javax.faces.component.html.HtmlColumn.COMPONENT_TYPE On Dec 23, 2007 1:14 PM, Cagatay Civici [EMAIL PROTECTED] wrote: Ok, I see. But the component-type

Re: HtmlColumn 1.2

2007-12-23 Thread Bruno Aranda
True, then reverting the fix for the bug should solve everything and would allow us to release properly, Cheers, Bruno On 23/12/2007, Matthias Wessendorf [EMAIL PROTECTED] wrote: btw. javax.faces.HtmlColumn is correct for HtmlColumn see:

Re: HtmlColumn 1.2

2007-12-23 Thread Matthias Wessendorf
this requires a change in the plugins, to generate a check against UIColumn, instead of HtmlColumn -M On Dec 23, 2007 1:14 PM, Cagatay Civici [EMAIL PROTECTED] wrote: Ok, I see. But the component-type for HtmlColumn in standart faces-config is still javax.faces.HtmlColumn. I see this

Re: HtmlColumn 1.2

2007-12-23 Thread Matthias Wessendorf
+1 on that On Dec 23, 2007 2:46 PM, Bruno Aranda [EMAIL PROTECTED] wrote: True, then reverting the fix for the bug should solve everything and would allow us to release properly, Cheers, Bruno On 23/12/2007, Matthias Wessendorf [EMAIL PROTECTED] wrote: btw. javax.faces.HtmlColumn is

Re: HtmlColumn 1.2

2007-12-23 Thread Matthias Wessendorf
it is just using 1.2.5 of the plugins; -M On Dec 23, 2007 2:48 PM, Matthias Wessendorf [EMAIL PROTECTED] wrote: +1 on that On Dec 23, 2007 2:46 PM, Bruno Aranda [EMAIL PROTECTED] wrote: True, then reverting the fix for the bug should solve everything and would allow us to release

HtmlColumn 1.2

2007-12-22 Thread Cagatay Civici
Hi, I've noticed this weird thing in impl 1.2 build. In myfaces-build - HtmlColumn.xml the component type is set as; component-typejavax.faces.HtmlColumn/component-type But in the generated HtmlColumnTag.java in myfaces-impl 1.2 by faces plugin, it is; @Override public String

Re: HtmlColumn 1.2

2007-12-22 Thread Bruno Aranda
Hi, see https://issues.apache.org/jira/browse/MYFACES-1790 Acording to the release (section 4.1.1.1) the component type for UIColumn is javax.faces.Column, bug which was fixed last week, but apparently fixing it has provoked some side effect. And the component type in the xml should be that one