Re: JspStateManagerImpl into shared?

2008-04-02 Thread Mario Ivankovits
of JspStateManagerImpl it should be possible to just replace the actual storing/loading stuff. Does this qualify to move JspStateManagerImpl into shared? Or should I better copy the source over? Ciao, Mario

Re: JspStateManagerImpl into shared?

2008-04-02 Thread [EMAIL PROTECTED]
into Orchestra. With slight refactoring of JspStateManagerImpl it should be possible to just replace the actual storing/loading stuff. Does this qualify to move JspStateManagerImpl into shared? Or should I better copy the source over? There are some jira issues and email threads that might

Re: JspStateManagerImpl into shared?

2008-04-02 Thread Manfred Geiler
that large portions of JspStateManagerImpl can be reused, but requires to copy it over into Orchestra. With slight refactoring of JspStateManagerImpl it should be possible to just replace the actual storing/loading stuff. Does this qualify to move JspStateManagerImpl into shared? Or should I

shared discuss again [was Re: JspStateManagerImpl into shared?]

2008-04-02 Thread Mario Ivankovits
Hi! Mario, you are not alone in hating the shared concept. ;-) Good! 1) has a super stable API That is true, that might be the hardest part. 2) is used (ie. shared) by the myfaces core(!) as well as other myfaces projects Sure! 3) may be used by the experienced JSF app

Shared module (was Re: JspStateManagerImpl into shared?)

2008-04-02 Thread [EMAIL PROTECTED]
Manfred Geiler schrieb: Mario, you are not alone in hating the shared concept. ;-) This is exactly where the myfaces-commons-xxx library comes into play, I often mentioned before. What we need is a module, that 1) has a super stable API 2) is used (ie. shared) by the myfaces core(!) as

Re: shared discuss again [was Re: JspStateManagerImpl into shared?]

2008-04-02 Thread Matthias Wessendorf
Problem here again is the name of such a lib: myfaces-commons-base? myfaces-commons-core? myfaces-commons-super? myfaces-commons-commons? ;-) I'd opt for myfaces-base, but to say the truth, I do not care about the name, whatever name it has will be good for me as long as

Re: Shared module (was Re: JspStateManagerImpl into shared?)

2008-04-02 Thread Matthias Wessendorf
Personally, I think the shared concept works fine. fine is a bit to much, right? But, yeah it works One problem with a commons jar used by core is that Sun Mojarra will need two jars (jsf-api, jsf-impl) and myfaces will need three (jsf-api, jsf-impl, commons-whatever.jar). This is

Re: JspStateManagerImpl into shared?

2008-04-02 Thread [EMAIL PROTECTED]
Mario Ivankovits schrieb: Hi! Does this qualify to move JspStateManagerImpl into shared? Or should I better copy the source over? There are some jira issues and email threads that might be relevant: Thanks for the links, for me it seems there is need

Re: Shared module (was Re: JspStateManagerImpl into shared?)

2008-04-02 Thread [EMAIL PROTECTED]
Matthias Wessendorf schrieb: I'm also sceptical that it will be possible to create a super stable API. Just look at what is in shared at the moment! And in addition to the API, the *implementation* will also need to be super-stable. For example, if a Tomahawk issue (whether bug or new

Re: shared discuss again [was Re: JspStateManagerImpl into shared?]

2008-04-02 Thread Volker Weber
Hi, 2008/4/2, Matthias Wessendorf [EMAIL PROTECTED]: Problem here again is the name of such a lib: myfaces-commons-base? myfaces-commons-core? myfaces-commons-super? myfaces-commons-commons? ;-) I'd opt for myfaces-base, but to say the truth, I do not care about

Re: JspStateManagerImpl into shared?

2008-04-02 Thread Mario Ivankovits
Hi! Orchestra having its own JspStateManagerImpl sounds interesting though. Enabling this on Sun Mojarra for example will quite radically change the way that a JSF app on Mojarra performs. That's not really Orchestra's role. I thought about this like an optional feature one has to

Re: shared discuss again [was Re: JspStateManagerImpl into shared?]

2008-04-02 Thread Matthias Wessendorf
we already have a very raw starting point in the current commons, not yet finished, but it's there ;-) The started commons-(converters|validators) are IMHO a other type of commons, not for use in jsf-impl classes but for application developper. This is for nice and convenient utils

Re: JspStateManagerImpl into shared?

2008-04-02 Thread Scott O'Bryan
I largely agree with Simon here.. Myfaces Core should not be dependent on a commons library. It has an obligation to the TCK. I see no reason, though that if this library has universal appeal, it can't be duplicated in commons. Unlike everyone else though, I don't like the base name.

Re: JspStateManagerImpl into shared?

2008-04-02 Thread Matthias Wessendorf
Myfaces Core should not be dependent on a commons library. It has an obligation to the TCK. currently we have dependencies on some apache commons lib, that's fine, I think (we passed the TCK thing). Or did I got you wrong ? Unlike everyone else though, I don't like the base name. It

Re: JspStateManagerImpl into shared?

2008-04-02 Thread Matthias Wessendorf
On Wed, Apr 2, 2008 at 3:18 PM, Mario Ivankovits [EMAIL PROTECTED] wrote: Hi! Orchestra having its own JspStateManagerImpl sounds interesting though. Enabling this on Sun Mojarra for example will quite radically change the way that a JSF app on Mojarra performs. That's not really

JspStateManagerImpl into shared?

2008-04-01 Thread Mario Ivankovits
into Orchestra. With slight refactoring of JspStateManagerImpl it should be possible to just replace the actual storing/loading stuff. Does this qualify to move JspStateManagerImpl into shared? Or should I better copy the source over? Ciao, Mario