Re: Newt feature: run custom commands at build time

> I do not have a strong opinion on this, we can keep it as is, however... I > expected that these paths are relative to package root but seems like they > are relative to project root. Is this intended behavior? I did not find any > way to address script in a package other that using full path,

Re: Newt feature: run custom commands at build time

Hi Chris, On Tue, Oct 1, 2019 at 3:21 AM Christopher Collins wrote: > Hi Andrzej, > > On Thu, Sep 26, 2019 at 07:24:54PM +0200, Andrzej Kaczmarek wrote: > > This looks very good! I was thinking if it would be possible to reference > > other targets (i.e. artifacts) from scripts but with the

Re: Newt feature: run custom commands at build time

Hi Andrzej, On Thu, Sep 26, 2019 at 07:24:54PM +0200, Andrzej Kaczmarek wrote: > This looks very good! I was thinking if it would be possible to reference > other targets (i.e. artifacts) from scripts but with the latest addition of > shared folder this does not seem to be a problem since it can

Re: Newt feature: run custom commands at build time

Hi Chris, On Tue, Sep 24, 2019 at 2:48 AM Christopher Collins wrote: > Hello all, > > I have implemented a feature in newt: the ability to run custom shell > commands at build time. > > > > Is there any extra functionality that you'd like to see

Re: Newt feature: run custom commands at build time

On Wed, Sep 25, 2019 at 06:29:19PM +0300, marko kiiskila wrote: > Sounds good. If we need to add more, we can do that later. Thanks. I have updated the PR with the discussed changes: Chris

Re: Newt feature: run custom commands at build time

> On 24 Sep 2019, at 20.14, Christopher Collins wrote: > > Hi Marko, > > On Tue, Sep 24, 2019 at 03:19:24PM +0300, marko kiiskila wrote: >> Thanks, this is a very useful feature. >> >>> On 24 Sep 2019, at 3.50, Christopher Collins wrote: >>> >> ... >>> >>> A package specifies custom

Re: Newt feature: run custom commands at build time

Hi Marko, On Tue, Sep 24, 2019 at 03:19:24PM +0300, marko kiiskila wrote: > Thanks, this is a very useful feature. > > > On 24 Sep 2019, at 3.50, Christopher Collins wrote: > > > ... > > > > A package specifies custom commands in its `pkg.yml` file. There are > > two types of commands: 1)

Re: Newt feature: run custom commands at build time

Thanks, this is a very useful feature. > On 24 Sep 2019, at 3.50, Christopher Collins wrote: > ... > > A package specifies custom commands in its `pkg.yml` file. There are > two types of commands: 1) pre_cmds (run before the build), and 2) > post_cmds (run after the build). > > ### EXAMPLE

Newt feature: run custom commands at build time

Hello all, I have implemented a feature in newt: the ability to run custom shell commands at build time. Is there any extra functionality that you'd like to see here? All comments are appreciated. I am duplicating the PR text here, but the