Re: [CANCELLED] [VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-12 Thread Josh Juneau
Hi Neil, I submitted the new PR https://github.com/apache/netbeans/pull/1375 and Travis fails on some external binaries that are not related to my changes. BUILD FAILED /home/travis/build/apache/netbeans/nbbuild/build.xml:1584: Failed VerifyLibsAndLicenses test(s): Some binaries were found outs

Re: [CANCELLED] [VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-12 Thread Josh Juneau
I am working on the repaired PR now...will be in touch soon. Thanks Josh Juneau juneau...@gmail.com http://jj-blogger.blogspot.com https://www.apress.com/us/search?query=Juneau > On Jul 12, 2019, at 5:09 AM, Neil C Smith wrote: > > On Fri, 12 Jul 2019 at 10:26, Geertjan Wielenga wrote: >> >

Re: [CANCELLED] [VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-12 Thread Neil C Smith
On Fri, 12 Jul 2019 at 11:32, Geertjan Wielenga wrote: > > I think the following should go in to beta-4: > > - Gaurav's fix for the Payara Micro issue that triggered the need for beta-4 > - Laszlo's license fixes > - Josh's PR, if he can get to it in time, > - Toni's PR about the DukeScript suppop

Re: [CANCELLED] [VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-12 Thread Geertjan Wielenga
I think the following should go in to beta-4: - Gaurav's fix for the Payara Micro issue that triggered the need for beta-4 - Laszlo's license fixes - Josh's PR, if he can get to it in time, - Toni's PR about the DukeScript suppoprt and JDK 11 That's all, I think. Gj On Fri, Jul 12, 2019 at 12:0

Re: [CANCELLED] [VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-12 Thread Neil C Smith
On Fri, 12 Jul 2019 at 10:26, Geertjan Wielenga wrote: > > Excellent, great, thank you! > Just waiting to hear if Josh can look at fixing the J2EE PR. Have opened a sync PR to the release branch. Let me know if anything else looks missing. https://github.com/apache/netbeans/pull/1374 As an as

Re: [CANCELLED] [VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-12 Thread Geertjan Wielenga
Excellent, great, thank you! Gj On Fri, Jul 12, 2019 at 10:19 AM Neil C Smith wrote: > Hi, > > So, unfortunately a critical issue was picked up in NB 11.1-vc1, and > voting on that has had to be cancelled. See > https://issues.apache.org/jira/browse/NETBEANS-2824 Despite > downgrading to Crit

[CANCELLED] [VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-12 Thread Neil C Smith
Hi, So, unfortunately a critical issue was picked up in NB 11.1-vc1, and voting on that has had to be cancelled. See https://issues.apache.org/jira/browse/NETBEANS-2824 Despite downgrading to Critical because there is a (horrible) workaround, there's no way we should release NB 11.1 with it in.

Re: [VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-12 Thread Neil C Smith
On Thu, 11 Jul 2019 at 22:00, Laszlo Kishalmi wrote: > Having that in I cannot say +1 however I wish. I do not think that is a > real blocker, so you can still overrule me with +1-s, as it seems to be > a good release in every other aspect I've checked. Well, as you've seen elsewhere, we have a c

Re: [VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-12 Thread Neil C Smith
On Fri, 12 Jul 2019 at 07:52, Alessandro wrote: > Neil explained that the NOTICE file in the zip is generated by an Ant task > that takes nbbuild/notice-stub.txt as a header, the NOTICE file in the root > of the repo is not going to be distributed. > Maybe it would be better to delete it? No, it

Re: [VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-12 Thread Neil C Smith
On Thu, 11 Jul 2019 at 23:54, Laszlo Kishalmi wrote: > > Here is it: https://github.com/apache/netbeans/pull/1370 Thanks! > As of the date in the NOTICE file, we need to check the build as both on > master and on release111 the NOTICE file is different than the one ended > up in the zip and both

Re: [VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-11 Thread Alessandro
Hi Laszlo, I already reported the NOTICE inconsistency. Neil explained that the NOTICE file in the zip is generated by an Ant task that takes nbbuild/notice-stub.txt as a header, the NOTICE file in the root of the repo is not going to be distributed. Maybe it would be better to delete it? Greet

Re: [VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-11 Thread Laszlo Kishalmi
Here is it: https://github.com/apache/netbeans/pull/1370 As of the date in the NOTICE file, we need to check the build as both on master and on release111 the NOTICE file is different than the one ended up in the zip and both has the correct year: 2019. On 7/11/19 2:27 PM, Geertjan Wielenga w

Re: [VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-11 Thread Geertjan Wielenga
Great, can you provide a PR to fix this, together with the PRs from Gaurav, Josh, and Toni, we’ll enable Neil to create beta-4 in preparation for vc2 early next week, yes, small slip, but we’re learning and it’s a process. Gj On Thu, 11 Jul 2019 at 23:00, Laszlo Kishalmi wrote: > -1 (binding)

Re: [VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-11 Thread Laszlo Kishalmi
-1 (binding) Dear all, You won't like me, as it is all my fault. What was checked: Checksum - OK Signatures - OK LICENSE, NOTICE, DEPENDENCIES - OK NOTICE Year - FAIL Build from Source - OK Run on Ubuntu with OpenJDK8 - OK Run on Ubuntu with OpenJDK11 - OK Run on Ubuntu with OpenJDK12 - OK Run

RE: [VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-11 Thread Eric Barboni
+1 (binding) Sha512+asc check Regards Eric (notice-stub.txt in nbbuild folder is used and not up to date) -Message d'origine- De : Alessandro Envoyé : jeudi 11 juillet 2019 15:54 À : dev@netbeans.apache.org Objet : Re: [VOTE] Release Apache NetBeans 11.1 [vote candidate 1

Re: [VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-11 Thread Neil C Smith
On Thu, 11 Jul 2019 at 14:54, Alessandro wrote: > Don't know if this matters a lot but the NOTICE file in the source archive > is completely different from that on the git repository (copyright end > year, additional license statements for Kotlin, IntelliJ IDEA, Struts, > Jakarta Validator). This

Re: [VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-11 Thread Alessandro
+1 Don't know if this matters a lot but the NOTICE file in the source archive is completely different from that on the git repository (copyright end year, additional license statements for Kotlin, IntelliJ IDEA, Struts, Jakarta Validator). Steps: - Verified sha512 - Unzipped source archives - Ver

Re: [VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-11 Thread Kai Uwe Pel
+1 Built it by success... no issues with 11.1-vc1! Thanks! Kai On 7/10/2019 9:41 PM, Neil C Smith wrote: Dear all, This is our first voting candidate for the 11.1 release of Apache NetBeans. Apache NetBeans 11.1 constitutes all clusters in the Apache NetBeans Git repo, which together provide

Re: [VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-11 Thread Patrick Musembi
+1 I have been using apache Netbeans 11.1 for sometime and its working as expected. On Thu, Jul 11, 2019, 11:49 Geertjan Wielenga wrote: > Me too. Built it successfully as well and will be voting +1 today. > > We also must remember this is not a LTS release, i.e., it will not be > perfect and th

Re: [VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-11 Thread Josh Juneau
+1 ... The vc1 sources build without issue. Verified files and signature. Thanks for the hard work! On Wed, Jul 10, 2019 at 2:41 PM Neil C Smith wrote: > Dear all, > > This is our first voting candidate for the 11.1 release of Apache NetBeans. > > Apache NetBeans 11.1 constitutes all clusters

Re: [VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-11 Thread Geertjan Wielenga
Me too. Built it successfully as well and will be voting +1 today. We also must remember this is not a LTS release, i.e., it will not be perfect and the better we can document that, the better. I.e., let's provide a list of issues that we know are significant in the Java EE 8 world, since that's o

Re: [VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-11 Thread huang kai
+1 I've been using netbeans 11.1 for a while, it's good and functioning smoothly, I like it. 在2019年07月11,上午 3:41,Neil C Smith 写道: Dear all, This is our first voting candidate for the 11.1 release of Apache NetBeans. Apache NetBeans 11.1 constitutes all clusters in the Apache NetBeans Git repo,

[VOTE] Release Apache NetBeans 11.1 [vote candidate 1]

2019-07-10 Thread Neil C Smith
Dear all, This is our first voting candidate for the 11.1 release of Apache NetBeans. Apache NetBeans 11.1 constitutes all clusters in the Apache NetBeans Git repo, which together provide the NetBeans Platform (i.e., the underlying application framework), as well as all the modules that provide t