[GitHub] nifi pull request: NIFI-901: Add QueryCassandra and PutCassandraQL...

2016-03-15 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/237#discussion_r56214671 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/AbstractCassandraProcessor.java

[GitHub] nifi pull request: NIFI-1047 Added additional method to get proces...

2016-03-15 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/278#discussion_r56213996 --- Diff: nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java --- @@ -1131,6 +1135,22 @@ public void run() { this.loggingFutures

[GitHub] nifi pull request: NIFI-1464 fixed OnScheduled invocation to pass ...

2016-03-15 Thread olegz
Github user olegz closed the pull request at: https://github.com/apache/nifi/pull/279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...

2016-03-15 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/222#issuecomment-196861594 Agreed and the JIRA is https://issues.apache.org/jira/browse/NIFI-1628 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...

2016-03-15 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/222#issuecomment-196855425 So the problem with Tibco and SSL is that Tibco does things differently then other providers. In other words they don't use SSLContext and instead rely on setting

[GitHub] nifi pull request: NIFI-1464 fixed OnScheduled invocation to pass ...

2016-03-15 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/279 NIFI-1464 fixed OnScheduled invocation to pass ProcessContext You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1464C Alternatively

[GitHub] nifi pull request: NIFI-1464 life-cycle refactoring part-2

2016-03-15 Thread olegz
Github user olegz closed the pull request at: https://github.com/apache/nifi/pull/275 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-14 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/271#discussion_r56106623 --- Diff: nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/bootstrap/SpringContextDelegate.java --- @@ -0,0

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-14 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/271#discussion_r56106557 --- Diff: nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java --- @@ -0,0 +1,382

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-14 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/271#discussion_r56106464 --- Diff: nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextFactory.java --- @@ -0,0 +1,139

[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...

2016-03-14 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/222#issuecomment-196535593 I'll look at it. I think I know what's going on. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request: NIFI-1464 life-cycle refactoring part-2

2016-03-14 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/275 NIFI-1464 life-cycle refactoring part-2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1464B Alternatively you can review

[GitHub] nifi pull request: NIFI-1464 Refactored Processor's life-cycle ope...

2016-03-11 Thread olegz
Github user olegz closed the pull request at: https://github.com/apache/nifi/pull/210 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-11 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/271 NIFI-1571 initial commit of SpringContext support You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1571 Alternatively you can

[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...

2016-03-11 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/222#issuecomment-195427526 We'll be adding more docs in there in the future related to specific providers (e.g., IBM, Tibco etc), so treat it as place holder --- If your project is set up

[GitHub] nifi pull request: Nifi 1540 - AWS Kinesis Get and Put Processors

2016-03-08 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/239#discussion_r55397257 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/kinesis/consumer/GetKinesis.java --- @@ -0,0 +1,238

[GitHub] nifi pull request: Nifi 1540 - AWS Kinesis Get and Put Processors

2016-03-08 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/239#discussion_r55396443 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/AbstractBaseAWSProcessor.java --- @@ -0,0 +1,211

[GitHub] nifi pull request: NIFI-1537 Added SNMP processors

2016-03-08 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/257#discussion_r55371374 --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/test/java/org/apache/nifi/snmp/processors/SetSNMPTest.java --- @@ -0,0 +1,411

[GitHub] nifi pull request: NIFI-1537 Added SNMP processors

2016-03-08 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/257#discussion_r55369456 --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/AbstractSNMPProcessor.java --- @@ -0,0 +1,414

[GitHub] nifi pull request: NIFI-1595 fixed ReflectionUtils to honor bridge...

2016-03-07 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/260#issuecomment-193428093 np, most of the formatting was done to javadocs since they were too long. Is that the changes you are referring to? Just curious --- If your project is set up for it, you

[GitHub] nifi pull request: NIFI-1595 fixed ReflectionUtils to honor bridge...

2016-03-07 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/260 NIFI-1595 fixed ReflectionUtils to honor bridge methods Refactored and simplified ReflectionUtils while at it Added ReflectionUtilsTest You can merge this pull request into a Git repository

[GitHub] nifi pull request: NIFI-1537 Added SNMP processors

2016-03-06 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/257#discussion_r55147036 --- Diff: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SNMPUtils.java --- @@ -0,0 +1,268

[GitHub] nifi pull request: NIFI-1568: Add Filter Capability to UnpackConte...

2016-02-26 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/248#discussion_r54299720 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java --- @@ -202,11

[GitHub] nifi pull request: NIFI-901: Add QueryCassandra and PutCassandraQL...

2016-02-26 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/237#discussion_r54299220 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/AbstractCassandraProcessor.java

[GitHub] nifi pull request: NIFI-1568: Add Filter Capability to UnpackConte...

2016-02-26 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/248#discussion_r54298253 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java --- @@ -202,11

[GitHub] nifi pull request: Nifi 1516 - AWS DynamoDB Get/Put/Delete Process...

2016-02-26 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/224#discussion_r54296973 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/dynamodb/GetDynamoDB.java --- @@ -0,0 +1,180

[GitHub] nifi pull request: Nifi 1516 - AWS DynamoDB Get/Put/Delete Process...

2016-02-26 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/224#discussion_r54296834 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/dynamodb/DeleteDynamoDB.java --- @@ -0,0 +1,152

[GitHub] nifi pull request: Nifi 1516 - AWS DynamoDB Get/Put/Delete Process...

2016-02-26 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/224#discussion_r54296295 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/dynamodb/AbstractDynamoDBProcessor.java --- @@ -0,0

[GitHub] nifi pull request: NIFI-1464, NIFI-78, NIFI-1487 Refactored Proces...

2016-02-26 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/210#issuecomment-189315181 Point taken, wasn't sure what DISABLED meant in the context of Processor and thought it was some leftover that shouldn't be there. Will put it back and add tests

[GitHub] nifi pull request: NIFI-1420 Adding Splunk bundle

2016-02-25 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/233#discussion_r54099029 --- Diff: nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/put/sender/ChannelSender.java --- @@ -0,0 +1,103

[GitHub] nifi pull request: NIFI-1420 Adding Splunk bundle

2016-02-25 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/233#discussion_r54098283 --- Diff: nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/put/AbstractPutEventProcessor.java --- @@ -0,0 +1,474

[GitHub] nifi pull request: NIFI-1513: fixed some easy to fix errors

2016-02-25 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/221#discussion_r54095802 --- Diff: nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/bin/Bin.java --- @@ -121,8 +125,9 @@ public boolean offer(final

[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...

2016-02-22 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/222#discussion_r53622460 --- Diff: nifi-nar-bundles/nifi-jms-bundle/nifi-jms-cf-service/.gitignore --- @@ -0,0 +1 @@ +/lib/ --- End diff -- It isn't ;) --- If your

[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor

2016-02-17 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/232#issuecomment-185272014 Ok, let's collaborate. If you can simply describe what you needed to do on both client and server to have SSL, I can definitely mock it on the _TestConnection_

[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor

2016-02-17 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/232#issuecomment-185265232 Pierre, first of all, huge thanks for the contribution! Quite an important feature especially for enterprise users. Quick question though. One of the initiatives we

[GitHub] nifi pull request: NIFI-1519 upgraded to the latest version of Spa...

2016-02-17 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/231 NIFI-1519 upgraded to the latest version of Spark 1.6.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1519 Alternatively you can

[GitHub] nifi pull request: NIFI-1464, NIFI-78, NIFI-1487 Refactored Proces...

2016-02-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/210#discussion_r53169078 --- Diff: nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java --- @@ -71,6 +71,7 @@ public static final String

[GitHub] nifi pull request: NIFI-1464, NIFI-78, NIFI-1487 Refactored Proces...

2016-02-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/210#discussion_r53164352 --- Diff: nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java --- @@ -71,6 +71,7 @@ public static final String

[GitHub] nifi pull request: NIFI-1464, NIFI-78, NIFI-1487 Refactored Proces...

2016-02-16 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/210#discussion_r53057308 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service

[GitHub] nifi pull request: NIFI-1464, NIFI-78, NIFI-1487 Refactored Proces...

2016-02-15 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/210#discussion_r52926642 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/scheduling/StandardProcessScheduler.java

[GitHub] nifi pull request: NIFI-1464, NIFI-78, NIFI-1487 Refactored Proces...

2016-02-15 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/210#discussion_r52907459 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/service

[GitHub] nifi pull request: NIFI-1464, NIFI-78, NIFI-1487 Refactored Proces...

2016-02-15 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/210#discussion_r52907228 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/scheduling/StandardProcessScheduler.java

[GitHub] nifi pull request: NIFI-614 Added initial support for new style JM...

2016-02-14 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/222 NIFI-614 Added initial support for new style JMS NIFI-614 finalized JMSConnectionFactoryProvider ControllerService NIFI-614 finalized implementation of both Processors and ControllerService

[GitHub] nifi pull request: NIFI-1464, NIFI-78, NIFI-1487 Refactored Proces...

2016-02-08 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/210 NIFI-1464, NIFI-78, NIFI-1487 Refactored Processor's life-cycle opera… …tion sequence * Simplified and cleaned StandardProcessScheduler.start/stopProcessor methods * Added stop/start

[GitHub] nifi pull request: NIFI-1486 added commons io and lang to nifi-amq...

2016-02-07 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/208#issuecomment-181098653 Ok, then what about the rest of the dependencies (i.e., antlr, slf4j etc)? Just trying to understand for the future. --- If your project is set up for it, you can reply

[GitHub] nifi pull request: NIFI-1486 added commons io and lang to nifi-amq...

2016-02-07 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/208#issuecomment-181098054 Shouldn't it be implied under NiFi since those dependencies are pulled by NiFi dependencies and are not explicitly imported by AMQP NAR? --- If your project is set up

[GitHub] nifi pull request: Test Performance improvement. test Timeout Miti...

2016-02-02 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/202#issuecomment-178865279 @PuspenduBanerjee could you please raise JIRAs before submitting PRs. This is kind of the process that these projects follow and its easier for planning as well

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

2016-02-02 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/200#issuecomment-178925056 @bbende doing it now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

2016-02-02 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/200#issuecomment-178928684 @bbende done! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

2016-02-02 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51596690 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPUtils.java --- @@ -0,0 +1,115

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

2016-02-02 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51600206 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java --- @@ -0,0 +1,219

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

2016-02-02 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51602109 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPWorker.java --- @@ -0,0 +1,104

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

2016-02-02 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/200#issuecomment-178641022 Sorry, the S2 naming habit. Will change --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

2016-02-02 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51593879 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AbstractAMQPProcessor.java --- @@ -0,0 +1,204

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

2016-02-02 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51603654 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPUtils.java --- @@ -0,0 +1,115

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

2016-02-02 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51604778 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPUtils.java --- @@ -0,0 +1,115

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

2016-02-02 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51605138 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPWorker.java --- @@ -0,0 +1,104

[GitHub] nifi pull request: NIFI-924:Nifi-Camel Integration

2016-02-01 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/197#issuecomment-178287033 @PuspenduBanerjee We are currently in the process of releasing 0.5 which is imminent. We'll be happy to help you through this (review, polish etc) once 0.5 is out. Hope you

[GitHub] nifi pull request: [REVIEW ONLY]]NIFI-865 added initial support fo...

2016-02-01 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/199 [REVIEW ONLY]]NIFI-865 added initial support for AMQP publish/subscribe Still working on docs and tests You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi pull request: [REVIEW ONLY]]NIFI-865 added initial support fo...

2016-02-01 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/199#discussion_r51445239 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/test/resources/log4j.properties --- @@ -0,0 +1,22 @@ +# Licensed to the Apache Software

[GitHub] nifi pull request: [REVIEW ONLY]]NIFI-865 added initial support fo...

2016-02-01 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/199#discussion_r51444249 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPPublisher.java --- @@ -0,0 +1,128

[GitHub] nifi pull request: [REVIEW ONLY]]NIFI-865 added initial support fo...

2016-02-01 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/199#discussion_r51442275 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPConsumer.java --- @@ -0,0 +1,78

[GitHub] nifi pull request: [REVIEW ONLY]]NIFI-865 added initial support fo...

2016-02-01 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/199#discussion_r51444624 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPConsumer.java --- @@ -0,0 +1,78

[GitHub] nifi pull request: [REVIEW ONLY]]NIFI-865 added initial support fo...

2016-02-01 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/199#discussion_r51443924 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPWorker.java --- @@ -0,0 +1,104

[GitHub] nifi pull request: [REVIEW ONLY]]NIFI-865 added initial support fo...

2016-02-01 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/199#issuecomment-178159306 Closing it after initial review. Will open a new one once all comments are addressed and cleanup. --- If your project is set up for it, you can reply to this email

[GitHub] nifi pull request: NIFI-1447 modified SimpleProcessLogger

2016-01-29 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/193 NIFI-1447 modified SimpleProcessLogger Modified SimpleProcessLogger to ensure that whenever is called it prints full stack trace. You can merge this pull request into a Git repository by running

[GitHub] nifi pull request: NIFI-1093 added support for handling non-requir...

2016-01-29 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/195 NIFI-1093 added support for handling non-required columns Mostly based on contribution from Daniel Cave You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi pull request: Nifi-Camel Integration

2016-01-28 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/186#discussion_r51128670 --- Diff: nifi-nar-bundles/nifi-camel-bundle/nifi-camel-processors/src/main/java/org/apache/nifi/processors/camel/CamelProcessor.java --- @@ -0,0 +1,240

[GitHub] nifi pull request: Nifi-Camel Integration

2016-01-28 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/186#discussion_r51128900 --- Diff: nifi-nar-bundles/nifi-camel-bundle/nifi-camel-processors/src/main/java/org/apache/nifi/processors/camel/CamelProcessor.java --- @@ -0,0 +1,240

[GitHub] nifi pull request: Nifi-Camel Integration

2016-01-27 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/186#discussion_r51000926 --- Diff: nifi-nar-bundles/nifi-camel-bundle/nifi-camel-processors/src/main/java/org/apache/nifi/processors/camel/CamelProcessor.java --- @@ -0,0 +1,240

[GitHub] nifi pull request: NIFI-1337: Add Riemann Reporting Task

2016-01-27 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/188#discussion_r51007338 --- Diff: nifi-nar-bundles/nifi-riemann-bundle/nifi-riemann-reporting-task/src/main/java/org/apache/nifi/reporting/riemann/RiemannReportingTask.java --- @@ -0,0

[GitHub] nifi pull request: NIFI-1337: Add Riemann Reporting Task

2016-01-27 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/188#discussion_r51010766 --- Diff: nifi-nar-bundles/nifi-riemann-bundle/nifi-riemann-reporting-task/src/main/java/org/apache/nifi/reporting/riemann/RiemannReportingTask.java --- @@ -0,0

[GitHub] nifi pull request: Nifi-Camel Integration

2016-01-27 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/186#discussion_r51003529 --- Diff: nifi-nar-bundles/nifi-camel-bundle/nifi-camel-processors/src/main/java/org/apache/nifi/processors/camel/CamelProcessor.java --- @@ -0,0 +1,240

[GitHub] nifi pull request: NIFI-1337: Add Riemann Reporting Task

2016-01-27 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/188#discussion_r51005574 --- Diff: nifi-nar-bundles/nifi-riemann-bundle/nifi-riemann-reporting-task/src/main/java/org/apache/nifi/reporting/riemann/RiemannReportingTask.java --- @@ -0,0

[GitHub] nifi pull request: Nifi-Camel Integration

2016-01-27 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/186#discussion_r51004665 --- Diff: nifi-nar-bundles/nifi-camel-bundle/nifi-camel-processors/src/main/java/org/apache/nifi/processors/camel/CamelProcessor.java --- @@ -0,0 +1,240

[GitHub] nifi pull request: NIFI-1337: Add Riemann Reporting Task

2016-01-27 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/188#discussion_r51006207 --- Diff: nifi-nar-bundles/nifi-riemann-bundle/nifi-riemann-reporting-task/src/main/java/org/apache/nifi/reporting/riemann/RiemannReportingTask.java --- @@ -0,0

[GitHub] nifi pull request: NIFI-1337: Add Riemann Reporting Task

2016-01-27 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/188#discussion_r51008302 --- Diff: nifi-nar-bundles/nifi-riemann-bundle/nifi-riemann-reporting-task/src/main/java/org/apache/nifi/reporting/riemann/RiemannReportingTask.java --- @@ -0,0

[GitHub] nifi pull request: NIFI-1423 Allow to penalize FlowFiles to No Ret...

2016-01-27 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/183#issuecomment-175748677 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request: NIFI-1436 Fixing race condition in SocketChanne...

2016-01-25 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/189#issuecomment-174577480 Yes, the releasing of resources implies closing. You can easily test it and see broken connection on the client side. --- If your project is set up for it, you can reply

[GitHub] nifi pull request: NIFI-1378 fixed JMS URI validation

2016-01-21 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/167#issuecomment-173604806 @trkurc I do see your point, so let me throw something else at you. The _URI_VALIDATOR_ simply validates based on success of this ```new URI(input);``` and we can certainly

[GitHub] nifi pull request: NIFI-1406 Collecting the number of bytes sent r...

2016-01-18 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/176#issuecomment-172556905 There is also a compile warning in the catch clause preceding the place where you made you changes ``` } catch (final IOException e

[GitHub] nifi pull request: NIFI-1384 Changed DocumentWriter to accept Clas...

2016-01-18 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/171#issuecomment-172564889 At the moment I agree, this should not be merged as it was primarily done to start the conversation - https://cwiki.apache.org/confluence/pages/viewpage.action?pageId

[GitHub] nifi pull request: NIFI-1384 Changed DocumentWriter to accept Clas...

2016-01-18 Thread olegz
Github user olegz closed the pull request at: https://github.com/apache/nifi/pull/171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

2016-01-18 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/148#issuecomment-172583777 I am not surprised, that's why I was against having a lock in a shutdown in the first place. It doesn't bring any value since If you follow the logic of shutting down

[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

2016-01-14 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/148#issuecomment-171660747 @markap14 @joewitt Guys, please review. As agreed I've put read lock back in. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi pull request: NIFI-1317 removed duplicate 'name' instance var...

2016-01-13 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/169#issuecomment-171283707 @trkurc went ahead with your suggestion. It's definitely safer. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi pull request: NIFI-1378 fixed JMS URI validation

2016-01-12 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/167 NIFI-1378 fixed JMS URI validation simplified JmsFactory check for SSL and scheme-less URIs ensured URI validation is handled by ActiveMqConnectionFactory ensured informative error messages

[GitHub] nifi pull request: NIFI-1376 Provide access to logged messages fro...

2016-01-12 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/165#discussion_r49470011 --- Diff: nifi-mock/src/main/java/org/apache/nifi/util/MockProcessorLog.java --- @@ -16,20 +16,57 @@ */ package org.apache.nifi.util

[GitHub] nifi pull request: NIFI-1233 upgraded to Kafka 0.9.0.0

2016-01-12 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/168 NIFI-1233 upgraded to Kafka 0.9.0.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1233 Alternatively you can review and apply

[GitHub] nifi pull request: NIFI-1317 removed duplicate 'name' instance var...

2016-01-12 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/169#discussion_r49540950 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/AbstractConfiguredComponent.java

[GitHub] nifi pull request: NIFI-1317 removed duplicate 'name' instance var...

2016-01-12 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/169#issuecomment-171109933 Coo. thx @trkurc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: Nifi 1324

2016-01-12 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/170#discussion_r49536701 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/PGPUtil.java --- @@ -46,9 +46,8

[GitHub] nifi pull request: NIFI-1317 removed duplicate 'name' instance var...

2016-01-12 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/169 NIFI-1317 removed duplicate 'name' instance variable You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1317 Alternatively you can

[GitHub] nifi pull request: NIFI-1233 upgraded to Kafka 0.9.0.0

2016-01-12 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/168#discussion_r49477360 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/pom.xml --- @@ -37,12 +37,12 @@ org.apache.kafka

[GitHub] nifi pull request: Nifi 1365

2016-01-12 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/163#discussion_r49476661 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/PGPUtil.java --- @@ -0,0 +1,89

[GitHub] nifi pull request: Nifi 1365

2016-01-12 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/163#discussion_r49477103 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/PGPUtil.java --- @@ -0,0 +1,89

[GitHub] nifi pull request: NIFI-1289 reverted changes to NiFiProperties

2015-12-24 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/150 NIFI-1289 reverted changes to NiFiProperties in favor of the localized relection call in test to refresh properties. polish javadoc You can merge this pull request into a Git repository

[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

2015-12-23 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/148 NIFI-1333 fixed FlowController shutdown deadlock The relevant test is available here: https://github.com/olegz/nifi/blob/int-test/nifi-integration-tests/src/test/java/org/apache/nifi/test/flowcontroll

[GitHub] nifi pull request: NIFI-1218 upgraded Kafka to 0.9.0.0 client API

2015-12-16 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/143#issuecomment-165207075 Addressed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request: NIFI-1218 upgraded Kafka to 0.9.0.0 client API

2015-12-16 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/143#discussion_r47814866 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/test/java/org/apache/nifi/processors/kafka/TestPutKafka.java --- @@ -474,6 +475,18

<    1   2   3   4   5   >