[
https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273854#comment-13273854
]
Jacopo Cappellato commented on OFBIZ-4856:
--
Full set of revisions for trunk:
[
https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273867#comment-13273867
]
Jacques Le Roux commented on OFBIZ-4856:
Thanks :)
webapp
That's fine.
+1
-Adrian
On 5/11/2012 1:56 PM, Jacopo Cappellato wrote:
Adrian, can I proceed with the proposed change then?
Thanks,
Jacopo
On Apr 24, 2012, at 2:36 PM, Adrian Crum wrote:
I hadn't thought of that. Thanks for the tip!
-Adrian
On 4/24/2012 1:10 PM, Jacopo Cappellato
Original Message
Subject:Build failed in Jenkins: OFBizTrunk #144
Date: Sat, 12 May 2012 03:23:25 + (UTC)
From: jenk...@antwebsystems.com
To: jenk...@hansbakker.com
Seehttp://jenkins.antwebsystems.com/job/OFBizTrunk/144/changes
Changes:
[doogie]
On May 11, 2012, at 9:51 PM, Adam Heath wrote:
On 05/11/2012 02:46 PM, Jacopo Cappellato wrote:
The UtilCache objects *are* thread-safe. You will not get any
internal corruption inside UtilCache. That is all that can be guaranteed.
What isn't thread safe, is that calling code may end up
Jacques Le Roux created OFBIZ-4874:
--
Summary: Improve site-conf.xsd
Key: OFBIZ-4874
URL: https://issues.apache.org/jira/browse/OFBIZ-4874
Project: OFBiz
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/OFBIZ-4874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-4874:
---
Description:
I have always wondered why the controller syntax is poorly documented. I will
I see the same failure; Adam earlier mentioned that it is caused by Adrian's
commit 1337103 but I didn't check.
I will wait for Adrian's review for a while before looking into this more
closely (later today).
Jacopo
On May 12, 2012, at 8:55 AM, Hans Bakker wrote:
Original
On May 11, 2012, at 9:51 PM, Adam Heath wrote:
(I've wanted to add a UtilCache.getOrCreate(key, creator) method for a
while to solve this problem, but have never gotten around to it).
Nice.
The following small utility method may also be useful:
Index:
The tests cases pass on my local machine. Could you provide the test
report XML file please?
-Adrian
On 5/12/2012 3:59 AM, Adam Heath wrote:
On 05/11/2012 05:25 AM, adri...@apache.org wrote:
Author: adrianc
Date: Fri May 11 10:25:33 2012
New Revision: 1337103
URL:
Adrian,
I am forwarding you a zip file with my test results.
Jacopo
On May 12, 2012, at 9:08 AM, Adrian Crum wrote:
The tests cases pass on my local machine. Could you provide the test report
XML file please?
-Adrian
On 5/12/2012 3:59 AM, Adam Heath wrote:
On 05/11/2012 05:25 AM,
Yet another thread might explicitly *remove* the key between the
putIfAbsent and following get; so the above really needs to be done in
a loop.
This is a good point and probably the only real issue of your initial code
(and in the latest version of my code, the one without synchronized
Thanks Jacopo! I am working on it.
-Adrian
On 5/12/2012 8:14 AM, Jacopo Cappellato wrote:
Adrian,
I am forwarding you a zip file with my test results.
Jacopo
On May 12, 2012, at 9:08 AM, Adrian Crum wrote:
The tests cases pass on my local machine. Could you provide the test report XML
Hold off. On trunk, I get issues, but if I reverse the below patch, it
doesn't solve the problem. git bisect can be confused when 2 problems
are happening. I'll check this further in the morning.
On 05/12/2012 02:08 AM, Adrian Crum wrote:
The tests cases pass on my local machine. Could you
Once more, how can be that the file in repository https://svn.apache.org/repos/asf/ofbiz/site/build/index.php is not the same than
the one rendered at http://ci.apache.org/projects/ofbiz/snapshots/ ?
Should I open an infra Jira?
The file in repository is
Copyright 2001-2008 The Apache Software
yeah, it could be something unrelated to Adrian's commit.
Adrian let me know if you find something or if you want me to have a look as
well.
Jacopo
On May 12, 2012, at 9:20 AM, Adam Heath wrote:
Hold off. On trunk, I get issues, but if I reverse the below patch, it
doesn't solve the
I believe the check-errors fix revealed a test failure that was being
hidden before the fix.
-Adrian
On 5/12/2012 8:24 AM, Jacopo Cappellato wrote:
yeah, it could be something unrelated to Adrian's commit.
Adrian let me know if you find something or if you want me to have a look as
well.
Also the snapshots page show a link snapshots which is not in the main page.
Found this at http://svn.apache.org/viewvc?view=revisionrevision=1293792
+!--
+jacopoc: publishing a link to download tarballs that are not official release
may not be allowed by ASF: snapshots are fine but
should be
OK this has been added by ruppert at
http://svn.apache.org/viewvc?view=revisionrevision=889055
Maybe it's now handled by the infra team, hence no answers here. I will contact
them, forget it ;o)
Jacques
From: Jacques Le Roux jacques.le.r...@les7arts.com
Also the snapshots page show a link
Thank you Jacopo solving this problem.
Regards,
Hans
On 05/12/2012 01:09 PM, Jacopo Cappellato (JIRA) wrote:
[
https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273854#comment-13273854
]
Jacopo
[
https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273891#comment-13273891
]
Hans Bakker commented on OFBIZ-4856:
Thank you Jacopo solving this problem.
Regards,
Thanks; committed in rev. 1337484
Jacopo
On May 12, 2012, at 8:54 AM, Adrian Crum wrote:
That's fine.
+1
-Adrian
On 5/11/2012 1:56 PM, Jacopo Cappellato wrote:
Adrian, can I proceed with the proposed change then?
Thanks,
Jacopo
On Apr 24, 2012, at 2:36 PM, Adrian Crum wrote:
On May 10, 2012, at 6:23 PM, Adam Heath wrote:
On 05/10/2012 11:16 AM, Adrian Crum wrote:
The scripts are helpful if you have a Subversion client that runs from
the command line. Some of us use a graphical Subversion client - like
Tortoise, or the Eclipse plugin.
Which brings up another
+1
Though I'd like to keep revert.bat, it's easier to change path (and not forget) with new release than have to search in build.xml,
not a big deal though...
I like the idea of having ofbiz instead of ant to avoid confusion
Jacques
From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com
Complete if you have some information
https://issues.apache.org/jira/browse/INFRA-4785
Jacques
From: Jacques Le Roux jacques.le.r...@les7arts.com
OK this has been added by ruppert at
http://svn.apache.org/viewvc?view=revisionrevision=889055
Maybe it's now handled by the infra team, hence no
On 12/05/2012, at 10:34 PM, jler...@apache.org wrote:
Author: jleroux
Date: Sat May 12 10:34:00 2012
New Revision: 1337502
URL: http://svn.apache.org/viewvc?rev=1337502view=rev
Log:
Noted this in trunk demo log
2012-05-04 23:43:12,687 (Finalizer) [ SQLProcessor.java:836:ERROR]
Okay, rev 1337518 gets the tests to pass, but it isn't a fix - it merely
masks the real problem. I made the commit so others can continue with
their work, and I will continue working on the real problem.
Without going into too much detail, here is a summary of the problem:
1. Previously,
Right, I also removed a superfluous eli null check, already checked at the
beginning of the block
Jacques
From: Scott Gray scott.g...@hotwaxmedia.com
On 12/05/2012, at 10:34 PM, jler...@apache.org wrote:
Author: jleroux
Date: Sat May 12 10:34:00 2012
New Revision: 1337502
URL:
[
https://issues.apache.org/jira/browse/OFBIZ-4802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13274027#comment-13274027
]
Tom Burns commented on OFBIZ-4802:
--
Pierre,
My apologies for pointing the finger at you.
Tom Burns created OFBIZ-4875:
Summary: Problem Display Behavior Using Response type=view-last
Key: OFBIZ-4875
URL: https://issues.apache.org/jira/browse/OFBIZ-4875
Project: OFBiz
Issue Type: Bug
On 05/12/2012 07:17 AM, Adrian Crum wrote:
Okay, rev 1337518 gets the tests to pass, but it isn't a fix - it merely
masks the real problem. I made the commit so others can continue with
their work, and I will continue working on the real problem.
Without going into too much detail, here is a
On 05/12/2012 04:01 AM, Jacopo Cappellato wrote:
On May 10, 2012, at 6:23 PM, Adam Heath wrote:
On 05/10/2012 11:16 AM, Adrian Crum wrote:
The scripts are helpful if you have a Subversion client that runs from
the command line. Some of us use a graphical Subversion client - like
Tortoise, or
On 05/12/2012 05:15 AM, Jacques Le Roux wrote:
+1
Though I'd like to keep revert.bat, it's easier to change path (and not
forget) with new release than have to search in build.xml, not a big
deal though...
tools/ant-revert.xml:
./ant revert
./ant -f tools/ant-revert.xml revert
both commands
On 5/12/2012 9:12 PM, Adam Heath wrote:
On 05/12/2012 07:17 AM, Adrian Crum wrote:
Okay, rev 1337518 gets the tests to pass, but it isn't a fix - it merely
masks the real problem. I made the commit so others can continue with
their work, and I will continue working on the real problem.
Without
I just meant it's easier to edit revert.bat than to seek for it in the build.xml when you have to update the path for a new release.
Forget it, sometimes I'm too lazy :o)
Jacques
From: Adam Heath doo...@brainfood.com
On 05/12/2012 05:15 AM, Jacques Le Roux wrote:
+1
Though I'd like to keep
From: Adam Heath doo...@brainfood.com
On 05/12/2012 04:01 AM, Jacopo Cappellato wrote:
On May 10, 2012, at 6:23 PM, Adam Heath wrote:
On 05/10/2012 11:16 AM, Adrian Crum wrote:
The scripts are helpful if you have a Subversion client that runs from
the command line. Some of us use a
1st: well spotted!
This was not only in examples but in all framework components (example,
examplext, webtools). I was just a matter of moving the line
set field=layoutSettings.suppressTab value=ofbizsetup/!-- diseable ofbiz
setup by default --
from ApplicationDecorator to GlobalDecorator
On 05/12/2012 03:36 PM, Jacques Le Roux wrote:
I just meant it's easier to edit revert.bat than to seek for it in the
build.xml when you have to update the path for a new release. Forget it,
sometimes I'm too lazy :o)
I mean the definition for the ant revert command should be in a separate
On 05/12/2012 03:39 PM, Jacques Le Roux wrote:
From: Adam Heath doo...@brainfood.com
On 05/12/2012 04:01 AM, Jacopo Cappellato wrote:
On May 10, 2012, at 6:23 PM, Adam Heath wrote:
On 05/10/2012 11:16 AM, Adrian Crum wrote:
The scripts are helpful if you have a Subversion client that runs
Is there a reason why some actions of GlobalDecorator are not in GlobalActions?
Jacques
From: Adam Heath doo...@brainfood.com
On 05/12/2012 03:36 PM, Jacques Le Roux wrote:
I just meant it's easier to edit revert.bat than to seek for it in the
build.xml when you have to update the path for a new release. Forget it,
sometimes I'm too lazy :o)
I mean the definition for the ant
From: Adam Heath doo...@brainfood.com
On 05/12/2012 03:39 PM, Jacques Le Roux wrote:
From: Adam Heath doo...@brainfood.com
On 05/12/2012 04:01 AM, Jacopo Cappellato wrote:
On May 10, 2012, at 6:23 PM, Adam Heath wrote:
On 05/10/2012 11:16 AM, Adrian Crum wrote:
The scripts are helpful if
On 05/12/2012 04:04 PM, Jacques Le Roux wrote:
From: Adam Heath doo...@brainfood.com
On 05/12/2012 03:36 PM, Jacques Le Roux wrote:
I just meant it's easier to edit revert.bat than to seek for it in the
build.xml when you have to update the path for a new release. Forget it,
sometimes I'm too
From: Adam Heath doo...@brainfood.com
On 05/12/2012 04:04 PM, Jacques Le Roux wrote:
From: Adam Heath doo...@brainfood.com
On 05/12/2012 03:36 PM, Jacques Le Roux wrote:
I just meant it's easier to edit revert.bat than to seek for it in the
build.xml when you have to update the path for a new
I'm sure you are both afraid of that, but in case you freithened people about DCL I wanted to say that since jdk 1.5 way of handling
volatile it's now possible to safely use this pattern with Java
http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html#ThreadLocal
(see Fixing
On 05/12/2012 04:28 PM, Jacques Le Roux wrote:
I'm sure you are both afraid of that, but in case you freithened people
about DCL I wanted to say that since jdk 1.5 way of handling volatile
it's now possible to safely use this pattern with Java
46 matches
Mail list logo
