[jira] [Closed] (OFBIZ-5182) LoginServices.userLogin add info to fail message

2013-04-22 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-5182. -- Resolution: Fixed Assignee: Jacques Le Roux Thanks Carsten, Your patch is in trunk at

Re: Important: Entity list cache and GenericValue discussion

2013-04-22 Thread Jacopo Cappellato
It seems actually to be an issue rather than a feature (I can't think of a use case where this behavior would be useful); I have created a few test cases (similar to the one you have provided in the other thread) that further analyze your discovery but they don't add much to what you found

Re: Important: Entity list cache and GenericValue discussion

2013-04-22 Thread Adrian Crum
Thanks Jacopo. I haven't looked into the entity cache implementation thoroughly, but I was under the impression that it can be configured to be distributed. I have the fix working on my local copy. As you can see, I have made some related changes already and will be making some more, but I

Re: Important: Entity list cache and GenericValue discussion

2013-04-22 Thread Jacopo Cappellato
On Apr 22, 2013, at 10:45 AM, Adrian Crum adrian.c...@sandglass-software.com wrote: Thanks Jacopo. I haven't looked into the entity cache implementation thoroughly, but I was under the impression that it can be configured to be distributed. I don't remember the details but the issue you

Re: Important: Entity list cache and GenericValue discussion

2013-04-22 Thread Jacques Le Roux
From: Adrian Crum adrian.c...@sandglass-software.com Thanks Jacopo. I haven't looked into the entity cache implementation thoroughly, but I was under the impression that it can be configured to be distributed. Yes it is

Re: Important: Entity list cache and GenericValue discussion

2013-04-22 Thread Adrian Crum
The fix will be pretty simple - when a GenericValue is stored or removed, any related entity condition caches (the ones the GenericValue is a member of) will be cleared. So I'm assuming clearing a cache that is distributed will clear all clustered caches. If you have access to a test cluster,

Re: Important: Entity list cache and GenericValue discussion

2013-04-22 Thread Jacques Le Roux
I guess indeed normally an event will be fired and the cache clearing distributed I'd ask for a bit of more time for the rest of us to have a deeper look but from your explanation below this seems safe to me. It would be good if we could measure, or at least have an idea about the order of

Re: Important: Entity list cache and GenericValue discussion

2013-04-22 Thread Jacques Le Roux
BTW the event is fired by EntityCacheServices.clearCacheLine() I see that delegator.clearCacheLineByCondition(entityName, condition, distribute); is called there, so yes should be safe Jacques Jacques Le Roux wrote: I guess indeed normally an event will be fired and the cache clearing

Re: Important: Entity list cache and GenericValue discussion

2013-04-22 Thread Jacques Le Roux
Mmm sorry, rather in this case fired by EntityCacheServices.distributedClearCacheLineByCondition() Below is a sub case Jacques Jacques Le Roux wrote: BTW the event is fired by EntityCacheServices.clearCacheLine() I see that delegator.clearCacheLineByCondition(entityName, condition,

Re: Important: Entity list cache and GenericValue discussion

2013-04-22 Thread Adrian Crum
The performance hit I envisioned was the overhead of notifying listeners during store or remove. But I think I solved that with the custom Observable class and some other optimizations I have in mind. -Adrian On 4/22/2013 11:02 AM, Jacques Le Roux wrote: I guess indeed normally an event will

[jira] [Resolved] (OFBIZ-5181) missing de UI Labels in Accounting

2013-04-22 Thread Christian Geisert (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Geisert resolved OFBIZ-5181. -- Resolution: Fixed Fix Version/s: Release Branch 12.04 Patch committed, thanks

Re: Important: Entity list cache and GenericValue discussion

2013-04-22 Thread Adrian Crum
I went ahead and committed the immutable GenericEntity change. I didn't want to wait or come up with a transitional GenericValue. After looking through the code, I determined that leaving cached instances mutable could cause data corruption. I still plan to commit the stale cache fix this

buildbot failure in ASF Buildbot on ofbiz-trunk

2013-04-22 Thread buildbot
The Buildbot has detected a new failure on builder ofbiz-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-trunk/builds/3702 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: portunus_ubuntu Build Reason: scheduler Build Source