[jira] [Commented] (OFBIZ-5607) Include Thailand Province Geo data

2014-04-01 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956195#comment-13956195 ] Jacques Le Roux commented on OFBIZ-5607: Finally I did it myself (not a big deal,

Birthday's Change

2014-04-01 Thread Rupert Howell
There's a definite problem with the way the dates are displayed in OFBiz. If you enter a birthday with your local timezone set to UTC, then change the timezone to -12, the birthday changes to the previous day. This is clearly wrong and is really apparent if you have your Server Timezone set to GB.

[jira] [Closed] (OFBIZ-5607) Include Thailand Province Geo data

2014-04-01 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-5607. -- Resolution: Implemented Fix Version/s: Release Branch 13.07 Release

Re: OFBiz Demo site being down

2014-04-01 Thread Pierre Smits
Hi all, Again 10 days have passed and our website is still down. Should we not escalate? Regards, Pierre Smits *ORRTIZ.COM http://www.orrtiz.com* Services Solutions for Cloud- Based Manufacturing, Professional Services and Retail Trade http://www.orrtiz.com On Fri, Mar 21, 2014 at 7:25 AM,

Re: Birthday's Change

2014-04-01 Thread Pierre Smits
Rupert, A date should not be stored as a date-time, but as a date. This appears throughout the entire spectrum of apps where dates are intended. Over 600 entity fields are designated as date-time, 18 entity fields are designated as date and 8 as time. Regards, Pierre Smits *ORRTIZ.COM

Re: Birthday's Change

2014-04-01 Thread Pierre Smits
Hmm. Digging a bit deeper I see that birthday is persisted as a date. So that shouldn't be creating issues. Pierre Smits *ORRTIZ.COM http://www.orrtiz.com* Services Solutions for Cloud- Based Manufacturing, Professional Services and Retail Trade http://www.orrtiz.com On Tue, Apr 1, 2014 at

Re: Birthday's Change

2014-04-01 Thread Rupert Howell
Hi Pierre, Yes I am aware of that. The 18 date fields are being stored correctly. They are however being displayed incorrectly because they are having the Timezone applied on line 977 UtilDateTime. If you carry out the test I described in the previous email. Birth Date on the person entity is the

Re: Birthday's Change

2014-04-01 Thread Rupert Howell
Correct date I should say - not time On 1 April 2014 09:10, Rupert Howell ruperthow...@provolve.com wrote: Hi Pierre, Yes I am aware of that. The 18 date fields are being stored correctly. They are however being displayed incorrectly because they are having the Timezone applied on line

buildbot failure in ASF Buildbot on ofbiz-branch11

2014-04-01 Thread buildbot
The Buildbot has detected a new failure on builder ofbiz-branch11 while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-branch11/builds/204 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: portunus_ubuntu Build Reason: scheduler Build

Re: Birthday's Change

2014-04-01 Thread Pierre Smits
Rupert, You are right when you don't want to be to specific. But if you are specific and precise then a birthday needs to have a time zone associated. Remember it is not the birthday itself that shifts, but your viewpoint of it when changing locations (meaning time zones). Regarding. Pierre

Re: OFBiz Demo site being down

2014-04-01 Thread Jacques Le Roux
I'm not too eager, because I see an opportunity to update the demo environment. Actually not that much changes, but since there will be some work needed, depending on how the infra team will be kind, I'd prefer to directly have stable = R13.07 old= R12.04 Jacques Le 01/04/2014 09:51, Pierre

Re: Birthday's Change

2014-04-01 Thread Pierre Smits
Rupert, That happens when the user shifts time zones while updating date fields. I guess that is why in legal documents Date of Birth and Date of Death always come a registration of a Place of Birth and Place of Death so that the correct time zone can be associated. Regards, Pierre Smits

Re: Birthday's Change

2014-04-01 Thread Pierre Smits
See section 'Time zones and birthdays' in http://en.wikipedia.org/wiki/Birthday Pierre Smits *ORRTIZ.COM http://www.orrtiz.com* Services Solutions for Cloud- Based Manufacturing, Professional Services and Retail Trade http://www.orrtiz.com On Tue, Apr 1, 2014 at 10:21 AM, Pierre Smits

Re: Birthday's Change

2014-04-01 Thread adrian . crum
The date is stored as a java.sql.Timestamp - which is referenced to UTC. The UTC-referenced date is converted to the user's time zone during display. This is the intended behavior. -Adrian Quoting Rupert Howell ruperthow...@provolve.com: There's a definite problem with the way the dates

Re: Birthday's Change

2014-04-01 Thread Rupert Howell
My birth date is my birth date wherever I am in the world - it is not relative. My passport doesn't change as I travel through Timezones. Yet if I view my passport information is OFBiz it will change, Dates need to be viewed as dates and be totally independent of timezones. I cannot think of a

Re: OFBiz Demo site being down

2014-04-01 Thread Pierre Smits
Jacques, r13.07 hasn't been released to the general public yet. So it should have stable=12.04 and old=11.04. Are we sure that we want to wait with fixing this until r13.x has been released? Regards, Pierre Smits *ORRTIZ.COM http://www.orrtiz.com* Services Solutions for Cloud- Based

Re: Birthday's Change

2014-04-01 Thread Rupert Howell
This behavior is clearly wrong. A 1 hour change in a timezone and people's birthdays are wrong! Postgres is storing the date fields as date fields. It is OFBiz that is applying the LOCAL timezone information to the date on line 977 of UtilDateTime. On 1 April 2014 09:27,

Re: Birthday's Change

2014-04-01 Thread gareth_carter
Hi all Me and Rupert have been looking at this as we've had this issue for a while with specifically the Birth Date field - but any date only fields will have this issue. The birth date field is date only in ofbiz and in the database java.sql.Date is returned from jdbc drivers when the field

Re: Birthday's Change

2014-04-01 Thread Rupert Howell
Adrian - this is definitely incorrect, the Birth Date field is stored as a date field in Postgres so when OFbiz is converting the date to apply the user's timezone it is taking the time as 00:00: hence drastic changes over a 1 hour time change. I could accept what you are saying if the

Re: OFBiz Demo site being down

2014-04-01 Thread Jacques Le Roux
I don't want to spend time (read have free time) changing from stable=R11.04 to R12.04. If any volunteer wants when the demos will be back, then why not (Christian prepared R12.04) Anyway it depends on infra team goodwill... and free time... I'd not escalate personally. In this case the person

Re: Birthday's Change

2014-04-01 Thread adrian . crum
Thank you Gareth - that is helpful. I can reproduce the date change using UTC - so there must be another problem here (since UTC has no offset). -Adrian Quoting gareth_car...@stannah.co.uk: Hi all Me and Rupert have been looking at this as we've had this issue for a while with

Re: Birthday's Change

2014-04-01 Thread Rupert Howell
Thanks Gareth that was put much more eloquently. Adrian / Pierre are you happy there's an issue here and I'll raise a Jira and submit a patch. Can we discuss if there's a need for for a new date-fixed field type that never has the timezone applied to the date format on display or whether we

Re: Birthday's Change

2014-04-01 Thread Pierre Smits
Rupert, Please create the JIRA issue. Irrespective of what the users timezone is, the date must always be stored in accordance with the timezone setting of the internal company used (with a failover (if not set) to the default of the tenant, which - if not set - fails over to the default of the

Re: Birthday's Change

2014-04-01 Thread adrian . crum
Please do not provide a patch. The problem is not caused by applying a time zone to a date - it is caused by something else. All of this was working correctly until now, so there must be a problem somewhere else. -Adrian Quoting Rupert Howell ruperthow...@provolve.com: Thanks Gareth that

[jira] [Created] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2014-04-01 Thread Rupert Howell (JIRA)
Rupert Howell created OFBIZ-5608: Summary: Dates Displaying Incorrectly With Negative Offest Timezones. Key: OFBIZ-5608 URL: https://issues.apache.org/jira/browse/OFBIZ-5608 Project: OFBiz

Re: Birthday's Change

2014-04-01 Thread gareth_carter
Piere - SQL dates are stored without timezone information and dates are returned exactly the same with different default database timezones - unless you specifically convert the date field to a different timezone in SQL Such as Default timezone on our database set timezone to 'GB'; select

Re: Birthday's Change

2014-04-01 Thread adrian . crum
How a DB manufacturer persists a date field is irrelevant. The issue here is how Java handles the date type in the JDBC driver and supporting code. I repeat: I can reproduce the problem using a time zone with ZERO OFFSET, so this is not a problem caused by applying a time zone to a date.

Re: Birthday's Change

2014-04-01 Thread Jacques Le Roux
Rupert, Gareth, Can we qualify recently? I guess R13.07 works? Then by dichotomy it should not be too hard to find a range of concerned commits and then the culprit. The result of these research would fit in the Jira Thanks Jacques Le 01/04/2014 12:17, adrian.c...@sandglass-software.com a

Re: Birthday's Change

2014-04-01 Thread gareth_carter
Adrian - Yes how the db stores any data is irrelevant but the important bit is how the date field is treated and returned to Java, I am merely stating the fact that standard SQL date fields have no time/timezone element and are unaffected by timezone changes in the db. Time and timestamps can

Re: Birthday's Change

2014-04-01 Thread adrian . crum
Jacques, I am analyzing the problem. The discussion so far reflects a lack of understanding of how Java's date/time handling works, so it would be best if I take care of this myself. -Adrian Quoting Jacques Le Roux jacques.le.r...@les7arts.com: Rupert, Gareth, Can we qualify recently?

Re: Birthday's Change

2014-04-01 Thread Pierre Smits
Gareth, True. But if there is a misalignment of the db timezone and timezones applied/determined in OFBiz (general - from properties, tenant setting, organisation default or user specific) then overviews (displaying aspects related as previous month/week, yesterday, today, tomorrow and next

Re: Birthday's Change

2014-04-01 Thread Rupert Howell
Jacques. The problem I am describing exists in 13.07. I can check if it exists in 12.04 but I strongly suspect it will. Adrian. Our discussion so far does not indicate a lack of understanding - we have spent a fair amount of time looking into this and investigating it. Your last comment was

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2014-04-01 Thread Rupert Howell (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956447#comment-13956447 ] Rupert Howell commented on OFBIZ-5608: -- This issue exists in both the trunk and

Re: Birthday's Change

2014-04-01 Thread Jacques Le Roux
Great, thanks Adrian Jacques Le 01/04/2014 13:39, adrian.c...@sandglass-software.com a écrit : Jacques, I am analyzing the problem. The discussion so far reflects a lack of understanding of how Java's date/time handling works, so it would be best if I take care of this myself. -Adrian

Re: Birthday's Change

2014-04-01 Thread Jacques Le Roux
Thanks Rupert, So this contradicts Adrian's assertion so far Let's see... Jacques Le 01/04/2014 14:01, Rupert Howell a écrit : Jacques. The problem I am describing exists in 13.07. I can check if it exists in 12.04 but I strongly suspect it will. Adrian. Our discussion so far does not

Minilang call-language

2014-04-01 Thread Jacques Le Roux
Hi, I was wondering, we have call-bsh but not call-groovy. Should we not add it? Jacques

Re: Minilang call-language

2014-04-01 Thread adrian . crum
Use script. https://cwiki.apache.org/confluence/display/OFBADMIN/Mini-language+%28minilang%29+Reference -Adrian Quoting Jacques Le Roux jacques.le.r...@les7arts.com: Hi, I was wondering, we have call-bsh but not call-groovy. Should we not add it? Jacques

[jira] [Created] (OFBIZ-5609) Add Israel geo data OOTB

2014-04-01 Thread Christian Carlow (JIRA)
Christian Carlow created OFBIZ-5609: --- Summary: Add Israel geo data OOTB Key: OFBIZ-5609 URL: https://issues.apache.org/jira/browse/OFBIZ-5609 Project: OFBiz Issue Type: Improvement

[jira] [Updated] (OFBIZ-5609) Add Israel geo data OOTB

2014-04-01 Thread Christian Carlow (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Carlow updated OFBIZ-5609: Attachment: OFBIZ-5609.patch This patch adds the Israel geo data that is missing OOTB. It

Re: Minilang call-language

2014-04-01 Thread Jacques Le Roux
Yes I know that, but sometimes a snippet is easier Jacques Le 01/04/2014 15:42, adrian.c...@sandglass-software.com a écrit : Use script. https://cwiki.apache.org/confluence/display/OFBADMIN/Mini-language+%28minilang%29+Reference -Adrian Quoting Jacques Le Roux jacques.le.r...@les7arts.com:

[jira] [Assigned] (OFBIZ-5609) Add Israel geo data OOTB

2014-04-01 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-5609: -- Assignee: Jacques Le Roux Add Israel geo data OOTB

[jira] [Closed] (OFBIZ-5609) Add Israel geo data OOTB

2014-04-01 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-5609. -- Resolution: Implemented Fix Version/s: Release Branch 13.07 Release

[jira] [Updated] (OFBIZ-5607) Include Thailand Province Geo data

2014-04-01 Thread Christian Carlow (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Carlow updated OFBIZ-5607: Attachment: OFBIZ-5607-3.patch This patch includes the CountryAddressFormat records for my

[jira] [Updated] (OFBIZ-5607) Include Thailand Province Geo data

2014-04-01 Thread Christian Carlow (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Carlow updated OFBIZ-5607: Attachment: OFBIZ-5607-2.patch This patch corrects three Thailand provinces added from the

[jira] [Comment Edited] (OFBIZ-5607) Include Thailand Province Geo data

2014-04-01 Thread Christian Carlow (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956563#comment-13956563 ] Christian Carlow edited comment on OFBIZ-5607 at 4/1/14 2:38 PM:

buildbot success in ASF Buildbot on ofbiz-branch11

2014-04-01 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-branch11 while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-branch11/builds/205 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: portunus_ubuntu Build Reason: scheduler Build

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2014-04-01 Thread Rupert Howell (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956573#comment-13956573 ] Rupert Howell commented on OFBIZ-5608: -- The issue exists in 12.04. Dates Displaying

Re: Birthday's Change

2014-04-01 Thread Rupert Howell
I've added a Jira for this. https://issues.apache.org/jira/browse/OFBIZ-5608 I've replicated it now in trunk, 13.07 and 12.04. Regards, On 1 April 2014 13:21, Jacques Le Roux jacques.le.r...@les7arts.com wrote: Thanks Rupert, So this contradicts Adrian's assertion so far Let's see...

[jira] [Commented] (OFBIZ-5607) Include Thailand Province Geo data

2014-04-01 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956590#comment-13956590 ] Jacques Le Roux commented on OFBIZ-5607: Thanks Christian, Your patches are

[jira] [Comment Edited] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2014-04-01 Thread Rupert Howell (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956653#comment-13956653 ] Rupert Howell edited comment on OFBIZ-5608 at 4/1/14 3:40 PM: --

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2014-04-01 Thread Rupert Howell (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956653#comment-13956653 ] Rupert Howell commented on OFBIZ-5608: -- The timezone that is being used on line 666