Re: svn commit: r1758774 - in /ofbiz/trunk: applications/product/src/main/java/org/apache/ofbiz/shipment/thirdparty/dhl / framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/ special

2016-09-01 Thread Jacques Le Roux
Thanks, reverted at revision: 1758779 Jacques Le 01/09/2016 à 15:57, Jacopo Cappellato a écrit : Hi Jacques, you have committed some unwanted/unrelated changes in this commit. Jacopo On Thu, Sep 1, 2016 at 3:34 PM, wrote: Author: jleroux Date: Thu Sep 1 13:34:17

Re: svn commit: r1758774 - in /ofbiz/trunk: applications/product/src/main/java/org/apache/ofbiz/shipment/thirdparty/dhl/ framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/ specialp

2016-09-01 Thread Jacopo Cappellato
Hi Jacques, you have committed some unwanted/unrelated changes in this commit. Jacopo On Thu, Sep 1, 2016 at 3:34 PM, wrote: > Author: jleroux > Date: Thu Sep 1 13:34:17 2016 > New Revision: 1758774 > > URL: http://svn.apache.org/viewvc?rev=1758774=rev > Log: > A patch

Re: svn commit: r1758700 - in /ofbiz/trunk: applications/accounting/ applications/accounting/lib/ applications/datamodel/ applications/manufacturing/ specialpurpose/assetmaint/ specialpurpose/birt/ sp

2016-09-01 Thread Jacques Le Roux
OK we can also add the ASL2 headers to all our readme files, not a problem with me Jacques Le 01/09/2016 à 12:34, Jacopo Cappellato a écrit : On Thu, Sep 1, 2016 at 11:41 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: ... Wait, I don't want a different license header in readme

Re: svn commit: r1757991 - in /ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manu facturing: bom/ jobshopmgt/ mrp/ techdata/

2016-09-01 Thread Harsh Vijaywargiya
Thanks Jacques, Sounds good. I will take care of this suggestion in coming commits. Thanks & Regards, Harsh On Wednesday 31 August 2016 04:51 PM, Jacques Le Roux wrote: OK I checked, the commented out lines were from pre Apache Era. So indeed it was not an easy decision. For public void

Re: svn commit: r1758700 - in /ofbiz/trunk: applications/accounting/ applications/accounting/lib/ applications/datamodel/ applications/manufacturing/ specialpurpose/assetmaint/ specialpurpose/birt/ sp

2016-09-01 Thread Jacopo Cappellato
On Thu, Sep 1, 2016 at 11:41 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > ... > Wait, I don't want a different license header in readme files (w/ or w/o > suffixes) > I just want things to be consistent. Which resumes to no header at all in > those files, Consistency can be

Re: svn commit: r1758700 - in /ofbiz/trunk: applications/accounting/ applications/accounting/lib/ applications/datamodel/ applications/manufacturing/ specialpurpose/assetmaint/ specialpurpose/birt/ sp

2016-09-01 Thread Jacques Le Roux
Le 01/09/2016 à 11:33, Jacopo Cappellato a écrit : On Thu, Sep 1, 2016 at 10:50 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: So we don't apply a lazy consensus here and we need a vote? Why not follow the advice in this page? My suggestion is to go in one of the following two

Re: svn commit: r1758700 - in /ofbiz/trunk: applications/accounting/ applications/accounting/lib/ applications/datamodel/ applications/manufacturing/ specialpurpose/assetmaint/ specialpurpose/birt/ sp

2016-09-01 Thread Jacopo Cappellato
On Thu, Sep 1, 2016 at 10:50 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > So we don't apply a lazy consensus here and we need a vote? Why not follow > the advice in this page? > My suggestion is to go in one of the following two directions: 1) apply the standard license header to

A

2016-09-01 Thread Jacques Le Roux
So we don't apply a lazy consensus here and we need a vote? Why not follow the advice in this page? Note that I have no strong opinion on putting the ASL2 header or not, I want things to be consistent Jacques Le 01/09/2016 à 10:48, Jacopo Cappellato a écrit : I still don't see where the

Re: svn commit: r1758700 - in /ofbiz/trunk: applications/accounting/ applications/accounting/lib/ applications/datamodel/ applications/manufacturing/ specialpurpose/assetmaint/ specialpurpose/birt/ sp

2016-09-01 Thread Jacopo Cappellato
I still don't see where the consensus was reached: discussions in Jira are not the same as discussion on the dev list (which is mentioned by Jacques in "as per consensus in dev mail thread"). Also the conversation between Jacques and Pierre in Jira is resolved with an unclear resolution to me. In

Re: svn commit: r1758700 - in /ofbiz/trunk: applications/accounting/ applications/accounting/lib/ applications/datamodel/ applications/manufacturing/ specialpurpose/assetmaint/ specialpurpose/birt/ sp

2016-09-01 Thread Pierre Smits
Actually I asked first whether there was consensus. And that was confirmed. Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutions & services OFBiz Extensions Marketplace http://oem.ofbizci.net/oci-2/ On Thu, Sep 1, 2016 at 9:58 AM, Jacques Le Roux <

Re: svn commit: r1758700 - in /ofbiz/trunk: applications/accounting/ applications/accounting/lib/ applications/datamodel/ applications/manufacturing/ specialpurpose/assetmaint/ specialpurpose/birt/ sp

2016-09-01 Thread Jacques Le Roux
Actually Pierre just followed http://www.apache.org/legal/src-headers.html#faq-exceptions <> That seems OK with me Jacques Le 01/09/2016 à 08:36, Jacopo Cappellato a écrit : On Thu, Sep 1, 2016 at 6:53 AM, wrote: ... Legal statements are not required in readme files,

Re: ofbiz entity query problem?

2016-09-01 Thread Hans Bakker
looks like it is caused by the underlying viewforget it for now. On 01/09/16 13:18, Hans Bakker wrote: Sorry it is a bit more complicated: andExprs = []; andExprs.add(EntityCondition.makeCondition("marketingCampaignId", EntityOperator.EQUALS, parameters.marketingCampaignId));

Re: svn commit: r1758700 - in /ofbiz/trunk: applications/accounting/ applications/accounting/lib/ applications/datamodel/ applications/manufacturing/ specialpurpose/assetmaint/ specialpurpose/birt/ sp

2016-09-01 Thread Jacopo Cappellato
On Thu, Sep 1, 2016 at 6:53 AM, wrote: > ... > Legal statements are not required in readme files, as per consensus in dev > mail thread with title 'Shorter ASL2 header in short files'. The mail > thread started here: http://ofbiz.markmail.org/message/pc5bzrsiupef7xjt > >

Re: ofbiz entity query problem?

2016-09-01 Thread Hans Bakker
Sorry it is a bit more complicated: andExprs = []; andExprs.add(EntityCondition.makeCondition("marketingCampaignId", EntityOperator.EQUALS, parameters.marketingCampaignId)); andExprs.add(EntityCondition.makeCondition("actionIsActive", EntityOperator.NOT_EQUAL, "N")); orExprs = [];

ofbiz entity query problem?

2016-09-01 Thread Hans Bakker
if i write the groovy statement: orExprs = []; orExprs.add(EntityCondition.makeCondition("workEffortId", EntityOperator.NOT_EQUAL, null)); i get the error message: java.lang.IllegalArgumentException: Operator must be EQUALS or NOT_EQUAL when right/rhs argument is NULL ) if i change the