Re: Unused attributes of ShoppingCart and ShoppingCartItem

2017-05-08 Thread Arun Patidar
+1 Suraj, If value of 'attributes' is not getting populated in DB then it should be replaced. -- Thanks & Regards --- Arun Patidar Manager, Enterprise Software Development HotWax Systems Pvt Ltd.www.hotwaxsystems.com On Tue, May 9, 2017 at 10:31 AM, Suraj Khurana < suraj.khur...@hotwaxsystems

Unused attributes of ShoppingCart and ShoppingCartItem

2017-05-08 Thread Suraj Khurana
Hi Devs, I am curious about some protected data members of ShoppingCartItem and ShoppingCart class. ShoppingCartItem contains: *private Map orderItemAttributes = null;private Map attributes = null;* While ShoppingCart have: *private Map orderAttributes = FastMap.newInstance();* *private Map at

Re: Loading standard web application

2017-05-08 Thread Taher Alkhateeb
Jacopo summarized this very nicely. So yeah I would say the code quality of code in this feature is good and can go to the code base, but let's stay open to the idea of refactoring which may affect it in the future. I am already doing some low level work in that area BTW Cheers, Taher Alkhateeb

Re: Loading standard web application

2017-05-08 Thread James Yong
Hi Jacopo, Thank you for looking into the matter. Was just looking at loading standard web application due to one use-case, but the issue of deploying OFBiz WAR was bought up. Just to reiterate that allowing standard web application now should not impede efforts towards building OFBiz WAR late

Re: Loading standard web application

2017-05-08 Thread Jacopo Cappellato
Hi James, thanks for your design proposal and implementation: I have reviewed your patch in Jira and it looks good to me. As mentioned by Taher, in the future we may try to move away from the OFBiz container driven startup process in order to make OFBiz more easily deployable in an application ser

Re: [PROPOSAL] deprecate mini lang

2017-05-08 Thread James Yong
Hi Michael, Okay, I didn't look at that page. Yes, it should be sufficient. Thanks. Sincerely, James On 2017-05-08 16:54 (+0800), Michael Brohl wrote: > Hi James, > > thanks for your suggestion. That's exactly what I did in [1], which pops > up a warning. > > Don't you think it is sufficien

Re: [PROPOSAL] deprecate mini lang

2017-05-08 Thread Michael Brohl
Hi James, thanks for your suggestion. That's exactly what I did in [1], which pops up a warning. Don't you think it is sufficient? Best regards, Michael [1] https://cwiki.apache.org/confluence/display/OFBADMIN/Mini+Language+-+minilang+-+simple-method+-+Reference Am 08.05.17 um 05:34 sch

Re: Broken pipe (write failed) [BUG]

2017-05-08 Thread Jacques Le Roux
Yep: http://ofbiz.markmail.org/search/?q=ClientAbortException Jacques Le 07/05/2017 à 22:43, Nicola Mazzoni a écrit : Hello everyone, I'd like to ask you about an issue regarding ​ecommerce app​ . We are monitoring our OFBiz ecommerce application with NewRelic and we noticed that there are *l