Re: OFBiz Version Info

2017-11-28 Thread Michael Brohl
-1 for storing the version in .properties. +1 for using a VERSION or RELEASE file in the root folder to store this information. It's easily accessible, you cannot overlook it and the content can be read by any functionality. It can also be automatically set by (custom) builds to be

Re: Fwd: ISO Notifications

2017-11-28 Thread Jacques Le Roux
Hi devs, For the moment, using my "Online Browsing Platform (OBP)" personal information, I have subscribed this ML, to ISO notifications and created https://issues.apache.org/jira/browse/OFBIZ-10028 I think we should rather subscribe the dev ML on behalf of the OFBiz PMC What do you think?

Re: OFBiz Version Info

2017-11-28 Thread Taher Alkhateeb
Hi James, The purpose of Config.java is to configure critical server settings at startup such as log location, admin settings, etc. These settings could be also used in test.properties and load-data.properties and all such properties get a default value if not set. OFBiz version by definition is

Re: Permission overrides auth parameter of service

2017-11-28 Thread Jacques Le Roux
Le 17/11/2017 à 09:20, Jacques Le Roux a écrit : Le 03/11/2017 à 05:35, Suraj Khurana a écrit : Hello team, I noticed that in any service definition if auth is set to false and permission service is also the service definition, it overrides the auth parameter to true by itself. For quick

Re: OFBiz Version Info

2017-11-28 Thread James Yong
Hi Taher, The reason of putting released version (e.g. 16.11.03) in start.properties file is because the start program is already reading that file and that info will be included in the startup message. Printing released version to the console is in line with what other applications, like

Re: Planning for the creation of the new 17.xx branch(es)

2017-11-28 Thread Taher Alkhateeb
I think Rishi makes a good point. OFBIZ-9501 is a big task but it would be nice to create the release after the majority of data is moved. Rishi is already progressing in this task I think it might be worth waiting a little bit to have a clean datamodel component. On Tue, Nov 28, 2017 at 7:20 PM,

Re: OFBiz Version Info

2017-11-28 Thread Taher Alkhateeb
Hi James, I'm not sure of the purpose of doing all of that? start.properties is a file to feed into Config.java which in turn configures the startup settings of OFBiz. The version has nothing with the startup code so it seems like an improper place to put the property and maybe it might confuse

Re: Planning for the creation of the new 17.xx branch(es)

2017-11-28 Thread Rishi Solanki
Jacopo, Thanks for heads-up, I have OFBIZ-9501 with me, and I think it should be part of new release. As the data movement will impact on ease of debugging and maintenance. I'm planning to move most seed and seed-initial data by this weekend. This should not impact the release date, because If

Re: Planning for the creation of the new 17.xx branch(es)

2017-11-28 Thread Michael Brohl
Hi Jacopo, I am planning to do a bunch of FindBugs/refactoring commits in the coming days/weeks, hopefully all of the currently open issues. It would be great if we can move the release to December. @all: any help on the FindBugs/refactoring issues by fellow committers are greatly

Re: Planning for the creation of the new 17.xx branch(es)

2017-11-28 Thread Jacques Le Roux
Hi Jacopo, If nobody minds I'd prefer to wait a month more (or a bit less) I have several actions pending and my mind is in a mess because of that. So 15+ days more would help Thanks Jacques Le 28/11/2017 à 16:42, Jacopo Cappellato a écrit : It's the end of November and we are close to

Re: Planning for the creation of the new 17.xx branch(es)

2017-11-28 Thread Jacopo Cappellato
It's the end of November and we are close to the deadline for the creation of the 17.11 branches: how do we feel about it? Let me know if you want me to proceed, otherwise we will create the branches in December and they will be named 17.12 Regards, Jacopo On Thu, Oct 12, 2017 at 6:09 PM,

Re: Translating simple-method codes to Groovy

2017-11-28 Thread Jacopo Cappellato
Hi Dennis, in general the best way to go is to wrap up the Minilang method into a service definition and then convert simple-method-call into service-call. For this specific case, genericBasePermissionCheck, you will find that the method has been already wrapped into the homonymous service so you

Re: OFBiz Version Info

2017-11-28 Thread James Yong
Hi all, If there is no further discusson, I will create a JIRA issue later to 1) add an ofbiz.version key in start.properties file; and 2) have the ofbiz.version key value included in the startup message. Regards, James Yong On 2017-11-28 01:35, Jacques Le Roux

Translating simple-method codes to Groovy

2017-11-28 Thread Dennis Balkir
Hello Devs, while converting some of the Mini-Lang files to Groovy I have encountered a problem. I started converting the file CatalogServices.xml to Groovy, as I noticed, that one of its methods made a simple-method-call for the method „genericBasePermissionCheck“ from

Re: svn propchange: r1816537 - svn:log

2017-11-28 Thread Jacques Le Roux
Thanks Deepak, I also reopened https://issues.apache.org/jira/browse/OFBIZ-9264 in case it helps you. Anyway there are other related issues with OFBIZ-9264, so other reasons to reopen A pity Francis did not answer so far :-( Jacques Le 28/11/2017 à 11:53, jler...@apache.org a écrit :

Re: svn propchange: r1816537 - svn:log

2017-11-28 Thread Deepak Dixit
Thanks Jacques. Thanks & Regards -- Deepak Dixit www.hotwaxsystems.com www.hotwax.co On Tue, Nov 28, 2017 at 4:23 PM, wrote: > Author: jleroux > Revision: 1816537 > Modified property: svn:log > > Modified: svn:log at Tue Nov 28 10:53:11 2017 >