Re: Tomcat SSO

2017-12-12 Thread James Yong
Hi Kwadwo, OFBiz supports a few external single sign-on mechanism like CAS SSO, LinkedIn sign-on etc. If you uses KeyCloak, you are welcome to contribute code or article on KeyCloak support for OFBiz. Regards, James Yong On 2017-12-11 05:38, Kwadwo Boahen wrote: >

Re: Please add me as an Apache OFBiz Contributor

2017-12-12 Thread Michael Brohl
Hi Dennis, we have received your ICLA and I have given you permission to edit our wiki. Welcome aboard and happy contributing! Thanks, Michael Am 08.12.17 um 16:04 schrieb Dennis Balkir: Hi Devs, I just recognised, that another Email, which I used as an draft for my own mail I just send,

Re: Removal of trailing white spaces, was: Re: [jira] [Commented] (OFBIZ-9777) [FB] Package org.apache.ofbiz.product.imagemanagement

2017-12-12 Thread Michael Brohl
Am 12.12.17 um 14:38 schrieb Jacques Le Roux: I catch up to Jacques's comment, I prefer to separate the formating to the functional even if I was do the same in the past and I will do it by oversight in the future :) This was what David taught us and I found it reasonable Yes, and that's

Re: Removal of trailing white spaces, was: Re: [jira] [Commented] (OFBIZ-9777) [FB] Package org.apache.ofbiz.product.imagemanagement

2017-12-12 Thread Jacques Le Roux
Le 12/12/2017 à 14:13, Nicolas Malin a écrit : Hello Le 12/12/2017 à 13:29, Michael Brohl a écrit : [...] I have a very simple but effective workflow for this, you might find it helpful also: 1. copy the link to the patch file in the Jira issue 2. right click on your OFBiz project in Eclipse

Re: Removal of trailing white spaces, was: Re: [jira] [Commented] (OFBIZ-9777) [FB] Package org.apache.ofbiz.product.imagemanagement

2017-12-12 Thread Jacques Le Roux
BTW Michael, Don't get me wrong, I want to again compliment you and your team for the excellent work done recently :) Jacques Le 12/12/2017 à 14:28, Jacques Le Roux a écrit : Le 12/12/2017 à 13:29, Michael Brohl a écrit : Hi Jacques, inline... Am 12.12.17 um 11:48 schrieb Jacques Le

Re: Removal of trailing white spaces, was: Re: [jira] [Commented] (OFBIZ-9777) [FB] Package org.apache.ofbiz.product.imagemanagement

2017-12-12 Thread Jacques Le Roux
Le 12/12/2017 à 13:29, Michael Brohl a écrit : Hi Jacques, inline... Am 12.12.17 um 11:48 schrieb Jacques Le Roux: Hi Michael, I already answered you in Jira here it is another more complete version: Removing trailing spaces has been discussed in the past and the consensus is that we don't

Re: Removal of trailing white spaces, was: Re: [jira] [Commented] (OFBIZ-9777) [FB] Package org.apache.ofbiz.product.imagemanagement

2017-12-12 Thread Nicolas Malin
Hello Le 12/12/2017 à 13:29, Michael Brohl a écrit : [...] I have a very simple but effective workflow for this, you might find it helpful also: 1. copy the link to the patch file in the Jira issue 2. right click on your OFBiz project in Eclipse and select Team/Apply patch 3. the copied

Re: Removal of trailing white spaces, was: Re: [jira] [Commented] (OFBIZ-9777) [FB] Package org.apache.ofbiz.product.imagemanagement

2017-12-12 Thread Michael Brohl
Am 12.12.17 um 11:48 schrieb Jacques Le Roux: This is a bit out of subject, but while at it: As you can see at [3] I'm not against  removing trailing spaces. But experience told me one thing since. One of the most important things in version control is what happened  to a line, because you

Re: Removal of trailing white spaces, was: Re: [jira] [Commented] (OFBIZ-9777) [FB] Package org.apache.ofbiz.product.imagemanagement

2017-12-12 Thread Michael Brohl
Hi Jacques, inline... Am 12.12.17 um 11:48 schrieb Jacques Le Roux: Hi Michael, I already answered you in Jira here it is another more complete version: Removing trailing spaces has been discussed in the past and the consensus is that we don't remove trailing spaces in patches because it

Re: [DISCUSSION] Review ProductPromo action and condition process

2017-12-12 Thread Rishi Solanki
+1 for the proposal, Nicolas! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Mon, Dec 11, 2017 at 7:20 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Ha I see, you speak about

Re: Extending a form which uses auto-fields-service

2017-12-12 Thread Rishi Solanki
Jacques, IMO, we can discard this thread for now. I'll check once I'll finish by in-progress work and get back on this if found anything. Thanks! -- Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com

Re: Removal of trailing white spaces, was: Re: [jira] [Commented] (OFBIZ-9777) [FB] Package org.apache.ofbiz.product.imagemanagement

2017-12-12 Thread Jacques Le Roux
Hi Michael, I already answered you in Jira here it is another more complete version: Removing trailing spaces has been discussed in the past and the consensus is that we don't remove trailing spaces in patches because it hurts reviewers with false changes. What was suggested then is to split

Removal of trailing white spaces, was: Re: [jira] [Commented] (OFBIZ-9777) [FB] Package org.apache.ofbiz.product.imagemanagement

2017-12-12 Thread Michael Brohl
Hi Jacques, I propose to do it the other way around: when reviewing diffs, you can configure the IDE to ignore these white space changes. It works perfectly in Eclipse and you will not be bothered by such changes. In my view, trailing white spaces do not belong there and should be removed