Re: Unused jQuery MockJax Plugin

2019-01-10 Thread Aditya Sharma
Thanks Michael and Jacques :-) Done for trunk at r1851013 and R18.12 at r1851014 Thanks and Regards, *Aditya Sharma* | Enterprise Software Engineer HotWax Commerce by HotWax Systems [image: https://www.linkedin.com/in/aditya-p-sharma/]

Re: Unable to set the autoLogin Cookie when mount-point is set as an empty string

2019-01-10 Thread Mathieu Lirzin
Hello, Deepak Nigam writes: > Thank you, Jacques, for looking into it. > > In my case, there is only one webapp with the empty mount point and I want > to use the autoLogin cookie. But the code is written in such a way that in > case of empty mount point 'webappInfo' object is coming null due to

Re: Session timeout for webapps

2019-01-10 Thread Deepak Nigam
Thanks, Jacques and Girish. Yes, it makes sense to get back to web.xml for the session timeout value. On Fri, Jan 11, 2019 at 11:13 AM Girish Vasmatkar < girish.vasmat...@hotwaxsystems.com> wrote: > Hi Jacques > > Yes, we should put back the session timeout declaration in web.xml. Given > the fa

Re: Session timeout for webapps

2019-01-10 Thread Girish Vasmatkar
Hi Jacques Yes, we should put back the session timeout declaration in web.xml. Given the fact that we can always mix web.xml and Annotation based configuration, it only makes sense to let web.xml decide the session timeout and even if we have the session listener (via web.xml declaration or Annota

Re: Unable to set the autoLogin Cookie when mount-point is set as an empty string

2019-01-10 Thread Deepak Nigam
Thank you, Jacques, for looking into it. In my case, there is only one webapp with the empty mount point and I want to use the autoLogin cookie. But the code is written in such a way that in case of empty mount point 'webappInfo' object is coming null due to which autoLogin cookie is not getting c

Re: Unable to set the autoLogin Cookie when mount-point is set as an empty string

2019-01-10 Thread Jacques Le Roux
Hi Deepak, It's not a problem if we create an autologin cookie even if it's not used, just unclean. So in this case we could force the same cookie values but the name and path to "root". But what happens if we have several empty mountpoints, is that a problem? I guess if we deploy on root ther

Re: Session timeout for webapps

2019-01-10 Thread Jacques Le Roux
Hi Deepak, Girish, I had a look at the issue. The specifications of Java Servlet Specification 3.0 don't include an annotation to change the session time out. https://www.baeldung.com/servlet-session-timeout https://stackoverflow.com/questions/20389833/session-timeout-config-with-no-web-

Re: Unused jQuery MockJax Plugin

2019-01-10 Thread Jacques Le Roux
Hi Aditya, Michael, Yes indeed it's not used in OFBiz, I think we are good to remove it and mention it in OFBIZ-9978 Jacques Le 10/01/2019 à 11:37, Aditya Sharma a écrit : Thanks for the quick response Michael. Indeed it was upgraded with the Jquery upgrade at https://issues.apache.org/jir

Re: Unused jQuery MockJax Plugin

2019-01-10 Thread Aditya Sharma
Thanks for the quick response Michael. Indeed it was upgraded with the Jquery upgrade at https://issues.apache.org/jira/browse/OFBIZ-9978 but there was no trace of its use. Even I couldn't find it being loaded. I guess it is used by jquery.validation for test https://github.com/jquery-validation

Re: Unused jQuery MockJax Plugin

2019-01-10 Thread Michael Brohl
Hi Aditya, a quick search shows that it was added in r1815824 by Jacques for the update from Jquery 1.11.0 to JQuery 3.2.1. Maybe it's a dependency or part of the Jquery stack? Regards, Michael Am 10.01.19 um 10:07 schrieb Aditya Sharma: Hello all, I can't find any use of the jQuery MockJ

Unused jQuery MockJax Plugin

2019-01-10 Thread Aditya Sharma
Hello all, I can't find any use of the jQuery MockJax Plugin included in OFBiz. If it is not used anywhere, we can remove it. Is there anything I am missing? Thanks and Regards, *Aditya Sharma* | Enterprise Software Engineer HotWax Commerce

Re: Unable to set the autoLogin Cookie when mount-point is set as an empty string

2019-01-10 Thread Jacques Le Roux
Thanks Deepak, I'll have a look ASAP Jadques Le 10/01/2019 à 09:26, Deepak Nigam a écrit : Hello all, In the method to set the autoLogin cookie, LoginWorker.autoLoginSet(), system fetches the webAppInfo by using the method ComponentConfig.getWebappInfo(). In this method, serverId and applicat

Unable to set the autoLogin Cookie when mount-point is set as an empty string

2019-01-10 Thread Deepak Nigam
Hello all, In the method to set the autoLogin cookie, LoginWorker.autoLoginSet(), system fetches the webAppInfo by using the method ComponentConfig.getWebappInfo(). In this method, serverId and applicationName are passed as the arguments. *WebappInfo webappInfo = ComponentConfig.getWebappInfo((St