How do committers decide which features to backport to 18.12?

2020-02-23 Thread Daniel Watford
Hello, I would quite like to see https://issues.apache.org/jira/browse/OFBIZ-11330 (Using FlexibleStringExpander in form widget field's parameter names) backported to the release18.12 branch as, quite selfishly, it will make my life easier! :) I also like to think it would be useful to others

Re: buildbot exception in on ofbizBranch17FrameworkPlugins

2020-02-23 Thread Suraj Khurana
Hello Deepak, Thanks for taking care of it. Much appreciated. I think due to same indexes on patch and codebase, patch applied successfully at different place than expected. Also, performed build with same procedure on release18.12 and trunk where everything went flawless, somehow I missed for

Re: buildbot exception in on ofbizBranch17FrameworkPlugins

2020-02-23 Thread Jacques Le Roux
Maybe this needs more explanation for the common good. The build Deepak used as reference was not at the origin of the issue. Actually it was https://ci.apache.org/builders/ofbizBranch17Framework/builds/407 The reason that the issue also appeared in the build Deepak used as reference is

Re: OFBIZ-4035: change the id Attribute for input fields in the model macro form renderer from String to FlexibleStringExpander

2020-02-23 Thread Daniel Watford
Hello, I've replaced the original PRs with a few more focused ones: https://github.com/apache/ofbiz-framework/pull/24 https://github.com/apache/ofbiz-framework/pull/25 https://github.com/apache/ofbiz-framework/pull/26 Hopefully the above are considered low risk and/or minor improvements and can

Re: [DISCUSSION] Make Back-Office screens dynamic

2020-02-23 Thread James Yong
Hi all, I have created a JIRA issue for it i.e. OFBIZ-11409: POC for Dynamic Screen Using MVVM. Chose KnockoutJs because it uses only the data-bind attribute, instead of special attributes. Regards, James On 2020/01/15 10:52:14, Jacques Le Roux wrote: > Hi James, > > I did not look into

Re: buildbot exception in on ofbizBranch17FrameworkPlugins

2020-02-23 Thread Michael Brohl
Thanks Deepak, I missed the stdio link at the bottom. Regards, Michael Am 23.02.20 um 14:00 schrieb Deepak Dixit: Hi Michael, Please see the details for failure https://ci.apache.org/builders/ofbizBranch17FrameworkPlugins/builds/466/steps/shell_1/logs/stdio I fixed these errors in commit

Re: buildbot exception in on ofbizBranch17FrameworkPlugins

2020-02-23 Thread Deepak Dixit
Hi Michael, Please see the details for failure https://ci.apache.org/builders/ofbizBranch17FrameworkPlugins/builds/466/steps/shell_1/logs/stdio I fixed these errors in commit https://github.com/apache/ofbiz-framework/commit/1a8903e1d529540238798ce234b39c8f45256cb1 Thanks & Regards -- Deepak

Re: buildbot exception in on ofbizBranch17FrameworkPlugins

2020-02-23 Thread Michael Brohl
Hi Deepak, the failures in the given buildbot link seem not to match with the build erros shown below. Am I missing something or is something wrong with this report? Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 23.02.20 um 12:17 schrieb Deepak Dixit: Hi Dev,

Re: buildbot exception in on ofbizBranch17FrameworkPlugins

2020-02-23 Thread Deepak Dixit
Thanks Pierre, I'll check and reply on it. @Dev: Please review your changes those were backported to 17.12, we can't publish broken 17.12 release, Thanks & Regards -- Deepak Dixit ofbiz.apache.org On Sun, Feb 23, 2020 at 4:55 PM Pierre Smits wrote: > Hi Deepak, > > I guess this also

Re: buildbot exception in on ofbizBranch17FrameworkPlugins

2020-02-23 Thread Pierre Smits
Hi Deepak, I guess this also validates my proposal to do an automated vetting of contributor's code changes before these be added to the codebase. See https://ofbiz.markmail.org/message/gkpej7gcxwidggvl?q=vetting for more information. Met vriendelijke groet, Pierre Smits *Proud* *contributor*

Re: buildbot exception in on ofbizBranch17FrameworkPlugins

2020-02-23 Thread Deepak Dixit
Hi Dev, https://ci.apache.org/builders/ofbizBranch17FrameworkPlugins/builds/466 Build failing for release 17.12, please be very careful while backporting changes to release branches, Please make sure you are verifying changes after merge/backport. Also please check the build boat failure