Re: LineLength for checkstyle

How many files would violate that 2000-lines rule? Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz since 2008 (without privileges) *Apache Trafodion , Vice President* *Apache Directory

Re: LineLength for checkstyle

+1 for setting rule. Also we can think of some configured values instead of 2000 (default). may be we should set it to 3000 instead. And then as Daniel mentioned, work on refactoring those offending source files where possible. -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon,

Re: Adopting Github Workflow

Hi All, I believe we are now pragmatically using JIRA + Patch, or GH + PR. Remains the question about allowing the creation of issues in GH. It seems to me that nobody actually asked for that since Jira is enough for our needs. So I should not need more than what we use currently and can put h

Re: Have a README.TXT file in release package

Hi Pierre, All, I have backported the new INSTALL file in R17 and R18 and closed OFBIZ-11691 Pierre, I suggest you create a Jira for your propositions below. Because moving these scripts has implication in their content (code) Thanks Jacques Le 14/05/2020 à 19:53, Pierre Smits a écrit : Ind

Re: Parameterized Unit Tests?

Hi Carsten, Yes, if parameterized testing were to be introduced then a low-priority jira should be raised for possibly introducing the same pattern in FlexibleStringExpanderTests. It should be a low-priority improvement JIRA since what we currently have is working well enough for the moment, but

Re: Allow external script in multi-block html template to be headerized

Hi all, Created JIRA issue OFBIZ-11741. Also uploaded a patch usimg jstree library as example. The library will only be loaded when required. Regards, James On 2020/05/25 15:34:01, James Yong wrote: > Hi all, > > Currently setting multi-block=true for the html-template, allows inline > scrip

Re: Parameterized Unit Tests?

Sorry, misunderstanding here: I will try both suggestions from Stackoverflow and decide for one option. Regarding your suggestion, Dan, I guess that is a new JIRA Improvement once I validated the parametrized testing with my test case, right? > Am 25.05.2020 um 17:24 schrieb Carsten Schinzer

Allow external script in multi-block html template to be headerized

Hi all, Currently setting multi-block=true for the html-template, allows inline script within the freemarker to be transformed to an external script. This helps to reduce the CSP errors. Propose to allow external scripts within the multi-block html template, to be rendered within the html head

Re: Parameterized Unit Tests?

Thanks for the hint, Dan! Also, I just came across this one: https://stackoverflow.com/questions/3361239/excluding-a-non-param-test-in-parameterized-test-class I certainly support running each o

Re: Parameterized Unit Tests?

Hi Carsten, I don't know if there were any reasons historically that precluded use of the parameterized test pattern, but I think it can be quite useful if you are able to make use of it. Another test class that could benefit is FlexibleStringExpanderTests where the parameterized test pattern app

Re: LineLength for checkstyle

+1 for setting the max lines rule > Am 25.05.2020 um 17:05 schrieb Daniel Watford : > > Hi Jacques, > > I would vote for setting an explicit rule to have the max line length set > at 2000 lines and then work on refactoring those offending source files > where possible. > > If we find some files

Re: LineLength for checkstyle

Hi Jacques, I would vote for setting an explicit rule to have the max line length set at 2000 lines and then work on refactoring those offending source files where possible. If we find some files cannot be split up then I think we can add exceptions to prevent the max line length rule from being

Parameterized Unit Tests?

Hello all, I find no other reference to org.junit.Parameterized in the code stack on trunk which indicates that no-one else has committed parameterized unit tests. I am asking because I have a test case where I would need that (I want to run all options for the CustRequestStatusType against th

Re: LineLength for checkstyle

Hi All, Suraj rightly mentioned that we have no FileLength checkstyle rule and the max default is 2000 lines: https://checkstyle.sourceforge.io/config_sizes.html#FileLength We have some very large Java files in trunk and few (19) are longer than 2000 lines. The question is should we increase F

Re: LineLength for checkstyle

This is done in rev # d6ebef619349f809062641d1b558cacdec3da208 -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, May 25, 2020 at 2:16 PM Suraj Khurana wrote: > Thanks everyone, > > Here[1] is the ticket to track this improvement. > > [1]: https://issues.apache.org/jira/browse/

[GitHub] [ofbiz-tools] surajkhurana merged pull request #4: Improved: Changed lineSplit related values to 150

surajkhurana merged pull request #4: URL: https://github.com/apache/ofbiz-tools/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [ofbiz-tools] JacquesLeRoux commented on pull request #4: Improved: Changed lineSplit related values to 150

JacquesLeRoux commented on pull request #4: URL: https://github.com/apache/ofbiz-tools/pull/4#issuecomment-633534675 Sounds good to me, +1 for commit, thanks Suraj! This is an automated message from the Apache Git Service. To

[GitHub] [ofbiz-tools] surajkhurana opened a new pull request #4: Improved: Changed lineSplit related values to 150

surajkhurana opened a new pull request #4: URL: https://github.com/apache/ofbiz-tools/pull/4 (OFBIZ-11737) Earlier it was 120, as per discussion over ML we decided to make it 150 instead. Thanks Jacques Le Roux This is

Re: Difficulties to support the Community Days

Thanks Carsten. Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz since 2008 (without privileges) *Apache Trafodion , Vice President* *Apache Directory , PMC Member* Apache Incubat

Re: Difficulties to support the Community Days

https://issues.apache.org/jira/browse/OFBIZ-11738 :) > Am 25.05.2020 um 11:43 schrieb Pierre Smits : > > Ahh. Yes, there is also Fisheye (another Atlassian product, and still in > play). That aspect of our tooling hasn't been adjusted yet (showing (links > to) commits in Github. > > Please be

Re: Difficulties to support the Community Days

Ahh. Yes, there is also Fisheye (another Atlassian product, and still in play). That aspect of our tooling hasn't been adjusted yet (showing (links to) commits in Github. Please be so kind to raise an issue regarding this, so that it can be followed through. Met vriendelijke groet, Pierre Smit

Re: OFBiz contributions & Github Pull Requests

Hi all, In this thread we discussed improvements to the Contributing via Git and Github page in Confluence (see [1]). Some were then adamant that the page should have the WIP status referenced in the subject/title. However, since then the page hasn't changed. If nothing comes forward in the comin

Re: Difficulties to support the Community Days

Hi, Thanks indeed - #2 explains and is valid practice, just needed to know. Ad 1 - The following is what I get, when I click on the commits link on any JIRA ticket with existing commits a popup dialog opens (I use that inside my work evironment to investigate on the code level). Example: OFBIZ

Re: Difficulties to support the Community Days

Hi Carsten, Welcome back. re: 1 Indeed things has changes. Yet there is no dependency on Fishbowl. In fact there is no mention at all in any of our mailing lists regarding an integration with fishbowl. The tools still in use by the project: Jira (for issue management, release management, etc), Gi

Difficulties to support the Community Days

Hello all, Admittedly I have been away for a very long time and things have changed. I seem to be having difficulties to contribute to the Community Days, but maybe simply rookie issues, so any helping hand is appreciated. I have this status: * OFBiz code bases (framework and plugins) cloned fr

Re: LineLength for checkstyle

Thanks everyone, Here[1] is the ticket to track this improvement. [1]: https://issues.apache.org/jira/browse/OFBIZ-11737 -- Best Regards, Suraj Khurana Senior Technical Consultant On Sun, May 24, 2020 at 1:58 PM Olivier Heintz < holivier.li...@ofbizextra.org> wrote: > +1 > > Le 23/05/2020 à 1

Re: buildbot failure in on ofbizTrunkFrameworkPlugins

Sure Jacques. I will add them to the given task. Thanks and Regards, Aditya Sharma On Sun, May 24, 2020 at 4:02 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Thanks Guys, > > We have already https://issues.apache.org/jira/browse/OFBIZ-11304 > > Please Aditya add your references the