Copying over from the user list, seems to be wrong here...
Betreff: Re: [DISCUSSION] Committing Minilang test patches under
OFBIZ-1463
Datum: Thu, 6 Jun 2019 11:31:49 +0200
Von:Jacques Le Roux
Organisation: Les Arts Informatiques
An: u...@ofbiz.apache.org
Kopie (CC): Pierre
Hello everyone,
I am inclined with Jacques opinion (Initially what we proposed to commit
those patches into the repo) here, on the flip side I would like to mention
that we are gradually working on moving these XML's to groovy.
So whatever we conclude, I am up for it.
--
Best Regards,
Suraj Khura
Le 05/06/2019 à 09:24, Jacques Le Roux a écrit :
To explain my hard feeling regarding OFBiz integration tests. I find
them really hard to understand/debug due to the following points:
- Logs are unreadable! I mean understanding which test has failed is
already an endeavour.
Oh that! I never
Hi Mathieu,
[snip]
Then I see no problems doing that and having already Minilang tests
present. We "just have" to drop Minilang tests when Groovy ones are
ready.
What I'm missing?
The problem I see is that if the people proposing the patches are not
willing to do the migration work right now,
Hello
Jacques Le Roux writes:
> Le 02/06/2019 à 15:50, Mathieu Lirzin a écrit :
>>
>> Jacques Le Roux writes:
>>
>>> We started a discussion in OFBIZ-1463 about committing or not the Minilang
>>> test patches.
>>>
>>> There are already few mixed opinions there (Michael, Aditya, Suraj and I).
>
Le 03/06/2019 à 15:20, Michael Brohl a écrit :
I explained my POV in the Jira [1].
Why not encourage the contributors to move their minilang tests to Groovy code? I can see that this has already been done, e.g. here [2] (thanks
everyone involved!).
I'm sure that the remaining patches will get
As a general rule, minilang adds to the technical debt of this project. It
is hard to understand or maintain even simple constructs in minilang.
To generalize this concept... Patch != Good patch. So I recommend that
everything goes through the funnel of good old reviews. Good code has no
shortcuts
I explained my POV in the Jira [1].
Why not encourage the contributors to move their minilang tests to
Groovy code? I can see that this has already been done, e.g. here [2]
(thanks everyone involved!).
I'm sure that the remaining patches will get converted soon, no need to
choose the "easy w
OK if this is a veto, no need to continue the discussion.-
Else could you explain your POV Michael, notably about missing to put in some
new tests that could be helpful in the meantime?
Thanks
Le 02/06/2019 à 21:27, Michael Brohl a écrit :
-1 to introduce more minilang code to the codebase. N
-1 to introduce more minilang code to the codebase. New code should be provided
in either Java or Groovy code.
Thanks,
Michael
> Am 02.06.2019 um 12:56 schrieb Jacques Le Roux :
>
> Hi All,
>
> We started a discussion in OFBIZ-1463 about committing or not the Minilang
> test patches.
>
> T
Le 02/06/2019 à 15:50, Mathieu Lirzin a écrit :
Hello Jacques,
Jacques Le Roux writes:
We started a discussion in OFBIZ-1463 about committing or not the Minilang test
patches.
There are already few mixed opinions there (Michael, Aditya, Suraj and I).
Before voting I'd like to know if we ca
Hello Jacques,
Jacques Le Roux writes:
> We started a discussion in OFBIZ-1463 about committing or not the Minilang
> test patches.
>
> There are already few mixed opinions there (Michael, Aditya, Suraj and I).
>
> Before voting I'd like to know if we can come to a consensus.
>
> Please read in
Hi All,
We started a discussion in OFBIZ-1463 about committing or not the Minilang test
patches.
There are already few mixed opinions there (Michael, Aditya, Suraj and I).
Before voting I'd like to know if we can come to a consensus.
Please read in OFBIZ-1463 and come back with your opinion.
13 matches
Mail list logo
