[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12634042#action_12634042
]
Jacques Le Roux commented on OFBIZ-1885:
Maybe we could put at screen left, near
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12634046#action_12634046
]
Jacopo Cappellato commented on OFBIZ-1885:
--
In my opinion it is ok to show the
In my opinion both Select Visual Theme, Select language and Select Time-zone
should be part of a user preferences/profile screen.
The User Preferences screen should be a screen implemented in the common
component and should let other applications to insert additional settings
application related
This is interesting and make sense, but I think we should keep such comments in respective Jira issues. It's easier to follow later.
I noticed some others that why I suggest this, nothing specific.
My 2 cts
Jacques
From: Bruno Busco [EMAIL PROTECTED]
In my opinion both Select Visual Theme,
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12634008#action_12634008
]
Hans Bakker commented on OFBIZ-1885:
perhaps good to mention that the visual themes
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12632306#action_12632306
]
Bruno Busco commented on OFBIZ-1885:
Adrian,
I wonder if you are happy with the
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12632314#action_12632314
]
Adrian Crum commented on OFBIZ-1885:
Bruno,
I looked at the screencap of your theme -
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12630113#action_12630113
]
Bruno Busco commented on OFBIZ-1885:
We have now the Visual Theme Gallery here:
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12630160#action_12630160
]
Jacques Le Roux commented on OFBIZ-1885:
Not sure for the colors :D but great
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12629742#action_12629742
]
Jacques Le Roux commented on OFBIZ-1885:
Bruno,
I'd be interested to see counter
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12629775#action_12629775
]
Bruno Busco commented on OFBIZ-1885:
Jacques,
where I work we have set up years ago
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12629803#action_12629803
]
Bruno Busco commented on OFBIZ-1885:
No problem at all, Adrian!
Thank you.
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12629903#action_12629903
]
Bruno Busco commented on OFBIZ-1885:
Adrian,
what do you think of committing this work
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12629905#action_12629905
]
Adrian Crum commented on OFBIZ-1885:
Bruno,
I have very little time to spend on this
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12629974#action_12629974
]
Jacques Le Roux commented on OFBIZ-1885:
Something I do when I don't want to mix
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12629713#action_12629713
]
Bruno Busco commented on OFBIZ-1885:
Hi Adrian,
I was trying to give a little
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12629716#action_12629716
]
Bruno Busco commented on OFBIZ-1885:
Giving a quick look at some other Apache project
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12623570#action_12623570
]
Adrian Crum commented on OFBIZ-1885:
Bruno,
Thank you for taking the time to review
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12623567#action_12623567
]
Bruno Busco commented on OFBIZ-1885:
Tryed the updated patch and looks good to me.
I
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12622475#action_12622475
]
Bruno Busco commented on OFBIZ-1885:
Please find the new issue with a new patch here:
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12622216#action_12622216
]
Adrian Crum commented on OFBIZ-1885:
Bruno,
A collapsible masthead would be nice to
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12622283#action_12622283
]
Jacques Le Roux commented on OFBIZ-1885:
+1 for a new issue for the collapsible
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12621211#action_12621211
]
Bruno Busco commented on OFBIZ-1885:
Adrian,
I cannot find the listVisualThemes.ftl
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12620146#action_12620146
]
Adrian Crum commented on OFBIZ-1885:
Bruno,
On the eCommerce side, I know David Jones
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12619936#action_12619936
]
Adrian Crum commented on OFBIZ-1885:
Bruno,
I have already spent a considerable amount
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12620143#action_12620143
]
Bruno Busco commented on OFBIZ-1885:
Thank you for explanation, I now better understand
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12619550#action_12619550
]
Adrian Crum commented on OFBIZ-1885:
Bruno,
Thank you for your continuing work on
On Jul 30, 2008, at 11:36 PM, Bruno Busco wrote:
Adrian,
I agree that it could be simplyfied using the setUserPreferences
request,
thanks for the hint, I was also trying to understand how to rewrite
it.
In any case, if we consider that in the Visual Theme form additional
fields
could be
Adrian,
I am trying to simplify the VisualTheme selection form but unfortunately I
need still to learn...
Using this form:
form name=VisualTheme type=single
target=setUserPreference?userPrefTypeId=VISUAL_THEMEamp;userPrefGroupId=GLOBAL_PREFERENCESamp;userPrefValue=${myTheme}
actions
I cannot find any usage of the request setUserPreference in OFBiz.
I think that in order to be used as a form target, the method should be
defined with a different prototype such as
setUserPreference(HttpServletRequest, HttpServletResponse)
I have seen that similar event services follow this
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12618930#action_12618930
]
Bruno Busco commented on OFBIZ-1885:
Many thanks Adrian,
now I understand (and learned)
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12618564#action_12618564
]
Adrian Crum commented on OFBIZ-1885:
Bruno,
Thank you for your contribution. Your
Adrian,
I agree that it could be simplyfied using the setUserPreferences request,
thanks for the hint, I was also trying to understand how to rewrite it.
In any case, if we consider that in the Visual Theme form additional fields
could be added later like for example:
- Default number of rows to
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12617985#action_12617985
]
Bruno Busco commented on OFBIZ-1885:
Reading the thread back I found the list of todos:
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12617990#action_12617990
]
Adrian Crum commented on OFBIZ-1885:
Bruno,
Thank you very much for taking the time to
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12617998#action_12617998
]
Bruno Busco commented on OFBIZ-1885:
Theme_1.zip does not pretend to be an usable
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12618013#action_12618013
]
Bruno Busco commented on OFBIZ-1885:
Unfortunately #3 seems not as easy as adding a
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12618062#action_12618062
]
David E. Jones commented on OFBIZ-1885:
---
I'd say this is a case where a custom cache
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12617245#action_12617245
]
David E. Jones commented on OFBIZ-1885:
---
To make things more consistent, how about
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12617271#action_12617271
]
Adrian Crum commented on OFBIZ-1885:
How would I implement the theme cache in Groovy or
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12617225#action_12617225
]
Adrian Crum commented on OFBIZ-1885:
Steps needed for completion:
1. Theme CRUD
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12615014#action_12615014
]
Jacopo Cappellato commented on OFBIZ-1885:
--
Hi Adrian,
this is interesting,
[
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12615032#action_12615032
]
Adrian Crum commented on OFBIZ-1885:
Jacopo,
Those are great suggestions - thanks!
43 matches
Mail list logo
