Clojure service engine proposal for inclusion

2021-07-04 Thread Eugen Stan
Hello, I've implemented a clojure engine for OFBiz and I would like to contribute this to OFBiz repo. It was simpler than I thought. NOTE: Right now the code is bundled with the ofbiz-repl-plugin in https://github.com/netdava/ofbiz-clojure-repl . Code is a draft and will be cleaned up for i

Re: Clojure service engine proposal for inclusion

2021-07-06 Thread Nicolas Malin
Hello, Thanks for this detail email and your works. I'm not opposed to load closure in OFBiz code base for same reason that you exposed. For success the inclusion, I suggest to rename the namespace to org.apache.ofbiz, add test one framework/service/testdef and an example "hello world" service.

Re: Clojure service engine proposal for inclusion

2021-07-28 Thread Eugen Stan
Hello Nicolas, Thanks for the suggestions. I've made a PR for this: https://github.com/apache/ofbiz-framework/pull/317 * has a service test * has a service example (defn echo-service "Echo back all the parameters" [dctx ctx] (doto (new java.util.LinkedHashMap) (.putAll ctx) (.put

Re: Clojure service engine proposal for inclusion

2021-07-29 Thread Pierre Smits
Hi Ioan, Would it not be better for the community to be able to implement this set of functionalities by means of a downloadable plugin? It seems to me that - in a way - this levels up to plugins like the indexing (lucene) or the REST plugins. Not every adopters would be keen to have this by defa

Re: Clojure service engine proposal for inclusion

2021-07-29 Thread Nicolas Malin
Hello, @Eugeu Yeah nice, I added some suggest to the PR, and create the linked jira issue and we can push it on trunk @Pierre The service engine don't support an extension by plugins, you can't load a new engine without change the framework. In this case I prefer to load the minimal quantity o

Re: Clojure service engine proposal for inclusion

2021-07-29 Thread Pierre Smits
Hi Nicolas, I wasn't aware of that constraint. Thanks for the insight. Pierre Op do 29 jul. 2021 17:40 schreef Nicolas Malin : > Hello, > > @Eugeu > > Yeah nice, I added some suggest to the PR, and create the linked jira > issue and we can push it on trunk > > @Pierre > > The service engine do

Re: Clojure service engine proposal for inclusion

2021-07-29 Thread Eugen Stan
Hello Nicolas, Pierre, Thanks for your feedback, I replied to the issue. @Pierre: I would like to be able to use a "slim" OFBiz version but that is not easy to do at the moment. I would like to announce my intention to work on this issue. One way that would get us closer to a "Slim" (composa