Re: OFBiz 21.01 releases

2022-12-21 Thread Jacques Le Roux
Le 21/12/2022 à 12:33, Jacques Le Roux a écrit : The workaround is easy, the rest I doubt. Like this comment at top of GenericEntity.java     /** Contains the fields for this entity. Note that this should always be a *  HashMap to allow for two things: non-synchronized reads (synchronized

Re: OFBiz 21.01 releases

2022-12-21 Thread Jacques Le Roux
Le 21/12/2022 à 12:33, Jacques Le Roux a écrit : The workaround is easy, the rest I doubt. Like this comment at top of GenericEntity.java To be clear the issue I fixed with the workaround is about immutability

Re: OFBiz 21.01 releases

2022-12-21 Thread Jacques Le Roux
Hi Daniel, I was considering to commit in trunk because of the pending changes I have for OFBIZ-12721 "Replace all occurrences of java.util.TimeZone by java.time.ZoneId" and this one. But I finally decided not. I can live with it until we decide to run under Gradle 7.6 and JDK 17. I do and had

Re: OFBiz 21.01 releases

2022-12-21 Thread Daniel Watford
Hi Jacques, Will you be committing your fix/workaround under OFBIZ-12726? If this change goes in to the code perhaps we should consider it a stop-gap to unblock moving OFBiz to JDK 17 as it seems to go again the spirit of strong encapsulation described in the migration guide you linked to:

Re: OFBiz 21.01 releases

2022-12-21 Thread Jacques Le Roux
Hi, I closed OFBIZ-12726 as fixed. Fortunately, simply adding --add-opens=java.base/java.util=ALL-UNNAMED into applicationDefaultJvmArgs in build.gradle fixed the whole issues. Jacques Le 20/12/2022 à 12:28, Jacques Le Roux a écrit : I have created

Re: OFBiz 21.01 releases

2022-12-20 Thread Jacques Le Roux
I have created https://issues.apache.org/jira/browse/OFBIZ-12726 for that Le 20/12/2022 à 12:22, Jacques Le Roux a écrit : Yes of course, it's a "typo" :) Le 20/12/2022 à 12:02, Michael Brohl a écrit : You are confusing me, Jacques. There is no release 20.01.01, its 22.01.01, right? Michael

Re: OFBiz 21.01 releases

2022-12-20 Thread Jacques Le Roux
Yes of course, it's a "typo" :) Le 20/12/2022 à 12:02, Michael Brohl a écrit : You are confusing me, Jacques. There is no release 20.01.01, its 22.01.01, right? Michael Brohl ecomify GmbH - www.ecomify.de Am 20.12.22 um 11:55 schrieb Jacques Le Roux: You are right, confident as all seamed

Re: OFBiz 21.01 releases

2022-12-20 Thread Michael Brohl
You are confusing me, Jacques. There is no release 20.01.01, its 22.01.01, right? Michael Brohl ecomify GmbH - www.ecomify.de Am 20.12.22 um 11:55 schrieb Jacques Le Roux: You are right, confident as all seamed to go well running OFBiz, I did not ran integration tests yet There is a lot

Re: OFBiz 21.01 releases

2022-12-20 Thread Jacques Le Roux
You are right, confident as all seamed to go well running OFBiz, I did not ran integration tests yet There is a lot of work to do regarding those. Currently we have 322 errors and 190 failures. I'm still confident that it should not be as hard as it looks to fix, but indeed that could maybe

Re: OFBiz 21.01 releases

2022-12-20 Thread Michael Brohl
In my opinion, before we do a RELEASE based on a new JDK (doing a step from 8 to 17), we should have some serious testing with different environments etc. It's only a few weeks since the change which is much different from the long stabilization phases we had in the past. How can we

Re: OFBiz 21.01 releases

2022-12-19 Thread Jacques Le Roux
Hi All, After Eugen suggested so, for few weeks now I'm using 7.6 and JDK 17 without any problems. For that, we have OFBIZ-12400 "Upgrade to gradle 7.6 - support jdk 11 -> 17" with 2 minor subtasks open. I suggest that you also test on your side in order to allow to release the 22.01.01

Re: OFBiz 21.01 releases

2022-12-19 Thread Nicolas Malin
Yeah, I'm agree for the 22.01, I'm just disappointed to didn't find the time to present our work on the new decorator and theme for this release, but sure for the next :) Nicolas On 16/12/2022 10:12, Daniel Watford wrote: Hello, The ofbiz project recently announced there would be no

Re: OFBiz 21.01 releases

2022-12-16 Thread Michael Brohl
Hi Dan, remark: it will be an 22.01 release, not 21.01. We have created the branch at the beginning of this year. Stable  branches generally only receive bug fixes and - if the community agrees - non-breaking small features. So yes. Best regards, Michael Am 16.12.22 um 10:58 schrieb

Re: OFBiz 21.01 releases

2022-12-16 Thread Daniel Watford
Thanks, Jacques. If 21.01 is coming soon, does that mean we have a feature freeze in place - i.e. we should only commit bug fixes or agreed features to the 21.01 branch in order to stablise the release? On Fri, 16 Dec 2022 at 09:30, Jacques Le Roux wrote: > Hi Daniel, > > Not yet, but it

Re: OFBiz 21.01 releases

2022-12-16 Thread Jacques Le Roux
Hi Daniel, Not yet, but it should be "soon" (ie in few weeks), hopefully using JDK 17 and Gradle 7.6... Jacques Le 16/12/2022 à 10:12, Daniel Watford a écrit : Hello, The ofbiz project recently announced there would be no further releases for 18.12. Has there been any releases for version

OFBiz 21.01 releases

2022-12-16 Thread Daniel Watford
Hello, The ofbiz project recently announced there would be no further releases for 18.12. Has there been any releases for version 21.01, and if so should they be downloadable from the ofbiz website? Thanks, Dan -- Daniel Watford https://watfordconsulting.com