Re: Variables created from properties should not be final

2018-01-05 Thread Jacques Le Roux
Le 05/01/2018 à 10:03, Jacopo Cappellato a écrit : On Fri, Jan 5, 2018 at 9:26 AM, Michael Brohl wrote: [...] So, -1 for applying this as a general rule, +1 for a thorough review of the 53 cases and changes where they make sense. I agree with the reasoning and

Re: Variables created from properties should not be final

2018-01-05 Thread Jacques Le Roux
Le 05/01/2018 à 09:26, Michael Brohl a écrit : Hi Jacques, inline.. Am 05.01.18 um 08:31 schrieb Jacques Le Roux: Hi, We have roughly 3514 variables created from properties, either from properties files or from DB values. Among them 53 are declared final, this does not make sense to me.

Re: Variables created from properties should not be final

2018-01-05 Thread Jacques Le Roux
Le 05/01/2018 à 08:45, Taher Alkhateeb a écrit : -1 This is a perfect example of why mass-updates following a certain pattern are a bad idea. I did not say that all should be done. Of course every case should be checked. The properties files in the start component define critical startup

Re: Variables created from properties should not be final

2018-01-05 Thread Jacopo Cappellato
On Fri, Jan 5, 2018 at 9:26 AM, Michael Brohl wrote: > [...] So, > > -1 for applying this as a general rule, > +1 for a thorough review of the 53 cases and changes where they make sense. > I agree with the reasoning and conclusions above; to them I would add my: +1

Re: Variables created from properties should not be final

2018-01-05 Thread Michael Brohl
Hi Jacques, inline.. Am 05.01.18 um 08:31 schrieb Jacques Le Roux: Hi, We have roughly 3514 variables created from properties, either from properties files or from DB values. Among them 53 are declared final, this does not make sense to me. It might make sense depending on the business

Re: Variables created from properties should not be final

2018-01-04 Thread Taher Alkhateeb
-1 This is a perfect example of why mass-updates following a certain pattern are a bad idea. The properties files in the start component define critical startup parameters that cannot be changed without critically corrupting or even crashing the system. Therefore, I believe you should study

Variables created from properties should not be final

2018-01-04 Thread Jacques Le Roux
Hi, We have roughly 3514 variables created from properties, either from properties files or from DB values. Among them 53 are declared final, this does not make sense to me. Because a variable which depends on a properties is cached and can be dynamically changed. You simply change the