I just spent this last weekend refactoring the Party Manager findParty and
viewProfile pages as a way to test the HTML/CSS coding guidelines that I'm
working on. (That work was an experiment - not intended to be put in the main
project.) Now I can fully appreciate the decisions that need to go i
On Jan 15, 2007, at 4:49 PM, Adrian Crum wrote:
In this particular case, even a minor change to the maincss.css
file results in many modifications. For instance, setting a default
font style removes a ton of code. Same thing with setting default
styles for basic HTML elements.
The best t
Understood. I'm still inclined to present the "finished product" and then see
what incremental steps should be taken to get there.
Btw, the maincss.css file I have will drop into any OFBiz installation and work.
It doesn't need any additional modifications. It doesn't change the L&F in any
way
I feel you - especially when talking about something like this. If
it were me, I'd probably present a new file - and a particular screen
that you did in this style. Once you find adoption, it'll be easy to
get people behind it. But just beware of trying to fix too much - I
think that's t
On Jan 15, 2007, at 4:49 PM, Adrian Crum wrote:
If a new design approach results in greatly reduced code, how do
you present that approach to the community without presenting the
greatly reduced code?
Easy. Start with an example, a small localized change that
demonstrates your idea. Subm
Thanks you for the clarification Tim.
In this particular case, even a minor change to the maincss.css file results in
many modifications. For instance, setting a default font style removes a ton of
code. Same thing with setting default styles for basic HTML elements.
If a new design approach
Regardless, what I think that David is asking you to do was take the
modifications in small chunks - instead of trying to do everything
all at once. That way regardless of whether or not it's a patch or
attached to an email - it's easily reviewable by people.
Cheers,
Tim
--
Tim Ruppert
Hot
David E. Jones wrote:
BTW, I plead and beg on my knees Adrian: don't try to make massive
changes and submit huge patches! Please! Please! PLEASE! I beg of you!
Please try to keep patches more granular and to address a single issue
that can be easily reviewed by committers.
This is importan
On Jan 15, 2007, at 8:39 AM, Adrian Crum wrote:
David E. Jones wrote:
Actually, the point of this sort of CSS pattern is what you
described as the bad side effect, ie having the style tied to the
content.
If we have anything generic, it should be attached to generic
tags, not a messy an
David E. Jones wrote:
Actually, the point of this sort of CSS pattern is what you described
as the bad side effect, ie having the style tied to the content.
If we have anything generic, it should be attached to generic tags, not
a messy and confusing and difficult to maintain library of styl
Believe it or not, in the UK (perhaps other places too) there are laws
against setting text in px, well, not quite, but almost...
The DDA (Disability Discrimination Act 1995) was designed to make sure
that those with visual impairment were not excluded from accessing
websites, in much the same way
Actually, the point of this sort of CSS pattern is what you described
as the bad side effect, ie having the style tied to the content.
If we have anything generic, it should be attached to generic tags,
not a messy and confusing and difficult to maintain library of styles
like we have now
Now that I know that that section of the css file was an experiment, I'd like to
offer my perspective on that particular section.
It seems to me that those product detail styles tie style to content too
closely. In other words, they are pretty content specific.
I see the maincss.css file as b
edition). This chapter is only 30 pages but
there are some interesting tips for this kind of
problems. It speaks about pixels, em, etc.
Jacques
- Original Message -
From: "Adrian Crum" <[EMAIL PROTECTED]>
To:
Sent: Saturday, January 13, 2007 12:10 AM
Subject: Re: main
Thanks for the reminder Daniel! I was going to get to that next. If you try out
the file I attached, you'll see there are still a few small issues I need to
work out. So, it's a work in progress.
Daniel Kunkel wrote:
Hi Adrian
This is great, but I think Chris Howe had a great idea a little
Hi Adrian
This is great, but I think Chris Howe had a great idea a little while
back when he talked about defining text in em so browsers can adjust the
font size.
Thanks
Daniel
-
This is a vague recollection of things read/done on
css. Instead of setting the font size in pixels, you
"shou
I've spent the last two days consolidating the two main css files and cleaning
up the target file. There were a lot of duplicate and unnecessary assignments. I
also found font sizes expressed in points AND pixels, so I changed them all to
pixels. I also changed color names to color values - so t
Adrian,
I see, no problem. Yeah, it was a project started and never finished!
You'll probably also notice that there is still some table-based
formatting on the productdetail page that is a bit evil (well, and
ugly!) and needs to be converted to a CSS-based layout like much of
the other s
David,
Thanks for the reply! I understand completely what the ID attribute is for. I
was questioning why it was done differently than the rest of the file.
David E. Jones wrote:
This was part of the experimentation with the Zen CSS Garden way of
doing CSS. Using id attributes to mark reg
This was part of the experimentation with the Zen CSS Garden way of
doing CSS. Using id attributes to mark regions and styling implicitly
is the way we want to go in the future. If you're planning on working
on CSS stuff and you haven't read through The Zen of CSS Design, I
highly recomme
In the maincss.css file, Just below the comment
/* = Product Detail Styles = */
are six css classes defined using IDs instead of class names. Is there a reason
for that?
21 matches
Mail list logo
