Re: svn commit: r1845933 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/GroovyUtil.java

2018-11-12 Thread Jacques Le Roux
Done :) Jacques Le 11/11/2018 à 13:31, Mathieu Lirzin a écrit : Hello Jacques, Jacques Le Roux writes: So we would remove ant-scripts folder and its content; rename framework/base/groovyScript to framework/base/groovyScripts; move GroovyInit.groovy and GroovyServiceTest.groovy to

Re: svn commit: r1845933 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/GroovyUtil.java

2018-11-11 Thread Mathieu Lirzin
Hello Jacques, Jacques Le Roux writes: > So we would > > remove ant-scripts folder and its content; > > rename framework/base/groovyScript to framework/base/groovyScripts; > > move GroovyInit.groovy and GroovyServiceTest.groovy to > framework/base/groovyScripts and change their paths where

Re: svn commit: r1845933 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/GroovyUtil.java

2018-11-11 Thread Jacques Le Roux
Hi, So we would remove ant-scripts folder and its content; rename framework/base/groovyScript to framework/base/groovyScripts; move GroovyInit.groovy and GroovyServiceTest.groovy to framework/base/groovyScripts and change their paths where used. And let GroovyBaseScript.groovy where it is

Re: svn commit: r1845933 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/GroovyUtil.java

2018-11-09 Thread Jacques Le Roux
Le 09/11/2018 à 11:45, Jacques Le Roux a écrit : GroovyBaseScript.groovy (unused OOTB, it seems we should get rid of) I only made a search on the complete name, but this is injected with groovy.properties using the @BaseScript annotation It was introduced by Jacopo and relates to Groovy DSL:

Re: svn commit: r1845933 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/GroovyUtil.java

2018-11-09 Thread Jacques Le Roux
Here are the Groovy files in base not in groovyScript folder if-script.groovy (unused OOTB, it seems we should get rid of) GroovyInit.groovy (I see indeed no reasons to have in config, that's history) There are 2 other exceptions in framework (not in applications, nor plugins):

Re: svn commit: r1845933 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/GroovyUtil.java

2018-11-08 Thread Jacques Le Roux
Hi Pierre, Mathieu, I did not notice and I have no ideas why it's like that. We need to look at the history to see if there is a reason. Jacques Le 08/11/2018 à 18:10, Mathieu Lirzin a écrit : Hello Pierre, Pierre Smits writes: You're referencing a groovy script that is not located in

Re: svn commit: r1845933 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/GroovyUtil.java

2018-11-08 Thread Mathieu Lirzin
Hello Pierre, Pierre Smits writes: > You're referencing a groovy script that is not located in the agreed > folder, which is the 'groovyScript' folder. Is there a reason why the > referenced file is in the config folder? According to the developper documentation, ‘groovyScripts’ is the

Re: svn commit: r1845933 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/GroovyUtil.java

2018-11-08 Thread Pierre Smits
Hi Jacques, You're referencing a groovy script that is not located in the agreed folder, which is the 'groovyScript' folder. Is there a reason why the referenced file is in the config folder? Best regards, Pierre Smits *Apache Trafodion , Vice President* *Apache