Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-31 Thread Adrian Crum
--- On Sat, 1/30/10, David E Jones d...@me.com wrote: On Jan 30, 2010, at 8:30 PM, Adrian Crum wrote: The moral of the story is: developers shouldn't be allowed to write to the service context Map. If a service needs a Map for local storage, then it should create one. That's kind of

Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-31 Thread David E Jones
On Jan 31, 2010, at 2:00 AM, Adrian Crum wrote: --- On Sat, 1/30/10, David E Jones d...@me.com wrote: On Jan 30, 2010, at 8:30 PM, Adrian Crum wrote: The moral of the story is: developers shouldn't be allowed to write to the service context Map. If a service needs a Map for local storage,

Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-31 Thread Adrian Crum
--- On Sun, 1/31/10, David E Jones d...@me.com wrote: Subject: Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java To: dev@ofbiz.apache.org Date: Sunday, January 31, 2010, 12:12 AM On Jan 31, 2010, at 2:00 AM

Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-31 Thread David E Jones
On Jan 31, 2010, at 2:27 AM, Adrian Crum wrote: --- On Sun, 1/31/10, David E Jones d...@me.com wrote: Subject: Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java To: dev@ofbiz.apache.org Date: Sunday, January 31

Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-30 Thread Adam Heath
adri...@apache.org wrote: Author: adrianc Date: Sun Jan 31 00:08:14 2010 New Revision: 904921 URL: http://svn.apache.org/viewvc?rev=904921view=rev Log: Some changes to the UEL integration. While attempting to upgrade the JUEL library, some flaws in my original code were exposed. This

Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-30 Thread Adrian Crum
--- On Sat, 1/30/10, Adam Heath doo...@brainfood.com wrote: Subject: Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java To: dev@ofbiz.apache.org Date: Saturday, January 30, 2010, 4:36 PM adri...@apache.org wrote

Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-30 Thread Adrian Crum
--- On Sat, 1/30/10, Adrian Crum adrian.c...@yahoo.com wrote: From: Adrian Crum adrian.c...@yahoo.com Subject: Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java To: dev@ofbiz.apache.org Date: Saturday, January 30

Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-30 Thread Adam Heath
Adrian Crum wrote: If you really need to modify variable, then change the generics markup on context. I appreciate the review and comments, but I think you're not understanding the integration. I can't change the method signature because it is part of the JSR 245 specification, and yes,

Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-30 Thread Adrian Crum
--- On Sat, 1/30/10, Adam Heath doo...@brainfood.com wrote: From: Adam Heath doo...@brainfood.com Subject: Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java To: dev@ofbiz.apache.org Date: Saturday, January 30, 2010

Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-30 Thread Adam Heath
Adrian Crum wrote: --- On Sat, 1/30/10, Adam Heath doo...@brainfood.com wrote: From: Adam Heath doo...@brainfood.com Subject: Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java To: dev@ofbiz.apache.org Date

Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-30 Thread David E Jones
On Jan 30, 2010, at 7:28 PM, Adam Heath wrote: Adrian Crum wrote: --- On Sat, 1/30/10, Adam Heath doo...@brainfood.com wrote: From: Adam Heath doo...@brainfood.com Subject: Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string

Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-30 Thread Adrian Crum
--- On Sat, 1/30/10, Adam Heath doo...@brainfood.com wrote: From: Adam Heath doo...@brainfood.com Subject: Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java To: dev@ofbiz.apache.org Date: Saturday, January 30, 2010

Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-30 Thread Adam Heath
David E Jones wrote: On Jan 30, 2010, at 7:28 PM, Adam Heath wrote: When I originally came up with the read-only generics for service engine calls, I tried to make the maps writable. But upon modifying the entire stack, I discovered it wasn't possible. The service engine made copies in some

Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-30 Thread Adam Heath
Adrian Crum wrote: --- On Sat, 1/30/10, Adam Heath doo...@brainfood.com wrote: From: Adam Heath doo...@brainfood.com Subject: Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java To: dev@ofbiz.apache.org Date

Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-30 Thread Adrian Crum
--- On Sat, 1/30/10, Adam Heath doo...@brainfood.com wrote: What kind of modifications do you need to do? Auto-vivification kinda stuff? No, basic OFBiz kinda stuff. set field=var value=Hello World!/ I need to set the var Map element to Hello World! The Map I'm being handed

Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-30 Thread Adam Heath
Adrian Crum wrote: --- On Sat, 1/30/10, Adam Heath doo...@brainfood.com wrote: What kind of modifications do you need to do? Auto-vivification kinda stuff? No, basic OFBiz kinda stuff. set field=var value=Hello World!/ I need to set the var Map element to Hello World! The Map I'm being

Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-30 Thread Adrian Crum
--- On Sat, 1/30/10, David E Jones d...@me.com wrote: From: David E Jones d...@me.com Subject: Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java To: dev@ofbiz.apache.org Date: Saturday, January 30, 2010, 5:37 PM

Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-30 Thread Adam Heath
Adrian Crum wrote: The moral of the story is: developers shouldn't be allowed to write to the service context Map. If a service needs a Map for local storage, then it should create one. Maybe the service engine should make the map readonly, with Collections.unmodifiableMap?

Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-30 Thread David E Jones
On Jan 30, 2010, at 8:30 PM, Adrian Crum wrote: --- On Sat, 1/30/10, David E Jones d...@me.com wrote: From: David E Jones d...@me.com Subject: Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java To: dev

Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-30 Thread Adam Heath
David E Jones wrote: On Jan 30, 2010, at 8:30 PM, Adrian Crum wrote: --- On Sat, 1/30/10, David E Jones d...@me.com wrote: From: David E Jones d...@me.com Subject: Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string

Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-30 Thread Adrian Crum
--- On Sat, 1/30/10, David E Jones d...@me.com wrote: From: David E Jones d...@me.com Subject: Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java To: dev@ofbiz.apache.org Date: Saturday, January 30, 2010, 7:02 PM

Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-30 Thread Adrian Crum
--- On Sat, 1/30/10, Adam Heath doo...@brainfood.com wrote: From: Adam Heath doo...@brainfood.com Subject: Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java To: dev@ofbiz.apache.org Date: Saturday, January 30, 2010

Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java

2010-01-30 Thread Adam Heath
Adrian Crum wrote: --- On Sat, 1/30/10, Adam Heath doo...@brainfood.com wrote: From: Adam Heath doo...@brainfood.com Subject: Re: svn commit: r904921 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base: test/BaseUnitTests.java util/string/UelUtil.java To: dev@ofbiz.apache.org Date