[GitHub] incubator-omid pull request #46: [OMID-90] Integrate omid low latency to pho...

2018-10-10 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/46#discussion_r223974301 --- Diff: hbase-client/src/main/java/org/apache/omid/transaction/SnapshotFilterImpl.java --- @@ -181,22 +179,44 @@ public CommitTimestamp

[GitHub] incubator-omid pull request #46: [OMID-90] Integrate omid low latency to pho...

2018-10-10 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/46#discussion_r223993765 --- Diff: tso-server/src/main/java/org/apache/omid/tso/RequestProcessorSkipCT.java --- @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache

[GitHub] incubator-omid pull request #46: [OMID-90] Integrate omid low latency to pho...

2018-10-10 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/46#discussion_r223989230 --- Diff: transaction-client/src/main/java/org/apache/omid/transaction/AbstractTransactionManager.java --- @@ -350,6 +356,43 @@ private void

[GitHub] incubator-omid pull request #46: [OMID-90] Integrate omid low latency to pho...

2018-10-10 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/46#discussion_r223975170 --- Diff: hbase-client/src/main/java/org/apache/omid/transaction/SnapshotFilterImpl.java --- @@ -181,22 +179,44 @@ public CommitTimestamp

[GitHub] incubator-omid pull request #46: [OMID-90] Integrate omid low latency to pho...

2018-10-10 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/46#discussion_r223974621 --- Diff: hbase-client/src/main/java/org/apache/omid/transaction/SnapshotFilterImpl.java --- @@ -181,22 +179,44 @@ public CommitTimestamp

[GitHub] incubator-omid pull request #46: [OMID-90] Integrate omid low latency to pho...

2018-10-10 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/46#discussion_r223971768 --- Diff: hbase-client/src/main/java/org/apache/omid/transaction/SnapshotFilterImpl.java --- @@ -181,22 +179,44 @@ public CommitTimestamp

[GitHub] incubator-omid issue #43: [OMID-110]

2018-09-16 Thread ohadshacham
Github user ohadshacham commented on the issue: https://github.com/apache/incubator-omid/pull/43 +1 ---

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206860096 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206861622 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206848753 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/OmidSnapshotFilter.java --- @@ -83,92 +76,97 @@ public void start

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206867892 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206856182 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206857467 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206862264 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206843754 --- Diff: hbase-common/src/main/java/org/apache/omid/transaction/CellUtils.java --- @@ -382,13 +385,16 @@ public int hashCode

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206852241 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-01 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206839768 --- Diff: hbase-client/src/test/java/org/apache/omid/transaction/TestCellUtils.java --- @@ -99,11 +99,11 @@ public void testShadowCellQualifiers

[GitHub] incubator-omid pull request #40: [OMID-106] Delete should use write timestam...

2018-08-01 Thread ohadshacham
Github user ohadshacham closed the pull request at: https://github.com/apache/incubator-omid/pull/40 ---

[GitHub] incubator-omid pull request #39: [OMID-105] When a tentative family deletion...

2018-07-31 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/39#discussion_r206422618 --- Diff: hbase-client/src/main/java/org/apache/omid/transaction/SnapshotFilterImpl.java --- @@ -395,8 +427,8 @@ private Get createPendingGet

[GitHub] incubator-omid pull request #39: [OMID-105] When a tentative family deletion...

2018-07-31 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/39#discussion_r206422025 --- Diff: hbase-client/src/main/java/org/apache/omid/transaction/SnapshotFilterImpl.java --- @@ -298,26 +291,62 @@ public CommitTimestamp

[GitHub] incubator-omid pull request #36: [OMID-72] bug fix, accessed tables should b...

2018-06-05 Thread ohadshacham
Github user ohadshacham closed the pull request at: https://github.com/apache/incubator-omid/pull/36 ---

[GitHub] incubator-omid pull request #36: [OMID-72] bug fix, accessed tables should b...

2018-06-03 Thread ohadshacham
GitHub user ohadshacham opened a pull request: https://github.com/apache/incubator-omid/pull/36 [OMID-72] bug fix, accessed tables should be sent to transaction mana… …ger also for conflict free writes. This is because fences should also force conflict free transactions

[GitHub] incubator-omid pull request #35: [OMID-100] James Taylor's patch to: https:/...

2018-06-03 Thread ohadshacham
Github user ohadshacham closed the pull request at: https://github.com/apache/incubator-omid/pull/35 ---

[GitHub] incubator-omid pull request #34: [OMID-99] change TestNG version to 6.10.

2018-05-22 Thread ohadshacham
GitHub user ohadshacham opened a pull request: https://github.com/apache/incubator-omid/pull/34 [OMID-99] change TestNG version to 6.10. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ohadshacham/incubator-omid OMID-99

[GitHub] incubator-omid pull request #33: [OMID-98] Adding license headers to default...

2018-05-01 Thread ohadshacham
Github user ohadshacham closed the pull request at: https://github.com/apache/incubator-omid/pull/33 ---

[GitHub] incubator-omid pull request #29: [OMID-44] Since YCSB files are includes in ...

2018-04-29 Thread ohadshacham
GitHub user ohadshacham reopened a pull request: https://github.com/apache/incubator-omid/pull/29 [OMID-44] Since YCSB files are includes in OMID a reference in Yahoo … …is needed in the NOTICE file. Subject raised at: https://lists.apache.org/thread.html

[GitHub] incubator-omid pull request #32: [OMID-97] New MacBooks include a TouchBar. ...

2018-04-29 Thread ohadshacham
Github user ohadshacham closed the pull request at: https://github.com/apache/incubator-omid/pull/32 ---

[GitHub] incubator-omid pull request #33: [OMID-98] Adding license headers to default...

2018-04-29 Thread ohadshacham
GitHub user ohadshacham opened a pull request: https://github.com/apache/incubator-omid/pull/33 [OMID-98] Adding license headers to default-omid-server-configuration… ….yml and default-tso-server-benchmark-config.yml. You can merge this pull request into a Git repository

[GitHub] incubator-omid pull request #32: [OMID-97] New MacBooks include a TouchBar. ...

2018-04-24 Thread ohadshacham
GitHub user ohadshacham opened a pull request: https://github.com/apache/incubator-omid/pull/32 [OMID-97] New MacBooks include a TouchBar. This touch bar has a usb l… …ink that called iBridge. When choosing a network interface Omid accidentally chooses this iBridge instead

[GitHub] incubator-omid pull request #31: [OMID-96] Enable compactor on all column fa...

2018-04-03 Thread ohadshacham
Github user ohadshacham closed the pull request at: https://github.com/apache/incubator-omid/pull/31 ---

[GitHub] incubator-omid pull request #30: [OMID-95] Set hbase-1 as the default compil...

2018-04-03 Thread ohadshacham
Github user ohadshacham closed the pull request at: https://github.com/apache/incubator-omid/pull/30 ---

[GitHub] incubator-omid pull request #29: [OMID-44] Since YCSB files are includes in ...

2018-04-03 Thread ohadshacham
Github user ohadshacham closed the pull request at: https://github.com/apache/incubator-omid/pull/29 ---

[GitHub] incubator-omid pull request #29: [OMID-44] Since YCSB files are includes in ...

2018-03-26 Thread ohadshacham
GitHub user ohadshacham opened a pull request: https://github.com/apache/incubator-omid/pull/29 [OMID-44] Since YCSB files are includes in OMID a reference in Yahoo … …is needed in the NOTICE file. Subject raised at: https://lists.apache.org/thread.html

[GitHub] incubator-omid pull request #30: [OMID-95] Set hbase-1 as the default compil...

2018-03-26 Thread ohadshacham
GitHub user ohadshacham opened a pull request: https://github.com/apache/incubator-omid/pull/30 [OMID-95] Set hbase-1 as the default compilation profile You can merge this pull request into a Git repository by running: $ git pull https://github.com/ohadshacham/incubator-omid

[GitHub] incubator-omid pull request #31: [OMID-96] Enable compactor on all column fa...

2018-03-26 Thread ohadshacham
GitHub user ohadshacham opened a pull request: https://github.com/apache/incubator-omid/pull/31 [OMID-96] Enable compactor on all column families during initializati… …on. This comes in addition to the option of marking each column family using HBase metadata. You can merge

[GitHub] incubator-omid pull request #25: [OMID-93] mark mutation as committed

2018-03-22 Thread ohadshacham
Github user ohadshacham closed the pull request at: https://github.com/apache/incubator-omid/pull/25 ---

[GitHub] incubator-omid pull request #26: A bug fix in [OMID-74].

2018-03-22 Thread ohadshacham
Github user ohadshacham closed the pull request at: https://github.com/apache/incubator-omid/pull/26 ---

[GitHub] incubator-omid pull request #28: [OMID-94] Tune Omid for Phoenix testing env...

2018-03-19 Thread ohadshacham
GitHub user ohadshacham opened a pull request: https://github.com/apache/incubator-omid/pull/28 [OMID-94] Tune Omid for Phoenix testing environment. This commit changes visibility of several function in order to run Omid in testing mode from Phoenix testing environment. You can

[GitHub] incubator-omid pull request #26: A bug fix in [OMID-74].

2018-03-15 Thread ohadshacham
GitHub user ohadshacham opened a pull request: https://github.com/apache/incubator-omid/pull/26 A bug fix in [OMID-74]. The update of the write set is incorrect since the family deletion qualifier needs to be added instead of a row marker. Therefore, this commit fixes this case

[GitHub] incubator-omid pull request #27: reopen [OMID-70] in order to bind WorldCloc...

2018-03-15 Thread ohadshacham
GitHub user ohadshacham opened a pull request: https://github.com/apache/incubator-omid/pull/27 reopen [OMID-70] in order to bind WorldClockOracleImpl in TSOMockModule. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ohadshacham

[GitHub] incubator-omid pull request #25: [OMID-93] mark mutation as committed

2018-03-13 Thread ohadshacham
GitHub user ohadshacham opened a pull request: https://github.com/apache/incubator-omid/pull/25 [OMID-93] mark mutation as committed This pull request adds an option to add commit metadata (shadow cells) to an existing mutation. This feature is required by Apache Phoenix both

[GitHub] incubator-omid pull request #24: [OMID-92] Add Apache Rat to the build proce...

2018-03-13 Thread ohadshacham
Github user ohadshacham closed the pull request at: https://github.com/apache/incubator-omid/pull/24 ---

[GitHub] incubator-omid pull request #24: [OMID-92] Add Apache Rat to the build proce...

2018-03-12 Thread ohadshacham
GitHub user ohadshacham opened a pull request: https://github.com/apache/incubator-omid/pull/24 [OMID-92] Add Apache Rat to the build process and align code with Rat… …'s requirement. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-omid pull request #23: [OMID-89] Fix metrics in Persistence proces...

2018-02-13 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/23#discussion_r167857492 --- Diff: tso-server/src/test/java/org/apache/omid/tso/TestPersistenceProcessorHandler.java --- @@ -126,6 +126,36 @@ void afterMethod

[GitHub] incubator-omid pull request #17: [OMID-83] Attributes added to Put, Get, and...

2018-02-07 Thread ohadshacham
Github user ohadshacham closed the pull request at: https://github.com/apache/incubator-omid/pull/17 ---

[GitHub] incubator-omid pull request #20: [OMID-85] Writing directly to HBase using s...

2018-02-07 Thread ohadshacham
Github user ohadshacham closed the pull request at: https://github.com/apache/incubator-omid/pull/20 ---

[GitHub] incubator-omid pull request #20: [OMID-85] Writing directly to HBase using s...

2018-02-01 Thread ohadshacham
GitHub user ohadshacham opened a pull request: https://github.com/apache/incubator-omid/pull/20 [OMID-85] Writing directly to HBase using specific version marks the … …write as a write that was done by a specific transaction. However, due to lack of shadow cells

[GitHub] incubator-omid pull request #19: [OMID-84] Today, all the writes done by a t...

2018-02-01 Thread ohadshacham
GitHub user ohadshacham opened a pull request: https://github.com/apache/incubator-omid/pull/19 [OMID-84] Today, all the writes done by a transaction are taking part… … in conflict analysis. The purpose of this feature is to let the user decide for each write, whether it should

[GitHub] incubator-omid pull request #17: [OMID-83] Attributes added to Put, Get, and...

2017-12-19 Thread ohadshacham
GitHub user ohadshacham opened a pull request: https://github.com/apache/incubator-omid/pull/17 [OMID-83] Attributes added to Put, Get, and Scan are not propagated t… …o HBase. In many cases, as in the Phoenix case, these attributes are required and should be propagated

[GitHub] incubator-omid pull request #16: [OMID-78] Identify transaction snapshot at ...

2017-12-05 Thread ohadshacham
Github user ohadshacham closed the pull request at: https://github.com/apache/incubator-omid/pull/16 ---

[GitHub] incubator-omid pull request #16: [OMID-78] Identify transaction snapshot at ...

2017-11-14 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/16#discussion_r150795077 --- Diff: hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/regionserver/RegionAccessWrapper.java --- @@ -0,0 +1,58

[GitHub] incubator-omid pull request #16: [OMID-78] Identify transaction snapshot at ...

2017-11-14 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/16#discussion_r150794291 --- Diff: hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/regionserver/OmidRegionScanner.java --- @@ -0,0 +1,128

[GitHub] incubator-omid pull request #16: [OMID-78] Identify transaction snapshot at ...

2017-11-14 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/16#discussion_r150794375 --- Diff: hbase-client/src/main/java/org/apache/omid/transaction/HTableAccessWrapper.java --- @@ -0,0 +1,53 @@ +/* + * Licensed

[GitHub] incubator-omid pull request #16: [OMID-78] Identify transaction snapshot at ...

2017-11-14 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/16#discussion_r150794314 --- Diff: hbase-coprocessor/src/main/java/org/apache/hadoop/hbase/regionserver/OmidRegionScanner.java --- @@ -0,0 +1,128

[GitHub] incubator-omid pull request #13: [OMID-74] Efficient column family deletion ...

2017-08-02 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/13#discussion_r130809257 --- Diff: hbase-client/src/main/java/org/apache/omid/transaction/TTable.java --- @@ -396,20 +443,48 @@ public ResultScanner getScanner

[GitHub] incubator-omid pull request #13: [OMID-74] Efficient column family deletion ...

2017-08-02 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/13#discussion_r130805885 --- Diff: hbase-client/src/main/java/org/apache/omid/transaction/TTable.java --- @@ -228,21 +261,12 @@ public void delete(Transaction tx, Delete

[GitHub] incubator-omid pull request #13: [OMID-74] Efficient column family deletion ...

2017-07-27 Thread ohadshacham
GitHub user ohadshacham opened a pull request: https://github.com/apache/incubator-omid/pull/13 [OMID-74] Efficient column family deletion in Row level conflict analysis The idea is to use a qualifier to denote that all the columns of a specific family were deleted. Current