---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69916/#review212639
---
Ship it!
Ship It!
- András Piros
On Feb. 7, 2019, 3:48 p.m
eview comment to
clean up.
- András Piros
On Feb. 7, 2019, 3:48 p.m., Andras Salamon wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
tps://reviews.apache.org/r/69916/#comment298446>
Why do we need `AtomicBoolean` here?
- András Piros
On Feb. 7, 2019, 12:40 p.m., Andras Salamon wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69657/#review211827
---
Ship it!
Ship It!
- András Piros
On Jan. 10, 2019, 1:26 p.m
(patched)
<https://reviews.apache.org/r/69657/#comment297092>
Please provide a more descriptive name.
core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java
Line 3648 (original), 1219 (patched)
<https://reviews.apache.org/r/69657/#comment297093>
Please provide a more
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69594/#review211601
---
Ship it!
Ship It!
- András Piros
On Dec. 27, 2018, 3:13 p.m
t;
Can we express it JDK7-like? Maybe using [Guava's
`Function`](https://github.com/google/guava/wiki/FunctionalExplained)?
- András Piros
On Dec. 21, 2018, 3:17 p.m., Andras Salamon wrote:
>
>
java/org/apache/oozie/command/TestPurgeXCommand.java
Lines 2925 (patched)
<https://reviews.apache.org/r/69594/#comment296651>
Please give a more descriptive test method name.
- András Piros
On Dec. 19, 2018, 9:57 a.m., Andras Salamon wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69330/#review211036
---
Ship it!
Ship It!
- András Piros
On Dec. 4, 2018, 5:29 p.m
/org/apache/oozie/servlet/TestV2JobServlet.java
bacfe89bb3d836da1f6e559fa68a5bf4db970b09
Diff: https://reviews.apache.org/r/69492/diff/2/
Changes: https://reviews.apache.org/r/69492/diff/1-2/
Testing
---
Introduced new unit test class `TestCoordOldInputDependency`.
Thanks,
András
443 (original), 444-447 (patched)
> > <https://reviews.apache.org/r/69492/diff/1/?file=2111274#file2111274line445>
> >
> > This code (GET) appears multiple times. Could you extract it to a
> > method?
It's not part of the changed code.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69408/#review210997
---
Ship it!
Ship It!
- András Piros
On Nov. 30, 2018, 4:04 p.m
Diff: https://reviews.apache.org/r/69492/diff/1/
Testing
---
Introduced new unit test class `TestCoordOldInputDependency`.
Thanks,
András Piros
ched)
<https://reviews.apache.org/r/69469/#comment295763>
Typo in variable name. What about instead: `final long now = ...`
- András Piros
On Nov. 28, 2018, 11:56 a.m., zhang junfan wrote:
>
> ---
> This is an automatically genera
vlet/TestAuthFilterAuthOozieClient.java
Lines 368 (patched)
<https://reviews.apache.org/r/69330/#comment295760>
Assertion message.
- András Piros
On Nov. 28, 2018, 12:15 p.m., zhang junfan wrote:
>
> ---
> This is an auto
/src/test/java/org/apache/oozie/util/TestBufferDrainer.java
Lines 330 (patched)
<https://reviews.apache.org/r/69408/#comment295647>
`String.startsWith()`
core/src/test/java/org/apache/oozie/util/TestBufferDrainer.java
Lines 332 (patched)
<https:
intainers, or both?
core/src/test/java/org/apache/oozie/servlet/TestAuthFilterAuthOozieClient.java
Lines 312-336 (patched)
<https://reviews.apache.org/r/69330/#comment295444>
Can you please:
* extract to separate test method
* provide assertion messages
- András Piro
-CREATION
Diff: https://reviews.apache.org/r/69348/diff/2/
Changes: https://reviews.apache.org/r/69348/diff/1-2/
Testing
---
`TestCoordELFunctions`
Thanks,
András Piros
Diff: https://reviews.apache.org/r/69348/diff/1/
Testing
---
`TestCoordELFunctions`
Thanks,
András Piros
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69252/#review210346
---
Ship it!
Ship It!
- András Piros
On Nov. 6, 2018, 9 a.m
/TestCoordActionStartXCommand.java
Lines 238 (patched)
<https://reviews.apache.org/r/69252/#comment294991>
Isn't a `Map` better?
- András Piros
On Nov. 5, 2018, 12:58 p.m., Andras Salamon wrote:
>
> ---
> This is an automatica
021622277f67281c396988a139ae4dc92e135bbe
Diff: https://reviews.apache.org/r/69251/diff/1/
Testing
---
```
mvn clean install -DskipTests -Denforcer.skip=true -Dcheckstyle.skip=true
-Dfindbugs.skip=true -PgenerateDocs
```
Thanks,
András Piros
9b0e263bf2d9fb796bc26d50d16f72237c24baad
docs/src/site/markdown/WebServicesAPI.md
7cf62e5416c8198f5d3871d0adb812a10fc02011
Diff: https://reviews.apache.org/r/69250/diff/1/
Testing
---
`TestGraphGenerator` methods modified.
Thanks,
András Piros
abc7c9fb9262646887e8a7cc6fcb9785d7a12c0d
Diff: https://reviews.apache.org/r/68909/diff/1/
Testing
---
Thanks,
András Piros
/diff/1/
Testing
---
`TestGraphMapping#testMappingGraphFromWorkflow()` extended to cover.
Thanks,
András Piros
sting
---
New test cases / classes added:
* `TestJavaActionExecutor`
* `TestBytesAndUOMConverter`
* `TestLastParameterValueExtractor`
Thanks,
András Piros
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68737/#review208799
---
On Sept. 20, 2018, 2:27 p.m., András Piros wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68783/#review208839
---
Ship it!
Ship It!
- András Piros
On Sept. 20, 2018, 1:53
/TestLastParameterValueExtractor.java
PRE-CREATION
Diff: https://reviews.apache.org/r/68737/diff/5/
Changes: https://reviews.apache.org/r/68737/diff/4-5/
Testing
---
New test cases / classes added:
* `TestJavaActionExecutor`
* `TestBytesAndUOMConverter`
* `TestLastParameterValueExtractor`
Thanks,
András Piros
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68140/#review208795
---
Ship it!
Ship It!
- András Piros
On Sept. 19, 2018, 4:07
:
* `TestJavaActionExecutor`
* `TestBytesAndUOMConverter`
* `TestLastParameterValueExtractor`
Thanks,
András Piros
`
* `TestBytesAndUOMConverter`
* `TestLastParameterValueExtractor`
Thanks,
András Piros
pt string concatenation.
webapp/src/main/webapp/console/sla/js/oozie-sla.js
Line 54 (original), 54 (patched)
<https://reviews.apache.org/r/68140/#comment292854>
Please insert spaces around Javascript string concatenation.
- András Piros
On Sept. 18, 2018, 7:46 a.m., Andras Salamon wr
Diff: https://reviews.apache.org/r/68737/diff/2/
Changes: https://reviews.apache.org/r/68737/diff/1-2/
Testing
---
New test cases / classes added:
* `TestJavaActionExecutor`
* `TestBytesAndUOMConverter`
* `TestLastParameterValueExtractor`
Thanks,
András Piros
/TestLastParameterValueExtractor.java
PRE-CREATION
Diff: https://reviews.apache.org/r/68737/diff/1/
Testing
---
New test cases / classes added:
* `TestJavaActionExecutor`
* `TestBytesAndUOMConverter`
* `TestLastParameterValueExtractor`
Thanks,
András Piros
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68628/#review208626
---
Ship it!
Ship It!
- András Piros
On Sept. 13, 2018, 12:34
nd `oozie.pig.script.params.n`
docs/src/site/twiki/WebServicesAPI.twiki
Lines 1433 (patched)
<https://reviews.apache.org/r/68628/#comment292584>
Markdown: remove `` within `scope=\`
docs/src/site/twiki/WebServicesAPI.twiki
Lines 1632 (patched)
<https://reviews.apache.org/r/68628/#
t;
html
docs/src/site/twiki/DG_HCatalogIntegration.twiki
Line 14 (original), 14 (patched)
<https://reviews.apache.org/r/68628/#comment292492>
html
docs/src/site/twiki/DG_ShellActionExtension.twiki
Lines 224-226 (original), 229-231 (patched)
<https://reviews.apache.org/r/686
real cluster, plus added test cases to
`TestMapReduceActionExecutor` and new test classes.
Thanks,
András Piros
html
docs/src/site/twiki/CoordinatorFunctionalSpec.twiki
Line 3630 (original), 3751 (patched)
<https://reviews.apache.org/r/68628/#comment292432>
html
- András Piros
On Sept. 5, 2018, 10 a.m., Andras Salamon wrote:
>
> -
cluster, plus added test cases to
`TestMapReduceActionExecutor` and new test classes.
Thanks,
András Piros
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68237/#review208426
---
On Sept. 6, 2018, 3:59 p.m., András Piros wrote:
>
&
. Used
`Iterables#transform()` and `Ordering#max()` for clarity.
core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java
Lines 647-657 (patched)
<https://reviews.apache.org/r/68237/#comment292367>
Yes. Added Javadoc to make it clearer.
- András Piros
On Sept. 6
es to
`TestMapReduceActionExecutor` and new test classes.
Thanks,
András Piros
/#comment292228>
html
docs/src/site/twiki/AG_Install.twiki
Line 1131 (original), 1177 (patched)
<https://reviews.apache.org/r/68628/#comment292229>
html
docs/src/site/twiki/AG_Install.twiki
Line 1200 (original), 1249 (patched)
<https://reviews.apache.org/r/68628/#comment292
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67885/#review208313
---
Ship it!
Ship It!
- András Piros
On Sept. 4, 2018, 3:45 p.m
the`
core/src/test/java/org/apache/oozie/service/TestAsyncXCommandExecutor.java
Lines 75 (patched)
<https://reviews.apache.org/r/67885/#comment292143>
Remove newline
- András Piros
On Sept. 4, 2018, 12:05 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68505/#review208163
-------
On Aug. 31, 2018, 9:50 a.m., András Piros wrote:
>
>
es 175 (patched)
<https://reviews.apache.org/r/68140/#comment292134>
Login name? First / last name?
docs/src/site/twiki/DG_SLAMonitoring.twiki
Lines 176-182 (patched)
<https://reviews.apache.org/r/68140/#comment292135>
Any checks between start and end times
://reviews.apache.org/r/68237/diff/8/
Testing (updated)
---
Tested on a real cluster, plus added test cases to
`TestMapReduceActionExecutor` and new test classes.
Thanks,
András Piros
from
`ActionExecutorTestCase#startWorkflowAndFailChildMRJob()`.
Thanks,
András Piros
MRJob()`.
Thanks,
András Piros
ns
where different application IDs are read with different cluster startup times.
- András
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68237/#review208130
---
On Aug. 24, 2018, 2:18 p.m., Andr
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68505/#review208163
---
On Aug. 31, 2018, 9:50 a.m., András Piros wrote:
>
>
on the work Clay B. has done in previous patchsets till
[OOZIE-2877.014-3.patch](https://issues.apache.org/jira/secure/attachment/12934336/OOZIE-2877.014-3.patch).
Thanks,
András Piros
Oozie server w/ pseudo-distributed Hadoop.
Based on the work Clay B. has done in previous patchsets till
[OOZIE-2877.014-3.patch](https://issues.apache.org/jira/secure/attachment/12934336/OOZIE-2877.014-3.patch).
Thanks,
András Piros
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68517/#review208093
---
Ship it!
Ship It!
- András Piros
On Aug. 27, 2018, 2:45 p.m
://issues.apache.org/jira/secure/attachment/12934336/OOZIE-2877.014-3.patch).
Thanks,
András Piros
> On May 30, 2017, 11:08 a.m., András Piros wrote:
> > sharelib/git/src/test/java/org/apache/oozie/action/hadoop/TestIntegrationGitActionExecutor.java
> > Lines 60 (patched)
> > <https://reviews.apache.org/r/59620/diff/1/?file=1734071#file1734071line60>
> >
>
-
On Aug. 3, 2018, 10 p.m., Clay B. wrote:
>
> -------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59620/
>
- András
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59620/#review206939
---
On Aug. 3, 2018, 10 p.m., Clay B. wrote:
>
> -
#review204323
---
On Aug. 3, 2018, 10 p.m., Clay B. wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59620/
> ------
.org/r/59620/#review206974
---
On Aug. 3, 2018, 10 p.m., Clay B. wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apac
s://reviews.apache.org/r/59620/#review205636
---
On Aug. 3, 2018, 10 p.m., Clay B. wrote:
>
> -------
> This is an automatically generated e-mail. To reply, visit:
> https:
MRJob()`.
Thanks,
András Piros
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68467/#review207883
---
Ship it!
Ship It!
- András Piros
On Aug. 24, 2018, 1:36 p.m
to be placed to the end of the previous line
webapp/src/main/webapp/console/sla/css/oozie-sla.css
Line 45 (original), 45 (patched)
<https://reviews.apache.org/r/68140/#comment291494>
Did you test that on a pseudo-distributed Oozie?
webapp/src/main/webapp/console/sla/js/oozie-sla.js
Line
/reviews.apache.org/r/68140/#comment291123>
Can be `final`
core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetForFilterJPAExecutor.java
Lines 55-70 (patched)
<https://reviews.apache.org/r/68140/#comment291124>
Can be `static`
- András Piros
On Aug. 23, 2
ectly from
`ActionExecutorTestCase#startWorkflowAndFailChildMRJob()`.
Thanks,
András Piros
s://reviews.apache.org/r/68237/#review207853
-------
On Aug. 23, 2018, 6:36 p.m., András Piros wrote:
>
> ---
> This is an automatically generated e-mail.
#submit()` - apparently no YARN child
application is created. Please advise what's the best way to advance, maybe
call `JobClient#submitJob()` directly from
`ActionExecutorTestCase#startWorkflowAndFailChildMRJob()`.
Thanks,
András Piros
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68482/#review207813
---
Ship it!
Ship It!
- András Piros
On Aug. 23, 2018, 7:04 a.m
es 540-542 (patched)
<https://reviews.apache.org/r/68411/#comment291249>
Why do we need this at all? Why not rely on `tearDown()` instead?
- András Piros
On Aug. 17, 2018, 1:36 p.m., Andras Salamon wrote:
>
> ---
> Thi
67/#comment291246>
Would assert with `String` constants instead of existing `enum` values.
tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java
Line 762 (original), 753 (patched)
<https://reviews.apache.org/r/68467/#comment291247>
Nice :)
- Andr
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68438/#review207658
---
Ship it!
Ship It!
- András Piros
On Aug. 21, 2018, 10:18
from
`ActionExecutorTestCase#startWorkflowAndFailChildMRJob()`.
Thanks,
András Piros
what's the best way to advance, maybe
call `JobClient#submitJob()` directly from
`ActionExecutorTestCase#startWorkflowAndFailChildMRJob()`.
Thanks,
András Piros
281>
Dead code.
core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java
Lines 1075 (patched)
<https://reviews.apache.org/r/67885/#comment290286>
Better use `taskCount / 3`.
- András Piros
On Aug. 6, 2018, 3:28 p.m., Peter Bacsko wrote:
>
> --
from
`ActionExecutorTestCase#startWorkflowAndFailChildMRJob()`.
Thanks,
András Piros
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67999/#review207018
---
Ship it!
Ship It!
- András Piros
On Aug. 9, 2018, 8:11 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68255/#review206973
---
Ship it!
Ship It!
- András Piros
On Aug. 8, 2018, 9:15 a.m
710-711 (patched)
<https://reviews.apache.org/r/68255/#comment290120>
Any other way to refactor?
- András Piros
On Aug. 7, 2018, 12:54 p.m., Andras Salamon wrote:
>
> ---
> This is an automatically generated
using `OozieClient#submit()` - apparently no YARN child
application is created. Please advise what's the best way to advance, maybe
call `JobClient#submitJob()` directly from
`ActionExecutorTestCase#startWorkflowAndFailChildMRJob()`.
Thanks,
András Piros
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68180/#review206881
---
Ship it!
Ship It!
- András Piros
On Aug. 6, 2018, 12:21 p.m
atched)
<https://reviews.apache.org/r/68140/#comment290003>
Any chance to restructure? Too many `if-then-else` without providing
readable code.
webapp/src/main/webapp/console/sla/js/oozie-sla.js
Lines 30-35 (original), 30-54 (patched)
<https://reviews.ap
ws.apache.org/r/68180/#comment289981>
Please use telling assertion error messages.
- András Piros
On Aug. 6, 2018, 8:57 a.m., Daniel Becker wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
atched)
<https://reviews.apache.org/r/68180/#comment289927>
Apache 2.0 license header missing.
examples/src/test/java/org/apache/oozie/example/TestDateList.java
Lines 27 (patched)
<https://reviews.apache.org/r/68180/#comment289926>
Neat :)
- András Piros
On Aug. 3, 2018,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68102/#review206741
---
Ship it!
Ship It!
- András Piros
On Aug. 1, 2018, 1:44 p.m
an be `final`.
- András Piros
On Aug. 1, 2018, 9:59 a.m., Kinga Marton wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68102/#review206740
---
Ship it!
Ship It!
- András Piros
On Aug. 1, 2018, 9:59 a.m
/TestShareLibService.java
Lines 1052 (patched)
<https://reviews.apache.org/r/67999/#comment289729>
Nice catch!
- András Piros
On July 20, 2018, 11 a.m., Denes Bodo wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68008/#review206650
---
Ship it!
Ship It!
- András Piros
On July 22, 2018, 1:16 p.m
69 (original), 103 (patched)
<https://reviews.apache.org/r/67834/#comment289609>
Please provide more context to the assertion error message.
- András Piros
On July 25, 2018, 8:48 a.m., Kinga Marton wrote:
>
> ---
> This is an automa
static class SubWorkflowActionRunningPredicate
implements Predicate`.
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
Lines 708-712 (patched)
<https://reviews.apache.org/r/68102/#comment289601>
Please use latest schema version `1.0`.
- András Pi
> On July 6, 2018, 1:40 p.m., András Piros wrote:
> > tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java
> > Lines 88 (patched)
> > <https://reviews.apache.org/r/67834/diff/2/?file=2053414#file2053414line88>
> >
> > Problem is we
ment288708>
`message` missing.
tools/src/test/java/org/apache/oozie/tools/diag/IntegrationTestOozieSharelibCLI.java
Lines 147 (patched)
<https://reviews.apache.org/r/67834/#comment288709>
Nice `message` :)
- András Piros
On July 6, 2018, 8:36 a.m., Kinga Marton wrote:
>
> ---
eaning.
- András Piros
On July 3, 2018, 1:30 p.m., Mate Juhasz wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
> On June 20, 2018, 10:56 a.m., András Piros wrote:
> > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutorLibAddition.java
> > Lines 433-441 (patched)
> > <https://reviews.apache.org/r/66656/diff/3/?file=2042344#file2042344line433>
> On June 20, 2018, 10:56 a.m., András Piros wrote:
> > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutorLibAddition.java
> > Lines 433-441 (patched)
> > <https://reviews.apache.org/r/66656/diff/3/?file=2042344#file2042344line433>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67766/#review205634
---
Ship it!
Ship It!
- András Piros
On July 2, 2018, 8:06 a.m
1 - 100 of 371 matches
Mail list logo
