Re: Review Request 17720: OOZIE-1678 HA support for SLA

> On June 16, 2014, 5:59 p.m., Robert Kanter wrote: > > core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java, > > line 139 > > > > > > This can be removed and the similar method you added for the H

Re: Review Request 17720: OOZIE-1678 HA support for SLA

> On June 16, 2014, 5:59 p.m., Robert Kanter wrote: > > core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java, > > line 139 > > > > > > This can be removed and the similar method you added for the H

Re: Review Request 17720: OOZIE-1678 HA support for SLA

> On June 17, 2014, 10:38 p.m., Rohini Palaniswamy wrote: > > Ship It! multipleServerRunning -> isHighlyAvailableMode() as Robert suggested please. - Rohini --- This is an automatically generated e-mail. To reply, visit: https://reviews

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/#review46001 --- Ship it! Ship It! - Rohini Palaniswamy On June 13, 2014, 7:49 a.

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/#review45770 --- core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/ --- (Updated June 13, 2014, 7:49 a.m.) Review request for oozie. Changes ---

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/ --- (Updated June 11, 2014, 8:59 a.m.) Review request for oozie. Changes ---

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/#review45168 --- core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java

Re: Review Request 17720: OOZIE-1678 HA support for SLA

> On May 19, 2014, 10:44 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java, > > line 413 > > > > > > throw new UnSupportedOperationException(). > >

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/ --- (Updated May 31, 2014, 12:26 a.m.) Review request for oozie. Changes ---

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/#review43431 --- core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/ --- (Updated May 16, 2014, 11:46 p.m.) Review request for oozie. Changes ---

Re: Review Request 17720: OOZIE-1678 HA support for SLA

> On May 14, 2014, 4:53 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java, line 127 > > > > > > Shouldn't we be calling slaCalcStatus.acquireLock() instead of calling

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/#review42969 --- Doesn't handle case of removing from historySet. Similar to HCat HA

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/ --- (Updated May 14, 2014, 2:26 a.m.) Review request for oozie. Changes ---

Re: Review Request 17720: OOZIE-1678 HA support for SLA

> On May 13, 2014, 12:44 a.m., Robert Kanter wrote: > > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java, line 374 > > > > > > what happens if multipleServerRunning() gets called by server A when > > i

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/#review42795 --- core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/ --- (Updated May 7, 2014, 4:46 a.m.) Review request for oozie. Changes --- f

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/#review38769 --- core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQue

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/ --- (Updated March 17, 2014, 7:05 p.m.) Review request for oozie. Changes ---

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/#review36721 --- core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/ --- (Updated Feb. 27, 2014, 5:16 p.m.) Review request for oozie. Changes ---

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/ --- (Updated Feb. 25, 2014, 5:10 p.m.) Review request for oozie. Changes ---

Re: Review Request 17720: OOZIE-1678 HA support for SLA

> On Feb. 19, 2014, 11:23 p.m., Mona Chitnis wrote: > > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java, line 659 > > > > > > why "revert"? what are we reverting here? change name if possible i mean b

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/#review34939 --- core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/ --- (Updated Feb. 13, 2014, 9:27 p.m.) Review request for oozie. Changes ---

Re: Review Request 17720: OOZIE-1678 HA support for SLA

> On Feb. 8, 2014, 12:45 a.m., Rohini Palaniswamy wrote: > > This would not work. Need to rethink the approach. > > > > 1) Using zookeeper server index to load pending SLA into memory > > When server 1 starts it will get everything loaded into memory. When > > server 2 starts it will load

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/#review33989 --- This would not work. Need to rethink the approach. 1) Using zookeep

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/ --- (Updated Feb. 7, 2014, 10:17 p.m.) Review request for oozie. Changes ---

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/#review33803 --- core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/#review33709 --- Earlier if I recall correctly, we were doing confirmWithDB() only fo

Re: Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/ --- (Updated Feb. 4, 2014, 8:03 p.m.) Review request for oozie. Changes ---

Review Request 17720: OOZIE-1678 HA support for SLA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/ --- Review request for oozie. Bugs: OOZIE-1678 https://issues.apache.org/jira/b