Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/ --- (Updated Oct. 12, 2017, 5:59 p.m.) Review request for oozie and Robert Kanter.

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/ --- (Updated Oct. 8, 2017, 9:39 p.m.) Review request for oozie and Robert Kanter.

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/ --- (Updated Oct. 8, 2017, 8:08 p.m.) Review request for oozie and Robert Kanter.

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/ --- (Updated Oct. 8, 2017, 10 a.m.) Review request for oozie and Robert Kanter. C

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

> On Oct. 4, 2017, 8:20 a.m., Peter Cseh wrote: > > examples/src/main/apps/java-main/workflow.xml > > Lines 17-20 (original), 17-25 (patched) > > > > > > Is this change intentional? Reverting. - András --

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/#review187224 --- Fix it, then Ship it! Looks great! Just some trivial things.

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/ --- (Updated Oct. 5, 2017, 11:02 a.m.) Review request for oozie and Robert Kanter.

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

> On Oct. 2, 2017, 8:11 p.m., Peter Cseh wrote: > > core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java > > Lines 148 (patched) > > > > > > How is this test testing performance? > > András Piros w

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

> On Oct. 4, 2017, 10:07 a.m., Peter Cseh wrote: > > core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java > > Lines 54-56 (patched) > > > > > > Can this be null? Test case removed. > On Oct. 4, 20

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/#review187077 --- core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/#review187064 --- examples/src/main/apps/java-main/workflow.xml Lines 17-20 (origin

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

> On Oct. 2, 2017, 8:11 p.m., Peter Cseh wrote: > > core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java > > Lines 148 (patched) > > > > > > How is this test testing performance? > > András Piros w

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/ --- (Updated Oct. 3, 2017, 9:05 p.m.) Review request for oozie and Robert Kanter.

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

> On Oct. 2, 2017, 8:11 p.m., Peter Cseh wrote: > > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java > > Lines 365 (patched) > > > > > > UTF-8 This is a `Locale` instance, not an `Encoding`, or a `Strin

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

> On Oct. 3, 2017, 11:12 a.m., Peter Bacsko wrote: > > core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java > > Lines 170-173 (patched) > > > > > > To me this looks weird. We have a single threaded ex

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/#review186944 --- core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.j

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/ --- (Updated Oct. 2, 2017, 9:04 p.m.) Review request for oozie and Robert Kanter.

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

> On Oct. 2, 2017, 6:43 p.m., Peter Cseh wrote: > > core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java > > Lines 202 (patched) > > > > > > UTF-8 This is a `Locale` instance, not an `Encoding`,

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/#review186874 --- core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java Lin

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/#review186863 --- core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java Lin

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/ --- (Updated Oct. 2, 2017, 4:41 p.m.) Review request for oozie and Robert Kanter.

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/ --- (Updated Oct. 2, 2017, 11:59 a.m.) Review request for oozie and Robert Kanter.

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

> On Sept. 18, 2017, 11:39 p.m., Robert Kanter wrote: > > core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java > > Lines 47 (patched) > > > > > > Should we make this configurable via oozie-site? Removed

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/#review185629 --- core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.jav

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/ --- (Updated Sept. 17, 2017, 5:28 p.m.) Review request for oozie and Robert Kanter.

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/ --- (Updated Sept. 17, 2017, 5:17 p.m.) Review request for oozie and Robert Kanter.

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/#review185497 --- core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.jav

Re: Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/#review185498 --- sharelib/oozie/pom.xml Line 59 (original), 59 (patched)

Review Request 62352: OOZIE-2406 Completely rewrite GraphGenerator code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/ --- Review request for oozie and Robert Kanter. Repository: oozie-git Description