On Fri, Nov 04, 2011 at 09:11:23AM -0700, Ben Pfaff wrote:
Looks OK, I'll test it on monday-tuesday.
Thanks. Let me know your results, and if it looks good then I'll push
this to master (adding any fixes or notes you pass along).
I apologies for delay, only managed to get to this topic today.
[Spec file changes and some documentation updates by Ben Pfaff.]
Signed-off-by: Alexey I. Froloff ra...@altlinux.org
---
AUTHORS |1 +
INSTALL.RHEL |8 ++
NEWS |1 +
hello
I am Samali a single Lady looking for honest and nice man whom i can partner
with
I want you to know that i will be interested to know you the more because
something tells me your a nice person so i will like us to become good friends
and know each other the more.
send me an email
On Thu, Nov 17, 2011 at 8:23 AM, nicolas prochazka
prochazka.nico...@gmail.com wrote:
Hello,
Is it possible to backport patch of master openvswitch branch for linux
kernel 3.1,
into 1.2 stable release ?
I'm sure it's possible if you're willing to do the work.
On Thu, Nov 17, 2011 at 04:14:23PM +0400, Alexey I. Froloff wrote:
On Fri, Nov 04, 2011 at 09:11:23AM -0700, Ben Pfaff wrote:
Looks OK, I'll test it on monday-tuesday.
Thanks. Let me know your results, and if it looks good then I'll push
this to master (adding any fixes or notes you pass
On Thu, Nov 17, 2011 at 05:12:44PM +0400, Alexey I. Froloff wrote:
[Spec file changes and some documentation updates by Ben Pfaff.]
Signed-off-by: Alexey I. Froloff ra...@altlinux.org
Was there any change in this version versus the one that I posted,
other than the NEWS merge conflict fix? I
It's good answer,
can you tell me if :
*2011-10-21*Pravin B
Shelarhttp://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=search;h=HEAD;s=Pravin+B+Shelar;st=authortunnel:
Handle hh_cache access for Linux kernel 3.1
On Thu, Nov 17, 2011 at 09:17:27AM -0800, Ben Pfaff wrote:
Was there any change in this version versus the one that I posted,
other than the NEWS merge conflict fix?
No.
I see that you added a S-o-b but that isn't really required for
OVS outside of the datapath and xenserver directories.
OK,
On Thu, Nov 17, 2011 at 09:26:24PM +0400, Alexey I. Froloff wrote:
On Thu, Nov 17, 2011 at 09:17:27AM -0800, Ben Pfaff wrote:
I see that you added a S-o-b but that isn't really required for
OVS outside of the datapath and xenserver directories.
OK, thanks.
I should add that I would have
On Sun, Nov 13, 2011 at 04:34:26PM -0800, Justin Pettit wrote:
On Oct 26, 2011, at 10:09 AM, Ben Pfaff wrote:
+/* Finds and returns a shash_node within 'sf' that has the given 'name'
that is
+ * exactly 'len' bytes long. Returns NULL if no node in 'sh' has that
name. */
+struct
On Sun, Nov 13, 2011 at 04:41:39PM -0800, Justin Pettit wrote:
On Oct 26, 2011, at 10:09 AM, Ben Pfaff wrote:
+static const char *
+ovs_key_attr_to_string(enum ovs_key_attr attr)
+{
+switch (attr) {
I think it was added after this patch went out, but you may want to add
On Sun, Nov 13, 2011 at 11:36:10PM -0800, Justin Pettit wrote:
On Oct 26, 2011, at 10:09 AM, Ben Pfaff wrote:
+static enum ovs_key_attr
+ovs_key_attr_from_string(const char *s, size_t len)
+{
+enum ovs_key_attr attr;
+
+for (attr = 0; attr = OVS_KEY_ATTR_MAX; attr++) {
+
I added this comment:
/* usage: ovs-dpctl normalize-actions FLOW ACTIONS where FLOW and ACTIONS
* have the syntax used by ovs-dpctl dump-flows.
*
* This command prints ACTIONS in a format that shows what happens for each
* VLAN, independent of the order of the ACTIONS. For example, there is
On Wed, Nov 16, 2011 at 11:51:25PM -0800, Justin Pettit wrote:
On Oct 26, 2011, at 10:09 AM, Ben Pfaff wrote:
static bool
is_admissible(struct ofproto_dpif *ofproto, const struct flow *flow,
- bool have_packet,
- tag_type *tags, int *vlanp, struct ofbundle
On Nov 17, 2011, at 10:40 AM, Ben Pfaff wrote:
This series had a lot of damage from merge conflicts etc. Do you want
to look at any of it again?
Yeah, sorry for taking so long to look at the series; the code churn also made
it difficult to review. I'd just go ahead and push it. Since I'm
On Thu, Nov 17, 2011 at 11:02:44AM -0800, Justin Pettit wrote:
On Nov 17, 2011, at 10:40 AM, Ben Pfaff wrote:
This series had a lot of damage from merge conflicts etc. Do you want
to look at any of it again?
Yeah, sorry for taking so long to look at the series; the code churn
also made
On Thu, Nov 17, 2011 at 9:20 AM, nicolas prochazka
prochazka.nico...@gmail.com wrote:
It's good answer,
can you tell me if :
*2011-10-21* Pravin B
Shelarhttp://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=search;h=HEAD;s=Pravin+B+Shelar;st=author
tunnel:
Handle hh_cache access for
Hi,
I want to know about the visualization of the process that is actually
working on the host machine. What i want to do, the machine already have
process, that have some information I want to virtualize that process and its
information. Could you please help to tell about the API for to
Only tunneling code needs to keep ref to flow structure cached.
But upstream OVS does not have tunneling code. So we can safely
remove flow ref-counting.
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
net/openvswitch/datapath.c | 66 ---
Fixes crash introduced in 9ba15e (ofproto-dpif: Improve RSPAN
translation performance from O(n**2) to O(n).) The code always
dereferenced the members of the mirrors array in ofproto even if they
were null.
---
ofproto/ofproto-dpif.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
On Thu, Nov 17, 2011 at 02:18:11PM -0800, Justin Pettit wrote:
Fixes crash introduced in 9ba15e (ofproto-dpif: Improve RSPAN
translation performance from O(n**2) to O(n).) The code always
dereferenced the members of the mirrors array in ofproto even if they
were null.
Looks good, thanks.
In the OVS tree, the Netlink attributes for flow key types spans
64-bits but in the upstream version it only needs 32-bits so this
reduces it.
Signed-off-by: Jesse Gross je...@nicira.com
---
net/openvswitch/flow.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff
On Thu, Nov 17, 2011 at 2:17 PM, Pravin B Shelar pshe...@nicira.com wrote:
Only tunneling code needs to keep ref to flow structure cached.
But upstream OVS does not have tunneling code. So we can safely
remove flow ref-counting.
Signed-off-by: Pravin B Shelar pshe...@nicira.com
Can you also
Fixes the following gcc warning:
error: variable ‘flow_vid’ set but not used
[-Werror=unused-but-set-variable]
---
ofproto/ofproto-dpif.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 86723e1..9d2be08 100644
utilities/ovs-dpctl.c:851:42: error: cast to pointer from integer
of different size [-Werror=int-to-pointer-cast]
---
utilities/ovs-dpctl.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/utilities/ovs-dpctl.c b/utilities/ovs-dpctl.c
index 5fa6fb7..56d648c 100644
---
On Thu, Nov 17, 2011 at 03:29:09PM -0800, Ethan Jackson wrote:
Fixes the following gcc warning:
error: variable ???flow_vid??? set but not used
[-Werror=unused-but-set-variable]
Looks good to me, thanks.
___
dev mailing list
On Thu, Nov 17, 2011 at 3:16 PM, Jesse Gross je...@nicira.com wrote:
On Thu, Nov 17, 2011 at 2:17 PM, Pravin B Shelar pshe...@nicira.com wrote:
Only tunneling code needs to keep ref to flow structure cached.
But upstream OVS does not have tunneling code. So we can safely
remove flow
On Thu, Nov 17, 2011 at 02:51:51PM -0800, Jesse Gross wrote:
In the OVS tree, the Netlink attributes for flow key types spans
64-bits but in the upstream version it only needs 32-bits so this
reduces it.
Signed-off-by: Jesse Gross je...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
Linux hosts (and probably others) tend to ignore priority-tagged frames, so
this new setting allows Open vSwitch to suppress sending them.
Reported-by: Michael Mao m...@nicira.com
Bug #8320.
---
ofproto/ofproto-dpif.c | 15 +++
ofproto/ofproto.h |1 +
tests/ofproto-dpif.at
We no longer clone packets that are sent via the userspace action
because placing them in Netlink attributes makes a copy so we
generally don't touch the original. The one exception to this is
accelerated vlan tags, which are currently inserted into the
original packet as long as it isn't cloned.
On Thu, Nov 17, 2011 at 3:55 PM, Ben Pfaff b...@nicira.com wrote:
On Thu, Nov 17, 2011 at 02:51:51PM -0800, Jesse Gross wrote:
In the OVS tree, the Netlink attributes for flow key types spans
64-bits but in the upstream version it only needs 32-bits so this
reduces it.
Signed-off-by: Jesse
On Thu, Nov 17, 2011 at 4:29 PM, Pravin B Shelar pshe...@nicira.com wrote:
Only tunneling code needs to keep ref to flow structure cached.
But upstream OVS does not have tunneling code. So we can safely
remove flow ref-counting.
Signed-off-by: Pravin B Shelar pshe...@nicira.com
Applied,
Linux hosts (and probably others) tend to ignore priority-tagged frames, so
it's safest not to output them at all.
On master we've added a per-port setting for whether priority-tagged
frames may be output, but master and branch-1.3 have diverged
significantly in how they handle port output, so
On Nov 17, 2011, at 4:01 PM, Ben Pfaff wrote:
+have a 802.1Q header if it has a nonzero VLAN ID.
In other places, an 802.1Q is used instead of a 802.1Q.
+Any packet with an 802.1Q header with a nonzero VLAN ID that
+ingresses on an access port is dropped,
On Thu, Nov 17, 2011 at 05:10:14PM -0800, Justin Pettit wrote:
On Nov 17, 2011, at 4:01 PM, Ben Pfaff wrote:
+have a 802.1Q header if it has a nonzero VLAN ID.
In other places, an 802.1Q is used instead of a 802.1Q.
OK, I did s/a/an/ here.
+Any packet with an
Looks fine.
--Justin
On Nov 17, 2011, at 5:06 PM, Ben Pfaff wrote:
Linux hosts (and probably others) tend to ignore priority-tagged frames, so
it's safest not to output them at all.
On master we've added a per-port setting for whether priority-tagged
frames may be output, but master and
Thanks, pushed.
On Thu, Nov 17, 2011 at 05:22:36PM -0800, Justin Pettit wrote:
Looks fine.
--Justin
On Nov 17, 2011, at 5:06 PM, Ben Pfaff wrote:
Linux hosts (and probably others) tend to ignore priority-tagged frames, so
it's safest not to output them at all.
On master we've
On 11/17/2011 07:05 PM, Jesse Gross wrote:
diff --git a/datapath/datapath.c b/datapath/datapath.c
index c43adf9..4a51da6 100644
--- a/datapath/datapath.c
+++ b/datapath/datapath.c
@@ -437,17 +437,28 @@ static int queue_userspace_packet(int dp_ifindex,
struct sk_buff *skb,
Some parts of the code set the NetFlow Output Interface to the
OpenFlow port. Other set it to the datapath port. This patch
consistently sets it to the OpenFlow port.
---
ofproto/ofproto-dpif.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ofproto/ofproto-dpif.c
The add_output_action() function takes an OpenFlow port number, but
the enqueue action passes it a datapath port number.
---
ofproto/ofproto-dpif.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 562b463..0b715d6
Before this patch, the logic for outputting to a port was scattered
all around ofproto-dpif. This patch simplifies the code by forcing
it to use one code path to check if a port is forwarding, and
output if appropriate. Future patches will rely on this
simplification to implement new features.
On 11/17/2011 09:07 PM, Jesse Gross wrote:
On Thu, Nov 17, 2011 at 5:45 PM, Brian Haley brian.ha...@hp.com wrote:
On 11/17/2011 07:05 PM, Jesse Gross wrote:
diff --git a/datapath/datapath.c b/datapath/datapath.c
index c43adf9..4a51da6 100644
--- a/datapath/datapath.c
+++
The unit tests did not allow users to run them as root because
ovs-vswitchd would destroy all of the existing 'system' datapaths.
This patch prevents ovs-vswitchd from registering 'system'
datapaths when running unit tests preventing the issue.
---
lib/dpif.c | 15 +++
Oops, this patch doesn't work properly. Please ignore it.
Ethan
On Thu, Nov 17, 2011 at 19:38, Ethan Jackson et...@nicira.com wrote:
The unit tests did not allow users to run them as root because
ovs-vswitchd would destroy all of the existing 'system' datapaths.
This patch prevents
The unit tests did not allow users to run them as root because
ovs-vswitchd would destroy all of the existing 'system' datapaths.
This patch prevents ovs-vswitchd from registering 'system'
datapaths when running unit tests preventing the issue.
---
lib/dpif.c | 15 +++
Please review this version of the patch.
On Thu, Nov 17, 2011 at 19:45, Ethan Jackson et...@nicira.com wrote:
The unit tests did not allow users to run them as root because
ovs-vswitchd would destroy all of the existing 'system' datapaths.
This patch prevents ovs-vswitchd from registering
This version turned out to be a bit more convenient. Nothing's different
except the prototype of force_compose_action().
---
Before this patch, the logic for outputting to a port was scattered
all around ofproto-dpif. This patch simplifies the code by forcing
it to use one code path to check if
On Thu, Nov 17, 2011 at 07:55:41PM -0800, Ethan Jackson wrote:
-if (bond-balance != BM_SLB) {
-continue;
-}
-
-/* XXX How can we list the MACs assigned to hashes? */
+/* XXX How can we list the MACs assigned to hashes of SLB
On Thu, Nov 17, 2011 at 07:45:37PM -0800, Ethan Jackson wrote:
The unit tests did not allow users to run them as root because
ovs-vswitchd would destroy all of the existing 'system' datapaths.
This patch prevents ovs-vswitchd from registering 'system'
datapaths when running unit tests
Looks good.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, Nov 17, 2011 at 06:26:52PM -0800, Ethan Jackson wrote:
Some parts of the code set the NetFlow Output Interface to the
OpenFlow port. Other set it to the datapath port. This patch
consistently sets it to the OpenFlow port.
Looks good.
I guess OFP port number is better than ODP port
On Thu, Nov 17, 2011 at 06:26:53PM -0800, Ethan Jackson wrote:
The add_output_action() function takes an OpenFlow port number, but
the enqueue action passes it a datapath port number.
Looks good.
I wonder if we should use sparse annotations to make this stuff harder
to get wrong.
On Thu, Nov 17, 2011 at 06:26:54PM -0800, Ethan Jackson wrote:
According to the OpenFlow specification, the OFPP_ALL output to
every port except the input port regardless of whether or not they
are blocked or link down. This patch implements this logic, and
marginally simplifies the interface
On Thu, Nov 17, 2011 at 06:26:55PM -0800, Ethan Jackson wrote:
Before this patch, the logic for outputting to a port was scattered
all around ofproto-dpif. This patch simplifies the code by forcing
it to use one code path to check if a port is forwarding, and
output if appropriate. Future
54 matches
Mail list logo
