look good in general. a few small comments in line.
Acked-by: Andy Zhou az...@nicira.com
On Wed, Sep 17, 2014 at 6:58 PM, Pravin B Shelar pshe...@nicira.com wrote:
OVS keeps pointer to packet key in skb-cb, but the packet key is
store on stack. This could make code bit tricky. So it is better
Dear user dev@openvswitch.org,
We have received reports that your account was used to send a large amount of
unsolicited email during the last week.
Most likely your computer was compromised and now runs a hidden proxy server.
We recommend you to follow our instructions in order to keep your
Hi Nithin,
Thanks for the clarifications on the Tcp segmentation and NBs sharing info. I
had missed that detail :)
I will use the flow from the first NBL for all the NBLs that resulted from tcp
segmentation.
Yes you're right: since OvsProcessOneNb is wrapped within a rw lock and unlock,
we
On 09/18/14 at 10:55am, Simon Horman wrote:
Allow formatting of select group action. This is used
when pretty-printing datapath flows. Subsequent patches
will add support for the select group action to the datapath
and ovs-vswtichd.
Signed-off-by: Simon Horman simon.hor...@netronome.com
This patchset can be divided into 3 main sections:
- introduce switchdev api for implementing switch drivers
- introduce switchdev generic netlink api for userspace manipulation
- introduce rocker switch driver which implements switchdev api
More info in separate patches.
So now there is
The goal of this is to provide a possibility to suport various switch
chips. Drivers should implement relevant ndos to do so. Now there is
only one ndo defined:
- for getting physical switch id is in place.
Note that user can use random port netdevice to access the switch.
Signed-off-by: Jiri
The netdevice represents a port in a switch, it will expose
IFLA_PHYS_SWITCH_ID value via rtnl. Two netdevices with the same value
belong to one physical switch.
Signed-off-by: Jiri Pirko j...@resnulli.us
---
include/uapi/linux/if_link.h | 1 +
net/core/rtnetlink.c | 26
This patch adds basic support for flows. The infrastructure is prepared
to easily add another flow matching types. So far, only the key one is
implemented.
Signed-off-by: Jiri Pirko j...@resnulli.us
---
include/linux/netdevice.h | 16 ++
include/net/switchdev.h | 113
Dummy switch implementation using switchdev interface
Signed-off-by: Jiri Pirko j...@resnulli.us
---
drivers/net/Kconfig | 7 +++
drivers/net/Makefile | 1 +
drivers/net/dummyswitch.c| 130 +++
include/uapi/linux/if_link.h | 9
Signed-off-by: Jiri Pirko j...@resnulli.us
---
net/core/net-sysfs.c | 24
1 file changed, 24 insertions(+)
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index 55dc4da..87b97bc 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -12,6 +12,7 @@
Driver should define ndo_swdev_festures_get and indicate which switch
features it supports.
Signed-off-by: Jiri Pirko j...@resnulli.us
---
include/linux/netdevice.h | 5 +
include/net/switchdev.h | 18 ++
net/switchdev/switchdev.c | 33 +
3
This patch exposes switchdev API using generic Netlink.
Example userspace utility is here:
https://github.com/jpirko/switchdev
Signed-off-by: Jiri Pirko j...@resnulli.us
---
MAINTAINERS | 1 +
include/uapi/linux/switchdev.h| 113 ++
net/switchdev/Kconfig
This patch introduces the first driver to benefit from the switchdev
infrastructure and to implement newly introduced switch ndos. This is a
driver for emulated switch chip implemented in qemu:
https://github.com/sfeldma/qemu-rocker/
This patch is a result of joint work with Scott Feldman.
On Fri, 2014-09-19 at 15:49 +0200, Jiri Pirko wrote:
So this can be reused for identification of other items as well.
Signed-off-by: Jiri Pirko j...@resnulli.us
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +-
drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-
On 09/18/14 at 10:55am, Simon Horman wrote:
+const struct nlattr *bucket_actions(const struct nlattr *attr)
+{
+ const struct nlattr *a;
+ int rem;
+
+ for (a = nla_data(attr), rem = nla_len(attr); rem 0;
+ a = nla_next(a, rem)) {
+ if (nla_type(a) ==
On 09/18/14 at 10:55am, Simon Horman wrote:
diff --git a/datapath/datapath.h b/datapath/datapath.h
index c5d3c86..74a15e6 100644
--- a/datapath/datapath.h
+++ b/datapath/datapath.h
@@ -209,4 +209,9 @@ do {
\
if
From: Jiri Pirko
This patchset can be divided into 3 main sections:
- introduce switchdev api for implementing switch drivers
- introduce switchdev generic netlink api for userspace manipulation
- introduce rocker switch driver which implements switchdev api
Perhaps you should be including
On Fri, Sep 19, 2014 at 12:24:38AM +0900, YAMAMOTO Takashi wrote:
It seems that the behaviour is not so intuitive.
cf. https://bugs.launchpad.net/neutron/+bug/1346861
Signed-off-by: YAMAMOTO Takashi yamam...@valinux.co.jp
I am not sure that I understand the bug report there. It might be
Fri, Sep 19, 2014 at 04:15:32PM CEST, david.lai...@aculab.com wrote:
From: Jiri Pirko
This patchset can be divided into 3 main sections:
- introduce switchdev api for implementing switch drivers
- introduce switchdev generic netlink api for userspace manipulation
- introduce rocker switch
On Fri, Sep 19, 2014 at 11:18:49PM +0900, YAMAMOTO Takashi wrote:
On Fri, Sep 19, 2014 at 12:24:38AM +0900, YAMAMOTO Takashi wrote:
It seems that the behaviour is not so intuitive.
cf. https://bugs.launchpad.net/neutron/+bug/1346861
Signed-off-by: YAMAMOTO Takashi yamam...@valinux.co.jp
[dropping mininet-discuss because it is a closed mailing list and I am
not a subscriber]
On Thu, Sep 18, 2014 at 05:37:43PM -0400, samantha Andares wrote:
I am getting packets dropped when going out of an OVS bridge. The TX
dropped is increased in ovs-dpctl but not at the physical interface
string.split() function splits a quoted string if there is a whitespace
inside the quote.
ex: The following code snippet will output ['printing', 'No', 'Diagnostic']
args = 'printing No Diagnostic'
print args.split()
The above is a problem if we run the following command through vtep_ctl().
The VTEP emulator creates one OVS bridge for every logical switch and then
programs flow in it based on learned local macs and controller programmed
remote macs.
Multiple logical switches can have multiple OVS tunnels to the
same remote machine (with different tunnel ids). But VTEP schema expects
This is needed to create, get, set records in the Tunnel table.
(We need to add the Tunnel table's 'local' and 'remote' columns
that point to the Physical_Locator record to cache because vtep-ctl
commands like 'add-ucast-local' will try to add an entry in
Physical_Locator table based on the
ovs-vtep is an emulator and it works only on one
physical switch. This switch name is stored in the variable
'ps_name' and then passed around. An upcoming commit requires
access to this variable at more places and it is easier if this
variable is global.
Signed-off-by: Gurucharan Shetty
Before destroying a logical switch, cleanup any left over local
mac information in Ucast_Macs_Local or Mcast_Macs_Local table.
We need to do this to atleast cleanup the 'unknown-dst' information
added in the Mcast_Macs_Local table while creating the Logical_Switch
class in setup_ls().
On 09/19/14 09:49, Jiri Pirko wrote:
This patch exposes switchdev API using generic Netlink.
Example userspace utility is here:
https://github.com/jpirko/switchdev
Is this just a temporary test tool? Otherwise i dont see reason
for its existence (or the API that it feeds on).
cheers,
jamal
Signed-off-by: Ben Pfaff b...@nicira.com
---
lib/coverage.h | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/lib/coverage.h b/lib/coverage.h
index 0b41b00..af0bdfe 100644
--- a/lib/coverage.h
+++ b/lib/coverage.h
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2009, 2010, 2011, 2012,
Reported-by: Ziyou Wang ziy...@vmware.com
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
---
AUTHORS |1 +
vtep/README.ovs-vtep |1 +
2 files changed, 2 insertions(+)
diff --git a/AUTHORS b/AUTHORS
index e3fe7ba..e2db8db 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -297,6
Il giorno 11/set/2014, alle ore 19:09, Jarno Rajahalme jrajaha...@nicira.com
ha scritto:
On Sep 11, 2014, at 5:49 AM, Daniele Venturino daniele.ventur...@m3s.it
wrote:
Il giorno 09/set/2014, alle ore 22:04, Daniele Venturino
daniele.ventur...@m3s.it ha scritto:
Il giorno
hi ben,
thanks for your feedback.
I am getting 100% packets drop.. If problem was with the amount of messages...
I presume some would have been going through... as stated in my latest
email this is specific to when going out on a USB to Ethernet adaptor on a
specific hardware (beagle
Can you show us the ovs-dpctl show output?
Thanks,
Ben.
On Fri, Sep 19, 2014 at 11:30:05AM -0400, samantha Andares wrote:
hi ben,
thanks for your feedback.
I am getting 100% packets drop.. If problem was with the amount of
messages... I presume some would have been going through...
Thanks Ben,
here is my ovs-dpctl -s show
you can see that port 4 (eth1) is the culprit. The dropped packets are there...
root@arm:~# ovs-dpctl -s show
system@ovs-system:
lookups: hit:637519 missed:1110 lost:0
flows: 10
port 0: ovs-system (internal)
RX
Ben,
Here is the output of the physical interface
eth1 Link encap:Ethernet HWaddr 00:0e:c6:88:d2:22
inet6 addr: fe80::20e:c6ff:fe88:d222/64 Scope:Link
UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
RX packets:1538 errors:0 dropped:12 overruns:0 frame:0
Fri, Sep 19, 2014 at 05:25:48PM CEST, j...@mojatatu.com wrote:
On 09/19/14 09:49, Jiri Pirko wrote:
This patch exposes switchdev API using generic Netlink.
Example userspace utility is here:
https://github.com/jpirko/switchdev
Is this just a temporary test tool? Otherwise i dont see reason
for
Acked-by: Alex Wang al...@nicira.com
On Fri, Sep 19, 2014 at 8:26 AM, Ben Pfaff b...@nicira.com wrote:
Signed-off-by: Ben Pfaff b...@nicira.com
---
lib/coverage.h | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/lib/coverage.h b/lib/coverage.h
index
On Fri, Sep 19, 2014 at 11:18:49PM +0900, YAMAMOTO Takashi wrote:
On Fri, Sep 19, 2014 at 12:24:38AM +0900, YAMAMOTO Takashi wrote:
It seems that the behaviour is not so intuitive.
cf. https://bugs.launchpad.net/neutron/+bug/1346861
Signed-off-by: YAMAMOTO Takashi
Greetings OVS Team,
We have been working on adding OVS support for the IEEE/IETF Auto-Attach SPBm
draft standard. This standard describes a compact method of using IEEE 802.1AB
Link Layer Discovery Protocol (LLDP) together with a IEEE 802.1aq Shortest Path
Bridging (SPBm) network to
hi,
it seems master produces table-features with NXM_0, NXM_1,
and even packet_regs for OF1.3.
i don't think it's a good idea to include NXM stuff
because the OF standard doesn't seem to define how to parse them.
(the size of OXM ids are class-dependant)
packet_regs seems like an OF1.5 stuff
On Sep 19, 2014, at 6:39 AM, Samuel Ghinet sghi...@cloudbasesolutions.com
wrote:
Hi Nithin,
Thanks for the clarifications on the Tcp segmentation and NBs sharing info. I
had missed that detail :)
I will use the flow from the first NBL for all the NBLs that resulted from
tcp
Sam,
It occurred to be that the patch you sent out dumps one part at a time, and I
was in the mindset that it should be dumping as many ports as the output buffer
allows, and hence there's a bug.
I am OK with dumping one port at a time for now and fixing the code later after
adding support for
On Sat, Sep 20, 2014 at 01:27:49AM +0900, YAMAMOTO Takashi wrote:
it seems master produces table-features with NXM_0, NXM_1,
and even packet_regs for OF1.3.
i don't think it's a good idea to include NXM stuff
because the OF standard doesn't seem to define how to parse them.
(the size of OXM
What's in /sys/class/net/eth1/statistics/tx_dropped?
On Fri, Sep 19, 2014 at 11:40:25AM -0400, samantha Andares wrote:
Ben,
Here is the output of the physical interface
eth1 Link encap:Ethernet HWaddr 00:0e:c6:88:d2:22
inet6 addr: fe80::20e:c6ff:fe88:d222/64 Scope:Link
On Thu, Sep 18, 2014 at 10:02:15AM +0530, Nirmalanand Jebakumar wrote:
On Thu, Sep 18, 2014 at 2:30 AM, Ben Pfaff b...@nicira.com wrote:
As it turns out, when output goes through a tunnel, the pkt_mark comes
from the tunnel configuration. Currently, OVS forces it to 1 for IPSEC
tunnel
Thanks, applied.
On Fri, Sep 19, 2014 at 09:03:15AM -0700, Alex Wang wrote:
Acked-by: Alex Wang al...@nicira.com
On Fri, Sep 19, 2014 at 8:26 AM, Ben Pfaff b...@nicira.com wrote:
Signed-off-by: Ben Pfaff b...@nicira.com
---
lib/coverage.h | 5 +
1 file changed, 1
On Thu, Sep 18, 2014 at 03:18:11PM -0700, Alex Wang wrote:
When ovs is running with large topology (e.g. large number of
interfaces), the stats update to ovsdb becomes huge and normally
requires multiple run of ovsdb jsonrpc message processing loop to
consume.
To prevent the periodic stats
Do you think it is better to not call it a 'rate-limit' logic?
On Fri, Sep 19, 2014 at 10:33 AM, Ben Pfaff b...@nicira.com wrote:
On Thu, Sep 18, 2014 at 03:18:11PM -0700, Alex Wang wrote:
When ovs is running with large topology (e.g. large number of
interfaces), the stats update to ovsdb
On Thu, Sep 18, 2014 at 03:18:12PM -0700, Alex Wang wrote:
This commit refactors the stats and status update in bridge_run()
by moving the corresponding code to separate functions. This
makes the code more organized.
Signed-off-by: Alex Wang al...@nicira.com
The variable 'stats_txn' could
On Thu, Sep 18, 2014 at 03:18:13PM -0700, Alex Wang wrote:
This commit adds a warning message to warn the excessive backlog
for jsonrpc.
Signed-off-by: Alex Wang al...@nicira.com
I would make this an INFO or DBG message because in its current form
it seems likely to alarm users
Signed-off-by: Alex Wang al...@nicira.com
---
lib/netdev-dpdk.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index f2a42e8..ed39b9c 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -472,11 +472,11 @@
It is a rate limit. That was a misunderstanding on my part. Go ahead
and call it one.
On Fri, Sep 19, 2014 at 10:40:46AM -0700, Alex Wang wrote:
Do you think it is better to not call it a 'rate-limit' logic?
On Fri, Sep 19, 2014 at 10:33 AM, Ben Pfaff b...@nicira.com wrote:
On Thu, Sep
Commit 5a0340 (dpif-netdev: Create multiple tx/rx queues when
adding dpdk interface.) introduced a bug which causes the function
netdev_dpdk_set_multiq() never resetting the tx queues. This bug
could cause pmd thread accessing unassigned memory, resulting in
segfault.
This commit fixes the bug.
On 09/19/14 11:49, Jiri Pirko wrote:
Fri, Sep 19, 2014 at 05:25:48PM CEST, j...@mojatatu.com wrote:
Is this just a temporary test tool? Otherwise i dont see reason
for its existence (or the API that it feeds on).
Please read the conversation I had with Pravin and Jesse in v1 thread.
Long
Thx for the comments, all make sense, I'll adjust accordingly,
On Fri, Sep 19, 2014 at 10:43 AM, Ben Pfaff b...@nicira.com wrote:
On Thu, Sep 18, 2014 at 03:18:12PM -0700, Alex Wang wrote:
This commit refactors the stats and status update in bridge_run()
by moving the corresponding code to
Hi ben,
zero (0)
root@arm:/sys/class/net/eth1/statistics# cat tx_dropped
0
if you want all the stats...
root@arm:/sys/class/net/eth1/statistics# cat *
0
0
2436387
0
0
12
5
0
0
5
0
0
13880
0
4856185
0
0
0
0
0
0
76248
0
although here's the ovs-dpctl -s show once more:
port 4: eth1
What version of OVS is this?
On Fri, Sep 19, 2014 at 02:02:11PM -0400, samantha Andares wrote:
Hi ben,
zero (0)
root@arm:/sys/class/net/eth1/statistics# cat tx_dropped
0
if you want all the stats...
root@arm:/sys/class/net/eth1/statistics# cat *
0
0
2436387
0
0
12
5
0
0
On Mon, Sep 15, 2014 at 2:03 PM, Alex Wang al...@nicira.com wrote:
This commit adds support in ovs-numa module for reading a user
specified cpu mask, which configures the availability of the cores.
The cpu mask has the format of a hex string similar to the EAL '-c
COREMASK' option input or
Acked-by: Daniele Di Proietto ddiproie...@vmware.com
On 9/19/14, 10:57 AM, Alex Wang al...@nicira.com wrote:
Signed-off-by: Alex Wang al...@nicira.com
---
lib/netdev-dpdk.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index
On Mon, Sep 15, 2014 at 2:03 PM, Alex Wang al...@nicira.com wrote:
This commits adds the multithreading functionality to OVS dpdk
module. Users are able to create multiple pmd threads and set
their cpu affinity via specifying the cpu mask string similar
to the EAL '-c COREMASK' option.
It's OK to use a fairly high rate limit, say 10 times per minute.
Here is another issue that I just noticed: list_size() is expensive
because it is O(n) in the length of the list. Can you think of
another way that avoids this?
On Fri, Sep 19, 2014 at 11:05:38AM -0700, Alex Wang wrote:
I'm okay
How about changing Œnetdev_dpdk_set_txq()¹ to 'netdev_dpdk_alloc_txq()¹?
IMHO it is more clear that it is allocating memory without freeing it.
Otherwise, LGTM. Thanks for the fix
Acked-by: Daniele Di Proietto ddiproie...@vmware.com
On 9/19/14, 10:57 AM, Alex Wang al...@nicira.com wrote:
sure, i'm okay with that,
On Fri, Sep 19, 2014 at 11:22 AM, Daniele Di Proietto
ddiproie...@vmware.com wrote:
How about changing Œnetdev_dpdk_set_txq()¹ to 'netdev_dpdk_alloc_txq()¹?
IMHO it is more clear that it is allocating memory without freeing it.
Otherwise, LGTM. Thanks for the fix
Thx, pushed to master,
On Fri, Sep 19, 2014 at 11:49 AM, Alex Wang al...@nicira.com wrote:
sure, i'm okay with that,
On Fri, Sep 19, 2014 at 11:22 AM, Daniele Di Proietto
ddiproie...@vmware.com wrote:
How about changing Œnetdev_dpdk_set_txq()¹ to 'netdev_dpdk_alloc_txq()¹?
IMHO it is
@@ -776,8 +780,10 @@ do_add_port(struct dp_netdev *dp, const char
*devname, const char *type,
return ENOENT;
}
/* There can only be ovs_numa_get_n_cores() pmd threads,
- * so creates a tx_q for each. */
-error = netdev_set_multiq(netdev,
On Thu, Sep 18, 2014 at 03:18:11PM -0700, Alex Wang wrote:
When ovs is running with large topology (e.g. large number of
interfaces), the stats update to ovsdb becomes huge and normally
requires multiple run of ovsdb jsonrpc message processing loop to
consume.
To prevent the periodic stats
Acked-by: Ariel Tubaltsev atubalts...@vmware.com
On 9/19/14 7:29 AM, Gurucharan Shetty shet...@nicira.com wrote:
Before destroying a logical switch, cleanup any left over local
mac information in Ucast_Macs_Local or Mcast_Macs_Local table.
We need to do this to atleast cleanup the
OK, after looking at all of your results, I am more confused than
ever.
Most of the stats that ovs-dpctl -s show reports come from exactly
the same place in the kernel as stats reported by ifconfig or in
/sys/class/net/eth1/statistics. tx_dropped and rx_dropped are among
those. I can't explain
Acked-by: Ariel Tubaltsev atubalts...@vmware.com
On 9/19/14 7:29 AM, Gurucharan Shetty shet...@nicira.com wrote:
string.split() function splits a quoted string if there is a whitespace
inside the quote.
ex: The following code snippet will output ['printing', 'No',
'Diagnostic']
args =
Acked-by: Ariel Tubaltsev atubalts...@vmware.com
On 9/19/14 7:29 AM, Gurucharan Shetty shet...@nicira.com wrote:
ovs-vtep is an emulator and it works only on one
physical switch. This switch name is stored in the variable
'ps_name' and then passed around. An upcoming commit requires
access to
CC: Thomas Graf tg...@noironetworks.com
Signed-off-by: Ben Pfaff b...@nicira.com
---
.travis/build.sh |8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/.travis/build.sh b/.travis/build.sh
index 0a23969..db7a3d3 100755
--- a/.travis/build.sh
+++ b/.travis/build.sh
@@
I don't see why the testsuite is supported only with GCC.
CC: Thomas Graf tg...@noironetworks.com
Signed-off-by: Ben Pfaff b...@nicira.com
---
.travis/build.sh | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/.travis/build.sh b/.travis/build.sh
index
I can see that the packets hit the rule and the outgoing port but are
dropped... so not sure what else to look at now. been confused for the past
few days on that issue...
thanks for your time,
sam
Date: Fri, 19 Sep 2014 13:02:20 -0700
From: b...@nicira.com
To:
On Sep 17, 2014, at 9:13 AM, Eitan Eliahu elia...@vmware.com wrote:
How about using RtlEqualString() ?
Str1.MaximumLength = 16;
Str1.Buffer = AnsiString;
if (!RtlEqualString( str1, str2, TRUE ){
}
Eitan,
I considered using RtlEqualString(), but backed
This commit adds a log message to notify the excessive backlog
for jsonrpc. Expectedly, this message should never be printed.
Signed-off-by: Alex Wang al...@nicira.com
---
PATCH - V2:
- change the log level to INFO and use rate-limiter.
- avoid calling list_size().
---
lib/jsonrpc.c | 10
If a packet didn't match a rule in the fast path classifier its memory was
never freed. The issue was particularly clear with DPDK devices because it was
not possible to process more than ~25 DPDK mbufs in the slow path.
This commit fixes the problem by:
* calling dpif_packet_delete() if the
On 09/19/14 at 01:09pm, Ben Pfaff wrote:
I don't see why the testsuite is supported only with GCC.
The motivation was to keep the total build time on a reasonable level
and below the 1h limit for all build threads.
___
dev mailing list
On 09/19/14 at 01:09pm, Ben Pfaff wrote:
CC: Thomas Graf tg...@noironetworks.com
Signed-off-by: Ben Pfaff b...@nicira.com
Nice
Acked-by: Thomas Graf tg...@noironetworks.com
___
dev mailing list
dev@openvswitch.org
On 09/19/14 at 10:47pm, Thomas Graf wrote:
On 09/19/14 at 01:09pm, Ben Pfaff wrote:
I don't see why the testsuite is supported only with GCC.
The motivation was to keep the total build time on a reasonable level
and below the 1h limit for all build threads.
I tried to re-find the original
On Fri, Sep 19, 2014 at 01:59:36PM -0700, Ben Pfaff wrote:
On Fri, Sep 19, 2014 at 10:54:06PM +0200, Thomas Graf wrote:
On 09/19/14 at 10:47pm, Thomas Graf wrote:
On 09/19/14 at 01:09pm, Ben Pfaff wrote:
I don't see why the testsuite is supported only with GCC.
The motivation was
On Fri, Sep 19, 2014 at 10:54:06PM +0200, Thomas Graf wrote:
On 09/19/14 at 10:47pm, Thomas Graf wrote:
On 09/19/14 at 01:09pm, Ben Pfaff wrote:
I don't see why the testsuite is supported only with GCC.
The motivation was to keep the total build time on a reasonable level
and below
Looks good. A few minor comments in line.
Acked-by: Andy Zhou az...@nicira.com
It would be good to add some more back ground information in the commit message.
On Wed, Sep 17, 2014 at 4:08 PM, Pravin B Shelar pshe...@nicira.com wrote:
This was required for old compatibility code. Now vswitchd
From: Nicolas Dichtel nicolas.dich...@6wind.com
Date: Thu, 18 Sep 2014 10:31:03 +0200
This function is the counterpart of the function netlink_has_listeners().
Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com
Applied.
___
dev mailing list
From: Nicolas Dichtel nicolas.dich...@6wind.com
Date: Thu, 18 Sep 2014 10:31:04 +0200
From: Samuel Gauthier samuel.gauth...@6wind.com
Since commit fb5d1e9e127a (openvswitch: Build flow cmd netlink reply only if
needed.),
the new flows are not notified to the listeners of OVS_FLOW_MCGROUP.
Signed-off-by: Nithin Raju nit...@vmware.com
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/ovsext/Netlink/Netlink.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/Netlink/Netlink.c
In this patch we implement a utility function to compare ANSI
strings using the Rtl* functions. As much as possible, in an
NDIS driver, we stick to Rtl* functions for memory/string
manipulation.
Signed-off-by: Nithin Raju nit...@vmware.com
---
datapath-windows/ovsext/Util.c | 14 ++
In this patch, we add support for two commands, both of them are issued
as part of transactions semantics from userspace:
1. OVS_DP_CMD_SET is used to get the properties of a DP as well as set
some properties. The set operations does not seem to make much sense for
the Windows datpath right now.
The Windows kernel datapath needs the definition of 'IFNAMSIZ' for
specifying attribute sizes in netlink policies. Adding the definition
of 'IFNAMSIZ' to be part of OvsDpInterface.h similar to ETH_ADDR_LEN.
Signed-off-by: Nithin Raju nit...@vmware.com
Acked-by: Samuel Ghinet
In this patch, we add support for nl_transact() on Windows using
the OVS_IOCTL_TRANSACT ioctl that sends down the request and gets
the reply in the same call to the kernel.
This is obviously a digression from the way it is implemented in
Linux where all the sends are done at once using sendmsg()
All applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Acked-by: Alex Wang al...@nicira.com
Hey Pravin, could you also have a look~
On Fri, Sep 19, 2014 at 1:28 PM, Daniele Di Proietto ddiproie...@vmware.com
wrote:
If a packet didn't match a rule in the fast path classifier its memory was
never freed. The issue was particularly clear with DPDK
On 09/19/2014 10:57 AM, Jamal Hadi Salim wrote:
On 09/19/14 11:49, Jiri Pirko wrote:
Fri, Sep 19, 2014 at 05:25:48PM CEST, j...@mojatatu.com wrote:
Is this just a temporary test tool? Otherwise i dont see reason
for its existence (or the API that it feeds on).
Please read the conversation
+for (j = 0; j 4; j++) {
+struct cpu_core *core;
+
+core = CONTAINER_OF(hmap_first_with_hash(all_cpu_cores,
+
hash_int(core_id++, 0)),
+struct cpu_core, hmap_node);
+core-available = (bin j) 0x1;
This
On 09/19/14 18:12, John Fastabend wrote:
On 09/19/2014 10:57 AM, Jamal Hadi Salim wrote:
On 09/19/14 11:49, Jiri Pirko wrote:
Fri, Sep 19, 2014 at 05:25:48PM CEST, j...@mojatatu.com wrote:
Is this just a temporary test tool? Otherwise i dont see reason
for its existence (or the API that it
In the flow related functions, there's a stack variable called
'linux_flow'. Since this code is not specific to Linux anymore,
in this patch, we rename the variable to 'datpath_flow'.
Signed-off-by: Nithin Raju nit...@vmware.com
---
lib/dpif-netlink.c | 32
1
On Fri, Sep 19, 2014 at 03:34:45PM -0700, Nithin Raju wrote:
In the flow related functions, there's a stack variable called
'linux_flow'. Since this code is not specific to Linux anymore,
in this patch, we rename the variable to 'datpath_flow'.
Signed-off-by: Nithin Raju nit...@vmware.com
On Fri, Sep 19, 2014 at 1:28 PM, Daniele Di Proietto
ddiproie...@vmware.com wrote:
If a packet didn't match a rule in the fast path classifier its memory was
never freed. The issue was particularly clear with DPDK devices because it was
not possible to process more than ~25 DPDK mbufs in
Applied the patches with suggested changes
Thanks a lot for the review!
Alex Wang,
On Fri, Sep 19, 2014 at 12:14 PM, Alex Wang al...@nicira.com wrote:
@@ -776,8 +780,10 @@ do_add_port(struct dp_netdev *dp, const char
*devname, const char *type,
return ENOENT;
}
msg digest changes to add Bens (blp) patch get reverted.
utilities/ovs-pki
utilities/ovs-pki.in
openvswitch-2.3.0/tests/pki/controllerca/ca.cnf
openvswitch-2.3.0/tests/pki/switchca/ca.cnf
files where default_md is assigned all revert after:
(cd ~/rpmbuild/BUILD/openvswitch-2.3.0 make clean
On Thu, Sep 18, 2014 at 10:09:58PM -0700, Ben Pfaff wrote:
This fixes numerous testsuite failures of the form SSL_connect:
error:0D0C50A1:asn1 encoding routines:ASN1_item_verify:unknown message
digest algorithm on systems that disable MD5 in OpenSSL. Centos 7 is one
example. Presumably it
Thanks for the reviews,
I¹m about to send a v2
On 9/19/14, 3:49 PM, Pravin Shelar pshe...@nicira.com wrote:
On Fri, Sep 19, 2014 at 1:28 PM, Daniele Di Proietto
ddiproie...@vmware.com wrote:
If a packet didn't match a rule in the fast path classifier its memory
was
never freed. The issue was
1 - 100 of 112 matches
Mail list logo
