Fixes dp-packet access. Removes netinet/if_ether.h
include due to duplicate definition of ether_addr error.
--
In file included from /usr/include/netinet/if_ether.h:60:0,
from lib/lldp/lldpd.h:23,
from lib/ovs-lldp.h:26,
from lib/ovs-lldp.c:30
> On Wed, Mar 04, 2015 at 03:00:54PM +0900, YAMAMOTO Takashi wrote:
>> Fix a compilation problem introduced by
>> commit cf62fa4c7074121184a1f1d07980990113657612
>> ("dp-packet: Remove ofpbuf dependency.")
>>
>> Signed-off-by: YAMAMOTO Takashi
>
> Acked-by: Ben Pfaff
thank you. applied.
_
> On Wed, Mar 04, 2015 at 03:00:55PM +0900, YAMAMOTO Takashi wrote:
>> Signed-off-by: YAMAMOTO Takashi
>
> Acked-by: Ben Pfaff
thank you. applied.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Mar 04, 2015 at 03:00:55PM +0900, YAMAMOTO Takashi wrote:
> Signed-off-by: YAMAMOTO Takashi
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Feb 27, 2015 at 05:36:18PM -0800, Alex Wang wrote:
> This commit makes check_word_hash() run to finish even when there
> is a failure during the run. The test will still fail due to the
> output check in AT_CHECK. And developers can benefit from having
> all failed hashes instead of only
On Wed, Mar 04, 2015 at 03:00:54PM +0900, YAMAMOTO Takashi wrote:
> Fix a compilation problem introduced by
> commit cf62fa4c7074121184a1f1d07980990113657612
> ("dp-packet: Remove ofpbuf dependency.")
>
> Signed-off-by: YAMAMOTO Takashi
Acked-by: Ben Pfaff
__
On Sat, Feb 28, 2015 at 10:24:19AM -0800, Alex Wang wrote:
> Commit 9ba4f3c5(XenServer: PEP8 Cleanup for openvswitch-cfg-update).
> introduced a bug which causes the setting of 'ssl::6632' at xenserver
> boot.
It appears to me that it was the following commit 032c09ddd10
(XenServer: Don't reset
Signed-off-by: YAMAMOTO Takashi
---
lib/dp-packet.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index d754984..9cae74d 100644
--- a/lib/dp-packet.h
+++ b/lib/dp-packet.h
@@ -477,4 +477,4 @@ static inline void dp_packet_set_dp_hash(struct d
Fix a compilation problem introduced by
commit cf62fa4c7074121184a1f1d07980990113657612
("dp-packet: Remove ofpbuf dependency.")
Signed-off-by: YAMAMOTO Takashi
---
lib/netdev-bsd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
index 7dfff13..f97a5c3 1006
On Mon, Feb 23, 2015 at 08:49:00AM -0800, Alex Wang wrote:
> This commit includes the unit tests for ovs-vsctl-bashcomp
> and refines the ovs-command-bashcomp.INSTALL.md to introduce
> the bash completion for ovs-vsctl.
>
> Signed-off-by: Alex Wang
It appears to me that there is something wrong
On Mon, Feb 23, 2015 at 08:48:59AM -0800, Alex Wang wrote:
> From: Peter Amidon
>
> This patch adds bash command-line completion script for ovs-vsctl.
> Therein, codes are added to ovs-vsctl to allow it to print the
> options and command arguments. The ovs-vsctl-bashcomp.bash will
> parse the vs
Can you get laid using the magic words in this video?
Click Here To Find Out http://urla.ru/1Hwn
This shocking free video shows you how to make any
girl want to fuck you in 60 seconds or less.
Just say the magic words
And any woman is yours.
100% of the time.
Click Here To Watch The Video
On Mon, Mar 02, 2015 at 04:00:17PM +, Flynn, Dennis R (Dennis) wrote:
> Hi Ben,
>
> We have completed our testing with your additional refinements and everything
> looks good.
>
> I have the following comments after reviewing your changes.
> Once these are addressed to your satisfaction we a
> On Mar 3, 2015, at 3:04 PM, Ben Pfaff wrote:
>
> On Tue, Mar 03, 2015 at 11:22:43AM -0800, Ben Pfaff wrote:
>> I need to continue reading this patch starting from
>> ofproto-dpif-upcall.c.
>
> Continuing:
>
> ofproto-dpif-upcall.c
> -
>
> s/deleate/delete/:
> + * rel
On Tue, Mar 03, 2015 at 04:01:24PM -0800, Pravin Shelar wrote:
> On Tue, Mar 3, 2015 at 3:55 PM, Ben Pfaff wrote:
> > In all the churn around ofpbuf and dp_packet, this code seems to have been
> > overlooked. This fixes the problem.
> >
> > Signed-off-by: Ben Pfaff
>
> Looks good.
> Acked-by: P
On Tue, Mar 3, 2015 at 3:55 PM, Ben Pfaff wrote:
> In all the churn around ofpbuf and dp_packet, this code seems to have been
> overlooked. This fixes the problem.
>
> Signed-off-by: Ben Pfaff
Looks good.
Acked-by: Pravin B Shelar
___
dev mailing lis
If sex brings no joy, life gradually loses its colors
http://urla.ru/1HAe
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
In all the churn around ofpbuf and dp_packet, this code seems to have been
overlooked. This fixes the problem.
Signed-off-by: Ben Pfaff
---
lib/stream-ssl.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/stream-ssl.c b/lib/stream-ssl.c
index c2ace71..2ad794d 100
On Fri, Jan 30, 2015 at 01:23:21PM -0800, Ben Pfaff wrote:
> The manpage was poorly organized and failed to mention some options.
This could still use a review.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Mar 03, 2015 at 03:00:34PM -0800, Jarno Rajahalme wrote:
> Thanks for your detailed comments, and sorry for only compiling with
> gcc before posting.
No problem.
> > On Mar 3, 2015, at 11:22 AM, Ben Pfaff wrote:
> >
>
> (snip)
>
> > ofproto-dpif-rid.c
> > --
> >
> > T
On Tue, Mar 03, 2015 at 11:22:43AM -0800, Ben Pfaff wrote:
> I need to continue reading this patch starting from
> ofproto-dpif-upcall.c.
Continuing:
ofproto-dpif-upcall.c
-
s/deleate/delete/:
+ * relies on OVS userspace internal state, we need to deleate all old
ofprot
Ben,
Thanks for your detailed comments, and sorry for only compiling with gcc before
posting.
> On Mar 3, 2015, at 11:22 AM, Ben Pfaff wrote:
>
(snip)
> ofproto-dpif-rid.c
> --
>
> This comment in recirc_run() gave me pause. 250 ms "should be" enough?
> What happens if some
Having sex three times per night is as easy as pie for me!
http://urla.ru/1HAL
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Mar 3, 2015 at 9:34 AM, Ben Pfaff wrote:
> On Mon, Mar 02, 2015 at 10:51:47AM -0800, Pravin B Shelar wrote:
>> ofpbuf was complicated due to its wide usage across all
>> layers of OVS, Now we have introduced independent dp_packet
>> which can be used for datapath packet, we can simplify of
There are a couple of cases where OpenFlow 1.0 controllers that use
Nicira extensions can get OFPBMC_BAD_FIELD, so we should have an error
code for it in that protocol.
Reported-by: Soner Sevinc
Signed-off-by: Ben Pfaff
---
AUTHORS |1 +
lib/ofp-errors.h |2 +-
2 files changed,
On Tue, Mar 3, 2015 at 12:57 PM, Ben Pfaff wrote:
> On Tue, Mar 3, 2015 at 12:30 PM, Pravin Shelar wrote:
>> On Tue, Mar 3, 2015 at 10:36 AM, Ben Pfaff wrote:
>>> On Tue, Mar 03, 2015 at 10:33:43AM -0800, Jarno Rajahalme wrote:
> On Mar 3, 2015, at 8:29 AM, Ben Pfaff wrote:
>
>>>
On Tue, Mar 3, 2015 at 12:30 PM, Pravin Shelar wrote:
> On Tue, Mar 3, 2015 at 10:36 AM, Ben Pfaff wrote:
>> On Tue, Mar 03, 2015 at 10:33:43AM -0800, Jarno Rajahalme wrote:
>>>
>>> > On Mar 3, 2015, at 8:29 AM, Ben Pfaff wrote:
>>> >
>>> > On Mon, Mar 02, 2015 at 10:51:27AM -0800, Pravin B Shel
On Tue, Mar 3, 2015 at 10:36 AM, Ben Pfaff wrote:
> On Tue, Mar 03, 2015 at 10:33:43AM -0800, Jarno Rajahalme wrote:
>>
>> > On Mar 3, 2015, at 8:29 AM, Ben Pfaff wrote:
>> >
>> > On Mon, Mar 02, 2015 at 10:51:27AM -0800, Pravin B Shelar wrote:
>> >> static inline size_t ofpbuf_l4_size(const stru
> On Mar 3, 2015, at 10:09 AM, Ben Pfaff wrote:
>
> On Tue, Feb 24, 2015 at 03:42:03PM -0800, Jarno Rajahalme wrote:
>> Traces should not modify the flow table without the a packet or
>> "-generate" option.
>>
>> This patch also adds further testing to verify that MPLS recirculation
>> works.
>
> On Mar 3, 2015, at 10:00 AM, Ben Pfaff wrote:
>
> On Tue, Feb 24, 2015 at 03:42:02PM -0800, Jarno Rajahalme wrote:
>> Signed-off-by: Jarno Rajahalme
>
> Does this fix a bug that someone noticed, or did you just spot it while
> looking at the code ("by inspection")?
>
By inspection. I’ll no
On Tue, Mar 03, 2015 at 10:46:29AM -0800, Jarno Rajahalme wrote:
>
> > On Mar 3, 2015, at 9:55 AM, Ben Pfaff wrote:
> >
> > On Tue, Feb 24, 2015 at 03:42:01PM -0800, Jarno Rajahalme wrote:
> >> Recirculation id was scanned without a mask, which led to it being
> >> ignored.
> >>
> >> Signed-off
On Tue, Mar 3, 2015 at 9:01 AM, Kavanagh, Mark B
wrote:
>> Currently dp-packet make use of ofpbuf for managing packet
>> buffers. That complicates ofpbuf, by making dp-packet
>> independent of ofpbuf both libraries can be optimized for
>> their own use case.
>> This avoids mapping operation betwee
On Tue, Mar 03, 2015 at 11:20:14AM -0800, Pravin Shelar wrote:
> On Tue, Mar 3, 2015 at 8:51 AM, Ben Pfaff wrote:
> > On Mon, Mar 02, 2015 at 10:51:40AM -0800, Pravin B Shelar wrote:
> >> Currently dp-packet make use of ofpbuf for managing packet
> >> buffers. That complicates ofpbuf, by making dp
On Tue, Feb 24, 2015 at 03:42:06PM -0800, Jarno Rajahalme wrote:
> xlate_actions() now takes an optional recirclulation context as a
s/recirclulation/recirculation/
> parameter and restores OpenFlow pipeline metadata based on it. The
> recirculation context is returned by the xlate_lookup() and m
On Tue, Mar 3, 2015 at 8:51 AM, Ben Pfaff wrote:
> On Mon, Mar 02, 2015 at 10:51:40AM -0800, Pravin B Shelar wrote:
>> Currently dp-packet make use of ofpbuf for managing packet
>> buffers. That complicates ofpbuf, by making dp-packet
>> independent of ofpbuf both libraries can be optimized for
>>
Do you know how to make any girl horny for you?
This Video Shows You How http://urla.ru/1Hwu
Just watch the video, use the tips, and start banging between
5 and 7 girls every week.
If you want to use the tips to get a loyal dedicated girlfriend,
you can use it for that too.
And when you use
> On Mar 3, 2015, at 9:55 AM, Ben Pfaff wrote:
>
> On Tue, Feb 24, 2015 at 03:42:01PM -0800, Jarno Rajahalme wrote:
>> Recirculation id was scanned without a mask, which led to it being
>> ignored.
>>
>> Signed-off-by: Jarno Rajahalme
>
> Do you know what the idea was here? Is it just that i
> On Mar 3, 2015, at 3:45 AM, Kavanagh, Mark B
> wrote:
>
>> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
>> index 54bad02..70ef97b 100644
>> --- a/lib/dpif-netdev.c
>> +++ b/lib/dpif-netdev.c
>> @@ -33,6 +33,7 @@
>>
>> #include "cmap.h"
>> #include "csum.h"
>> +#include "dp-packet.h"
>>
On Tue, Mar 03, 2015 at 10:33:43AM -0800, Jarno Rajahalme wrote:
>
> > On Mar 3, 2015, at 8:29 AM, Ben Pfaff wrote:
> >
> > On Mon, Mar 02, 2015 at 10:51:27AM -0800, Pravin B Shelar wrote:
> >> static inline size_t ofpbuf_l4_size(const struct ofpbuf *b)
> >> {
> >> -return b->l4_ofs != UINT1
> On Mar 3, 2015, at 8:29 AM, Ben Pfaff wrote:
>
> On Mon, Mar 02, 2015 at 10:51:27AM -0800, Pravin B Shelar wrote:
>> Signed-off-by: Pravin B Shelar
>> ---
>> lib/ofpbuf.h |5 +
>> 1 files changed, 1 insertions(+), 4 deletions(-)
>>
>> diff --git a/lib/ofpbuf.h b/lib/ofpbuf.h
>> index
On Tue, Feb 24, 2015 at 03:42:05PM -0800, Jarno Rajahalme wrote:
> There is no point trying to create ukeys for non-miss upcalls, such as
> upcalls due to an explicit userspace actions.
>
> Signed-off-by: Jarno Rajahalme
At first glance this was a no-brainer. When I looked closer, it became
mor
ovs-appctl vlog/* doesn't handle kernel logging.
Modifying files in datapath/linux/compat/* may or may not have an
effect depending on the kernel version that you are building against;
compat code is only compiled in if the kernel doesn't have that
functionality.
On 3 March 2015 at 00:08, 苌智 wro
On Tue, Feb 24, 2015 at 03:42:04PM -0800, Jarno Rajahalme wrote:
> Signed-off-by: Jarno Rajahalme
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Feb 24, 2015 at 03:42:03PM -0800, Jarno Rajahalme wrote:
> Traces should not modify the flow table without the a packet or
> "-generate" option.
>
> This patch also adds further testing to verify that MPLS recirculation
> works.
>
> Signed-off-by: Jarno Rajahalme
We also don't have a pa
On Tue, Feb 24, 2015 at 03:42:02PM -0800, Jarno Rajahalme wrote:
> Signed-off-by: Jarno Rajahalme
Does this fix a bug that someone noticed, or did you just spot it while
looking at the code ("by inspection")?
Acked-by: Ben Pfaff
___
dev mailing list
d
On Tue, Feb 24, 2015 at 03:42:00PM -0800, Jarno Rajahalme wrote:
> Translate action set only if not dropping the packet.
>
> Signed-off-by: Jarno Rajahalme
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/lis
On Tue, Feb 24, 2015 at 03:42:01PM -0800, Jarno Rajahalme wrote:
> Recirculation id was scanned without a mask, which led to it being
> ignored.
>
> Signed-off-by: Jarno Rajahalme
Do you know what the idea was here? Is it just that it doesn't make
sense to bitwise match the recirc_id, so we did
tc_load is called the first time that a queue-related operation happens
on a netdev. For example, when a netdev is first added to a bridge, and
high-level code calls netdev_get_qos(), netdev-linux will check the
current qdisc and then, if that one is known, call the tc_load function
to find out th
On Mon, Mar 02, 2015 at 10:51:47AM -0800, Pravin B Shelar wrote:
> ofpbuf was complicated due to its wide usage across all
> layers of OVS, Now we have introduced independent dp_packet
> which can be used for datapath packet, we can simplify ofpbuf.
> Following patch removes DPDK mbuf and access AP
On Mon, Mar 2, 2015 at 1:41 PM, Mark Maglana wrote:
> This change ensures that we always end up with two elements even
> if the name of the physical port contains dashes. For example, a
> binding of "0100-br0-eth1" will be split to ["0100", "br0-eth1"]
> instead of ["0100", "br0", "eth1"].
>
> Sig
> Currently dp-packet make use of ofpbuf for managing packet
> buffers. That complicates ofpbuf, by making dp-packet
> independent of ofpbuf both libraries can be optimized for
> their own use case.
> This avoids mapping operation between ofpbuf and dp_packet
> in datapath upcalls.
>
> Signed-off-
Thank you for the information, it makes sense, removing the
conditional made it work nicely. So, I have another question, exactly
what is tc_load used for? In what case is it called? I can't seem to
trigger it for a specific qdisc (say HTB). If I get this working, I
can hopefully contribute my chan
On Tue, Mar 3, 2015 at 1:58 AM, Gianluca Merlo wrote:
> Signed-off-by: Gianluca Merlo
Thank you! I applied this to the master branch.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Mar 02, 2015 at 10:51:40AM -0800, Pravin B Shelar wrote:
> Currently dp-packet make use of ofpbuf for managing packet
> buffers. That complicates ofpbuf, by making dp-packet
> independent of ofpbuf both libraries can be optimized for
> their own use case.
> This avoids mapping operation bet
On Mon, Mar 02, 2015 at 10:51:34AM -0800, Pravin B Shelar wrote:
> dp_packet is shorter, so I prefer it over current name.
>
> Signed-off-by: Pravin B Shelar
I'm happy with the renaming. I assume that this doesn't make any
behavioral changes; I only skimmed the patch.
__
On Mon, Mar 02, 2015 at 10:51:27AM -0800, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar
> ---
> lib/ofpbuf.h |5 +
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/lib/ofpbuf.h b/lib/ofpbuf.h
> index 4e7038d..82588e3 100644
> --- a/lib/ofpbuf.h
> +++ b/lib/of
Sex is an inseparable part in every womans life!
http://urla.ru/1HD8
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> There is bug in dpif-packet clone where it does not copy
> pading size for buffer. That resulted in incorrect SCTP
> checksum. This pach also fixes this issue.
>
Two typos above - 'pading' and 'pach', respectively .
Looks good otherwise.
> Signed-off-by: Pravin B Shelar
> ---
> lib/ofpbuf
> Subject: [ovs-dev] [PATCH 2/4] dpif_packet: Rename to dp_packet
>
> dp_packet is shorter, so I prefer it over current name.
>
> Signed-off-by: Pravin B Shelar
> ---
(snip)
> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
> index 54bad02..70ef97b 100644
> --- a/lib/dpif-netdev.c
> +++
Signed-off-by: Gianluca Merlo
2015-03-02 23:10 GMT+01:00 Gurucharan Shetty :
> I think this is sufficient, but I am not an expert at these things.
> So, just to be sure, can you reply back with the following one liner.
> Signed-off-by: Gianluca Merlo
>
> Thanks,
> Guru
>
> On Mon, Mar 2, 2015 a
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> -Original Message-
> From: Daniele Di Proietto [mailto:diproiet...@vmware.com]
> Sent: Thursday, February 26, 2015 1:54 PM
> To: Traynor, Kevin
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] vswitchd: simplify dpdk option parsing.
>
>
> > On 26 Feb 2015, at 13:19, Traynor,
How could I get debug info from datapath? Thanks a lot!
2015-03-03 16:08 GMT+08:00 苌智 :
> Hi,
> I want to get log info from datapath, so I add "pr_err("error has
> occur");" in datapath/linux/compat/vxlan.c. But I can not get any error
> info from /var/log/messages after I execute "ovs-appctl
Hi,
I want to get log info from datapath, so I add "pr_err("error has
occur");" in datapath/linux/compat/vxlan.c. But I can not get any error
info from /var/log/messages after I execute "ovs-appctl vlog/set
ANY:syslog:dbg". Could someone helps me?
Best wishes!
64 matches
Mail list logo
