On 22.02.2016 19:10, Flavio Leitner wrote:
>> Reviewed-by: Aaron Conole
>> Acked-by: Flavio Leitner
>
> If you do small changes to the patch that doesn't alter its logic you
> can preserve the signature from others (e.g.: typos, indentation,
>
Thanks for review.
Comments inline.
On 23.02.2016 05:33, Daniele Di Proietto wrote:
>> Reassignment of all rx queues done to achieve fair distribution.
>> @@ -2401,11 +2405,20 @@ static int
>> dpif_netdev_pmd_set(struct dpif *dpif, const char *cmask)
>> {
>> struct dp_netdev *dp =
On Tue, Feb 23, 2016 at 3:38 PM, Han Zhou wrote:
>
>
> On Tue, Feb 23, 2016 at 1:04 PM, Ben Pfaff wrote:
> >
> > Will this have the desired effect? I think that putting multiple VIFs
> > on a logical switch and redirecting outputs to them through the localnet
>
Before this patch, inter-chassis communication between VIFs of same
lswitch will always go through tunnel, which end up of modeling a
single physical network with many lswitches and pairs of lports, and
complexity in CMS like OpenStack neutron to manage the lswitches and
lports.
With this patch,
On Mon, Feb 22, 2016 at 04:04:42PM -0800, Jarno Rajahalme wrote:
> > On Jan 19, 2016, at 10:15 PM, Simon Horman
> > wrote:
> >
> > Provide leading padding to allow pushing a value to a miniflow where
> > the value is not aligned to 64 bytes and no value has already
On Mon, Feb 22, 2016 at 04:03:59PM -0800, Jarno Rajahalme wrote:
> > On Jan 19, 2016, at 10:15 PM, Simon Horman
> > wrote:
> >
> > The motivation is to allow pushing single bytes in
> > a manner to that already used for 16, 32 and 64 bit integers.
> >
> > This will
This macro is not required as we drop support for unsupported
kernel versions.
Signed-off-by: Pravin B Shelar
---
Added back compat ip_defrag()
---
acinclude.m4 | 9 -
datapath/compat.h
Currently OVS out of tree datapath supports a large number of kernel
versions. From 2.6.32 to 4.3 and various distribution-specific
kernels. But at this point major features are only available on more
recent kernels. For example, stateful services are only available
starting in kernel 3.10 and
On Tue, Feb 23, 2016 at 01:27:51PM +0900, Simon Horman wrote:
> On Mon, Feb 22, 2016 at 10:00:50AM -0800, Ben Pfaff wrote:
> > compat.at mixes compatibility for m4sh, which is used by Autoconf and
> > Autotest, with compatibility for Autotest. It makes more sense to separate
> > them. This moves
On Wed, Feb 17, 2016 at 11:45:30AM -0800, Jarno Rajahalme wrote:
> So far we have tried to optimize MPLS POP action not to recirculate
> unless later matching actually needs the inner headers. This made the
> code complex and error-prone. Also the cases where this optimization
> would have been
Thanks for the review Flavio, I applied this to master and brach-2.5
On 22/02/2016 20:29, "Flavio Leitner" wrote:
>On Mon, 22 Feb 2016 11:43:23 -0800
>Daniele Di Proietto wrote:
>
>> This check prevents an obvious way for a vhost-user socket to escape
Thanks! I applied the following incremental
(minor style fixes) and push this to master
diff --git a/tests/dpdk/ring_client.c b/tests/dpdk/ring_client.c
index 089657a..8a43c64 100644
--- a/tests/dpdk/ring_client.c
+++ b/tests/dpdk/ring_client.c
@@ -99,10 +99,11 @@ usage(const char *progname)
Thanks! I applied the following incremental
(minor style fixes) and push this to master
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index d0c3d66..f94e0d4 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -649,10 +649,11 @@ dpdk_dev_parse_name(const char dev_name[], const
char
On Tue, Feb 23, 2016 at 5:09 PM, Joe Stringer wrote:
> On 23 February 2016 at 17:06, Jesse Gross wrote:
>> On Fri, Feb 19, 2016 at 4:03 PM, Pravin B Shelar wrote:
>>> Currently OVS out of tree datapath supports a large number of kernel
>>>
On Tue, Feb 23, 2016 at 5:01 PM, Joe Stringer wrote:
> On 19 February 2016 at 16:03, Pravin B Shelar wrote:
>> @@ -119,25 +119,9 @@ static inline int rpl_ip_do_fragment(struct sock *sk,
>> struct sk_buff *skb,
>> int rpl_ip_defrag(struct sk_buff *skb, u32 user);
Sorry for the late response, I was out of town. I will test this patch, or
simply update my git, the next time I load it, which shouldn't take long.Thanks
On Tuesday, 23 February 2016 9:36 AM, Ben Pfaff wrote:
On Tue, Feb 23, 2016 at 08:10:50AM -0300, Thadeu Lima de Souza
On 23 February 2016 at 17:06, Jesse Gross wrote:
> On Fri, Feb 19, 2016 at 4:03 PM, Pravin B Shelar wrote:
>> Currently OVS out of tree datapath supports a large number of kernel
>> versions. From 2.6.32 to 4.3 and various distribution-specific
>> kernels. But
On Fri, Feb 19, 2016 at 4:03 PM, Pravin B Shelar wrote:
> Currently OVS out of tree datapath supports a large number of kernel
> versions. From 2.6.32 to 4.3 and various distribution-specific
> kernels. But at this point major features are only available on more
> recent kernels.
On Wed, Feb 17, 2016 at 11:45:29AM -0800, Jarno Rajahalme wrote:
> So far we have been limited to including only one MPLS label in the
> textual datapath flow format. Allow upto 3 labels to be included so
> that testing with multiple labels becomes easier.
>
> Signed-off-by: Jarno Rajahalme
On 19 February 2016 at 16:03, Pravin B Shelar wrote:
> @@ -119,25 +119,9 @@ static inline int rpl_ip_do_fragment(struct sock *sk,
> struct sk_buff *skb,
> int rpl_ip_defrag(struct sk_buff *skb, u32 user);
> #define ip_defrag rpl_ip_defrag
>
> +#endif /*
Thanks for your review!
>
> From this part of the patch, it looks like external-ids:zone-id is
> accepted even if there are duplicates, or if the value is not valid. I
> think that it should reject such cases:
>
> With that in mind, update_local_zone_ids() should also update
>
On Wed, Feb 17, 2016 at 11:45:28AM -0800, Jarno Rajahalme wrote:
> Some MPLS tests used non-MPLS ethertype for popping a label from a
> multi-label stack. Also, reveal actions in some MPLS tests. This
> will make later patches more easily understandable.
>
> Fix the mpls-xlate banner and remove
I spent some time looking this over, just now, and I'm a bit confused.
It's clear that the python implementation of PassiveStream did not
support TCP. Great, the patch adds that. If the patch just added that,
I'd be happy, I'd just commit it.
What I don't understand is why other changes are
- Original Message -
> From: "Ben Pfaff"
> To: "Lance Richardson"
> Cc: dev@openvswitch.org
> Sent: Tuesday, February 23, 2016 7:26:13 PM
> Subject: Re: [ovs-dev] [PATCH] ovsdb-idl: improve error handling when schema
> is not available
>
> On Tue, Feb
> On Feb 23, 2016, at 1:43 PM, Dennis Sam wrote:
>
> Documents error codes that a Hardware Switch Controller can publish to the NVC
> to indicate errors related to the provisioning of logical routers.
>
>
> Signed-off-by: Dennis Sam
> Acked-by: Anupam Chanda
On Tue, Feb 16, 2016 at 11:51:44AM -0500, Lance Richardson wrote:
> A common error scenario with OVN is to attempt to use ovn-nbctl when
> the OVN databases have not been created in ovsdb-server:
>1. ovn-nbctl sends a "get_schema" request for the OVN db to ovsdb-server.
>2. ovsdb-server
Reported-At: https://bugs.launchpad.net/networking-ovn/+bug/1539347
Reported-By: na...@cn.ibm.com
Co-Authored-By: na...@cn.ibm.com,rua...@cn.ibm.com
---
openstack-neutron (CMS) allows the configuration of
"static-routes" on a router as shown below.
neutron router-update --route
On Mon, Feb 15, 2016 at 03:46:38PM -0500, Ramu Ramamurthy wrote:
> Currently, ovn-controller does not record the
> lport->zoneid map, and so, after ovn-controller restart,
> zone-ids may get set inconsistently on lports, resulting
> in possible hits to already established connections.
>
> Set
I see that now.
I believe that some of my comments are still applicable. I'll re-send
them for v5.
On Mon, Feb 22, 2016 at 07:49:01PM -0500, Russell Bryant wrote:
> Hi, Ben. I know we've had a lot of mailing list problems so you may have
> missed some of the follow-up to this patch. It's up
On Mon, Feb 15, 2016 at 04:22:07PM +0100, Quentin Monnet wrote:
> Add color output for flow actions for ovs-ofctl dump-flows command
> utility, by calling ds_put_color() instead of ds_put_format() in the
> functions responsible for printing the actions.
>
> This also causes the option to be
On Tue, Feb 23, 2016 at 10:06:34AM -0500, Russell Bryant wrote:
> On Tue, Feb 23, 2016 at 9:57 AM, Russell Bryant wrote:
>
> >
> > On Mon, Feb 22, 2016 at 10:26 PM, Flavio Leitner wrote:
> >
> >> Fixes: 981cbd52c942 ("ovs-bugtool: Create OVN plugin and add
On Mon, Feb 15, 2016 at 04:21:25PM +0100, Quentin Monnet wrote:
> This commit adds colors to the “left part” of printed flows (to flow
> properties that are always present: `cookie`, `table`, timeouts, etc.).
> It uses the functions previously defined in dynamic-string.{c,h} to
> insert color
On Tue, Feb 23, 2016 at 1:04 PM, Ben Pfaff wrote:
>
> Will this have the desired effect? I think that putting multiple VIFs
> on a logical switch and redirecting outputs to them through the localnet
> port will have surprising consequences in some cases. The first case
> that
On Mon, Feb 15, 2016 at 04:21:06PM +0100, Quentin Monnet wrote:
> Define three functions, respectively used for:
>
> * printing a new color marker before text to colorize
> * printing end color marker
> * wrapping the two previous functions into a substitute to
> ds_put_format(), with colors
>
On Mon, Feb 15, 2016 at 04:20:51PM +0100, Quentin Monnet wrote:
> OVS_COLORS environment variable is parsed to extract user-defined
> preferences regarding colors (this is used to set up a color theme, not
> to replace the `--color` option for activating color output).
>
> The string should be of
On Mon, Feb 15, 2016 at 04:20:33PM +0100, Quentin Monnet wrote:
> Add an option to ovs-ofctl utility so as to obtain colorized output in
> tty, for easier reading. Currently, only the dump-flows command supports
> colors.
>
> A new `--color` option has been added to ovs-ofctl so as to indicate
>
On 23 February 2016 at 13:31, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
Thanks, applied to master and branch-2.5.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
During our tests with OVSDB we found out that memory allocation is
used intensively by the server, so we thought that using a different
memory allocator could increase the performance. We tried jemalloc
and the performance gain was between 20% and 40%.
This patch would allow anyone to enable
Hi Daniele,
I didn't know about that function, thanks!.
I already sent the new versions:
http://openvswitch.org/pipermail/dev/2016-February/066650.html
http://openvswitch.org/pipermail/dev/2016-February/066649.html
Thank you very much!.
On 23 February 2016 at 19:12, Daniele Di Proietto
Current implementation of dpdk_dev_parse_name does not perform a robust
error handling, port names as "dpdkr" and "dpdkr1x" are considered valid.
With this patch only positive port numbers in decimal notation are considered
valid.
Signed-off-by: Mauricio Vasquez B
Current implementation of the ring_client test only supports until the
dpdkr255 port, this patch extends it to support the full range of possible
dpdkr ports.
Signed-off-by: Mauricio Vasquez B
---
v3:
use str_to_uint
tests/dpdk/ring_client.c | 46
Documents error codes that a Hardware Switch Controller can publish to the NVC
to indicate errors related to the provisioning of logical routers.
Signed-off-by: Dennis Sam
Acked-by: Anupam Chanda
---
AUTHORS | 1 +
vtep/vtep.xml | 22
v2->v3
- Pass all test cases
- Introduce separate lock elision for rwlock
- Add performance comparison of cmap/hmap search
v1->v2
- Fix a bug at UNLOCK_ELISION
- Add checking if glibc version >= 2.21 (OVS_CHECK_GLIBC_TSX)
- Add checking of whether cpu has TSX support (OVS_CHECK_RTM)
- Enable
v2->v3
- Pass all test cases
- Introduce separate lock elision for rwlock
- Add performance comparison of cmap/hmap search
v1->v2
- Fix a bug at UNLOCK_ELISION
- Add checking if glibc version >= 2.21 (OVS_CHECK_GLIBC_TSX)
- Add checking of whether cpu has TSX support (OVS_CHECK_RTM)
- Enable
Acked-by: Jarno Rajahalme
> On Feb 23, 2016, at 1:26 PM, Joe Stringer wrote:
>
> Signed-off-by: Joe Stringer
> ---
> utilities/ovs-ofctl.8.in | 41 -
> 1 file changed, 24 insertions(+), 17 deletions(-)
>
> diff
Signed-off-by: Joe Stringer
---
utilities/ovs-ofctl.8.in | 41 -
1 file changed, 24 insertions(+), 17 deletions(-)
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
index 981e60acec92..1b280efde6bd 100644
---
On Mon, Feb 15, 2016 at 10:08:51AM -0500, Lance Richardson wrote:
> NetBSD requires to be included before .
> Without this fix we have:
>
> In file included from lib/netdev-vport.c:25:0:
> /usr/include/netinet/ip6.h:82:18: error: field 'ip6_src' has incomplete type
>
On Sat, Feb 13, 2016 at 01:56:01PM -0800, Ansis Atteka wrote:
> Otherwise, "ovs-ctl force-reload-kmod ..." command fails with:
>
> Detected internal interfaces: br-int p1[ OK ]
> Saving flows /usr/share/openvswitch/scripts/ovs-ctl:
> line 267:
On Thu, Feb 11, 2016 at 09:36:02PM -0800, Han Zhou wrote:
> Before this patch, inter-chassis communication between VIFs of same
> lswitch will always go through tunnel, which end up of modeling a
> single physical network with many lswitches and pairs of lports, and
> complexity in CMS like
On Mon, Feb 22, 2016 at 12:50 AM, Huang Lei <148012...@qq.com> wrote:
> From: Huang Lei
>
> For setting the inactivity probe interval of the json session to the OVN
> southbound database.
>
> Signed-off-by: Huang Lei
> ---
> lib/jsonrpc.c
Thanks for taking a look, I will send an updated patch in the afternoon.
On Tue, Feb 23, 2016 at 10:02 AM, Justin Pettit wrote:
>
> > On Feb 22, 2016, at 4:15 PM, Dennis Sam wrote:
>
> In the title, there should be a space between "vtep:" and "Add".
Sure,
Apologies for the delay in the review.
I think this and the previous patch could benefit from using str_to_uint().
Would you mind making that change and resubmitting? I'll be happy to apply
it then.
Thanks,
Daniele
On 25/01/2016 11:55, "dev on behalf of Mauricio Vasquez B"
Apologies for the delay and thanks for the patch and the review!
I applied this to master
On 25/01/2016 07:43, "dev on behalf of Aaron Conole"
wrote:
>Mauricio Vasquez B writes:
>> A ring
> On Feb 22, 2016, at 4:15 PM, Dennis Sam wrote:
In the title, there should be a space between "vtep:" and "Add".
> @@ -251,6 +252,7 @@ Andrey Korolyov and...@xdel.ru
> Anshuman Manral anshuman.man...@outlook.com
> Anton Matsiuk
On Mon, Feb 22, 2016 at 07:57:07PM -0500, Russell Bryant wrote:
> On Mon, Feb 22, 2016 at 6:47 PM, Ben Pfaff wrote:
>
> > Found "make distcheck".
> >
>
> Found *by* "make distcheck" ?
Yes.
> > Signed-off-by: Ben Pfaff
> >
>
> Acked-by: Russell Bryant
On Tue, Feb 23, 2016 at 08:10:50AM -0300, Thadeu Lima de Souza Cascardo wrote:
> On Mon, Feb 22, 2016 at 04:25:57PM -0800, Ben Pfaff wrote:
> > This patch seems obviously correct to me, so whenever you give me a
> > Signed-off-by, I'll apply it.
> >
> > On Wed, Feb 17, 2016 at 12:43:56PM -0200,
> -Original Message-
> From: Flavio Leitner [mailto:f...@sysclose.org]
> Sent: Tuesday, February 23, 2016 2:10 AM
> To: Stokes, Ian
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v4] netdev_dpdk.c: Add QoS functionality.
>
> On Fri, 19 Feb 2016 17:26:30 +
> Ian Stokes
On Thu, Feb 11, 2016 at 12:24:43PM +0530, niti1...@gmail.com wrote:
> From: Niti Rohilla
>
> "ovs-ofctl set-first-egress-table " can be used to set
> first egress
> table.
> This patch enhances TABLE_FEATURES_REQUEST message to set the first egress
> table and
>
On Tue, Feb 23, 2016 at 9:57 AM, Russell Bryant wrote:
>
> On Mon, Feb 22, 2016 at 10:26 PM, Flavio Leitner wrote:
>
>> Fixes: 981cbd52c942 ("ovs-bugtool: Create OVN plugin and add output.")
>> Signed-off-by: Flavio Leitner
>> ---
>>
> From: RYAN D. MOATS
>
> This series of patches changes lflow_run from processing the
> entire southbound logical flow table to doing incremental
> processing during each run.
>
> To make this work, several pre-requisites are necessary, and
> these are contained in the initial patches of the
>
>On Fri, 19 Feb 2016 11:25:12 +
>Mark Kavanagh wrote:
>
>> Add support for Jumbo Frames to DPDK-enabled port types,
>> using single-segment-mbufs.
>>
>> Using this approach, the amount of memory allocated for each mbuf
>> to store frame data is increased to a
On Mon, Feb 22, 2016 at 10:26 PM, Flavio Leitner wrote:
> Fixes: 981cbd52c942 ("ovs-bugtool: Create OVN plugin and add output.")
> Signed-off-by: Flavio Leitner
> ---
> rhel/openvswitch-fedora.spec.in | 3 +++
> 1 file changed, 3 insertions(+)
>
Acked-by:
On Mon, Feb 22, 2016 at 11:23 PM, Simon Horman
wrote:
> On Tue, Feb 23, 2016 at 12:26:39AM -0300, Flavio Leitner wrote:
> > Fixes: 981cbd52c942 ("ovs-bugtool: Create OVN plugin and add output.")
> > Signed-off-by: Flavio Leitner
> > ---
> >
Hi Russel.
Did you have a chance to check V6 patch?
This should fix the testing problem.
Ofer.
-- Forwarded message -
From: Ofer Ben Yacov
Date: יום ד׳, 17 בפבר׳ 2016 ב-17:21
Subject: [PATCH V6] Add Passive TCP connection to IDL.
To:
96
FDA Approved World ONLINE PHARMACY
p{margin:10px 0;padding:0;}
table{border-collapse:collapse;}
h1,h2,h3,h4,h5,h6{display:block;margin:0;padding:0;}
img,a img{border:0;height:auto;outline:none;text-decoration:none;}
On Mon, Feb 22, 2016 at 04:25:57PM -0800, Ben Pfaff wrote:
> This patch seems obviously correct to me, so whenever you give me a
> Signed-off-by, I'll apply it.
>
> On Wed, Feb 17, 2016 at 12:43:56PM -0200, Thadeu Lima de Souza Cascardo wrote:
> > The revalidator thread may set may_learn and call
On Mon, Feb 22, 2016 at 04:10:06PM -0800, Ben Pfaff wrote:
> On Tue, Feb 09, 2016 at 06:22:04AM -0200, Thadeu Lima de Souza Cascardo wrote:
> > Fix the IPv6 pseudoheader checksum. Requires that the payload length is
> > given to
> > the function.
> >
> > Signed-off-by: Thadeu Lima de Souza
The original message was received at Tue, 23 Feb 2016 12:54:43 +0300 from
140.5.21.62
- The following addresses had permanent fatal errors -
___
dev mailing list
dev@openvswitch.org
Andy Zhou wrote on 23/02/2016 11:21:31 AM:
> > dbmon's changes should be stored with the next transaction number,
> > rather than the current transaction number. This bug causes the
> > changes of a transaction stored in a monitor to be unnoticed by
> > the jsonrpc connections
On Tue, Feb 23, 2016 at 12:14 AM, Liran Schour wrote:
> "dev" wrote on 23/02/2016 02:28:12 AM:
>
> > dbmon's changes should be stored with the next transaction number,
> > rather than the current transaction number. This bug causes the
> >
"dev" wrote on 23/02/2016 02:28:12 AM:
> dbmon's changes should be stored with the next transaction number,
> rather than the current transaction number. This bug causes the
> changes of a transaction stored in a monitor to be unnoticed by
> the jsonrpc connections
71 matches
Mail list logo