Re: [ovs-dev] [PATCH v2, 1/1] ovn: Extend Address_Set to Set to support define port name sets

On Wed, Sep 28, 2016 at 11:47 PM, Ben Pfaff wrote: > On Wed, Sep 28, 2016 at 03:17:04AM +, Zongkai LI wrote: >> From: Zongkai LI >> >> This patch aims to extend table Address_Set to Set, make it more common to >> accept variable set, not only

Re: [ovs-dev] [PATCH RFC v3] ovn-northd: add default_dhcpvx_options for Logical_Switch

On Thu, Sep 15, 2016 at 7:48 AM, Ben Pfaff wrote: > On Thu, Sep 01, 2016 at 09:56:30AM +, Zongkai LI wrote: >> This patch adds default_dhcpv4_options and default_dhcpv6_options columns for >> Logical_Switch, which should help CMS not to calculate and set dhcpv4_options >> and

Re: [ovs-dev] [PATCH v2 4/8] flow: update is_nd for all ND msg types

On Thu, Sep 8, 2016 at 9:39 AM, Justin Pettit wrote: > >> On Sep 2, 2016, at 10:09 PM, Zongkai LI wrote: >> >> This patch updates method is_nd to let type ND_ROUTER_SOLICIT, >> ND_ROUTER_ADVERT, ND_REDIRECT can be recoginzed. >> And introduces method

Re: [ovs-dev] [PATCH v2 3/8] ovn: extend expr symbols for ND

On Thu, Sep 8, 2016 at 9:13 AM, Justin Pettit wrote: > >> On Sep 2, 2016, at 10:09 PM, Zongkai LI wrote: >> >> This patch updates symbols in logical-fields for ND, such as "nd", >> "nd.target", "nd.sll", "nd.tll", to describe more clear about "icmp6.type" >>

[ovs-dev] please help review serial patches supporting Router Solicitation responder

hi, guys, please help review serial patches supporting Router Solicitation responder. http://patchwork.ozlabs.org/patch/665380/ [ovs-dev,v2,1/8] packets: add compose_nd_ra to compose Router Advertisement packet http://patchwork.ozlabs.org/patch/665381/ [ovs-dev,v2,2/8] lib: rename ovs_nd_opt to

Re: [ovs-dev] please help review patch "allow DHCPv6 respond multiple IA Address Options"

On Thu, Sep 1, 2016 at 6:05 PM, Numan Siddique <nusid...@redhat.com> wrote: > > > On Wed, Aug 31, 2016 at 8:44 AM, Zong Kai Li <zealo...@gmail.com> wrote: >> >> On Tue, Aug 30, 2016 at 8:28 PM, Numan Siddique <nusid...@redhat.com> >> wrote: >> >

[ovs-dev] please help review patch "allow DHCPv6 respond multiple IA Address Options"

Hi, Numan and Justin. I wish you can help review patch "allow DHCPv6 respond multiple IA Address Options". http://patchwork.ozlabs.org/patch/663493/ For current DHCPv6 implementation, it will respond one IPv6 address for a lswitch port in a DHCPv6 Reply message. The "one IPv6 address", I mean,

[ovs-dev] [PATCH RFC v1] ovn-northd: add default_dhcpvx_options for Logical_Switch

From: Zongkai LI This patch adds default_dhcpv4_options and default_dhcpv6_options columns for Logical_Switch, which should help CMS not to calculate and set dhcpv4_options and dhcpv6_options columns for lswitch ports on lswitchs one by one, when most of lswitch ports on the

[ovs-dev] [PATCH v1] ovn-northd: allow DHCPv6 respond multiple IA Address Options

From: Zongkai LI This patch tries to allow OVN native DHCPv6 responder to respond multiple IA Address Options in a DHCPv6 reply message, this will help a lswitch port to configure all IPv6 addresses belongs to it in DHCPv6 processing. This fixes issue lswitch port can only

[ovs-dev] [PATCH v1, 5/6] ovn-controller: add 'put_nd_ra' and 'put_nd_opt_*' actions support

From: Zongkai LI This patch adds specific inner actions 'put_nd_ra', 'put_nd_opt_prefix', 'put_nd_opt_mtu', 'put_nd_opt_sll' for action 'nd_ra'. Action put_nd_ra will set cur_hop_limit(8-bit unsigned integer), "Managed address configuration" and "Other configuration"

[ovs-dev] [PATCH v1, 4/6] ovn-controller: add 'nd_ra' action against 'nd_na' action

From: Zongkai LI This patchs add a new action 'nd_ra' against current 'nd_na' action, to work as a Router Solicitation packet responder. The inner actions to set fields, flags, options in RA packet will be introduced in the following patch. --- include/ovn/actions.h | 7

[ovs-dev] [PATCH v1,6/6] ovn-northd: add flow support for SLAAC

From: Zongkai LI This patch adds a new logical flow table to support Router Advertisement responder. And it also adds flow support for SLAAC. --- ovn/northd/ovn-northd.c | 97 +--- ovn/ovn-nb.ovsschema| 5 ++- ovn/ovn-nb.xml

[ovs-dev] [PATCH v1, 0/6] ovn: add 'nd_ra' action and SLAAC support for

From: Zongkai LI This serial patches try to support Stateless Address Autoconfiguration(SLAAC) for IPv6, via Router Solicitation (RS) message responder, which will reply Router Advertisement (RA) message. User case: After this serial patches, a user can follow the

[ovs-dev] [PATCH v1, 3/6] ovs.lib.flow: extend is_nd for all ND messages types

From: Zongkai LI This patch updates method "is_nd" to let type ND_ROUTER_SOLICIT, ND_ROUTER_ADVERT, ND_REDIRECT can be recoginzed. --- lib/flow.h | 5 - lib/nx-match.c | 4 +++- lib/odp-util.c | 6 +- ovn/controller/pinctrl.c | 10

[ovs-dev] [PATCH v1, 1/6] ovs.packets: add compose_nd_ra and packet_put_ra_*_opt support

From: Zongkai LI This patch introduces methods to compose a Router Advertisement (RA) packet, introduces flags for RA, and renames ovs_nd_opt to ovs_nd_lla_opt to specify it's Source/Target Link-layer Address option. --- lib/flow.c| 26 - lib/odp-execute.c |

[ovs-dev] [PATCH v1,2/6] ovn.lib: update logical-fields for ND

From: Zongkai LI This patch updates symbols in logical-fields for ND, such as "nd", "nd.target", "nd.sll", "nd.tll", to describe more clear about "icmp6.type" predicate. And it adds new symbols: - "nd_rs" stands for Router Solicitation message, - "nd_ra" stands for Router

Re: [ovs-dev] [PATCH v1] ovn: rename Address_Set to Set to reflect a more broad purpose

On Fri, Aug 12, 2016 at 1:33 AM, Russell Bryant <russ...@ovn.org> wrote: > > On Tue, Aug 9, 2016 at 11:55 PM, Zong Kai LI <zealo...@gmail.com> wrote: >> >> This patch renames table Address_Set to Set, Address_Set.addresses to >> Set.members to reflect a more bro

Re: [ovs-dev] [PATCH v1] ovn: rename Address_Set to Set to reflect a more broad purpose

On Thu, Aug 11, 2016 at 1:51 PM, Han Zhou <zhou...@gmail.com> wrote: > > > On Tue, Aug 9, 2016 at 8:55 PM, Zong Kai LI <zealo...@gmail.com> wrote: >> >> This patch renames table Address_Set to Set, Address_Set.addresses to >> Set.members to reflect a more

Re: [ovs-dev] [PATCH v1] ovn: Extend Address_Set to Macros to support define port name sets

On Thu, Aug 4, 2016 at 7:46 PM, Russell Bryant <russ...@ovn.org> wrote: > > > On Wed, Aug 3, 2016 at 6:31 PM, Ben Pfaff <b...@ovn.org> wrote: >> >> On Wed, Aug 03, 2016 at 11:14:20PM +0800, Zong Kai LI wrote: >> > This patch aims to extend Address_Set to

[ovs-dev] [PATCH v1] ovn: rename Address_Set to Set to reflect a more broad purpose

Kai LI <zealo...@gmail.com> --- ovn/controller/lflow.c| 22 +++--- ovn/northd/ovn-northd.c | 26 +- ovn/ovn-nb.ovsschema | 12 ++-- ovn/ovn-nb.xml| 13 +++-- ovn/ovn-sb.ovsschema | 12 ++-- ovn/ovn-

Re: [ovs-dev] [PATCH v1] ovn: Extend Address_Set to Macros to support define port name sets

On Thu, Aug 4, 2016 at 6:31 AM, Ben Pfaff <b...@ovn.org> wrote: > On Wed, Aug 03, 2016 at 11:14:20PM +0800, Zong Kai LI wrote: >> This patch aims to extend Address_Set to Macros, make it more common to >> accept variable set, not only address. And by that, we can skinny do

[ovs-dev] [PATCH v1] ovn: Extend Address_Set to Macros to support define port name sets

rmance on installation plenty of similar ACLs/lflows. For port comes and leaves scenario, when there are no special ACL entries assigned to ports, it will be the ones first come and last leave to update ACL uuid refers in Logical_Switch.acl. TODO: - go check how will ovn-northd use port sets defined under M

Re: [ovs-dev] [PATCH RFC] ovn: Extend Address_Set to Macros_Set to support define port sets

On Wed, Aug 3, 2016 at 7:56 PM, Russell Bryant <russ...@ovn.org> wrote: > > > On Wed, Aug 3, 2016 at 7:01 AM, Zong Kai LI <zealo...@gmail.com> wrote: >> >> This patch aims to extend Address_Set to Macros_Set, make it more common >> to >> accept variab

[ovs-dev] [PATCH RFC] ovn: Extend Address_Set to Macros_Set to support define port sets

ng work quicker. Port set defined under Macros_Set will improve ovn-controller performance on installation plenty of similar ACLs/lflows, but not for port comes and leaves scenario. Potential drawback: not sure yet. TODO: go check how will ovn-northd use port sets defined under Macros_Set Signe

[ovs-dev] [PATCH RFC v2 2/3] ovn: add SLAAC support for IPv6

This patch tries to implement Router Advertisement (RA) responder for SLAAC on ovn-controller side. It parses lflows which have: - match: inport == LRP_NAME && ip6.dst == ff02::2 && nd_rs (nd_rs: icmp6.type == 133 && icmp6.code == 0 && ttl == 255) - action: nd_ra{slaac(prefix,...,MTU,

[ovs-dev] [PATCH RFC v2 3/3] ovn: add SLAAC support for IPv6

This patch tries to implement Router Advertisement (RA) responder for SLAAC on ovn-northd side. It tries to build lflows per each Logical Router Port, who have IPv6 networks and set their 'slaac' column to true. The lflows will look like: match=(inport ==

[ovs-dev] [PATCH RFC v2 1/3] ovn: add SLAAC support for IPv6

This patch introduces methods to compose a Router Advertisement (RA) packet, introduces flags for RA, renames ovs_nd_opt to ovs_nd_lla_opt to specify it's Source/Target Link-layer Address option. Signed-off-by: Zong Kai LI <zealo...@gmail.com> --- lib/flow.c| 26 - l

[ovs-dev] [PATCH RFC v2 0/3] ovn: add SLAAC support for IPv6

ess, such as fa:16:3e:32:3c:e0. After a RA packet is composed, the left nested actions will make RA packet transmitted back to the inport, where Router Solicitation (RS) packet comes. For more details, will be described in each following patches. Zong Kai LI (1): ovn: add SLAAC support for IP

[ovs-dev] [PATCH v1] ovn-test: add flags.loopback to test-ovn

Action "flags.loopback" is introduced recently, but symtab in test-ovn doesn't recognize it yet. This may cause action parsing test broken. This patch fixes that. Signed-off-by: Zong Kai LI <zealo...@gmail.com> --- tests/test-ovn.c | 7 +++ 1 file changed, 7 insertions(+) di

Re: [ovs-dev] [PATCH RFC v1] ovn: add SLAAC support for IPv6

On Thu, Jul 28, 2016 at 2:04 PM, Ben Pfaff <b...@ovn.org> wrote: > On Wed, Jul 27, 2016 at 04:02:11PM +0800, Zong Kai LI wrote: >> This patch introduces(from north to south): >> - OVN NB DB: >> * mtu(integer) column for Logical_Switch, used by Router Advertisement &g

[ovs-dev] [PATCH RFC v1] ovn: add SLAAC support for IPv6

m not sure whether it's good to keep use 'continuation'. Signed-off-by: Zong Kai LI <zealo...@gmail.com> --- lib/packets.c| 105 +++ lib/packets.h| 58 ++ ovn/controller

[ovs-dev] [PATCH] [PATCH v1] ovn-northd: Fix {}-enclosed constants for ND responder

It missed comma as constant seperator in match string for ND responder. Signed-off-by: Zong Kai LI <zealo...@gmail.com> --- ovn/northd/ovn-northd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index a3d1672..8e5c5c5

Re: [ovs-dev] [ovn-ipv6 24/26] [RFC] ovn-northd: Implement basic IPv6 routing.

> dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev I tested this patch on my 2 chassis environment, with manually rebased, with ping test between VMs from different subnets attached on the same router. And it works. Thanks. Zong Kai, LI ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] [PATCH v1] ovs-dev: add set type for ovs.idl.data.Datum.from_python

-by: Zong Kai LI <zealo...@gmail.com> --- python/ovs/db/data.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/ovs/db/data.py b/python/ovs/db/data.py index 747acd5..6d87f89 100644 --- a/python/ovs/db/data.py +++ b/python/ovs/db/data.py @@ -521,7 +521,7 @@ class Datum(

Re: [ovs-dev] [ovn-ipv6 06/26] ovn: Renumber logical field registers to the newly extended registers.

On Wed, Jul 20, 2016 at 4:50 AM, Justin Pettit <jpet...@ovn.org> wrote: > >> On Jul 13, 2016, at 3:19 AM, Zong Kai Li <zealo...@gmail.com> wrote: >> >> Hi, Justin. I tried your patches one by one. P1~P5 are OK. >> But something wrong seems happened to P6. &g

[ovs-dev] [PATCH] [PATCH v1] ovs python: add set type for from_python

python. Signed-off-by: Zong Kai LI <zealo...@gmail.com> --- python/ovs/db/data.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/ovs/db/data.py b/python/ovs/db/data.py index 747acd5..6d87f89 100644 --- a/python/ovs/db/data.py +++ b/python/ovs/db/data.py @@ -521,7

Re: [ovs-dev] [ovn-ipv6 06/26] ovn: Renumber logical field registers to the newly extended registers.

>On Wed, Jul 13, 2016 at 6:19 PM, Zong Kai Li <zealo...@gmail.com> wrote: > Hi, Justin. I tried your patches one by one. P1~P5 are OK. > But something wrong seems happened to P6. > In my OpenStack integrated environment, after using P6, I cannot ping > VM dhcp netns. And

Re: [ovs-dev] [ovn-ipv6 06/26] ovn: Renumber logical field registers to the newly extended registers.

for MFF_LOG_DNAT_ZONE...MFF_LOG_OUTPORT, and this time, table OFTABLE_PHY_TO_LOG comes back. I hope you can check this. Thanks, Zong Kai, LI ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [ovn-ipv6 07/26] ovn: Add xxreg[01] symbols.

>On Wed, Jul 13, 2016 at 11:24 AM, Justin Pettit <jpet...@ovn.org> wrote: > >> On Jul 12, 2016, at 7:53 PM, Zong Kai Li <zealo...@gmail.com> wrote: >> >>> + >>> +The regX symbols are 32-bit integers. >>> +The xxregX

Re: [ovs-dev] [ovn-ipv6 07/26] ovn: Add xxreg[01] symbols.

MFF_REG7 to MFF_REG11...MFF_REG15. REGBIT_CONNTRACK_** which are using MFF_REG0 should be renumbered too. Thanks. Zong Kai, LI ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [ovn-ipv6 14/26] ovn: Support multiple addresses on a single logical router port.

ther a switch or another router, and a lsp.peer should either be empty or be set with another lsp.name. So when a lrp has its nbr->peer been set, we should parse current network and mac column for it. For peer router port still these to build static route. And when a lrp has empty nbr->peer, we can let lsp processing branch in join_logical_ports to extract addresses for it. And even, for op is lrp and op->peer->nbs is NULL case, we can directly use ip, network, mask via op->peer, without extracting addresses for lrp at first. I can't figure why a patched lsp and lrp could have different addresses, networks, masks, macs. So I think this should make sense. :) Thanks. Zong Kai, LI ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [ovn-ipv6 16/26] packets: Cleanup ND compose functions.

GNED_CAST does not solve a problem, it only suppresses a warning.". So I'm not sure will this be a good way to cleanup. Thanks. Zong Kai, LI ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] [Patch v1] ovn-controller: ignore lflow matching remote VM port

rt, it will have 50 + C flows been installed in table ls_in_port_sec_l2 on each node. Signed-off-by: Zong Kai LI <zealo...@gmail.com> --- ovn/controller/lflow.c | 42 +++-- ovn/controller/lflow.h | 3 ++- ovn/controller/ovn

[ovs-dev] [PATCH] [RFC Patch] ovn-controller: ignore lflow matching remote VM port

ss pipeline, when it tries to match a VM(or VIF) port that doesn't belong to current chassis. This can help ovn-controller to avoid to install many unnecessary flows. Signed-off-by: Zong Kai LI <zealo...@gmail.com> --- ovn/controller/lflow.c | 42 +

Re: [ovs-dev] [PATCH v4] ovn-northd: Add logical flows to support native DHCPv4

On Wed, Jul 6, 2016 at 5:14 PM, Numan Siddique <nusid...@redhat.com> wrote: > > > On Tue, Jul 5, 2016 at 12:04 PM, Zong Kai LI <zealo...@gmail.com> wrote: > >> +/* Logical switch ingress table 10 and 11: DHCP options and response >>> + * priori

Re: [ovs-dev] [PATCH 7/7] ovn-northd: Logical flows for load balancers.

I suppose this is another place will cause load balance failure. Thanks. Zong Kai, LI ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v4] ovn-northd: Add logical flows to support native DHCPv4

CP_RESPONSE, 0, "1", > "next;"); > +} > Great work, but only one thing makes me feel uncomfortable. DHCP Options flows are generated per each port, but not per each switch datapath. Since the resumed packet copies L2-L4 fields from original packet, and DHCP options fields are the same for each port in the same switch. It doesn't make sense to build DHCP Options flows for each ports. The inport and eth.src in DHCP Options flows, I think we need logical switch metadata field indeed. Thanks and have a nice day. Zong Kai, LI ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 7/7] ovn-northd: Logical flows for load balancers.

_lflow_add(lflows, od, S_SWITCH_IN_LB, > + 120, ds_cstr(), action); > +} else { > +ovn_lflow_add(lflows, od, S_SWITCH_IN_LB, > + 110, ds_cstr(), action); > +} > S_SWITCH_IN_LB, I think you missed to put them into method build_lb. > + > +ds_destroy(); > +free(action); > + } > +} > } > > Thanks. Zong Kai, LI ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 5/7] ovn-nb: Add Load-balancer table to schema.

10.0.0.1:80, 10.0.0.2:80,10.0.0.3:80"' vips:'"30.0.0.1:5000"'='"10.0.0.1:80,10.0.0.2:80, 10.0.0.3:80"', this time it get correctly parsed in ovn-northd. Woud you mind to update the description here to notice it's a list of maps, or/and give some examples? Thanks. Zong Kai

Re: [ovs-dev] [PATCH 4/7] ovn-northd: Introduce stateful table.

t. */ > +ovn_lflow_add(lflows, od, S_SWITCH_IN_STATEFUL, 0, "1", "next;"); > +ovn_lflow_add(lflows, od, S_SWITCH_OUT_STATEFUL, 0, "1", "next;"); > if we allow non-stateful stuff to skip PRE_STATEFUL and STATEFUL table, we will don't need the default next action in the two tables. Thanks, Zong Kai, LI ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 3/7] ovn-northd: Introduce pre-stateful table.

REGBIT_CONNTRACK_DEFRAG" == 1", "ct_next;"); > +ovn_lflow_add(lflows, od, S_SWITCH_OUT_PRE_STATEFUL, 100, > + REGBIT_CONNTRACK_DEFRAG" == 1", "ct_next;"); > +} > I hope you can also modify the default next lflo

Re: [ovs-dev] [PATCH 2/7] ovn-northd.8: Update documentation.

from-lport" to make table name simpler and clearer? > Ingress table 4: from-lport ACLs > > - This is similar to ingress table 3 except for to-lport > - traffic. > + This is similar to ingress table Pre-ACLs except for > + to-lport traffic. >

Re: [ovs-dev] [PATCH v6 2/2] ovn: Add address_set() support for ACLs.

I've tested this serial patches, it works as expected. Only one thing I'm not sure: diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c > index a12b247..d85efd5 100644 > --- a/ovn/utilities/ovn-sbctl.c > +++ b/ovn/utilities/ovn-sbctl.c > @@ -779,6 +779,10 @@ static const struct

Re: [ovs-dev] [PATCH v2] ovn-northd: Add logical flows to support native DHCPv4

32 ip; > +unsigned int plen; > +char *error = ip_parse_cidr(ctx->argv[1], , ); > +if (error){ > +/* check if its IPv6 cidr */ > +free(error); > +struct in6_addr ipv6; > +error = ipv6_parse_cidr(ctx->argv[1], , ); > + if (error)

Re: [ovs-dev] [PATCH v2] ovn-northd: Add logical flows to support native DHCPv4

_action, > _action)) { > There are some dhcp_options relevant but not lsp address relevant checking in build_dhcpv4_action. So think about it, it's unnecessary to do duplicated check when lsp has multiple addresses. @@ -43,6 +43,11 @@ > "max": "unlimited"}}, > "up": {"type": {"key": "boolean", "min": 0, "max": 1}}, > "enabled": {"type": {"key": "boolean", "min": 0, "max": > 1}}, > +"dhcpv4_options": {"type": {"key": {"type": "uuid", > +"refTable": "DHCP_Options", > +"refType": "strong"}, > Great for the refTable. That's all what I can see now. Thanks. Zong Kai, LI ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v4 2/2] ovn: Add address_set() support for ACLs.

> > +static void > +update_address_sets(struct controller_ctx *ctx) > +{ > +/* Remember the names of all address sets currently in > expr_address_sets > + * so we can detect address sets that have been deleted. */ > +struct sset cur_addr_set_names = > SSET_INITIALIZER(_addr_set_names);

Re: [ovs-dev] [PATCH v4 1/2] Add address set support.

} > + > +cs->type = EXPR_C_INTEGER; > Hi, Babu. It's odd you don't directly fix here with assign_constant_set_type, but in the following patch. Hope it doesn't matter to others. Thanks. Zong Kai, LI ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] [PATCH, v7] ovn: Add 'na' action and lflow for ND

track on ND and NA packets in following tables: - S_SWITCH_IN_PRE_ACL - S_SWITCH_OUT_PRE_ACL - S_SWITCH_IN_ACL - S_SWITCH_OUT_ACL (Rebase on upstream) Signed-off-by: Zong Kai LI <zealo...@gmail.com> --- lib/packets.c| 29 ++ lib/packets.h| 4 ++

Re: [ovs-dev] [PATCH v3 2/2] ovn: Add address_set() support for ACLs.

et_delete, sset_destroy will do it for you. > +SHASH_FOR_EACH_SAFE (node, next, _address_sets) { > +sbrec_address_set_delete(node->data); > + shash_delete(_address_sets, node); > +} > +shash_destroy(_address_sets); The same, you don't need manually call shash_delete, shash_destroy will do it for you. Thanks and have a nice day! :) Zong Kai, LI ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] [PATCH v1] ovn: align lrp 'network' to lsp 'addresses'

On Fri, Jun 24, 2016 at 4:43 AM, Justin Pettit wrote: > > > diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c > > index 17713ec..5851fca 100644 > > --- a/ovn/northd/ovn-northd.c > > +++ b/ovn/northd/ovn-northd.c > > @@ -612,11 +612,12 @@ join_logical_ports(struct

[ovs-dev] [PATCH] [PATCH v1] ovn: align lrp 'network' to lsp 'addresses'

lrp port has only 1 address in 'network' column. It's inconsistent, this patch tries to fix that. Signed-off-by: Zong Kai LI <zealo...@gmail.com> --- ovn/northd/ovn-northd.c | 5 +++-- ovn/ovn-nb.ovsschema | 6 -- ovn/ovn-nb.xml| 7 +++--- ovn/utilities/ovn-nbctl.

[ovs-dev] [PATCH] [PATCH, v6] ovn: Add 'na' action and lflow for ND

track on ND and NA packets in following tables: - S_SWITCH_IN_PRE_ACL - S_SWITCH_OUT_PRE_ACL - S_SWITCH_IN_ACL - S_SWITCH_OUT_ACL Signed-off-by: Zong Kai LI <zealo...@gmail.com> --- lib/packets.c| 29 ++ lib/packets.h| 4 ++

Re: [ovs-dev] [PATCH] [PATCH, v4, 1/2] ovn-controller: Add 'na' action for ND

On Wed, Jun 15, 2016 at 10:17 PM, Ryan Moats <rmo...@us.ibm.com> wrote: > "dev" <dev-boun...@openvswitch.org> wrote on 06/14/2016 10:09:37 PM: > > > From: Zong Kai LI <zealo...@gmail.com> > > To: dev@openvswitch.org > > Cc: Zong Kai L

[ovs-dev] [PATCH] [PATCH, v5] ovn: Add 'na' action and lflow for ND

track on ND and NA packets in following tables: - S_SWITCH_IN_PRE_ACL - S_SWITCH_OUT_PRE_ACL - S_SWITCH_IN_ACL - S_SWITCH_OUT_ACL Signed-off-by: Zong Kai LI <zealo...@gmail.com> --- lib/packets.c| 29 ++ lib/packets.h| 4 ++

[ovs-dev] [PATCH] [PATCH, , v4, 2/2] ovn: add lflows for 'na' action for ND

flows will be set in tabel ls_in_arp_nd_rsp, which is renamed from previous ls_in_arp_rsp. This patch also modified current ACL lflows for ND, not to do conntrack on ND packets in following tables: - S_SWITCH_IN_PRE_ACL - S_SWITCH_OUT_PRE_ACL - S_SWITCH_IN_ACL - S_SWITCH_OUT_ACL Signed-off-by: Zong

[ovs-dev] [PATCH] [PATCH, v4, 1/2] ovn-controller: Add 'na' action for ND

lows works for this action. Signed-off-by: Zong Kai LI <zealo...@gmail.com> --- lib/packets.c| 29 ++ lib/packets.h| 4 ++ ovn/controller/pinctrl.c | 134 ++- ovn/lib/actions.c| 43 +++ o

Re: [ovs-dev] [PATCH] WIP OVN ND for Logical_Port

On Thu, Jun 9, 2016 at 12:43 AM, Justin Pettit <jpet...@ovn.org> wrote: > > > On Jun 8, 2016, at 1:12 AM, Zong Kai LI <zealo...@gmail.com> wrote: > > > > I know Justin is working on implement router patch port for IPv6 switch, > but I'm not sure whether w

Re: [ovs-dev] [PATCH] [PATCH v3 1/2] ovn-controller: Add 'na' action for ND

On Thu, Jun 9, 2016 at 5:25 AM, Ben Pfaff <b...@ovn.org> wrote: > On Wed, Jun 08, 2016 at 03:26:30PM +0800, Zong Kai LI wrote: > > This patch adds a new OVN action 'na' to support ND versus ARP. > > > > When ovn-controller received a ND packet, it frames a NA pac

Re: [ovs-dev] [PATCH] [PATCH v3 2/2] ovn: add lflows for 'na' action for ND

On Thu, Jun 9, 2016 at 5:32 AM, Ben Pfaff <b...@ovn.org> wrote: > On Wed, Jun 08, 2016 at 03:28:58PM +0800, Zong Kai LI wrote: > > This patch adds some lflows for 'na' action to support ND versus ARP. > > > > For ovn-northd, it will generate lflows per each IPv

Re: [ovs-dev] [PATCH] [PATCH v3 1/2] ovn-controller: Add 'na' action for ND

>> +These are default values that the nested actions will >> probably want >> +to change: >> + >> + >> + >> +reg0 = 0x1(Mark as replied by >> ovn-controller) >> +outport copied fr

Re: [ovs-dev] [PATCH] WIP OVN ND for Logical_Port

On Tue, Jun 7, 2016 at 5:08 AM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, May 27, 2016 at 10:32:56AM +0800, Zong Kai LI wrote: > > From: lzklibj <lzkl...@cn.ibm.com> > > > > This patch tries to implement ND for Logical_Port in OVN. > > > > Signed-of

[ovs-dev] [PATCH] [PATCH v3 2/2] ovn: add lflows for 'na' action for ND

d of NA packets are replied by ovn-controller, and for these packets, dont do conntrack on them. Also modfiy current table 32 and table 48, to make these packets output directly. Signed-off-by: Zong Kai LI <zealo...@gmail.com> --- ovn/controller/physical.c | 41 +++

[ovs-dev] [PATCH] [PATCH v3 1/2] ovn-controller: Add 'na' action for ND

do logical flows works for this action. Signed-off-by: Zong Kai LI <zealo...@gmail.com> --- lib/packets.c| 33 + lib/packets.h| 4 ++ ovn/controller/pinctrl.c | 119 +-- ovn/lib/actions.c| 50 +

[ovs-dev] [PATCH] [PATCH v2 1/2] ovn-controller: Add 'na' action for ND

do logical flows works for this action. Signed-off-by: Zong Kai LI <zealo...@gmail.com> --- lib/packets.c| 33 + lib/packets.h| 4 ++ ovn/controller/pinctrl.c | 119 +-- ovn/lib/actions.c| 50 +

[ovs-dev] [PATCH] [PATCH v2 2/2] ovn: add lflows for 'na' action for ND

d of NA packets are replied by ovn-controller, and for these packets, they dont need conntrack. So I also modfiy current table 32 and table 48, to make these packets output directly. (Will try to add test once I figure out what to test.) Signed-off-by: Zong Kai LI <zealo...@gmail.com> --- ovn/c

[ovs-dev] [PATCH] [PATCH v1 1/2] ovn-controller: Add 'na' action in ovn-controller

his action. Signed-off-by: Zong Kai LI <zealo...@gmail.com> --- ovn/controller/pinctrl.c | 119 +-- ovn/lib/actions.c| 50 ovn/lib/actions.h| 6 +++ ovn/lib/expr.c | 47 ++- ovn/lib/expr.h

[ovs-dev] [PATCH] WIP OVN ND for Logical_Port

From: lzklibj This patch tries to implement ND for Logical_Port in OVN. Signed-off-by: lzklibj --- lib/packets.c| 2 +- lib/packets.h| 3 + ovn/controller/pinctrl.c | 156 +++