Re: Release?

+1 to get a *new* SPI for the allocation (ok if we test if definingService is an instanceof it and reuse the same instance but should stay split) +1 to port the logic of tomee to OWB around unsafe with new method handles if it does not trigger any warning by default (was the reason to bypass

Re: Release?

For the sake of clarity here is our problem. We want to support JDK 17 in TomEE. For our proxy creation, we were used to using Unsafe (like OWB and a lot more). We changed that to use a method handles lookup, but still from JDK 17+ it does not work either. We have a similar service ClassDefiner

Re: Switching from Unsafe to ClassLoaderProxyService

it is because the quick and dirty change leds to use 2 services instance so test is right there and quick and dirty change is wrong ;) Romain Manni-Bucau @rmannibucau | Blog | Old Blog |

Re: Release?

Hi JL, It looks weird because we already had a fallback to use the constructor - and BTW i'm not sure the commented part of the test should be. So this shouldn't help TomEE. Do you have a test where this change helps? side note: we likely don't want to break the SPI since it is an user facing

Re: Switching from Unsafe to ClassLoaderProxyService

Quick and dirty change in AbstractProxyFactory definingService = new ClassLoaderProxyService(webBeansContext); // webBeansContext.getService(DefiningClassService.class); `mvn clean install` under JDK8 [ERROR] Failures: > [ERROR] ClassLoaderProxyServiceTest.defineInProxy:45 > expected: > but >

Re: Switching from Unsafe to ClassLoaderProxyService

Haven't look quickly but I can easily change the default again and run the build again. Le mer. 6 oct. 2021 à 08:10, Romain Manni-Bucau a écrit : > It is the only identified/expected one at least, did you spot another one? > > Romain Manni-Bucau > @rmannibucau

Re: Release?

Thanks Thomas I've created https://issues.apache.org/jira/browse/OWB-1392 And I pushed https://github.com/apache/openwebbeans/commit/2af6184ee5ec6b474f037b3c5768c82bba136722 I'd appreciate feedback, review and comments. Should have created a PR sorry. Functionally, it's the same as previously,

[jira] [Created] (OWB-1392) Fully abstract defining class service

Jean-Louis Monteiro created OWB-1392: Summary: Fully abstract defining class service Key: OWB-1392 URL: https://issues.apache.org/jira/browse/OWB-1392 Project: OpenWebBeans Issue Type:

Re: Switching from Unsafe to ClassLoaderProxyService

It is the only identified/expected one at least, did you spot another one? Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn