Re: OWB 2 not firing ProcessAnnotatedType for all bean classes

2017-07-23 Thread Eric Covener
On Sun, Jul 23, 2017 at 8:13 AM, John D. Ament wrote: > We should probably review on cdi-dev. I believe the intention behind > saying "classes discovered" [1] is to indicate that its for all classes, > not just eligible beans. Here's a use case: I have framework specific > classes, where the de

Re: rename owb-2.0 to owb-1.5?

2014-08-30 Thread Eric Covener
On Sat, Aug 30, 2014 at 3:01 AM, Mark Struberg wrote: > What about renaming our current trunk to 1.5.0-SNAPSHOT? +1, awfully confusing w/o it. -- Eric Covener cove...@gmail.com

Re: BDA scanning via isBDABeansXmlScanningEnabled

2014-05-11 Thread Eric Covener
On Sun, May 11, 2014 at 4:55 PM, Mark Struberg wrote: > The current impl of isBDABeansXmlScanningEnabled() is pretty much > disfunctional. > This has to do that the BDA specification in CDI-1.1 is not as clear as it > should be. +1. IMO even if 1.1 is still unclear, it stil seems to have dista

Re: [VOTE] Release Apache OpenWebBeans-1.2.2

2014-02-20 Thread Eric Covener
err once more with dev@ On Thu, Feb 20, 2014 at 11:19 AM, Eric Covener wrote: >> Source Release: >> http://repository.apache.org/content/repositories/orgapacheopenwebbeans-1001/org/apache/openwebbeans/openwebbeans/1.2.2/openwebbeans-1.2.2-source-release.zip > > +1 --

Re: targetting CDI-1.1 in trunk

2014-01-26 Thread Eric Covener
> I suggest we move the current trunk to an owb_1.2.x branch and move our > trunk to target the new CDI-1.1 MR release (as discussed in November > already). > Then I'll go on and cut an owb-1.2.2 release from the branch. +1

[jira] [Commented] (OWB-771) Invocation​ContextImpl cleans target field if occurs an exception

2013-02-12 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577118#comment-13577118 ] Eric Covener commented on OWB-771: -- I don't think this assignment accomplishes

[jira] [Updated] (OWB-568) Decorater for generic Interfaces does not work

2012-12-21 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener updated OWB-568: - Attachment: owb-trunk-generic_decorator.diff I took the approach of removing types from the bean types of

[jira] [Commented] (OWB-738) CODI @ConversationScope + @Stateful in a bean = java.lang.StackOverflowError

2012-12-15 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533046#comment-13533046 ] Eric Covener commented on OWB-738: -- The confusing part is why it needs to call Context

[jira] [Commented] (OWB-738) CODI @ConversationScope + @Stateful in a bean = java.lang.StackOverflowError

2012-12-15 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533043#comment-13533043 ] Eric Covener commented on OWB-738: -- AFAICT WSEjbBean is calling Context.get wit

Re: New OpenWebBeans home page

2012-12-13 Thread Eric Covener
Looks good here, but I would suggest the non-mandatory feather at least on the index but preferrably in the top nav pane.

Re: [VOTE] release Apache OpenWebBeans 1.1.5

2012-08-09 Thread Eric Covener
> Source release: > https://repository.apache.org/content/repositories/orgapacheopenwebbeans-126/org/apache/openwebbeans/openwebbeans/1.1.5/openwebbeans-1.1.5-source-release.zip +1

Re: [VOTE] take2 Release Apache OpenWebBeans-1.1.4

2012-04-08 Thread Eric Covener
> https://svn.apache.org/repos/asf/openwebbeans/tags/openwebbeans-1.1.4/ > > Source release: > > https://repository.apache.org/content/repositories/orgapacheopenwebbeans-007/org/apache/openwebbeans/openwebbeans/1.1.4/openwebbeans-1.1.4-source-release.zip +1

Re: OWB Decorators

2012-04-02 Thread Eric Covener
>> Is this a bug or is it not allowed to call other methods than the decorated >> one >> in the decorator method? I think the behavior he expects is the correct behavior, having not looked at the code, as the stack unwinds we need to back up the decorator we're looking at as "next".

Re: [DISCUSS] remove webbeans-openejb module from OWB

2012-03-22 Thread Eric Covener
>> > > Thus I'd like to remove the webbeans-openejb module from OWB. +1 on any branch other than 1.0.

[jira] [Commented] (OWB-655) CDI doesn´t inject stateless EJB by abstract class.

2012-03-21 Thread Eric Covener (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OWB-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234928#comment-13234928 ] Eric Covener commented on OWB-655: -- We wouldn't inject an abstract class, we'

[jira] [Commented] (OWB-655) CDI doesn´t inject stateless EJB by abstract class.

2012-03-21 Thread Eric Covener (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OWB-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234813#comment-13234813 ] Eric Covener commented on OWB-655: -- Does it really require the base class to be abst

[jira] [Resolved] (OWB-649) exceptions in EJB's are wrapped in InvocationTargetException

2012-02-23 Thread Eric Covener (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/OWB-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-649. -- Resolution: Fixed > exceptions in EJB's are wrapped in InvocationTargetE

[jira] [Created] (OWB-649) exceptions in EJB's are wrapped in InvocationTargetException

2012-02-23 Thread Eric Covener (Created) (JIRA)
: Bug Components: Enterprise Web Beans Affects Versions: 1.1.3 Reporter: Eric Covener Assignee: Eric Covener Fix For: 1.1.4 When an EJB is @Injected and the EjbBeanproxyHandler is used as the javassist MethodHandler, exceptions become wrapp

Re: [VOTE] Release Apache OpenWebBeans-1.1.3

2011-12-04 Thread Eric Covener
> https://repository.apache.org/content/repositories/orgapacheopenwebbeans-291/org/apache/openwebbeans/openwebbeans/1.1.3/openwebbeans-1.1.3-source-release.zip +1

Re: [VOTE] Release Apache OpenWebBeans-1.1.2

2011-10-19 Thread Eric Covener
> Source release: > https://repository.apache.org/content/repositories/orgapacheopenwebbeans-072/org/apache/openwebbeans/openwebbeans/1.1.2/openwebbeans-1.1.2-source-release.zip +1 for GA

Re: Status of our AnnotatedType integration + Class Scanning

2011-07-21 Thread Eric Covener
> B.) Create the Beans solely based on the AnnotatedType and ditch the > 'default' bean creation (see AbstractBeanCreator#isDefaultMetaDataProvider()) +1 here IIUC, we provide scanner-service produced AnnotatedType's and just allow them to be replaced by extensions.

Re: svn commit: r1079926 - /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/inject/AbstractInjectable.java

2011-06-04 Thread Eric Covener
list > +        if (!WebBeansUtil.isStaticInjection(injectionPoint) && > WebBeansUtil.isDependent(injectedBean)) > +        { > +            if(instanceUnderInjection.get() != null) > +            { > +                 > ((CreationalContextImpl)this.injectionOwnerCreationalContext

Re: [VOTE] release Apache OpenWebBeans 1.1.0

2011-03-25 Thread Eric Covener
> Source release: > https://repository.apache.org/content/repositories/orgapacheopenwebbeans-040/org/apache/openwebbeans/openwebbeans/1.1.0/openwebbeans-1.1.0-source-release.zip +1 (sigs, checksums, built and did reasonably well on standalone TCK)

[jira] [Updated] (OWB-488) move WebBeansConfigurationException messages to message bundles

2011-03-21 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener updated OWB-488: - Fix Version/s: 1.2.0 > move WebBeansConfigurationException messages to message bund

[jira] [Updated] (OWB-479) detect loops in producer beans vs. producer method parameters at deployment time

2011-03-21 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener updated OWB-479: - Fix Version/s: 1.2.0 > detect loops in producer beans vs. producer method parameters at deployment >

Re: Fwd: [jira] Commented: (OWB-472) archive centric beans.xml enabling

2011-02-13 Thread Eric Covener
On Sun, Feb 13, 2011 at 4:23 PM, Mark Struberg wrote: > https://issues.jboss.org/browse/CDI-18 > My personal fear is that this will quickly lead to lots of follow up failures > like one can currently see in glassfish and JBossAS. The concept or the code we have? What failure in the other server

Re: [jira] Commented: (OWB-472) archive centric beans.xml enabling

2011-02-13 Thread Eric Covener
On Sun, Feb 13, 2011 at 4:12 PM, Gerhard wrote: > yes - it's non-intrusive because i fixed it. Non-intrusive in terms of technical rationale to call for a revert, not non-intrusive in terms of you had to refactor to use trunk in an appserver. > however, we have a spi (ScannerService) for such ad

Fwd: [jira] Commented: (OWB-472) archive centric beans.xml enabling

2011-02-13 Thread Eric Covener
nables the interceptor defined in > a.jar (ends up enabled for beans from either archive if enabled in one > -- this is in the more troubling neighborhood)..." -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira -- Eric Covener cove...@gmail.com

Re: Yan:: svn commit: r1042754 - /openwebbeans/trunk/webbeans-jsf/src/main/resources/META-INF/faces-config.xml

2010-12-08 Thread Eric Covener
On Wed, Dec 8, 2010 at 1:25 PM, David Jencks wrote: > Investigating this is taking longer than I hoped.  There's a tck test for > 6.4.3, but it doesn't test most of the requirements in 6.4.3 and it's not > clear to me that it has any relevance to how EL would work in a jsp or jsf > page since t

Re: Proxy problems

2010-12-07 Thread Eric Covener
applications that would not be > acceptable for the next OWB release?  If so, why? I don't see any sense in ripping it out without taking the time to wrap it in an SPI, so people impacted negatively by the alternative have some recourse. -- Eric Covener cove...@gmail.com

[jira] Created: (OWB-488) move WebBeansConfigurationException messages to message bundles

2010-11-04 Thread Eric Covener (JIRA)
Components: Core Affects Versions: 1.0.0 Reporter: Eric Covener Assignee: Gurkan Erdogdu lots of grave WebBeansConfigurationException use string literals for stuff that ought to be translatable. -- This message is automatically generated by JIRA. - You can

[jira] Commented: (OWB-487) Section 5.5.7 restrictions on injecting InjectionPoint not enforced

2010-10-28 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926028#action_12926028 ] Eric Covener commented on OWB-487: -- I think this is best read as "... qualifiers

[jira] Commented: (OWB-485) AmbiguousResolutionException doesn't print details about the injection point

2010-10-26 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925226#action_12925226 ] Eric Covener commented on OWB-485: -- thanks, got it in r102

[jira] Resolved: (OWB-485) AmbiguousResolutionException doesn't print details about the injection point

2010-10-26 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-485. -- Resolution: Fixed > AmbiguousResolutionException doesn't print details about the injecti

[jira] Created: (OWB-485) AmbiguousResolutionException doesn't print details about the injection point

2010-10-26 Thread Eric Covener (JIRA)
Beans Issue Type: Improvement Components: Injection and Lookup Affects Versions: 1.0.0 Reporter: Eric Covener Assignee: Eric Covener Priority: Minor Fix For: 1.1.0 AmbiguousResolutionException doesn't print details about the injec

[jira] Created: (OWB-479) detect loops in producer beans vs. producer method parameters at deployment time

2010-10-21 Thread Eric Covener (JIRA)
Issue Type: Improvement Components: Injection and Lookup Affects Versions: 1.0.0 Reporter: Eric Covener Assignee: Gurkan Erdogdu Priority: Minor Currently OWB can cause a stack overflow if a parameter on a producer method is satisfied by

Re: Maintenance on owb_1.0_x Branch

2010-10-20 Thread Eric Covener
On Wed, Oct 20, 2010 at 12:06 PM, Mark Struberg wrote: > small addendum: we must _only_ touch the 1.0.x branch if this is really an > important issue. That means, a blocker or something similar. > > All new features + improving capabilities should _only_ be done in > 1.1.0-SNAPSHOT (aka our trun

Re: [VOTE] release Apache OpenWebBeans-1.0.0 2nd try

2010-10-13 Thread Eric Covener
> Vote will be open for 72 hours. [ ] +1 approve [ ] +0 no opinion [ ] -1 veto > (and reason why) +1

Re: [ANN] Welcome Rohit Kelapure as new committer!

2010-10-08 Thread Eric Covener
On Wed, Oct 6, 2010 at 2:48 AM, Gurkan Erdogdu wrote: > All, > > The OpenWebBeans PMC is pleased to announce  that Rohit Kelapure has accepted > our invitation to join OWB as committer. > Congrats Rohit!

Re: [ANN] Welcome Paul J Reder as new committer!

2010-10-08 Thread Eric Covener
On Fri, Oct 8, 2010 at 12:41 PM, Mark Struberg wrote: > Hi folks! > > The Apache OpenWebBeans PMC is pleased to announce  that Paul J Reder has > accepted > our invitation to join OWB as a committer. Congrats Paul! -- Eric Covener cove...@gmail.com

[jira] Resolved: (OWB-465) enhance EJB common code for crude @LocalBean support

2010-09-30 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-465. -- Resolution: Fixed > enhance EJB common code for crude @LocalBean supp

Re: svn commit: r1003072 - in /openwebbeans/trunk/webbeans-ejb/src/main/java/org/apache/webbeans/ejb/common/component: BaseEjbBean.java EjbBeanCreatorImpl.java

2010-09-30 Thread Eric Covener
On Thu, Sep 30, 2010 at 10:18 AM, wrote: > Author: covener > Date: Thu Sep 30 14:18:17 2010 > New Revision: 1003072 sorry Mark -- I know we are pseudo-frozen but need this [safe] hook for container integration.

[jira] Created: (OWB-465) enhance EJB common code for crude @LocalBean support

2010-09-30 Thread Eric Covener (JIRA)
: Java EE Integration Affects Versions: 1.0.0-alpha-2 Reporter: Eric Covener Assignee: Eric Covener Priority: Minor Fix For: 1.0.0-GA I need a small enhancement to expose no-interface local views for EJB to the 299 Api Types. I am not sure if this

Re: last TCK run

2010-09-30 Thread Eric Covener
On Thu, Sep 30, 2010 at 9:20 AM, Mark Struberg wrote: > and the others? > Failed tests: testDestroyedInstanceMustNotBeReturnedByGet(org.jboss.jsr299.tck.tests.context.DestroyedInstanceReturnedByGetTest) testBindingTypesAppliedToDisposalMethodParameters(org.jboss.jsr299.tck.tests.implementat

Re: last TCK run

2010-09-30 Thread Eric Covener
On Thu, Sep 30, 2010 at 8:57 AM, Mark Struberg wrote: > Hi! > > Before doing a release this afternoon, I'm currently running the TCK again. > > For standalone, I have one test which fails: > DestroyedInstanceReturnedByGetTest > > Anyone knows anything about it? > That's one of three I am used to

Re: ambiguous dependencies when using multiple qualifiers

2010-09-29 Thread Eric Covener
ing, the container will select this bean, and the ambiguous dependency is called resolvable." The spec says both producers satisfy the injection point, and does not allow it to discard the one with additional qualifiers. -- Eric Covener cove...@gmail.com

[jira] Resolved: (OWB-463) EjbDefinitionUtility.defineEjbBeanProxy() should be able to create proxies for no-interface local beans

2010-09-28 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-463. -- Resolution: Fixed > EjbDefinitionUtility.defineEjbBeanProxy() should be able to create proxies >

[jira] Created: (OWB-463) EjbDefinitionUtility.defineEjbBeanProxy() should be able to create proxies for no-interface local beans

2010-09-28 Thread Eric Covener (JIRA)
/browse/OWB-463 Project: OpenWebBeans Issue Type: Improvement Components: Java EE Integration Affects Versions: 1.0.0-alpha-2 Reporter: Eric Covener Assignee: Eric Covener Fix For: 1.0.0-alpha-3 Sometimes callers of

[jira] Resolved: (OWB-456) When multiple interceptors are defined for a bean OWB does NOT correctly remove the overriden base Interceptors

2010-09-28 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-456. -- Assignee: Eric Covener (was: Gurkan Erdogdu) Resolution: Fixed Thanks Rohit -- committed in

Re: svn commit: r1002175 - in /openwebbeans/trunk: pom.xml webbeans-ejb/pom.xml webbeans-openejb/pom.xml webbeans-porting/pom.xml webbeans-tck/pom.xml

2010-09-28 Thread Eric Covener
On Tue, Sep 28, 2010 at 10:23 AM, wrote: > Author: struberg > Date: Tue Sep 28 14:23:42 2010 > New Revision: 1002175 > > URL: http://svn.apache.org/viewvc?rev=1002175&view=rev > Log: > OWB-460 fix ejb artifact Ids > > owb-ejb -> owb-openejb > owb-ejb-common -> owb-ejb Thanks Mark!

Re: [DISCUSS] releasing owb-1.0.0-alpha-3

2010-09-28 Thread Eric Covener
if they were just ejb-common/ejb-common and ejb-openejb/ejb-openejb (or openejb/openejb) it would be less confusing. Of course I have no idea of the conventions in this area, the packaging ramifications, or am able to actually do the work :) -- Eric Covener cove...@gmail.com

Re: [cwiki] owb-committers

2010-09-28 Thread Eric Covener
On Tue, Sep 28, 2010 at 9:07 AM, Gerhard wrote: > @committers: > please post your confluence user-names and i'll add them to the > committers-group. > Thanks for this -- I just registered with cove...@apache.org as username.

Re: [DISCUSS] releasing owb-1.0.0-alpha-3

2010-09-28 Thread Eric Covener
FYI trying to get OWB-456 in today before tag

[jira] Resolved: (OWB-422) Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.

2010-09-27 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-422. -- Fix Version/s: 1.0.0-alpha-3 (was: 1.0.0-GA) Resolution: Fixed committed

Re: [DISCUSS] remove logging for "Calling method on proxy is restricted except Object.toString()"

2010-09-23 Thread Eric Covener
proxy. -- Eric Covener cove...@gmail.com

Re: [DISCUSS] remove logging for "Calling method on proxy is restricted except Object.toString()"

2010-09-23 Thread Eric Covener
gging. > I wonder if we could note it in the log once per Bean type, so we know that the app is using the undefined behavior Object methods. -- Eric Covener cove...@gmail.com

[jira] Commented: (OWB-447) unnecessary contextual/non-contextual distinction in OpenWebBeansEJBIntercpetor

2010-09-21 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913269#action_12913269 ] Eric Covener commented on OWB-447: -- I don't know how I managed it, but I ma

[jira] Resolved: (OWB-453) add a flag to disable context activation in EJB interceptor

2010-09-21 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-453. -- Resolution: Fixed > add a flag to disable context activation in EJB intercep

[jira] Resolved: (OWB-455) IllegalArgument method calling remove method of EJB during destroy

2010-09-19 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-455. -- Resolution: Fixed > IllegalArgument method calling remove method of EJB during dest

[jira] Created: (OWB-455) IllegalArgument method calling remove method of EJB during destroy

2010-09-19 Thread Eric Covener (JIRA)
Components: Java EE Integration Affects Versions: 1.0.0-alpha-2 Reporter: Eric Covener Assignee: Eric Covener Priority: Minor Fix For: 1.0.0-alpha-3 Caused by: java.lang.IllegalArgumentException: object is not an instance of declaring

[jira] Updated: (OWB-454) ClassUtil.callInstanceMethod() doesn't propogate original exception

2010-09-19 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener updated OWB-454: - Fix Version/s: 1.0.0-alpha-3 > ClassUtil.callInstanceMethod() doesn't propogate original e

[jira] Resolved: (OWB-454) ClassUtil.callInstanceMethod() doesn't propogate original exception

2010-09-19 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-454. -- Resolution: Fixed > ClassUtil.callInstanceMethod() doesn't propogate original e

[jira] Created: (OWB-454) ClassUtil.callInstanceMethod() doesn't propogate original exception

2010-09-19 Thread Eric Covener (JIRA)
: Bug Components: Core Affects Versions: 1.0.0-alpha-2 Reporter: Eric Covener Assignee: Eric Covener ClassUtil.callInstanceMethod() doesn't propogate original exception up the stack -- This message is automatically generated by JIRA. - You can reply to

[jira] Created: (OWB-453) add a flag to disable context activation in EJB interceptor

2010-09-15 Thread Eric Covener (JIRA)
Versions: 1.0.0-alpha-2 Reporter: Eric Covener Assignee: Eric Covener Fix For: 1.0.0-alpha-3 Some containers might activate contexts in some other way (another dedicated interceptor, or even something else), so make the OpenWebBeansEJBInterceptor conditionally

[jira] Resolved: (OWB-318) multiple methods with same EJB @interceptors(foo.class) in same bean class get multiple interceptor instances

2010-09-10 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-318. -- Fix Version/s: 1.0.0-alpha-3 (was: 1.0.0-alpha-1) Resolution: Fixed

[jira] Commented: (OWB-318) multiple methods with same EJB @interceptors(foo.class) in same bean class get multiple interceptor instances

2010-09-10 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908118#action_12908118 ] Eric Covener commented on OWB-318: -- whoops, I had DEBUG logging set at JRE level for

[jira] Commented: (OWB-318) multiple methods with same EJB @interceptors(foo.class) in same bean class get multiple interceptor instances

2010-09-10 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908101#action_12908101 ] Eric Covener commented on OWB-318: -- something wrong after applying the patch, mvn -D

[jira] Reopened: (OWB-318) multiple methods with same EJB @interceptors(foo.class) in same bean class get multiple interceptor instances

2010-09-09 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener reopened OWB-318: -- reopening per Rohit > multiple methods with same EJB @interceptors(foo.class) in same bean class &g

Re: Please reopen OWB-318, patch attached

2010-09-09 Thread Eric Covener
> After applying the attached patch (owb-318-patch.diff) this TCK test passes > successfully. reopened, but didn't see an email attachment. Can you attach it to OWB-318? https://issues.apache.org/jira/browse/OWB-318 -- Eric Covener cove...@gmail.com

[jira] Resolved: (OWB-451) Allow InterceptorUtil#callAroundInvokes to propogate a callers 'creational context key'

2010-09-08 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-451. -- Resolution: Fixed > Allow InterceptorUtil#callAroundInvokes to propogate a callers 'creational &

[jira] Created: (OWB-451) Allow InterceptorUtil#callAroundInvokes to propogate a callers 'creational context key'

2010-09-08 Thread Eric Covener (JIRA)
Project: OpenWebBeans Issue Type: Improvement Components: Java EE Integration Affects Versions: 1.0.0-alpha-2 Reporter: Eric Covener Assignee: Eric Covener Priority: Minor Fix For: 1.0.0-alpha-3 For EJB's, it's han

[jira] Commented: (OWB-447) unnecessary contextual/non-contextual distinction in OpenWebBeansEJBIntercpetor

2010-09-07 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907018#action_12907018 ] Eric Covener commented on OWB-447: -- re: referencing thread-locals beyond @PostConstrut

[jira] Resolved: (OWB-449) EJB interceptor has incorrect/unnecessary use of business method checks

2010-09-07 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-449. -- Resolution: Fixed > EJB interceptor has incorrect/unnecessary use of business method che

[jira] Created: (OWB-449) EJB interceptor has incorrect/unnecessary use of business method checks

2010-09-07 Thread Eric Covener (JIRA)
: Bug Components: Java EE Integration Affects Versions: 1.0.0-alpha-2 Reporter: Eric Covener Assignee: Eric Covener Priority: Minor EJB interceptor checks in its own @AroundInvoke whether the method is a business method but it: *) only considers

[jira] Resolved: (OWB-447) unnecessary contextual/non-contextual distinction in OpenWebBeansEJBIntercpetor

2010-09-07 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-447. -- Resolution: Fixed >>>* We should be managing a CreationalContext for the lifetime of the >&

[jira] Commented: (OWB-447) unnecessary contextual/non-contextual distinction in OpenWebBeansEJBIntercpetor

2010-09-07 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906766#action_12906766 ] Eric Covener commented on OWB-447: -- >>>Method invocations on non-contextual

[jira] Commented: (OWB-447) unnecessary contextual/non-contextual distinction in OpenWebBeansEJBIntercpetor

2010-09-06 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906602#action_12906602 ] Eric Covener commented on OWB-447: -- we also need to avoid adding the underlying ejb inst

[jira] Created: (OWB-447) unnecessary contextual/non-contextual distinction in OpenWebBeansEJBIntercpetor

2010-09-06 Thread Eric Covener (JIRA)
Issue Type: Bug Components: Enterprise Web Beans Affects Versions: 1.0.0-alpha-2 Reporter: Eric Covener Assignee: Eric Covener The separation between contextual and non-contextual is wrong/harmful and unnecessary. * We should be managing a

[jira] Resolved: (OWB-446) EJB lifecycle callbacks not stacked correctly

2010-09-06 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-446. -- Fix Version/s: 1.0.0-alpha-3 Resolution: Fixed > EJB lifecycle callbacks not stacked correc

[jira] Created: (OWB-446) EJB lifecycle callbacks not stacked correctly

2010-09-06 Thread Eric Covener (JIRA)
Affects Versions: 1.0.0-alpha-2 Reporter: Eric Covener Assignee: Eric Covener * We call proceed() on the EJB invocation context even when some 299 interceptor may not have proceeded. * The defined-in-class lifecycle callback does not happen in the same stack as the 299

Re: [VOTE] release Apache OpenWebBeans-1.0.0-alpha-2

2010-09-01 Thread Eric Covener
> Source release: > https://repository.apache.org/content/repositories/orgapacheopenwebbeans-158/org/apache/openwebbeans/openwebbeans/1.0.0-alpha-2/openwebbeans-1.0.0-alpha-2-source-release.zip +1 for alpha, tested ejb-sample in tomcat+openejb -- Eric Covener cove...@gmail.com

Re: svn commit: r932843 - in /openwebbeans/trunk/webbeans-ejb/src/main/java/org/apache/webbeans/ejb/common: component/BaseEjbBean.java interceptor/OpenWebBeansEjbInterceptor.java proxy/EjbBeanProxyHan

2010-08-29 Thread Eric Covener
sy to add to our interceptor for non-contextual -- in fact I think all the contextual vs non-contextual distinction can go away if we do a little more work in @PostConstruct. (hope to look at it this week) -- Eric Covener cove...@gmail.com

Re: CDI TCK Issues

2010-08-29 Thread Eric Covener
od invocations to remaining uninvoked decorators and eventually to the bean" -- Eric Covener cove...@gmail.com

Re: lifecycle interceptors for EJBs

2010-08-25 Thread Eric Covener
On Wed, Aug 25, 2010 at 2:24 PM, Eric Covener wrote: > In our OWBEjbInterceptor, we have a disconnect between how > @AroundInvoke and @PostConstruct/@PreDestroy are handled. answered offline -- aroundinvoke is right and lifecycles should ultimately behave the same. -- Eric Covene

lifecycle interceptors for EJBs

2010-08-25 Thread Eric Covener
this behave like @AroundInvoke and only call the EJB one when we fall off the bottom of our own invocation context? -- Eric Covener cove...@gmail.com

[jira] Resolved: (OWB-443) Normal-scoped EJB not removed by container during Contextual.destroy()

2010-08-19 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-443. -- Fix Version/s: 1.0.0-alpha-2 Resolution: Fixed > Normal-scoped EJB not removed by container dur

Re: EJB Bean Stateful Bean Remove Methods

2010-08-19 Thread Eric Covener
to be created just to remove it -- in such a case where the method invocation handler was never invoked and never actually obtained an EJB. I think all is well though. -- Eric Covener cove...@gmail.com

[jira] Created: (OWB-443) Normal-scoped EJB not removed by container during Contextual.destroy()

2010-08-19 Thread Eric Covener (JIRA)
: Bug Affects Versions: 1.0.0-alpha-1 Reporter: Eric Covener Assignee: Eric Covener Normal-scoped EJB not removed by container during Contextual.destroy() -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue

[jira] Resolved: (OWB-442) our EJB proxies are broken when multiple local interfaces are used on a single class

2010-08-19 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Covener resolved OWB-442. -- Fix Version/s: 1.0.0-alpha-2 Resolution: Fixed > our EJB proxies are broken when multiple lo

Re: EJB Bean Stateful Bean Remove Methods

2010-08-19 Thread Eric Covener
we > also have to call internal remove method of the container) > Yes this one looks busted, for normal scopes we should be causing the instance to be removed by the container unconditionally in Contextual.destroy(), since we always blocked the user from calling it. In a destroy() method is is still possible to check the context to make sure we actually obtained an EJB? -- Eric Covener cove...@gmail.com

[jira] Created: (OWB-442) our EJB proxies are broken when multiple local interfaces are used on a single class

2010-08-18 Thread Eric Covener (JIRA)
: OpenWebBeans Issue Type: Bug Components: Java EE Integration Affects Versions: 1.0.0-alpha-1 Reporter: Eric Covener Assignee: Eric Covener our javassist proxies for EJB beans only implement the single injected type, but they are stored in a cache keyed

jboss-test-harness.properties in both -tck and -porting?

2010-08-18 Thread Eric Covener
Why do we have two copies of jboss-test-harness.properties, one in -tck and one in -porting? Should they always have the same contents? It seems like the harness blows up if these are out of synch. -- Eric Covener cove...@gmail.com

Re: svn commit: r985746 - in /openwebbeans/trunk: webbeans-ejb/src/main/java/org/apache/webbeans/ejb/common/component/ webbeans-ejb/src/main/java/org/apache/webbeans/ejb/common/util/ webbeans-openejb/

2010-08-16 Thread Eric Covener
On Mon, Aug 16, 2010 at 11:20 AM, Eric Covener wrote: > On Mon, Aug 16, 2010 at 2:06 AM, Gurkan Erdogdu > wrote: >>>>>This proxy internally uses EJB >>>>>proxy instance that implements all of  local interfaces. >> This may be int

Re: svn commit: r985746 - in /openwebbeans/trunk: webbeans-ejb/src/main/java/org/apache/webbeans/ejb/common/component/ webbeans-ejb/src/main/java/org/apache/webbeans/ejb/common/util/ webbeans-openejb/

2010-08-16 Thread Eric Covener
On Mon, Aug 16, 2010 at 2:06 AM, Gurkan Erdogdu wrote: This proxy internally uses EJB proxy instance that implements all of  local interfaces. > This may be internally handled by the OpenEJB. > > Look org.apache.openejb.core.ivm.EjbHomeProxyHandler class in > container/openejb-core project

Re: svn commit: r985746 - in /openwebbeans/trunk: webbeans-ejb/src/main/java/org/apache/webbeans/ejb/common/component/ webbeans-ejb/src/main/java/org/apache/webbeans/ejb/common/util/ webbeans-openejb/

2010-08-15 Thread Eric Covener
On Sun, Aug 15, 2010 at 4:25 PM, wrote: > Author: gerdogdu > Date: Sun Aug 15 20:25:31 2010 > New Revision: 985746 > > URL: http://svn.apache.org/viewvc?rev=985746&view=rev > Log: > [OWB-439]  EjbPlugin session bean proxy creation thread safe problem > I had a little difficulty following, especi

[jira] Commented: (OWB-435) What is the expected result for following 2 decorators?

2010-08-12 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898041#action_12898041 ] Eric Covener commented on OWB-435: -- #1 seems like very wrong behavior > What

Re: ELContextStore Question

2010-08-12 Thread Eric Covener
slightly off-topic, but Mark I was wondering if you could explain why we need to call destroyELContextStore from both the WebBeansConfigurationListener and from the end of the RequestContext? Is there some path that would only hit one of these callers?

[jira] Commented: (OWB-435) What is the expected result for following 2 decorators?

2010-08-11 Thread Eric Covener (JIRA)
[ https://issues.apache.org/jira/browse/OWB-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897453#action_12897453 ] Eric Covener commented on OWB-435: -- I think the result you saw is correct. UserDecora

Re: [DISCUSS] releasing owb-1.0.0 next week?

2010-08-10 Thread Eric Covener
le than many commercial products with a 1.0 > release number ;) +1, I hope to work on BDA awareness in the scanner service / {Bean,Alternatives,Interceptor}Manager stuff and I don't want to derail 1.0 with it! Would we branch at 1.0, and would 1.0 still be CTR? -- Eric Covener cove...@gmail.com

299 q: AfterBeanDiscovery.addBean()

2010-08-09 Thread Eric Covener
;s no ways to enable anything for it? I couldn't find an alternative mechanism for enablement. -- Eric Covener cove...@gmail.com

  1   2   3   >