dongjoon-hyun merged PR #1097:
URL: https://github.com/apache/orc/pull/1097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.o
dongjoon-hyun commented on PR #1097:
URL: https://github.com/apache/orc/pull/1097#issuecomment-1109384703
Oh, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
williamhyun commented on PR #1097:
URL: https://github.com/apache/orc/pull/1097#issuecomment-1109374063
cc: @dongjoon-hyun @wgtmac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
williamhyun opened a new pull request, #1097:
URL: https://github.com/apache/orc/pull/1097
### What changes were proposed in this pull request?
This PR aims to add notification settings to .asf.yaml.
### Why are the changes needed?
ASF require that we receive all discussions
williamhyun merged PR #1095:
URL: https://github.com/apache/orc/pull/1095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
williamhyun merged PR #1094:
URL: https://github.com/apache/orc/pull/1094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
williamhyun commented on PR #1094:
URL: https://github.com/apache/orc/pull/1094#issuecomment-1109131253
+1 LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
dongjoon-hyun commented on PR #1095:
URL: https://github.com/apache/orc/pull/1095#issuecomment-1109110295
cc @williamhyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
dongjoon-hyun commented on PR #1094:
URL: https://github.com/apache/orc/pull/1094#issuecomment-1109110172
cc @williamhyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
naveensrinivasan opened a new pull request, #1096:
URL: https://github.com/apache/orc/pull/1096
Restrict the GitHub token permissions only to the required ones; this way,
even if the attackers will succeed in compromising your workflow, they won’t be
able to do much.
- Included perm
dongjoon-hyun closed pull request #1072: ORC-1138 Optimizes the read of streams
in ORC by combining multiple nearby reads into a single read, optionally
allowing the retention or drop of the extra bytes
URL: https://github.com/apache/orc/pull/1072
--
This is an automated message from the Apa
karan-k-deepr commented on issue #1022:
URL: https://github.com/apache/orc/issues/1022#issuecomment-1108610952
@stiga-huang I tried checking the `min` and `max` value of the batch
received by the `row_reader->next()` command. And the batch it's returned
doesn't filter anything for decimal v
dependabot[bot] opened a new pull request, #1095:
URL: https://github.com/apache/orc/pull/1095
Bumps [guava](https://github.com/google/guava) from 31.0.1-jre to 31.1-jre.
Release notes
Sourced from https://github.com/google/guava/releases";>guava's releases.
31.1
Maven
dependabot[bot] opened a new pull request, #1094:
URL: https://github.com/apache/orc/pull/1094
Bumps opencsv from 5.5.2 to 5.6.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.opencsv:opencsv&package-manager
dongjoon-hyun commented on issue #1092:
URL: https://github.com/apache/orc/issues/1092#issuecomment-1107918739
Thank you, @wgtmac and @williamhyun . I confirmed that both broken links are
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dongjoon-hyun closed issue #1092: Broken Avatar images in Apache ORC News
URL: https://github.com/apache/orc/issues/1092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
wgtmac commented on issue #1092:
URL: https://github.com/apache/orc/issues/1092#issuecomment-1107790104
> It's a traditional personal website hosting way in Apache Home account,
@wgtmac .
>
> 1. To simply put, your `https://people.apache.org/~gangwu` is mapped to
`public_html` under
dongjoon-hyun commented on issue #1092:
URL: https://github.com/apache/orc/issues/1092#issuecomment-1107755163
It's a traditional personal website hosting way in Apache Home account,
@wgtmac .
1. To simply put, your `https://people.apache.org/~gangwu` is mapped to
`public_html` under
wgtmac commented on issue #1092:
URL: https://github.com/apache/orc/issues/1092#issuecomment-1107690506
Thanks @dongjoon-hyun. I have the access now. But how can I upload my avatar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
dongjoon-hyun commented on issue #1092:
URL: https://github.com/apache/orc/issues/1092#issuecomment-1106809850
Gentle ping, @wgtmac . INFRA team is waiting for your confirmation. Please
comment on INFRA JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the m
dongjoon-hyun commented on issue #1092:
URL: https://github.com/apache/orc/issues/1092#issuecomment-1105971359
Thank you, @williamhyun . I confirmed that your news is recovered.
- https://orc.apache.org/news/2022/04/15/ORC-1.7.4/
--
This is an automated message from the Apache Git Servi
williamhyun commented on issue #1092:
URL: https://github.com/apache/orc/issues/1092#issuecomment-1105957090
It works!
```
% sftp home.apache.org
Connected to home.apache.org.
sftp> ls
```
--
This is an automated message from the Apache Git Service.
To respond to the message
dongjoon-hyun commented on issue #1092:
URL: https://github.com/apache/orc/issues/1092#issuecomment-1105946291
Hi, @wgtmac and @williamhyun . According to the INFRA team's comment, please
try to connect your home again.
> I have corrected the host attribute for "william." We do not have a
dongjoon-hyun commented on PR #1089:
URL: https://github.com/apache/orc/pull/1089#issuecomment-1105941089
Thank you, @wgtmac . Could you resolve ORC-1152 correspondingly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dongjoon-hyun commented on issue #1092:
URL: https://github.com/apache/orc/issues/1092#issuecomment-1105939226
Here is the INFRA JIRA.
- https://issues.apache.org/jira/browse/INFRA-23185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
dongjoon-hyun commented on PR #1088:
URL: https://github.com/apache/orc/pull/1088#issuecomment-1105936423
Hi All. I backported this to branch-1.7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dongjoon-hyun commented on PR #1090:
URL: https://github.com/apache/orc/pull/1090#issuecomment-1105935162
I believe we can backport this `benchmark` dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
dongjoon-hyun commented on issue #1092:
URL: https://github.com/apache/orc/issues/1092#issuecomment-1105933185
@wgtmac and @williamhyun .
1. According to https://infra.apache.org, they decommissioned the old server.
2. New machine is `home-lw-us (207.244.88.131)` whose aliases are
dongjoon-hyun closed pull request #1093: ORC-1155: Add Ubuntu 22.04 to docker
tests
URL: https://github.com/apache/orc/pull/1093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
wgtmac merged PR #1089:
URL: https://github.com/apache/orc/pull/1089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For
williamhyun commented on issue #1092:
URL: https://github.com/apache/orc/issues/1092#issuecomment-1105923166
@dongjoon-hyun Yes, I cannot access home.apache.org via sftp.
- https://home.apache.org/~william
--
This is an automated message from the Apache Git Service.
To respond to
williamhyun opened a new pull request, #1093:
URL: https://github.com/apache/orc/pull/1093
### What changes were proposed in this pull request?
This PR aims to add Ubuntu 22.04 to docker tests.
### Why are the changes needed?
Ubuntu 22.04 is the new LTS version.
wgtmac merged PR #1087:
URL: https://github.com/apache/orc/pull/1087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For
wgtmac commented on issue #1092:
URL: https://github.com/apache/orc/issues/1092#issuecomment-1104715933
@dongjoon-hyun I have tried to set up the page, but failed. Do you have any
guideline to proceed? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the
dongjoon-hyun commented on issue #1092:
URL: https://github.com/apache/orc/issues/1092#issuecomment-1104344318
Maybe, is ASF Home machine still inaccessible to you, @wgtmac and
@williamhyun ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
dongjoon-hyun opened a new issue, #1092:
URL: https://github.com/apache/orc/issues/1092
It seems that we have broken images at the following pages.
- https://orc.apache.org/news/2022/03/05/add-quanlong/
- https://orc.apache.org/news/2022/04/15/ORC-1.7.4/
--
This is an automated m
williamhyun merged PR #1090:
URL: https://github.com/apache/orc/pull/1090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
dongjoon-hyun commented on code in PR #1087:
URL: https://github.com/apache/orc/pull/1087#discussion_r854355561
##
c++/src/sargs/SargsApplier.hh:
##
@@ -60,10 +60,11 @@ namespace orc {
const std::map&
bloomFilters);
/**
- * Return a vector of b
stiga-huang commented on code in PR #1087:
URL: https://github.com/apache/orc/pull/1087#discussion_r854180338
##
c++/src/sargs/SargsApplier.hh:
##
@@ -60,10 +60,11 @@ namespace orc {
const std::map&
bloomFilters);
/**
- * Return a vector of boo
github-actions[bot] closed pull request #101: ORC-156
URL: https://github.com/apache/orc/pull/101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-un
github-actions[bot] closed pull request #142: [ORC-218] Cache timezone
information in the library.
URL: https://github.com/apache/orc/pull/142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
github-actions[bot] closed pull request #189: ORC-210 Add new encodings and
benchmarks for new double encoding.
URL: https://github.com/apache/orc/pull/189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] closed pull request #308: Covert tool should create a
lowercase schema
URL: https://github.com/apache/orc/pull/308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
github-actions[bot] closed pull request #483: ORC-601: Add more debug info to
error messages in the scanner
URL: https://github.com/apache/orc/pull/483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
github-actions[bot] closed pull request #283: ORC-378
URL: https://github.com/apache/orc/pull/283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-un
github-actions[bot] closed pull request #496: ORC-624: Fix UBSan errors
reported in the testsuite:
URL: https://github.com/apache/orc/pull/496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
github-actions[bot] closed pull request #504: ORC-625: Improve dictionary
lookup by marking common prefixes.
URL: https://github.com/apache/orc/pull/504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
github-actions[bot] closed pull request #564: ORC-274: Remove columnNames field
from Reader.Options
URL: https://github.com/apache/orc/pull/564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
github-actions[bot] closed pull request #586: ORC-703 : Fix RLE encoding bug on
large negative integer.
URL: https://github.com/apache/orc/pull/586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
github-actions[bot] closed pull request #601: ORC-703 : Fix RLE encoding bug on
large negative integer.
URL: https://github.com/apache/orc/pull/601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
dongjoon-hyun commented on PR #1023:
URL: https://github.com/apache/orc/pull/1023#issuecomment-1102969119
Hi, @HeenaBansal2009 . As you see in the right sidebar, this is planned for
v1.8.0 which is scheduled on September,
https://github.com/apache/orc/milestone/2.
![Screen Shot 2022-
HeenaBansal2009 commented on PR #1023:
URL: https://github.com/apache/orc/pull/1023#issuecomment-1102966383
Hi @dongjoon-hyun , Do we have a release with this fix?if yes, Please share
the release version.
Thanks
--
This is an automated message from the Apache Git Service.
To respo
coderex2522 commented on code in PR #1089:
URL: https://github.com/apache/orc/pull/1089#discussion_r852803848
##
java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java:
##
@@ -1783,8 +1783,9 @@ protected Decimal64TreeReader(int columnId,
@Override
public void
nehaljwani closed pull request #524: ZSTD_STATIC_LIB_NAME: Avoid double .a
extensions
URL: https://github.com/apache/orc/pull/524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
wgtmac commented on code in PR #1087:
URL: https://github.com/apache/orc/pull/1087#discussion_r852751678
##
c++/src/sargs/SargsApplier.hh:
##
@@ -60,10 +60,11 @@ namespace orc {
const std::map&
bloomFilters);
/**
- * Return a vector of bool for
wgtmac commented on code in PR #1089:
URL: https://github.com/apache/orc/pull/1089#discussion_r852699180
##
java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java:
##
@@ -1783,8 +1783,9 @@ protected Decimal64TreeReader(int columnId,
@Override
public void check
dongjoon-hyun commented on PR #1088:
URL: https://github.com/apache/orc/pull/1088#issuecomment-1102171023
+1 for backporting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
noirello commented on PR #1088:
URL: https://github.com/apache/orc/pull/1088#issuecomment-1102159784
> +1, LGTM. Do we need this at ORC 1.7.5?
Yes, I think this should be included in the 1.7 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message,
dongjoon-hyun commented on code in PR #1087:
URL: https://github.com/apache/orc/pull/1087#discussion_r852637818
##
c++/src/sargs/SargsApplier.hh:
##
@@ -60,10 +60,11 @@ namespace orc {
const std::map&
bloomFilters);
/**
- * Return a vector of b
wgtmac commented on code in PR #1087:
URL: https://github.com/apache/orc/pull/1087#discussion_r852596045
##
c++/src/Reader.cc:
##
@@ -1186,41 +1186,46 @@ namespace orc {
uint64_t currentRowInStripe,
stiga-huang merged PR #1088:
URL: https://github.com/apache/orc/pull/1088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
stiga-huang commented on code in PR #1087:
URL: https://github.com/apache/orc/pull/1087#discussion_r852580133
##
c++/src/Reader.cc:
##
@@ -1186,41 +1186,46 @@ namespace orc {
uint64_t currentRowInStripe,
coderex2522 commented on code in PR #1089:
URL: https://github.com/apache/orc/pull/1089#discussion_r852556124
##
c++/test/TestWriter.cc:
##
@@ -1996,5 +1996,5 @@ namespace orc {
}
}
- INSTANTIATE_TEST_CASE_P(OrcTest, WriterTest, Values(FileVersion::v_0_11(),
FileVers
wgtmac commented on code in PR #1087:
URL: https://github.com/apache/orc/pull/1087#discussion_r852538936
##
c++/src/Reader.cc:
##
@@ -1186,41 +1186,46 @@ namespace orc {
uint64_t currentRowInStripe,
stiga-huang commented on code in PR #1087:
URL: https://github.com/apache/orc/pull/1087#discussion_r852537049
##
c++/src/Reader.cc:
##
@@ -1186,41 +1186,46 @@ namespace orc {
uint64_t currentRowInStripe,
github-actions[bot] commented on PR #101:
URL: https://github.com/apache/orc/pull/101#issuecomment-1101868733
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue manageable.
If
github-actions[bot] commented on PR #142:
URL: https://github.com/apache/orc/pull/142#issuecomment-1101868720
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue manageable.
If
github-actions[bot] commented on PR #189:
URL: https://github.com/apache/orc/pull/189#issuecomment-1101868706
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue manageable.
If
github-actions[bot] commented on PR #283:
URL: https://github.com/apache/orc/pull/283#issuecomment-1101868694
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue manageable.
If
github-actions[bot] commented on PR #308:
URL: https://github.com/apache/orc/pull/308#issuecomment-1101868682
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue manageable.
If
github-actions[bot] commented on PR #483:
URL: https://github.com/apache/orc/pull/483#issuecomment-1101868668
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue manageable.
If
github-actions[bot] commented on PR #496:
URL: https://github.com/apache/orc/pull/496#issuecomment-1101868662
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue manageable.
If
github-actions[bot] commented on PR #504:
URL: https://github.com/apache/orc/pull/504#issuecomment-1101868650
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue manageable.
If
github-actions[bot] commented on PR #524:
URL: https://github.com/apache/orc/pull/524#issuecomment-1101868638
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue manageable.
If
github-actions[bot] commented on PR #564:
URL: https://github.com/apache/orc/pull/564#issuecomment-1101868623
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue manageable.
If
github-actions[bot] commented on PR #586:
URL: https://github.com/apache/orc/pull/586#issuecomment-1101868605
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue manageable.
If
github-actions[bot] commented on PR #601:
URL: https://github.com/apache/orc/pull/601#issuecomment-1101868593
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue manageable.
If
dongjoon-hyun commented on code in PR #1089:
URL: https://github.com/apache/orc/pull/1089#discussion_r852359519
##
c++/test/TestWriter.cc:
##
@@ -1996,5 +1996,5 @@ namespace orc {
}
}
- INSTANTIATE_TEST_CASE_P(OrcTest, WriterTest, Values(FileVersion::v_0_11(),
FileVe
williamhyun merged PR #1091:
URL: https://github.com/apache/orc/pull/1091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
dependabot[bot] opened a new pull request, #1091:
URL: https://github.com/apache/orc/pull/1091
Bumps [byte-buddy](https://github.com/raphw/byte-buddy) from 1.12.8 to
1.12.9.
Release notes
Sourced from https://github.com/raphw/byte-buddy/releases";>byte-buddy's
releases.
Byt
dependabot[bot] opened a new pull request, #1090:
URL: https://github.com/apache/orc/pull/1090
Bumps `hive.version` from 3.1.2 to 3.1.3.
Updates `hive-exec` from 3.1.2 to 3.1.3
Updates `hive-serde` from 3.1.2 to 3.1.3
Updates `hive-service-rpc` from 3.1.2 to 3.1.3
noirello commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r852041432
##
c++/test/TestTimestampStatistics.cc:
##
@@ -57,4 +62,97 @@ namespace orc {
EXPECT_EQ("Data type: Timestamp\nValues: 12\nHas null: no\nMinimum:
1995-01-01 00:00:00.
wgtmac commented on code in PR #1089:
URL: https://github.com/apache/orc/pull/1089#discussion_r851909221
##
c++/test/TestWriter.cc:
##
@@ -1996,5 +1996,5 @@ namespace orc {
}
}
- INSTANTIATE_TEST_CASE_P(OrcTest, WriterTest, Values(FileVersion::v_0_11(),
FileVersion::
dongjoon-hyun commented on code in PR #1089:
URL: https://github.com/apache/orc/pull/1089#discussion_r851862440
##
c++/test/TestWriter.cc:
##
@@ -1996,5 +1996,5 @@ namespace orc {
}
}
- INSTANTIATE_TEST_CASE_P(OrcTest, WriterTest, Values(FileVersion::v_0_11(),
FileVe
dongjoon-hyun commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851862133
##
c++/src/ColumnWriter.cc:
##
@@ -1837,7 +1837,7 @@ namespace orc {
// TimestampVectorBatch already stores data in UTC
int64_t millsUTC = secs[i] *
wgtmac commented on code in PR #1089:
URL: https://github.com/apache/orc/pull/1089#discussion_r851860205
##
c++/test/TestWriter.cc:
##
@@ -1996,5 +1996,5 @@ namespace orc {
}
}
- INSTANTIATE_TEST_CASE_P(OrcTest, WriterTest, Values(FileVersion::v_0_11(),
FileVersion::
wgtmac commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851858410
##
c++/src/ColumnWriter.cc:
##
@@ -1837,7 +1837,7 @@ namespace orc {
// TimestampVectorBatch already stores data in UTC
int64_t millsUTC = secs[i] * 1000 +
wgtmac commented on code in PR #1087:
URL: https://github.com/apache/orc/pull/1087#discussion_r851849272
##
c++/src/Reader.cc:
##
@@ -1186,41 +1186,46 @@ namespace orc {
uint64_t currentRowInStripe,
dongjoon-hyun commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851841698
##
c++/src/ColumnWriter.cc:
##
@@ -1837,7 +1837,7 @@ namespace orc {
// TimestampVectorBatch already stores data in UTC
int64_t millsUTC = secs[i] *
dongjoon-hyun commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851849032
##
c++/src/ColumnWriter.cc:
##
@@ -1837,7 +1837,7 @@ namespace orc {
// TimestampVectorBatch already stores data in UTC
int64_t millsUTC = secs[i] *
dongjoon-hyun commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851841698
##
c++/src/ColumnWriter.cc:
##
@@ -1837,7 +1837,7 @@ namespace orc {
// TimestampVectorBatch already stores data in UTC
int64_t millsUTC = secs[i] *
dongjoon-hyun commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851842056
##
c++/test/TestTimestampStatistics.cc:
##
@@ -57,4 +62,97 @@ namespace orc {
EXPECT_EQ("Data type: Timestamp\nValues: 12\nHas null: no\nMinimum:
1995-01-01 00:0
dongjoon-hyun commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851842026
##
c++/test/TestTimestampStatistics.cc:
##
@@ -57,4 +62,97 @@ namespace orc {
EXPECT_EQ("Data type: Timestamp\nValues: 12\nHas null: no\nMinimum:
1995-01-01 00:0
dongjoon-hyun commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851841698
##
c++/src/ColumnWriter.cc:
##
@@ -1837,7 +1837,7 @@ namespace orc {
// TimestampVectorBatch already stores data in UTC
int64_t millsUTC = secs[i] *
noirello commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851760919
##
c++/src/ColumnWriter.cc:
##
@@ -1837,7 +1837,7 @@ namespace orc {
// TimestampVectorBatch already stores data in UTC
int64_t millsUTC = secs[i] * 1000
noirello commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851760641
##
c++/src/ColumnWriter.cc:
##
@@ -1837,7 +1837,7 @@ namespace orc {
// TimestampVectorBatch already stores data in UTC
int64_t millsUTC = secs[i] * 1000
coderex2522 opened a new pull request, #1089:
URL: https://github.com/apache/orc/pull/1089
### What changes were proposed in this pull request?
This PR is to support writing short decimal64 in ORCv2.
The original writer codes come from
[ORC-49](https://github.com/apache/orc/pull/257)
dongjoon-hyun commented on code in PR #1088:
URL: https://github.com/apache/orc/pull/1088#discussion_r851687569
##
c++/src/ColumnWriter.cc:
##
@@ -1837,7 +1837,7 @@ namespace orc {
// TimestampVectorBatch already stores data in UTC
int64_t millsUTC = secs[i] *
noirello opened a new pull request, #1088:
URL: https://github.com/apache/orc/pull/1088
### What changes were proposed in this pull request?
Fix converting non UTC timestamps for statistics.
### Why are the changes needed?
Currently, the statistics for timestamp columns a
coderex2522 commented on code in PR #1087:
URL: https://github.com/apache/orc/pull/1087#discussion_r851644386
##
c++/src/Reader.cc:
##
@@ -1186,41 +1186,46 @@ namespace orc {
uint64_t currentRowInStripe,
1 - 100 of 4428 matches
Mail list logo
