[jira] [Commented] (PARQUET-1580) Page-level CRC checksum verification for DataPageV1

2021-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269932#comment-17269932 ] ASF GitHub Bot commented on PARQUET-1580: - wangyum commented on a change in pull request #647:

[GitHub] [parquet-mr] wangyum commented on a change in pull request #647: PARQUET-1580: Page-level CRC checksum verfication for DataPageV1

2021-01-21 Thread GitBox
wangyum commented on a change in pull request #647: URL: https://github.com/apache/parquet-mr/pull/647#discussion_r561914480 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageWriteStore.java ## @@ -119,14 +127,28 @@ public void

[jira] [Commented] (PARQUET-1746) Changed the data order after DataFrame reuse

2021-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269929#comment-17269929 ] ASF GitHub Bot commented on PARQUET-1746: - wangyum closed pull request #857: URL:

[GitHub] [parquet-mr] wangyum closed pull request #857: PARQUET-1746: Disable parquet.page.write-checksum.enabled by default

2021-01-21 Thread GitBox
wangyum closed pull request #857: URL: https://github.com/apache/parquet-mr/pull/857 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (PARQUET-1964) Properly handle missing/null filter

2021-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269924#comment-17269924 ] ASF GitHub Bot commented on PARQUET-1964: - gszadovszky merged pull request #856: URL:

[GitHub] [parquet-mr] gszadovszky merged pull request #856: PARQUET-1964: Properly handle missing/null filter

2021-01-21 Thread GitBox
gszadovszky merged pull request #856: URL: https://github.com/apache/parquet-mr/pull/856 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (PARQUET-1746) Changed the data order after DataFrame reuse

2021-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269895#comment-17269895 ] ASF GitHub Bot commented on PARQUET-1746: - wangyum opened a new pull request #857: URL:

[jira] [Commented] (PARQUET-1964) Properly handle missing/null filter

2021-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269864#comment-17269864 ] ASF GitHub Bot commented on PARQUET-1964: - shangxinli commented on pull request #856: URL:

[jira] [Commented] (PARQUET-1926) Add LogicalType support to ThriftType.I64Type

2021-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269863#comment-17269863 ] ASF GitHub Bot commented on PARQUET-1926: - jmartone commented on a change in pull request #832:

[GitHub] [parquet-mr] shangxinli commented on pull request #856: PARQUET-1964: Properly handle missing/null filter

2021-01-21 Thread GitBox
shangxinli commented on pull request #856: URL: https://github.com/apache/parquet-mr/pull/856#issuecomment-764237859 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [parquet-mr] jmartone commented on a change in pull request #832: PARQUET-1926: Add LogicalType support to ThriftType

2021-01-21 Thread GitBox
jmartone commented on a change in pull request #832: URL: https://github.com/apache/parquet-mr/pull/832#discussion_r562035955 ## File path: parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftSchemaConvertVisitor.java ## @@ -325,7 +323,7 @@ private ConvertedField

[jira] [Commented] (PARQUET-1580) Page-level CRC checksum verification for DataPageV1

2021-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269854#comment-17269854 ] ASF GitHub Bot commented on PARQUET-1580: - bbraams commented on a change in pull request #647:

[GitHub] [parquet-mr] bbraams commented on a change in pull request #647: PARQUET-1580: Page-level CRC checksum verfication for DataPageV1

2021-01-21 Thread GitBox
bbraams commented on a change in pull request #647: URL: https://github.com/apache/parquet-mr/pull/647#discussion_r561930066 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageWriteStore.java ## @@ -119,14 +127,28 @@ public void

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #832: PARQUET-1926: Add LogicalType support to ThriftType

2021-01-21 Thread GitBox
gszadovszky commented on a change in pull request #832: URL: https://github.com/apache/parquet-mr/pull/832#discussion_r561796333 ## File path: parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftSchemaConvertVisitor.java ## @@ -325,7 +323,7 @@ private ConvertedField

[jira] [Commented] (PARQUET-1746) Changed the data order after DataFrame reuse

2021-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269821#comment-17269821 ] ASF GitHub Bot commented on PARQUET-1746: - wangyum commented on pull request #857: URL:

[GitHub] [parquet-mr] wangyum commented on pull request #857: PARQUET-1746: Disable parquet.page.write-checksum.enabled by default

2021-01-21 Thread GitBox
wangyum commented on pull request #857: URL: https://github.com/apache/parquet-mr/pull/857#issuecomment-764048376 Sorry, this document outdate: http://mail-archives.apache.org/mod_mbox/parquet-dev/201906.mbox/%3cjira.13233926.1558083819000.446944.1560276180...@atlassian.jira%3E

[GitHub] [parquet-mr] jmartone commented on a change in pull request #832: PARQUET-1926: Add LogicalType support to ThriftType

2021-01-21 Thread GitBox
jmartone commented on a change in pull request #832: URL: https://github.com/apache/parquet-mr/pull/832#discussion_r562082846 ## File path: parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftSchemaConvertVisitor.java ## @@ -325,7 +323,7 @@ private ConvertedField

[jira] [Commented] (PARQUET-1926) Add LogicalType support to ThriftType.I64Type

2021-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269488#comment-17269488 ] ASF GitHub Bot commented on PARQUET-1926: - jmartone commented on a change in pull request #832:

[jira] [Commented] (PARQUET-1926) Add LogicalType support to ThriftType.I64Type

2021-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269467#comment-17269467 ] ASF GitHub Bot commented on PARQUET-1926: - gszadovszky commented on a change in pull request

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #832: PARQUET-1926: Add LogicalType support to ThriftType

2021-01-21 Thread GitBox
gszadovszky commented on a change in pull request #832: URL: https://github.com/apache/parquet-mr/pull/832#discussion_r562061225 ## File path: parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftSchemaConvertVisitor.java ## @@ -325,7 +323,7 @@ private ConvertedField

[jira] [Commented] (PARQUET-1926) Add LogicalType support to ThriftType.I64Type

2021-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269428#comment-17269428 ] ASF GitHub Bot commented on PARQUET-1926: - jmartone commented on a change in pull request #832:

[GitHub] [parquet-mr] jmartone commented on a change in pull request #832: PARQUET-1926: Add LogicalType support to ThriftType

2021-01-21 Thread GitBox
jmartone commented on a change in pull request #832: URL: https://github.com/apache/parquet-mr/pull/832#discussion_r562035955 ## File path: parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftSchemaConvertVisitor.java ## @@ -325,7 +323,7 @@ private ConvertedField

[GitHub] [parquet-mr] bbraams commented on a change in pull request #647: PARQUET-1580: Page-level CRC checksum verfication for DataPageV1

2021-01-21 Thread GitBox
bbraams commented on a change in pull request #647: URL: https://github.com/apache/parquet-mr/pull/647#discussion_r561930066 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageWriteStore.java ## @@ -119,14 +127,28 @@ public void

[jira] [Commented] (PARQUET-1580) Page-level CRC checksum verification for DataPageV1

2021-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269344#comment-17269344 ] ASF GitHub Bot commented on PARQUET-1580: - bbraams commented on a change in pull request #647:

[jira] [Commented] (PARQUET-1580) Page-level CRC checksum verification for DataPageV1

2021-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269328#comment-17269328 ] ASF GitHub Bot commented on PARQUET-1580: - wangyum commented on a change in pull request #647:

[GitHub] [parquet-mr] wangyum commented on a change in pull request #647: PARQUET-1580: Page-level CRC checksum verfication for DataPageV1

2021-01-21 Thread GitBox
wangyum commented on a change in pull request #647: URL: https://github.com/apache/parquet-mr/pull/647#discussion_r561914480 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageWriteStore.java ## @@ -119,14 +127,28 @@ public void

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #832: PARQUET-1926: Add LogicalType support to ThriftType

2021-01-21 Thread GitBox
gszadovszky commented on a change in pull request #832: URL: https://github.com/apache/parquet-mr/pull/832#discussion_r561796333 ## File path: parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftSchemaConvertVisitor.java ## @@ -325,7 +323,7 @@ private ConvertedField

[jira] [Commented] (PARQUET-1926) Add LogicalType support to ThriftType.I64Type

2021-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269235#comment-17269235 ] ASF GitHub Bot commented on PARQUET-1926: - gszadovszky commented on a change in pull request

[jira] [Resolved] (PARQUET-1964) Properly handle missing/null filter

2021-01-21 Thread Gabor Szadovszky (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Szadovszky resolved PARQUET-1964. --- Resolution: Fixed > Properly handle missing/null filter >

[jira] [Commented] (PARQUET-1964) Properly handle missing/null filter

2021-01-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269123#comment-17269123 ] ASF GitHub Bot commented on PARQUET-1964: - gszadovszky merged pull request #856: URL:

[GitHub] [parquet-mr] gszadovszky merged pull request #856: PARQUET-1964: Properly handle missing/null filter

2021-01-21 Thread GitBox
gszadovszky merged pull request #856: URL: https://github.com/apache/parquet-mr/pull/856 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to